ductwork 0.11.0 → 0.11.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a8865aef62511e2f94cd1400996127785cc5d46d9f2b16b00685145308addae3
-  data.tar.gz: f46683206d866c499f6f7eec03b5334038c77cf4078c7f78e150de11bd40b582
+  metadata.gz: aeafd6691af4722e01b18aefa76b2bd5ae75abe5930e0d7ab1a43593aba80010
+  data.tar.gz: 15ad867b7f98d0e3372b3e9f5a960964305df8f16da48a7273c4413f73f58c76
 SHA512:
-  metadata.gz: '08b1731d7f186650a6de90dad1b3ec3f797bddd55f03aab5d1812b7cf1476ec563d3f74537b04622778d3e3cd41afae2b38152805aa6d4d796764469f72703e7'
-  data.tar.gz: 6cc3908017094ad58f96c6db69cafca8b585e6f45217821f27559a7a7e47f59b8017a4d0fc87af4ea83286aa1aa0502b42d0159c2e1f6e54535296cecdd8149e
+  metadata.gz: 2a7df95cb4335e77d71f08bdfa1d0bb029fc651f458a129d4ccfd7b447d484fe780517a5e64280f242a0e52a6414385bdbb5b45bb14417c96d39d9fb017936c5
+  data.tar.gz: c9d5d363580913ca51869a7ff8df6d2c02dae61de6aa064eac2f8c9ab5f7199b0ed91f2858fe7c8ea62d110f7e201e0cf2ba60cf202b294c7c729a3e8dc75802

data/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Ductwork Changelog
 
+## [0.11.2]
+
+- fix: join error backtrace lines before persisting in `text` column
+- fix: use computed `max_retry` when determining job retry
+- fix: protect against a possible null `status` when advancing a pipeline
+- fix: correct spelling of `last_heartbeat_at` variable
+- fix: flip inverted deadline check in job worker runner
+- fix: flip inverted deadline check in pipeline advancer runner
+- fix: reference `thread` variable from `job_worker`, not top-level
+- fix: remove unnecessary, erroneous line in definition builder
+
+## [0.11.1]
+
+- fix: use info-level for job worker restart log messages
+- fix: use "killed" result in job execution log message when job worker is restarted
+
 ## [0.11.0]
 
 - feat: expose `job` attribute during claim and execution in job worker

data/lib/ductwork/dsl/definition_builder.rb

@@ -180,7 +180,6 @@ module Ductwork
           to = klasses.map { |klass| "#{klass.name}.#{stages.length}" }
           definition[:edges][last_node][:to] = to
           definition[:edges][last_node][:type] = type
-          definition[:edges][last_node][:klass] ||= klass
         end
       end
 

data/lib/ductwork/models/job.rb

@@ -123,7 +123,7 @@ module Ductwork
           pipeline: pipeline,
           job_id: id,
           job_klass: klass,
-          result: result,
+          result: result || "killed",
           role: :job_worker
         )
       end
@@ -163,7 +163,7 @@ module Ductwork
           result_type: "failure",
           error_klass: error.class.to_s,
           error_message: error.message,
-          error_backtrace: error.backtrace
+          error_backtrace: error.backtrace.join("\n")
         )
 
         if execution.retry_count < max_retry
@@ -174,7 +174,7 @@ module Ductwork
           new_execution.create_availability!(
             started_at: FAILED_EXECUTION_TIMEOUT.from_now
           )
-        elsif execution.retry_count >= Ductwork.configuration.job_worker_max_retry
+        elsif execution.retry_count >= max_retry
           halted = true
 
           step.update!(status: :failed)

data/lib/ductwork/processes/job_worker.rb

@@ -3,14 +3,14 @@
 module Ductwork
   module Processes
     class JobWorker
-      attr_reader :thread, :last_hearthbeat_at, :job
+      attr_reader :thread, :last_heartbeat_at, :job
 
       def initialize(pipeline, id)
         @pipeline = pipeline
         @id = id
         @running_context = Ductwork::RunningContext.new
         @thread = nil
-        @last_hearthbeat_at = Time.current
+        @last_heartbeat_at = Time.current
       end
 
       def start
@@ -67,7 +67,7 @@ module Ductwork
             sleep(polling_timeout)
           end
 
-          @last_hearthbeat_at = Time.current
+          @last_heartbeat_at = Time.current
         end
 
         Ductwork.logger.debug(

data/lib/ductwork/processes/job_worker_runner.rb

@@ -85,7 +85,7 @@ module Ductwork
           if !job_worker.alive?
             job_worker.restart
 
-            Ductwork.logger.debug(
+            Ductwork.logger.info(
               msg: "Restarted thread",
               role: :job_worker_runner,
               pipeline: pipeline
@@ -126,7 +126,7 @@ module Ductwork
 
         while Time.current < deadline && job_workers.any?(&:alive?)
           job_workers.each do |job_worker|
-            break if Time.current < deadline
+            break if Time.current > deadline
 
             # TODO: Maybe make this configurable. If there's a ton of workers
             # it may not even get to the "later" ones depending on the timeout
@@ -142,7 +142,7 @@ module Ductwork
             Ductwork.logger.debug(
               msg: "Killed thread",
               role: :job_worker_runner,
-              thread: thread.name
+              thread: job_worker.thread.name
             )
           end
         end

data/lib/ductwork/processes/pipeline_advancer.rb

@@ -56,15 +56,14 @@ module Ductwork
                 # rubocop:todo Metrics/BlockNesting
                 status = pipeline.completed? ? "completed" : "in_progress"
                 # rubocop:enable Metrics/BlockNesting
-
+              ensure
                 # release the pipeline and set last advanced at so it doesn't
                 # block. we're not using a queue so we have to use a db
                 # timestamp
-              ensure
                 pipeline.update!(
                   claimed_for_advancing_at: nil,
                   last_advanced_at: Time.current,
-                  status: status
+                  status: status || "in_progress"
                 )
               end
             else

data/lib/ductwork/processes/pipeline_advancer_runner.rb

@@ -125,7 +125,7 @@ module Ductwork
         )
         while Time.current < deadline && threads.any?(&:alive?)
           threads.each do |thread|
-            break if Time.current < deadline
+            break if Time.current > deadline
 
             # TODO: Maybe make this configurable. If there's a ton of workers
             # it may not even get to the "later" ones depending on the timeout

data/lib/ductwork/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ductwork
-  VERSION = "0.11.0"
+  VERSION = "0.11.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ductwork
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.11.2
 platform: ruby
 authors:
 - Tyler Ewing