duckdb 1.5.6.0 → 1.5.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cd491bbe1e80d7e2f20455e768b0331c91cbd015e570ccc023497c74217f86a0
-  data.tar.gz: b3c9d5bd5b38a7f72fa7d8c00be7bd20d61505c234efc702cd365b040dcce0dd
+  metadata.gz: 74ccac3599175a19bbc80ef6e9ad8e9aae62152d96b78dd6357623f647b62ff2
+  data.tar.gz: 9302451535c8b0b32f561a7deb45bd0f1800a77889592308c5e94714abd5fa33
 SHA512:
-  metadata.gz: acc1eb730e31250b6d8cc281923dd332b2141a4fb2ced34821126928b0c94757a6b1c5f49e29c39c01e899b196e4fe857ea529d62bd8fd88015c2dad806fbb8f
-  data.tar.gz: a18fc12e5e6252c32129d8ab005f75b29834711fc5790e009a8dc45fabcb9c9c9e88f1c16213a16bf346da906087ec9f57dea7e6162e51554d622a20575cdf55
+  metadata.gz: 29981f3882568513062d0a59e04e434dd8b557635c70b51fb2bfc017a077bf7076a10b384b676a7c32e7bf0d6d24420622e4e04164fced341b9165fe11cce062
+  data.tar.gz: e16e3171bd0c0f8f0e26f2c48e6f3a4d73fb1c93b00a01a4ae5d790a66ea0a198aa722d91790eb95e3b4fb1f66e167e3a69cf0377effa39138e801d7eb9eac16

data/CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.
 
 # Unreleased
 
+# 1.5.6.1 - 2026-10-17
+- fix `DuckDB::ExtractedStatements.new`, `Connection#query` and `Connection#extract` raising `Failed to extract statements(Database connection closed?).` for SQL that contains no statements, such as only a comment, whitespace or `;` (issue #1490). `ExtractedStatements#size` is now `0`, `Connection#query` returns `nil` and `Connection#extract` returns `[]`. Calling `ExtractedStatements.new` on a closed connection now raises `Database connection closed`.
+
 # 1.5.6.0 - 2026-10-11
 - bump up DuckDB 1.5.6 on CI.
 

data/ext/duckdb/connection.c

@@ -75,6 +75,15 @@ rubyDuckDBConnection *rbduckdb_get_struct_connection(VALUE obj) {
     return ctx;
 }
 
+rubyDuckDBConnection *rbduckdb_get_open_struct_connection(VALUE obj) {
+    rubyDuckDBConnection *ctx = rbduckdb_get_struct_connection(obj);
+
+    if (!(ctx->con)) {
+        rb_raise(eDuckDBError, "Database connection closed");
+    }
+    return ctx;
+}
+
 VALUE rbduckdb_create_connection(VALUE oDuckDBDatabase) {
     rubyDuckDB *ctxdb;
     rubyDuckDBConnection *ctxcon;
@@ -203,13 +212,9 @@ static VALUE connection__query_sql(VALUE self, VALUE str) {
 
     VALUE result = rbduckdb_create_result();
 
-    TypedData_Get_Struct(self, rubyDuckDBConnection, &connection_data_type, ctx);
+    ctx = rbduckdb_get_open_struct_connection(self);
     ctxr = rbduckdb_get_struct_result(result);
 
-    if (!(ctx->con)) {
-        rb_raise(eDuckDBError, "Database connection closed");
-    }
-
     /* Extract C string before releasing GVL (StringValueCStr is a Ruby operation) */
     const char *sql = StringValueCStr(str);
 
@@ -235,11 +240,7 @@ static VALUE connection__get_table_names(VALUE self, VALUE query, VALUE qualifie
     rubyDuckDBConnection *ctx;
     duckdb_value table_names;
 
-    ctx = rbduckdb_get_struct_connection(self);
-
-    if (!(ctx->con)) {
-        rb_raise(eDuckDBError, "Database connection closed");
-    }
+    ctx = rbduckdb_get_open_struct_connection(self);
 
     table_names = duckdb_get_table_names(ctx->con, StringValueCStr(query), RTEST(qualified));
 

data/ext/duckdb/connection.h

@@ -10,6 +10,7 @@ struct _rubyDuckDBConnection {
 typedef struct _rubyDuckDBConnection rubyDuckDBConnection;
 
 rubyDuckDBConnection *rbduckdb_get_struct_connection(VALUE obj);
+rubyDuckDBConnection *rbduckdb_get_open_struct_connection(VALUE obj);
 void rbduckdb_init_connection(void);
 VALUE rbduckdb_create_connection(VALUE oDuckDBDatabase);
 

data/ext/duckdb/extracted_statements.c

@@ -50,14 +50,19 @@ static VALUE extracted_statements__initialize(VALUE self, VALUE con, VALUE query
     }
 
     pquery = StringValuePtr(query);
-    pcon = rbduckdb_get_struct_connection(con);
+    pcon = rbduckdb_get_open_struct_connection(con);
     TypedData_Get_Struct(self, rubyDuckDBExtractedStatements, &extract_statements_data_type, ctx);
 
     ctx->num_statements = duckdb_extract_statements(pcon->con, pquery, &(ctx->extracted_statements));
 
-    if (ctx->num_statements == 0) {
-        error = duckdb_extract_statements_error(ctx->extracted_statements);
-        rb_raise(eDuckDBError, "%s", error ? error : "Failed to extract statements(Database connection closed?).");
+    /*
+     * duckdb_extract_statements returns 0 both on a parse error and when the
+     * query contains no statements (e.g. only a comment). Only the former
+     * sets an error message.
+     */
+    error = duckdb_extract_statements_error(ctx->extracted_statements);
+    if (error) {
+        rb_raise(eDuckDBError, "%s", error);
     }
 
     return self;

data/lib/duckdb/version.rb

@@ -3,5 +3,5 @@
 module DuckDB
   # The version string of ruby-duckdb.
   # Currently, ruby-duckdb is NOT semantic versioning.
-  VERSION = '1.5.6.0'
+  VERSION = '1.5.6.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: duckdb
 version: !ruby/object:Gem::Version
-  version: 1.5.6.0
+  version: 1.5.6.1
 platform: ruby
 authors:
 - Masaki Suketa