ducalis 0.5.7 → 0.5.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2287c52a483de43813b38fd3dbbb76dbe3780655
-  data.tar.gz: 70aabac07f3332f1f93066e8b62a0735e10d312c
+  metadata.gz: 21e653839c1ac51f59d14a84abede1d7f3fc8d95
+  data.tar.gz: 89f274016015741d35d85b1c664191b41ec05948
 SHA512:
-  metadata.gz: c83807a339d46e105dd31d431676215d3e5096ec1a4e24001f2d2f04b9b986a436a4d8f4cce5190d048472d0a52ff0dd98230842be0ec044eca77a37e4a479cd
-  data.tar.gz: 7141de63c1e561a7a509d37b461a9bbba0f77da84c1f7e45cb6b181fd6f8162789e23de5edbd473ffeee8a6a3ddd014877ae60d62e8b92762572b02272162685
+  metadata.gz: e2ac4461691ba39f23a0e1f5fa7bef701daf5b50cad2c31bec1ced0556899f27923efc0490d37bbcffa00fec3c594015497e6c406d325dc5d40e40d7ff9e2a92
+  data.tar.gz: 78e397569b05a3859b4ef295298f03cf17ea91746a1791d86f01688712cb9ad0619c46259f2f171cf71a58967275886e9075acc6751a002d8e11af8b0878bc65

data/.travis.yml

@@ -1,6 +1,8 @@
 language: ruby
 rvm:
+  - 2.2.8
   - 2.3.4
+  - 2.4.2
 before_install:
   - gem update --system
   - gem --version

data/DOCUMENTATION.md

@@ -489,47 +489,6 @@ def stop_terminated_employee
 end
 
 
-```
-
-![](https://placehold.it/10/2cbe4e/000000?text=+) [bugfix] calling methods on possible tap variable
-```ruby
-
-def create_message_struct(message)
-  objects = message.map { |object| process(object) }
-  Auditor::Message.new(message.process, objects)
-end
-
-```
-
-![](https://placehold.it/10/2cbe4e/000000?text=+) [bugfix] methods which simply returns instance var without changes
-```ruby
-
-def employee
-  @employee
-end
-
-```
-
-![](https://placehold.it/10/2cbe4e/000000?text=+) [bugfix] methods which ends with if condition
-```ruby
-
-def complete=(value, complete_at)
-  value = value.to_b
-  self.complete_at = complete_at if complete && value
-  self.complete_at = nil unless value
-end
-
-```
-
-![](https://placehold.it/10/2cbe4e/000000?text=+) [bugfix] methods with args without children nodes
-```ruby
-
-def filtered_admins(reducers)
-  reducers
-    .map { |reducer| @base_scope.public_send(reducer) }
-    .order("admin_users.created_at DESC")
-end
-
 ```
 ## Ducalis::PreferableMethods
 
@@ -667,7 +626,7 @@ MAPPING.find do |x|
 end
 
 ```
-## Ducalis::RaiseWithourErrorClass
+## Ducalis::RaiseWithoutErrorClass
 
 It's better to add exception class as raise argument. It will make
  easier to catch and process it later.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ducalis (0.5.7)
+    ducalis (0.5.8)
       git (~> 1.3, >= 1.3.0)
       policial (= 0.0.4)
       regexp-examples (~> 1.3, >= 1.3.2)

data/config/.ducalis.yml

@@ -71,7 +71,7 @@ Ducalis/ControllersExcept:
 Ducalis/PrivateInstanceAssign:
   Enabled: true
 
-Ducalis/RaiseWithourErrorClass:
+Ducalis/RaiseWithoutErrorClass:
   Enabled: true
 
 Ducalis/ModuleLikeClass:

data/lib/ducalis/cops/{raise_withour_error_class.rb → raise_without_error_class.rb}

@@ -3,7 +3,7 @@
 require 'rubocop'
 
 module Ducalis
-  class RaiseWithourErrorClass < RuboCop::Cop::Cop
+  class RaiseWithoutErrorClass < RuboCop::Cop::Cop
     OFFENSE = <<-MESSAGE.gsub(/^ +\|/, '').strip
       | It's better to add exception class as raise argument. It will make
       | easier to catch and process it later.
@@ -12,7 +12,7 @@ module Ducalis
     def on_send(node)
       _who, what, *args = *node
       return if what != :raise
-      return if args.first.type != :str
+      return if args.first && args.first.type != :str
       add_offense(node, :expression, OFFENSE)
     end
   end

data/lib/ducalis/documentation.rb

@@ -60,6 +60,7 @@ class Documentation
   RED_SQUARE = '![](https://placehold.it/10/f03c15/000000?text=+)'
   GREEN_SQUARE = '![](https://placehold.it/10/2cbe4e/000000?text=+)'
   SIGNAL_WORD = 'raises'
+  IGNORE_WORDS = ['[bugfix]'].freeze
 
   def call
     Dir['./lib/ducalis/cops/*.rb'].sort.map do |f|
@@ -100,7 +101,12 @@ class Documentation
     )
     SpecsProcessor.new.tap do |processor|
       processor.process(Parser::CurrentRuby.parse(source_code))
-    end.cases
+    end.cases.reject(&method(:ignored?))
+  end
+
+  def ignored?(example)
+    desc, _code = example
+    IGNORE_WORDS.any? { |word| desc.include?(word) }
   end
 
   def klass_const_for(f)

data/lib/ducalis/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ducalis
-  VERSION = '0.5.7'
+  VERSION = '0.5.8'
 end

data/lib/ducalis.rb

@@ -42,7 +42,7 @@ require 'ducalis/cops/possible_tap'
 require 'ducalis/cops/private_instance_assign'
 require 'ducalis/cops/preferable_methods'
 require 'ducalis/cops/protected_scope_cop'
-require 'ducalis/cops/raise_withour_error_class'
+require 'ducalis/cops/raise_without_error_class'
 require 'ducalis/cops/regex_cop'
 require 'ducalis/cops/rest_only_cop'
 require 'ducalis/cops/rubocop_disable'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ducalis
 version: !ruby/object:Gem::Version
-  version: 0.5.7
+  version: 0.5.8
 platform: ruby
 authors:
 - Ignat Zakrevsky
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-15 00:00:00.000000000 Z
+date: 2017-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: git
@@ -141,7 +141,7 @@ files:
 - lib/ducalis/cops/preferable_methods.rb
 - lib/ducalis/cops/private_instance_assign.rb
 - lib/ducalis/cops/protected_scope_cop.rb
-- lib/ducalis/cops/raise_withour_error_class.rb
+- lib/ducalis/cops/raise_without_error_class.rb
 - lib/ducalis/cops/regex_cop.rb
 - lib/ducalis/cops/rest_only_cop.rb
 - lib/ducalis/cops/rubocop_disable.rb