ducalis 0.5.5 → 0.5.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a37e051cff024cd88cc907c7f6588dbf45def229
-  data.tar.gz: e6aaaca1a78a6a7b9fe846b1f7e70f0e5dd47ec4
+  metadata.gz: 8a11daa74e66a48aa5dcf55449524a52ce95ccfe
+  data.tar.gz: be32ea0b59dcbaf77839929724d98ce64562407e
 SHA512:
-  metadata.gz: 9cd7e58476f46b3c6198b3a089c11550300349926616bb29fdff8810a4027faaa99ea1372bc048eebd25449ba484445eda97241ae75acb6f2c6accd5391f56fb
-  data.tar.gz: 34c024fb32a3ed7815df722daf4067dec4befad4ffbc55e5a0d9de640c5508d9a53beb5d528e2482797119deea8d7734a38f8ce4b5f1efbb5cd9839b62695391
+  metadata.gz: d1d720cf2eb513ce4073c5ed10ab6c96314efa49e3d416a1ae55bdba86530b8362da4bd49717322a161b04bbad5d134b38fe62885b498873cc4aec8e1af9d83c
+  data.tar.gz: f81669117b7f2ddb1c29d536cbe70823c8f435a25e93f517c712ed6f387a9a6aec4f42db6e4460ed266151350e5873de06b3fb03c0a80e1ff321222c10ae44f1

data/.codeclimate.yml

@@ -1,6 +1,6 @@
 engines:
   rubocop:
     enabled: true
-    channel: rubocop-0-50
+    channel: rubocop-0-46
     config:
       file: .rubocop.yml

data/DOCUMENTATION.md

@@ -1,33 +1,34 @@
 ## Ducalis::CallbacksActiverecord
 
-Please, avoid using of callbacks for models. It's better to keep models small ("dumb") and instead use "builder" classes/services: to construct new objects. You can read more [here](https://medium.com/planet-arkency/a61fd75ab2d3).
+Please, avoid using of callbacks for models. It's better to
+ keep models small ("dumb") and instead use "builder" classes
+ / services: to construct new objects. You can read more
+ [here](https://medium.com/planet-arkency/a61fd75ab2d3).
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises on ActiveRecord classes which contains callbacks
+![](https://placehold.it/10/f03c15/000000?text=+) raises on ActiveRecord classes which contains callbacks
 ```ruby
 
-class A < ActiveRecord::Base
+class Product < ActiveRecord::Base
   before_create :generate_code
 end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores non-ActiveRecord classes which contains callbacks
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores non-ActiveRecord classes which contains callbacks
 ```ruby
 
-class A < SomeBasicClass
+class Product < BasicProduct
   before_create :generate_code
 end
 
 ```
 ## Ducalis::CaseMapping
 
-Try to avoid `case when` statements. You can replace it with a sequence of
-`if... elsif... elsif... else`. For cases where you need to choose from a
-large number of possibilities, you can create a dictionary mapping case values
-to functions to call by `call`. It's nice to have prefix for the method
-names, i.e.: `visit_`.
-
-<details>
+Try to avoid `case when` statements. You can replace it with a sequence
+ of `if... elsif... elsif... else`. For cases where you need to choose
+ from a large number of possibilities, you can create a dictionary
+ mapping case values to functions to call by `call`. It's nice to have
+ prefix for the method names, i.e.: `visit_`.
 Usually `case when` statements are using for the next reasons:
 
 I. Mapping between different values.
@@ -100,7 +101,7 @@ more complex, table-driven code is simpler than complicated logic, easier to
 modify and more efficient.
 </details>
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises on case statements
+![](https://placehold.it/10/f03c15/000000?text=+) raises on case statements
 ```ruby
 
 case grade
@@ -117,125 +118,136 @@ end
 ```
 ## Ducalis::ControllersExcept
 
-Prefer to use `:only` over `:except` in controllers because it's more explicit and will be easier to maintain for new developers.
+Prefer to use `:only` over `:except` in controllers because it's more
+ explicit and will be easier to maintain for new developers.
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for `before_filters` with `except` method as array
+![](https://placehold.it/10/f03c15/000000?text=+) raises for `before_filters` with `except` method as array
 ```ruby
 
-class MyController < ApplicationController
-  before_filter :something, except: [:index]
+class ProductsController < ApplicationController
+  before_filter :update_cost, except: [:index]
+
   def index; end
   def edit; end
+
   private
-  def something; end
+
+  def update_cost; end
 end
 
 ```
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for filters with many actions and only one `except` method
+![](https://placehold.it/10/f03c15/000000?text=+) raises for filters with many actions and only one `except` method
 ```ruby
 
-class MyController < ApplicationController
-  before_filter :something, :load_me, except: %i[edit]
+class ProductsController < ApplicationController
+  before_filter :update_cost, :load_me, except: %i[edit]
+
   def index; end
   def edit; end
+
   private
-  def something; end
+
+  def update_cost; end
   def load_me; end
 end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores `before_filters` without arguments
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores `before_filters` without arguments
 ```ruby
 
-class MyController < ApplicationController
-  before_filter :something
+class ProductsController < ApplicationController
+  before_filter :update_cost
+
   def index; end
+
   private
-  def something; end
+
+  def update_cost; end
 end
 
 ```
 ## Ducalis::KeywordDefaults
 
-Prefer to use keyword arguments for defaults. It increases readability and reduces ambiguities.
+Prefer to use keyword arguments for defaults. It increases readability
+ and reduces ambiguities.
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises if method definition contains default values
+![](https://placehold.it/10/f03c15/000000?text=+) raises if method definition contains default values
 ```ruby
-def some_method(a, b, c = 3); end
+def calculate(step, index, dry = true); end
 ```
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises if class method definition contains default values
+![](https://placehold.it/10/f03c15/000000?text=+) raises if class method definition contains default values
 ```ruby
-def self.some_method(a, b, c = 3); end
+def self.calculate(step, index, dry = true); end
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores if method definition contains default values through keywords
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores if method definition contains default values through keywords
 ```ruby
-def some_method(a, b, c: 3); end
+def calculate(step, index, dry: true); end
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores for methods without arguments
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores for methods without arguments
 ```ruby
-def some_method; end
+def calculate_amount; end
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores for class methods without arguments
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores for class methods without arguments
 ```ruby
-def self.some_method; end
+def self.calculate_amount; end
 ```
 ## Ducalis::ModuleLikeClass
 
-Seems like it will be better to define initialize and pass %<args>s there instead of each method.
+Seems like it will be better to define initialize and pass %<args>s
+ there instead of each method.
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises if class doesn't contain constructor but accept the same args
+![](https://placehold.it/10/f03c15/000000?text=+) raises if class doesn't contain constructor but accept the same args
 ```ruby
 
-class MyClass
-
+class TaskJournal
   def initialize(customer)
     # ...
   end
 
-  def approve(task, estimate, some_args_1)
+  def approve(task, estimate, options)
     # ...
   end
 
-  def decline(user, task, estimate, some_args_2)
+  def decline(user, task, estimate, details)
     # ...
   end
 
   private
 
-  def anything_you_want(args)
+  def log(record)
     # ...
   end
 end
 
 ```
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for class with only one public method with args
+![](https://placehold.it/10/f03c15/000000?text=+) raises for class with only one public method with args
 ```ruby
 
-class MyClass
+class TaskJournal
   def approve(task)
     # ...
   end
 
   private
 
-  def anything_you_want(args)
+  def log(record)
     # ...
   end
 end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores classes with custom includes
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores classes with custom includes
 ```ruby
 
-class MyClass
+class TaskJournal
   include Singleton
 
   def approve(task)
@@ -245,27 +257,27 @@ end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores classes with inheritance
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores classes with inheritance
 ```ruby
 
-class MyClass < AnotherClass
+class TaskJournal < BasicJournal
   def approve(task)
     # ...
   end
 
   private
 
-  def anything_you_want(args)
+  def log(record)
     # ...
   end
 end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores classes with one method and initializer
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores classes with one method and initializer
 ```ruby
 
-class MyClass
+class TaskJournal
   def initialize(task)
     # ...
   end
@@ -278,79 +290,83 @@ end
 ```
 ## Ducalis::ParamsPassing
 
-It's better to pass already preprocessed params hash to services. Or you can use
-`arcane` gem
+It's better to pass already preprocessed params hash to services. Or
+ you can use `arcane` gem.
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises if user pass `params` as argument from controller
+![](https://placehold.it/10/f03c15/000000?text=+) raises if user pass `params` as argument from controller
 ```ruby
 
-class MyController < ApplicationController
+class ProductsController < ApplicationController
   def index
-    MyService.new(params).call
+    Record.new(params).log
   end
 end
 
 ```
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises if user pass `params` as any argument from controller
+![](https://placehold.it/10/f03c15/000000?text=+) raises if user pass `params` as any argument from controller
 ```ruby
 
-class MyController < ApplicationController
+class ProductsController < ApplicationController
   def index
-    MyService.new(first_arg, params).call
+    Record.new(first_arg, params).log
   end
 end
 
 ```
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises if user pass `params` as keyword argument from controller
+![](https://placehold.it/10/f03c15/000000?text=+) raises if user pass `params` as keyword argument from controller
 ```ruby
 
-class MyController < ApplicationController
+class ProductsController < ApplicationController
   def index
-    MyService.new(first_arg, any_name: params).call
+    Record.new(first_arg, any_name: params).log
   end
 end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores passing only one `params` field
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores passing only one `params` field
 ```ruby
 
-class MyController < ApplicationController
+class ProductsController < ApplicationController
   def index
-    MyService.new(first_arg, params[:id]).call
+    Record.new(first_arg, params[:id]).log
   end
 end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores passing processed `params`
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores passing processed `params`
 ```ruby
 
-class MyController < ApplicationController
+class ProductsController < ApplicationController
   def index
-    MyService.new(first_arg, params.slice(:name)).call
+    Record.new(first_arg, params.slice(:name)).log
   end
 end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores passing `params` from `arcane` gem
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores passing `params` from `arcane` gem
 ```ruby
 
-class MyController < ApplicationController
+class ProductsController < ApplicationController
   def index
-    MyService.new(params.for(Log).as(user).refine).call
+    Record.new(params.for(Log).as(user).refine).log
   end
 end
 
 ```
 ## Ducalis::PossibleTap
 
-Consider of using `.tap`, default ruby [method](<https://apidock.com/ruby/Object/tap>) which allows to replace intermediate variables with block, by this you are limiting scope pollution and make scope more clear. [Related article](<http://seejohncode.com/2012/01/02/ruby-tap-that/>).
+Consider of using `.tap`, default ruby
+ [method](<https://apidock.com/ruby/Object/tap>)
+ which allows to replace intermediate variables with block, by this you
+ are limiting scope pollution and make scope more clear.
+ [Related article](<http://seejohncode.com/2012/01/02/ruby-tap-that/>).
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for methods with scope variable return
+![](https://placehold.it/10/f03c15/000000?text=+) raises for methods with scope variable return
 ```ruby
 
 def load_group
@@ -361,7 +377,7 @@ end
 
 ```
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for methods with instance variable changes and return
+![](https://placehold.it/10/f03c15/000000?text=+) raises for methods with instance variable changes and return
 ```ruby
 
 def load_group
@@ -372,7 +388,7 @@ end
 
 ```
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for methods with instance variable `||=` assign and return
+![](https://placehold.it/10/f03c15/000000?text=+) raises for methods with instance variable `||=` assign and return
 ```ruby
 
 def define_roles
@@ -386,7 +402,7 @@ end
 
 ```
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for methods which return call on scope variable
+![](https://placehold.it/10/f03c15/000000?text=+) raises for methods which return call on scope variable
 ```ruby
 
 def load_group
@@ -400,7 +416,7 @@ end
 
 ```
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for methods which return instance variable but have scope vars
+![](https://placehold.it/10/f03c15/000000?text=+) raises for methods which return instance variable but have scope vars
 ```ruby
 
 def generate_file(file_name)
@@ -413,7 +429,7 @@ end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores empty methods
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores empty methods
 ```ruby
 
 def edit
@@ -421,7 +437,7 @@ end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores methods which body is just call
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores methods which body is just call
 ```ruby
 
 def total_cost(cost_field)
@@ -430,7 +446,7 @@ end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores methods which return some statement
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores methods which return some statement
 ```ruby
 
   def stop_terminated_employee
@@ -443,7 +459,7 @@ end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores methods which simply returns instance var without changes
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores methods which simply returns instance var without changes
 ```ruby
 
 def employee
@@ -454,40 +470,48 @@ end
 ## Ducalis::PreferableMethods
 
 Prefer to use %<alternative>s method instead of %<original>s because of
-%<reason>s.
+ %<reason>s.
+Dangerous methods are:
+`delete_all`, `delete`.
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for `delete` method calling
+![](https://placehold.it/10/f03c15/000000?text=+) raises for `delete` method calling
 ```ruby
 User.where(id: 7).delete
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores calling `delete` with symbol
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores calling `delete` with symbol
 ```ruby
 params.delete(:code)
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores calling `delete` with string
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores calling `delete` with string
 ```ruby
 string.delete("-")
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores calling `delete` with multiple args
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores calling `delete` with multiple args
 ```ruby
 some.delete(1, header: [])
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores calling `delete` on files-like variables
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores calling `delete` on files-like variables
 ```ruby
 tempfile.delete
 ```
 ## Ducalis::PrivateInstanceAssign
 
-Please, don't assign instance variables in controller's private methods. It's make hard to understand what variables are available in views.
+Don't use filters for setting instance variables, use them only for
+ changing application flow, such as redirecting if a user is not
+ authenticated. Controller instance variables are forming contract
+ between controller and view. Keeping instance variables defined in one
+ place makes it easier to: reason, refactor and remove old views, test
+ controllers and views, extract actions to new controllers, etc.
+If you want to memoize variable, please, add underscore to the variable name start: `@_name`.
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for assigning instance variables in controllers private methods
+![](https://placehold.it/10/f03c15/000000?text=+) raises for assigning instance variables in controllers private methods
 ```ruby
 
-class MyController < ApplicationController
+class EmployeesController < ApplicationController
   private
 
   def load_employee
@@ -497,36 +521,36 @@ end
 
 ```
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for memoization variables in controllers private methods
+![](https://placehold.it/10/f03c15/000000?text=+) raises for memoization variables in controllers private methods
 ```ruby
 
-class MyController < ApplicationController
+class EmployeesController < ApplicationController
   private
 
-  def service
-    @service ||= Service.new
+  def catalog
+    @catalog ||= Catalog.new
   end
 end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores memoization variables in controllers private methods with _
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores memoization variables in controllers private methods with _
 ```ruby
 
-class MyController < ApplicationController
+class EmployeesController < ApplicationController
   private
 
-  def service
-    @_service ||= Service.new
+  def catalog
+    @_catalog ||= Catalog.new
   end
 end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores assigning instance variables in controllers public methods
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores assigning instance variables in controllers public methods
 ```ruby
 
-class MyController < ApplicationController
+class EmployeesController < ApplicationController
   def index
     @employee = load_employee
   end
@@ -541,37 +565,37 @@ end
 ```
 ## Ducalis::ProtectedScopeCop
 
-Seems like you are using `find` on non-protected scope. Potentially it could
-lead to unauthorized access. It's better to call `find` on authorized resources
-scopes. Example:
+Seems like you are using `find` on non-protected scope. Potentially it
+ could lead to unauthorized access. It's better to call `find` on
+ authorized resources scopes. Example:
 
-```ruby
-current_group.employees.find(params[:id])
-# better then
-Employee.find(params[:id])
-```
+ ```ruby
+ current_group.employees.find(params[:id])
+ # better then
+ Employee.find(params[:id])
+ ```
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises if somewhere AR search was called on not protected scope
+![](https://placehold.it/10/f03c15/000000?text=+) raises if somewhere AR search was called on not protected scope
 ```ruby
 Group.find(8)
 ```
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises if AR search was called even for chain of calls
+![](https://placehold.it/10/f03c15/000000?text=+) raises if AR search was called even for chain of calls
 ```ruby
-Group.includes(:some_relation).find(8)
+Group.includes(:profiles).find(8)
 ```
 
-![](https://placehold.it/15/f03c15/000000?text=+) ignores where statements and still raises error
+![](https://placehold.it/10/f03c15/000000?text=+) ignores where statements and still raises error
 ```ruby
-Group.includes(:some_relation).where(name: "John").find(8)
+Group.includes(:profiles).where(name: "John").find(8)
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores find method with passed block
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores find method with passed block
 ```ruby
 MAPPING.find { |x| x == 42 }
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores find method with passed multiline block
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores find method with passed multiline block
 ```ruby
 
 MAPPING.find do |x|
@@ -581,33 +605,37 @@ end
 ```
 ## Ducalis::RaiseWithourErrorClass
 
-It's better to add exception class as raise argument. It will make easier to catch and process it later.
+It's better to add exception class as raise argument. It will make
+ easier to catch and process it later.
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises when `raise` called without exception class
+![](https://placehold.it/10/f03c15/000000?text=+) raises when `raise` called without exception class
 ```ruby
 raise "Something went wrong"
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores when `raise` called with exception class
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores when `raise` called with exception class
 ```ruby
 raise StandardError, "Something went wrong"
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores when `raise` called with exception instance
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores when `raise` called with exception instance
 ```ruby
 raise StandardError.new("Something went wrong")
 ```
 ## Ducalis::RegexCop
 
-It's better to move regex to constants with example instead of direct using it.
-It will allow you to reuse this regex and provide instructions for others.
+It's better to move regex to constants with example instead of direct
+ using it. It will allow you to reuse this regex and provide instructions
+ for others.
 
 ```ruby
 CONST_NAME = %<constant>s # "%<example>s"
 %<fixed_string>s
 ```
+Available regexes are:
+      `/[[:alnum:]]/`, `/[[:alpha:]]/`, `/[[:blank:]]/`, `/[[:cntrl:]]/`, `/[[:digit:]]/`, `/[[:graph:]]/`, `/[[:lower:]]/`, `/[[:print:]]/`, `/[[:punct:]]/`, `/[[:space:]]/`, `/[[:upper:]]/`, `/[[:xdigit:]]/`, `/[[:word:]]/`, `/[[:ascii:]]/`
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises if somewhere in code used regex which is not moved to const
+![](https://placehold.it/10/f03c15/000000?text=+) raises if somewhere in code used regex which is not moved to const
 ```ruby
 
 name = "john"
@@ -615,7 +643,7 @@ puts "hi" if name =~ /john/
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores matching constants
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores matching constants
 ```ruby
 
 REGEX = /john/
@@ -624,7 +652,7 @@ puts "hi" if name =~ REGEX
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores named ruby constants
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores named ruby constants
 ```ruby
 
 name = "john"
@@ -632,7 +660,7 @@ puts "hi" if name =~ /[[:alpha:]]/
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores dynamic regexs
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores dynamic regexs
 ```ruby
 
 name = "john"
@@ -642,33 +670,35 @@ puts "hi" if name =~ /.{#{name.length}}/
 ## Ducalis::RestOnlyCop
 
 It's better for controllers to stay adherent to REST:
-http://jeromedalbert.com/how-dhh-organizes-his-rails-controllers/
+ http://jeromedalbert.com/how-dhh-organizes-his-rails-controllers/
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for controllers with non-REST methods
+![](https://placehold.it/10/f03c15/000000?text=+) raises for controllers with non-REST methods
 ```ruby
 
-class MyController < ApplicationController
+class ProductsController < ApplicationController
   def index; end
-  def non_rest_method; end
+  def recalculate; end
 end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores controllers with private non-REST methods
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores controllers with private non-REST methods
 ```ruby
 
-class MyController < ApplicationController
+class ProductsController < ApplicationController
   def index; end
+
   private
-  def non_rest_method; end
+
+  def recalculate; end
 end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores controllers with only REST methods
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores controllers with only REST methods
 ```ruby
 
-class MyController < ApplicationController
+class ProductsController < ApplicationController
   def index; end
   def show; end
   def new; end
@@ -680,43 +710,42 @@ end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores non-controllers with non-REST methods
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores non-controllers with non-REST methods
 ```ruby
 
-class MyClass
+class PriceStore
   def index; end
-  def non_rest_method; end
+  def recalculate; end
 end
 
 ```
 ## Ducalis::RubocopDisable
 
+Please, do not suppress RuboCop metrics, may be you can introduce some
+ refactoring or another concept.
 
-Please, do not suppress RuboCop metrics, may be you can introduce some refactoring or another concept.
-    
-
-![](https://placehold.it/15/f03c15/000000?text=+) raises on RuboCop disable comments
+![](https://placehold.it/10/f03c15/000000?text=+) raises on RuboCop disable comments
 ```ruby
 
 # rubocop:disable Metrics/ParameterLists
-def some_method(a, b, c, d, e, f); end
+def calculate(five, args, at, one, list); end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores comment without RuboCop disabling
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores comment without RuboCop disabling
 ```ruby
 
 # some meaningful comment
-def some_method(a, b, c, d, e, f); end
+def calculate(five, args, at, one, list); end
 
 ```
 ## Ducalis::StringsInActiverecords
 
 Please, do not use strings as arguments for %<method_name>s argument.
-It's hard to test, grep sources, code highlighting and so on.
-Consider using of symbols or lambdas for complex expressions.
+ It's hard to test, grep sources, code highlighting and so on.
+ Consider using of symbols or lambdas for complex expressions.
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for string if argument
+![](https://placehold.it/10/f03c15/000000?text=+) raises for string if argument
 ```ruby
 
 before_save :set_full_name, 
@@ -724,129 +753,152 @@ before_save :set_full_name,
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores lambda if argument
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores lambda if argument
 ```ruby
 validates :file, if: -> { remote_url.blank? }
 ```
 ## Ducalis::UncommentedGem
 
-Please, add comment why are you including non-realized gem version for %<gem>s.
-It will increase [bus-factor](<https://en.wikipedia.org/wiki/Bus_factor>).
+Please, add comment why are you including non-realized gem version for
+ %<gem>s. It will increase
+ [bus-factor](<https://en.wikipedia.org/wiki/Bus_factor>).
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for gem from github without comment
+![](https://placehold.it/10/f03c15/000000?text=+) raises for gem from github without comment
 ```ruby
 
-gem 'a' 
-gem 'b', '~> 1.3.1' 
-gem 'c', git: 'https://github.com/c/c'
+gem 'pry', '~> 0.10', '>= 0.10.0'
+gem 'rake', '~> 12.1'
+gem 'rspec', git: 'https://github.com/rspec/rspec'
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores for gem from github with comment
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores for gem from github with comment
 ```ruby
 
-gem 'a' 
-gem 'b', '~> 1.3.1' 
-gem 'c', git: 'https://github.com/c/c' # some description
+gem 'pry', '~> 0.10', '>= 0.10.0'
+gem 'rake', '~> 12.1'
+gem 'rspec', github: 'rspec/rspec' # new non released API
 
 ```
 ## Ducalis::UselessOnly
 
-Seems like there is no any reason to keep before filter only for one action. Maybe it will be better to inline it?
+Seems like there is no any reason to keep before filter only for one
+ action. Maybe it will be better to inline it?
 
-```ruby
-before_filter :do_something, only: %i[index]
-def index; end
+ ```ruby
+ before_filter :do_something, only: %i[index]
+ def index; end
 
-# to
+ # to
 
-def index
-  do_something
-end
-```
+ def index
+   do_something
+ end
+ ```
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for `before_filters` with only one method as array
+![](https://placehold.it/10/f03c15/000000?text=+) raises for `before_filters` with only one method as array
 ```ruby
 
-class MyController < ApplicationController
-  before_filter :do_something, only: [:index]
+class ProductsController < ApplicationController
+  before_filter :update_cost, only: [:index]
+
   def index; end
+
   private
-  def do_something; end
+
+  def update_cost; end
 end
 
 ```
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for `before_filters` with only one method as keyword array
+![](https://placehold.it/10/f03c15/000000?text=+) raises for `before_filters` with only one method as keyword array
 ```ruby
 
-class MyController < ApplicationController
-  before_filter :do_something, only: %i[index]
+class ProductsController < ApplicationController
+  before_filter :update_cost, only: %i[index]
+
   def index; end
+
   private
-  def do_something; end
+
+  def update_cost; end
 end
 
 ```
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for `before_filters` with many actions and only one method
+![](https://placehold.it/10/f03c15/000000?text=+) raises for `before_filters` with many actions and only one method
 ```ruby
 
-class MyController < ApplicationController
-  before_filter :do_something, :load_me, only: %i[index]
+class ProductsController < ApplicationController
+  before_filter :update_cost, :load_me, only: %i[index]
+
   def index; end
+
   private
-  def do_something; end
+
+  def update_cost; end
   def load_me; end
 end
 
 ```
 
-![](https://placehold.it/15/f03c15/000000?text=+) raises for `before_filters` with only one method as argument
+![](https://placehold.it/10/f03c15/000000?text=+) raises for `before_filters` with only one method as argument
 ```ruby
 
-class MyController < ApplicationController
-  before_filter :do_something, only: :index
+class ProductsController < ApplicationController
+  before_filter :update_cost, only: :index
+
   def index; end
+
   private
-  def do_something; end
+
+  def update_cost; end
 end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores `before_filters` without arguments
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores `before_filters` without arguments
 ```ruby
 
-class MyController < ApplicationController
-  before_filter :do_something
+class ProductsController < ApplicationController
+  before_filter :update_cost
+
   def index; end
+
   private
-  def do_something; end
+
+  def update_cost; end
 end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores `before_filters` with `only` and many arguments
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores `before_filters` with `only` and many arguments
 ```ruby
 
-class MyController < ApplicationController
-  before_filter :do_something, only: %i[index show]
+class ProductsController < ApplicationController
+  before_filter :update_cost, only: %i[index show]
+
   def index; end
   def show; end
+
   private
-  def do_something; end
+
+  def update_cost; end
 end
 
 ```
 
-![](https://placehold.it/15/2cbe4e/000000?text=+) ignores `before_filters` with `except` and one argument
+![](https://placehold.it/10/2cbe4e/000000?text=+) ignores `before_filters` with `except` and one argument
 ```ruby
 
-class MyController < ApplicationController
-  before_filter :do_something, except: %i[index]
+class ProductsController < ApplicationController
+  before_filter :update_cost, except: %i[index]
+
   def index; end
+
   private
-  def do_something; end
+
+  def update_cost; end
 end
 
 ```