ducalis 0.5.4 → 0.5.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 328e7b375b3c04b775fa5857eccbc0ea72fde606
-  data.tar.gz: 9e36648c4778ba101e3af5811a8356359383b7a4
+  metadata.gz: a37e051cff024cd88cc907c7f6588dbf45def229
+  data.tar.gz: e6aaaca1a78a6a7b9fe846b1f7e70f0e5dd47ec4
 SHA512:
-  metadata.gz: 89622fd354b5feabd9390c12107a5e651e4dfbd1a3659efdebd578a930b33ebf4a40313723d00fde39b9558954f440413365701e59d891f2502b6bf0ddd10041
-  data.tar.gz: 1387adbbc6154a6b2eca280a3cea8d030b0f90fbf3a6bcc53e0604227df29d08607ba8b167d420f78099028d3ed1c2d6c8e130161464da237cfa9ff965fce4e0
+  metadata.gz: 9cd7e58476f46b3c6198b3a089c11550300349926616bb29fdff8810a4027faaa99ea1372bc048eebd25449ba484445eda97241ae75acb6f2c6accd5391f56fb
+  data.tar.gz: 34c024fb32a3ed7815df722daf4067dec4befad4ffbc55e5a0d9de640c5508d9a53beb5d528e2482797119deea8d7734a38f8ce4b5f1efbb5cd9839b62695391

data/DOCUMENTATION.md

@@ -460,6 +460,26 @@ Prefer to use %<alternative>s method instead of %<original>s because of
 ```ruby
 User.where(id: 7).delete
 ```
+
+![](https://placehold.it/15/2cbe4e/000000?text=+) ignores calling `delete` with symbol
+```ruby
+params.delete(:code)
+```
+
+![](https://placehold.it/15/2cbe4e/000000?text=+) ignores calling `delete` with string
+```ruby
+string.delete("-")
+```
+
+![](https://placehold.it/15/2cbe4e/000000?text=+) ignores calling `delete` with multiple args
+```ruby
+some.delete(1, header: [])
+```
+
+![](https://placehold.it/15/2cbe4e/000000?text=+) ignores calling `delete` on files-like variables
+```ruby
+tempfile.delete
+```
 ## Ducalis::PrivateInstanceAssign
 
 Please, don't assign instance variables in controller's private methods. It's make hard to understand what variables are available in views.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ducalis (0.5.4)
+    ducalis (0.5.5)
       git (~> 1.3, >= 1.3.0)
       policial (= 0.0.4)
       regexp-examples (~> 1.3, >= 1.3.2)

data/config/.ducalis.yml

@@ -5,6 +5,9 @@ AllCops:
     - 'node_modules/**/*'
     - 'vendor/bundle/**/*'
 
+Ducalis/PreferableMethods:
+  Enabled: true
+
 Ducalis/CaseMapping:
   Enabled: true
 

data/lib/ducalis.rb

@@ -39,6 +39,7 @@ require 'ducalis/cops/module_like_class'
 require 'ducalis/cops/params_passing'
 require 'ducalis/cops/possible_tap'
 require 'ducalis/cops/private_instance_assign'
+require 'ducalis/cops/preferable_methods'
 require 'ducalis/cops/protected_scope_cop'
 require 'ducalis/cops/raise_withour_error_class'
 require 'ducalis/cops/regex_cop'

data/lib/ducalis/cops/preferable_methods.rb

@@ -7,16 +7,22 @@ module Ducalis
 Prefer to use %<alternative>s method instead of %<original>s because of
 %<reason>s.
     ).strip
+    ALWAYS_TRUE = ->(_who, _what, _args) { true }
+    DELETE_CHECK = lambda do |who, _what, args|
+      !%i(sym str).include?(args.first&.type) &&
+        args.count <= 1 && who.to_s !~ /file/
+    end
     DESCRIPTION = {
-      # Method => [Alternative, Reason]
-      delete_all: [:destroy_all, 'it is not invoking callbacks'],
-      delete: [:destroy, 'it is not invoking callbacks']
+      # Method => [Alternative, Reason, Callable condition]
+      delete_all: [:destroy_all, 'it is not invoking callbacks', ALWAYS_TRUE],
+      delete: [:destroy, 'it is not invoking callbacks', DELETE_CHECK]
     }.freeze
 
     def on_send(node)
-      _who, what, *_args = *node
+      who, what, *args = *node
       return unless DESCRIPTION.keys.include?(what)
-      alternative, reason = DESCRIPTION.fetch(what)
+      alternative, reason, condition = DESCRIPTION.fetch(what)
+      return unless condition.call(who, what, args)
       add_offense(node, :expression, format(OFFENSE, original: what,
                                                      alternative: alternative,
                                                      reason: reason))

data/lib/ducalis/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ducalis
-  VERSION = '0.5.4'
+  VERSION = '0.5.5'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ducalis
 version: !ruby/object:Gem::Version
-  version: 0.5.4
+  version: 0.5.5
 platform: ruby
 authors:
 - Ignat Zakrevsky