ducalis 0.5.3 → 0.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 91cf323e4eba82ef0585479b751e91805b46bae2
-  data.tar.gz: f4e8b12ff782bc3fcf0e220f2f9ec3ca2771fcec
+  metadata.gz: 328e7b375b3c04b775fa5857eccbc0ea72fde606
+  data.tar.gz: 9e36648c4778ba101e3af5811a8356359383b7a4
 SHA512:
-  metadata.gz: 0c79353e420fe0386cd95da89c558668d9cad61a30df8e67c1198aafd910094db80529e1d3be1c3122a37ca0328e647eb02ed1f25cecee92e6fce7ed0165b119
-  data.tar.gz: 63018b24719db126d2230007546b3b09303dceaf6f00d5abbfe6a6cbe04b5f60d33e7beff930b84a5b1ffc272a6dbc70fc500cda8aa63828ac38182027e5eb6d
+  metadata.gz: 89622fd354b5feabd9390c12107a5e651e4dfbd1a3659efdebd578a930b33ebf4a40313723d00fde39b9558954f440413365701e59d891f2502b6bf0ddd10041
+  data.tar.gz: 1387adbbc6154a6b2eca280a3cea8d030b0f90fbf3a6bcc53e0604227df29d08607ba8b167d420f78099028d3ed1c2d6c8e130161464da237cfa9ff965fce4e0

data/DOCUMENTATION.md

@@ -450,6 +450,15 @@ def employee
   @employee
 end
 
+```
+## Ducalis::PreferableMethods
+
+Prefer to use %<alternative>s method instead of %<original>s because of
+%<reason>s.
+
+![](https://placehold.it/15/f03c15/000000?text=+) raises for `delete` method calling
+```ruby
+User.where(id: 7).delete
 ```
 ## Ducalis::PrivateInstanceAssign
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ducalis (0.5.3)
+    ducalis (0.5.4)
       git (~> 1.3, >= 1.3.0)
       policial (= 0.0.4)
       regexp-examples (~> 1.3, >= 1.3.2)

data/lib/ducalis/adapters/circle_ci.rb

@@ -11,7 +11,7 @@ module Ducalis
       end
 
       def id
-        @id ||= ENV.fetch('CI_PULL_REQUEST').split("/").last
+        @id ||= ENV.fetch('CI_PULL_REQUEST').split('/').last
       end
 
       def sha

data/lib/ducalis/cops/preferable_methods.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+require 'rubocop'
+
+module Ducalis
+  class PreferableMethods < RuboCop::Cop::Cop
+    OFFENSE = %(
+Prefer to use %<alternative>s method instead of %<original>s because of
+%<reason>s.
+    ).strip
+    DESCRIPTION = {
+      # Method => [Alternative, Reason]
+      delete_all: [:destroy_all, 'it is not invoking callbacks'],
+      delete: [:destroy, 'it is not invoking callbacks']
+    }.freeze
+
+    def on_send(node)
+      _who, what, *_args = *node
+      return unless DESCRIPTION.keys.include?(what)
+      alternative, reason = DESCRIPTION.fetch(what)
+      add_offense(node, :expression, format(OFFENSE, original: what,
+                                                     alternative: alternative,
+                                                     reason: reason))
+    end
+  end
+end

data/lib/ducalis/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ducalis
-  VERSION = '0.5.3'
+  VERSION = '0.5.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ducalis
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.5.4
 platform: ruby
 authors:
 - Ignat Zakrevsky
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-31 00:00:00.000000000 Z
+date: 2017-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: git
@@ -137,6 +137,7 @@ files:
 - lib/ducalis/cops/module_like_class.rb
 - lib/ducalis/cops/params_passing.rb
 - lib/ducalis/cops/possible_tap.rb
+- lib/ducalis/cops/preferable_methods.rb
 - lib/ducalis/cops/private_instance_assign.rb
 - lib/ducalis/cops/protected_scope_cop.rb
 - lib/ducalis/cops/raise_withour_error_class.rb