dual_burner 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b12d52c907a72c8b457e012cd28033a272da5975
-  data.tar.gz: e46f66e90b6c1709d21a6726d2ea32ece06176c7
+  metadata.gz: b1d8c2c25e1bcce734886cfcda729cafd83e81d0
+  data.tar.gz: 6ec0cf8e2238eb616a706542cef5e7042246a77a
 SHA512:
-  metadata.gz: c3d7ca6bad54f606ecd793a301e54a4967d5099a9fbfbd21bdea96bbbba7b73c4d7c1268a2f8942923575aaba8e5dc8aaa934c74a51f140b1278dddc236d34b5
-  data.tar.gz: 3ebc133f63dfb06afd11540936bf1a61bfcc0ec0a04494d78d0ba41e429198b1d5bd07e4735de63003c03954b8a9f9669704e163f37f9106011eee58b019ab03
+  metadata.gz: bbe353d8e66511ae3e5556b2fa362f662f0bc4c7a7a6f96a6ea559048670fcfb03c2ebf41c82b78f2eb5a95c9711bef36d3486ac34da4b67b59194bb3c8993d0
+  data.tar.gz: db3c3384cd97b8204674d0f3372962737237cb74ef19ab08c4187e550154dbd7b21d74783ad84bf1334d4197acc64f2547253304f65121d6729d9b791f2aed73

data/.rubocop.yml

@@ -13,7 +13,7 @@ Metrics/LineLength:
   Max: 120
 
 Metrics/MethodLength:
-  Max: 20
+  Max: 40 
 
 Metrics/ParameterLists:
   Max: 6
@@ -21,5 +21,8 @@ Metrics/ParameterLists:
 Style/Documentation:
   Enabled: false
 
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
 Style/SignalException:
   Enabled: false

data/README.md

@@ -89,7 +89,13 @@ You can pass in file locations of your deploy configuration if it is not under `
 
 You can verify that all versions are consistent with the following command.
 
-`dual_burner last_release --e wms_testing`
+`dual_burner last_release -e wms_testing`
+
+## Joining Heroku Apps
+
+You can join all Heroku apps in a cluster.
+
+`dual_burner join -e wms_testing`
 
 ## Heroku Config Management
 

data/Rakefile

@@ -1,6 +1,6 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/dual_burner.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'colorize', '~> 0.7' 
   spec.add_dependency 'thor', '~> 0.19' 
 
-  spec.add_development_dependency 'bundler', '~> 1.11'
+  spec.add_development_dependency 'bundler', '>= 1.9.5', '< 2.0'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'pry'

data/exe/dual_burner

@@ -3,4 +3,4 @@ require 'rubygems'
 require 'thor'
 require 'dual_burner'
 
-DualBurner::Runner.start
+DualBurner::Runner.start ? exit(0) : exit(1)

data/lib/dual_burner.rb

@@ -5,7 +5,9 @@ require 'dual_burner/configuration'
 require 'dual_burner/configuration_error'
 require 'dual_burner/environment_not_found_error'
 require 'dual_burner/base_command'
+require 'dual_burner/base_heroku_command'
 require 'dual_burner/commands/deployer'
 require 'dual_burner/commands/heroku_config'
+require 'dual_burner/commands/heroku_join'
 require 'dual_burner/commands/last_release'
 require 'dual_burner/runner'

data/lib/dual_burner/base_command.rb

@@ -15,12 +15,12 @@ module DualBurner
     protected
 
     def apps
-      @apps ||= get_apps_for_environment
+      @apps ||= apps_for_environment
     end
 
-    def get_apps_for_environment
+    def apps_for_environment
       raise ArgumentError, 'ENV IS NOT PRESENT!' if env.nil?
-      raise DualBurner::ConfigurationError, 'CONFIG IS NOT PRESENT!' unless File.exists?(configuration.deploy_file)
+      raise DualBurner::ConfigurationError, 'CONFIG IS NOT PRESENT!' unless File.exist?(configuration.deploy_file)
       config = YAML.load(File.read(configuration.deploy_file))[env]
       raise DualBurner::EnvironmentNotFoundError, "ENV #{env} NOT FOUND!" if config.nil?
       config.map { |c| app_instance(c) }
@@ -49,10 +49,22 @@ module DualBurner
       )
     end
 
+    def verify_results_exit_0(results, context:)
+      if !all_processes_exit_0?(results.map(&:value))
+        puts "The following #{context} failed:".red.blink
+        results.select { |r| r.value.exitstatus != 0 }.each do |r|
+          puts "#{r.app.name} failed with #{r.value.exitstatus}.".red
+        end
+        false
+      else
+        true
+      end
+    end
+
     ##
     # Determine of all processes return exit 0 status.
     def all_processes_exit_0?(processes)
-      if processes.select { |p| p.exitstatus == 0 }.size == processes.size
+      if processes.count { |p| p.exitstatus == 0 } == processes.size
         true
       else
         false
@@ -67,9 +79,9 @@ module DualBurner
       puts "#{app.name} #{Time.now} - executing command [#{command}]".send(app.color)
 
       result = result_instance
-      Open3.popen2e(command) do |stdin, stdout_and_stderr, thread|
+      Open3.popen2e(command) do |_stdin, stdout_and_stderr, thread|
         Thread.new do
-          until (raw_line = stdout_and_stderr.gets).nil? do
+          while (raw_line = stdout_and_stderr.gets)
             # There is a newline automatically appended from the stream.
             print "#{app.name} #{Time.now} - #{raw_line}".send(app.color) if print_lines
             result.lines << raw_line
@@ -96,24 +108,24 @@ module DualBurner
       # We have different commit hashes, env variables, whatever, we need to warn.
       if values.uniq.size > 1
         puts "Inconsistent #{context} found!".red.blink
-        puts ""
+        puts ''
 
         results.each_with_index do |result, i|
           print result.app.name.send(result.app.color)
           print " is at #{context} "
           print values[i].bold
-          puts ""
+          puts ''
         end
 
         false
       # Everything is fine!
       elsif values.uniq.size == 1
-        puts ""
-        print "All apps "
+        puts ''
+        print 'All apps '
         print results.map { |r| r.app.name }.join(', ').bold
         print " are on #{context} "
         print values.first.green
-        puts ""
+        puts ''
 
         true
       end

data/lib/dual_burner/base_heroku_command.rb

@@ -0,0 +1,15 @@
+module DualBurner
+  class BaseHerokuCommand < BaseCommand
+    protected
+
+    def execute_command_with_apps
+      results = []
+      apps.each do |app|
+        raise DualBurner::ConfigurationError, 'HEROKU APP NAME NOT CONFIGURED' if app.heroku_app_name.nil?
+        command = yield(app)
+        results << execute_command(command, app: app)
+      end
+      results
+    end
+  end
+end

data/lib/dual_burner/commands/deployer.rb

@@ -26,9 +26,7 @@ module DualBurner
         # Wait for all commands to complete.
         threads.map(&:join)
 
-        puts "Completed all deploys [#{threads.size}]!"
-
-        all_processes_exit_0?(results.map { |r| r.value })
+        verify_results_exit_0(results, context: 'deploys')
       end
 
       def build_deploy_command(app:, git_reference:)
@@ -43,17 +41,17 @@ module DualBurner
         # Show the user what Heroku apps are involved.
         puts "\n"
 
-        print "You are about to deploy "
+        print 'You are about to deploy '
         print git_reference.bold
-        print " to "
+        print ' to '
         print env.bold
-        print " on the following Apps: "
-        print apps.map { |a| a.name }.join(', ').bold
+        print ' on the following Apps: '
+        print apps.map(&:name).join(', ').bold
 
         puts "\n" * 2
 
         # Show the user what we are about to do on their machine.
-        puts "These commands will be executed:"
+        puts 'These commands will be executed:'
         apps.each do |app|
           puts build_deploy_command(app: app, git_reference: git_reference).send(app.color).bold
         end
@@ -65,10 +63,10 @@ module DualBurner
         puts "If this is ok, please type in the following: #{challenge}"
         response = STDIN.gets.chomp
         if challenge != response
-          puts "You didn't enter the right challenge. Aborting!".red.bold
+          puts 'You didn\'t enter the right challenge. Aborting!'.red.bold
           exit(1)
         else
-          puts "Preparing to deploy...."
+          puts 'Preparing to deploy....'
         end
       end
     end

data/lib/dual_burner/commands/heroku_config.rb

@@ -1,6 +1,6 @@
 module DualBurner
   module Commands
-    class HerokuConfig < DualBurner::BaseCommand
+    class HerokuConfig < DualBurner::BaseHerokuCommand
       def get(key:)
         results = execute_command_with_apps do |app|
           "heroku config:get #{key} -a #{app.heroku_app_name}"
@@ -11,28 +11,18 @@ module DualBurner
         end
       end
 
-      def set( key:, value:)
+      def set(key:, value:)
         results = execute_command_with_apps do |app|
           "heroku config:set #{key}=#{value} -a #{app.heroku_app_name}"
         end
-        all_processes_exit_0?(results.map { |r| r.value })
+        all_processes_exit_0?(results.map(&:value))
       end
 
       def unset(key:)
         results = execute_command_with_apps do |app|
           "heroku config:unset #{key} -a #{app.heroku_app_name}"
         end
-        all_processes_exit_0?(results.map { |r| r.value })
-      end
-
-      def execute_command_with_apps
-        results = []
-        apps.each do |app|
-          raise DualBurner::ConfigurationError, 'HEROKU APP NAME NOT CONFIGURED' if app.heroku_app_name.nil?
-          command = yield(app)
-          results << execute_command(command, app: app)
-        end
-        results
+        all_processes_exit_0?(results.map(&:value))
       end
     end
   end

data/lib/dual_burner/commands/heroku_join.rb

@@ -0,0 +1,13 @@
+module DualBurner
+  module Commands
+    class HerokuJoin < DualBurner::BaseHerokuCommand
+      def join
+        results = execute_command_with_apps do |app|
+          "heroku join -a #{app.heroku_app_name}"
+        end
+
+        verify_results_exit_0(results, context: 'Heroku app join')
+      end
+    end
+  end
+end

data/lib/dual_burner/commands/last_release.rb

@@ -3,7 +3,6 @@ module DualBurner
     class LastRelease < DualBurner::BaseCommand
       def verify_apps
         results = []
-        commit_hashes = []
 
         apps.each do |app|
           remote = app.remote_url

data/lib/dual_burner/configuration.rb

@@ -8,7 +8,7 @@ module DualBurner
     # Enable or disable user interaction.
     attr_accessor :interactive
 
-    alias_method :interactive?, :interactive
+    alias interactive? interactive
 
     def initialize
       @interactive = true

data/lib/dual_burner/runner.rb

@@ -2,9 +2,9 @@ require 'dual_burner'
 
 module DualBurner
   class Runner < Thor
-
-    ENV_DESC = 'The cluster environment.'.freeze unless defined?(ENV_DESC)
     CONFIG_DESC = 'Your configuration file if not .config/dual_burner.yml'.freeze unless defined?(CONFIG_DESC)
+    ENV_DESC = 'The cluster environment.'.freeze unless defined?(ENV_DESC)
+    GIT_DESC = 'The git reference to deploy.'.freeze unless defined?(GIT_DESC)
     HEROKU_KEY_DESC = 'The key to set on the Heroku app.'.freeze unless defined?(HEROKU_KEY_DESC)
 
     desc 'last_release', 'Finds the HEAD git revision for all applications in cluster <ENV>.'
@@ -14,18 +14,21 @@ module DualBurner
       ::DualBurner::Commands::LastRelease.new(
         env: options.fetch('env'),
         configuration: get_configuration_instance(deploy_file: options['config'])
-      ).verify_apps ? exit(0) : exit(1)
+      ).verify_apps
     end
 
     desc 'deploy', 'Deploy <REF> to all applications in cluster <ENV>.'
     method_option :env, aliases: '-e', type: :string, required: true, desc: ENV_DESC
     method_option :config, aliases: '-c', type: :string, optional: true, desc: CONFIG_DESC
-    method_option :git_reference, aliases: '-g', default: 'master', type: :string, required: false, desc: 'The git reference to deploy.'
+    method_option :git_reference, aliases: '-g', default: 'master', type: :string, optional: true, desc: GIT_DESC
+    method_option :join, aliases: '-j', default: true, optional: true, desc: 'Join all applications before deploy.'
     def deploy
+      invoke(:join, [], env: options['env']) if options['join'] == true
+
       ::DualBurner::Commands::Deployer.new(
         env: options.fetch('env'),
         configuration: get_configuration_instance(deploy_file: options['config'])
-      ).deploy(git_reference: options['git_reference']) ? exit(0) : exit(1)
+      ).deploy(git_reference: options['git_reference'])
     end
 
     desc 'config_set', 'Set <KEY> to <VALUE> for all Heroku appslocations in cluster <ENV>.'
@@ -37,7 +40,7 @@ module DualBurner
       ::DualBurner::Commands::HerokuConfig.new(
         env: options.fetch('env'),
         configuration: get_configuration_instance(deploy_file: options['config'])
-      ).set(key: options.fetch('key'), value: options['value']) ? exit(0) : exit(1)
+      ).set(key: options.fetch('key'), value: options['value'])
     end
 
     desc 'config_get', 'Get <KEY> for all Heroku appslocations in cluster <ENV>.'
@@ -48,7 +51,7 @@ module DualBurner
       ::DualBurner::Commands::HerokuConfig.new(
         env: options.fetch('env'),
         configuration: get_configuration_instance(deploy_file: options['config'])
-      ).get(key: options.fetch('key')) ? exit(0) : exit(1)
+      ).get(key: options.fetch('key'))
     end
 
     desc 'config_unset', 'Unset <KEY> for all Heroku appslocations in cluster <ENV>.'
@@ -59,13 +62,22 @@ module DualBurner
       ::DualBurner::Commands::HerokuConfig.new(
         env: options.fetch('env'),
         configuration: get_configuration_instance(deploy_file: options['config'])
-      ).unset(key: options.fetch('key')) ? exit(0) : exit(1)
+      ).unset(key: options.fetch('key'))
+    end
+
+    desc 'join', 'Join all Heroku appslocations in cluster <ENV>.'
+    method_option :env, aliases: '-e', type: :string, required: true, desc: ENV_DESC
+    def join
+      ::DualBurner::Commands::HerokuJoin.new(
+        env: options.fetch('env'),
+        configuration: get_configuration_instance(deploy_file: options['config'])
+      ).join
     end
 
     protected
 
     def get_configuration_instance(deploy_file: nil)
-      deploy_file ||=  File.join(Dir.getwd, 'config', 'dual_burner.yml')
+      deploy_file ||= File.join(Dir.getwd, 'config', 'dual_burner.yml')
 
       c = DualBurner::Configuration.new
       c.deploy_file = deploy_file

data/lib/dual_burner/version.rb

@@ -1,3 +1,3 @@
 module DualBurner
-  VERSION = "0.1.0"
+  VERSION = '0.2.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dual_burner
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Blue Apron Engineering
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-02-29 00:00:00.000000000 Z
+date: 2016-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -42,16 +42,22 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.9.5
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.9.5
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -144,8 +150,10 @@ files:
 - exe/dual_burner
 - lib/dual_burner.rb
 - lib/dual_burner/base_command.rb
+- lib/dual_burner/base_heroku_command.rb
 - lib/dual_burner/commands/deployer.rb
 - lib/dual_burner/commands/heroku_config.rb
+- lib/dual_burner/commands/heroku_join.rb
 - lib/dual_burner/commands/last_release.rb
 - lib/dual_burner/configuration.rb
 - lib/dual_burner/configuration_error.rb