dslr_shop 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1c114830324aca7cc1e4670feb9f113604232d58
-  data.tar.gz: d565f1f3f46f8e146866ca4f52f9b3d51d7c7e6e
+  metadata.gz: 8203cac3b029ccbb6442b73c7063540c756216cb
+  data.tar.gz: e55f45bd272db88c47f7b117f07b12d497580d22
 SHA512:
-  metadata.gz: 33e84872e5c206985c08c3cc9ed7589dd2dd4e08128fc855c0b8857ccc935ca48db0a77d67330a41ae061afd860a65b724c1a01ed5c84fd7e00064606a421f91
-  data.tar.gz: 2f945018d8222d6bcc8f3a026e728b64db92515d5152a7ed456fb01758d4b75c56fe2f51c7e2d2ae9264764f5de8dae6a508f580dea0455a37fdf9829073294b
+  metadata.gz: fd5d2bcf9e97fd6041bc32cbc7f558a9452fa696c5f4f88157b1099eae3df68009781fdf1abffdb40a4a8e5504a6787dbd10221ed8eb807196936b44e96e0e11
+  data.tar.gz: 3ed1c49206ea77fb8c8057c0cde184d8044a8d2cbb2b49ab27116c8b2474a825ea8c2a5645a88078aa71031da9a7483450a90a123e9c39463955065f342519c6

data/dslr_shop.gemspec

@@ -26,15 +26,15 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
-  # spec.bindir        = "exe"
+  spec.bindir        = "bin"
   spec.executables   << "dslr_shop"
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.14"
+  spec.add_runtime_dependency "bundler", "~> 1.14"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "nokogiri", ">= 0"
+  spec.add_runtime_dependency "nokogiri", ">= 0"
   spec.add_development_dependency "pry", ">= 0"
-  spec.add_development_dependency "require_all"
-  spec.add_development_dependency "colorize"
+  spec.add_runtime_dependency "require_all"
+  spec.add_runtime_dependency "colorize"
 end

data/lib/dslr_shop/camera.rb

@@ -7,25 +7,24 @@ class DslrShop::Camera
     @@all
   end
 
-  def initialize(camera_hash)
-    camera_hash.each {|key, value|
-      self.send(("#{key}="),value)
-    }
+  def initialize(brand = nil, name = nil, availability = nil, price = nil, url = nil)
+    @brand = brand
+    @name = name
+    @availability = availability
+    @price = price
+    @url = url
     @@all << self
   end
 
-  def self.create_from_collection(camera_collection)
-    # camera_collection=> array of camera_hashes
-    camera_collection.each {|camera_hash|
-      self.new(camera_hash)
-    }
-  end
-
-  def add_attributes(attribute_hash)
-    attribute_hash.each {|key, value|
-      self.send(("#{key}="), value)
-    }
+  # def self.create_from_collection(camera_collection)
+  #   # camera_collection=> array of camera_hashes
+  #   camera_collection.each {|camera_hash|
+  #     self.new(camera_hash)
+  #   }
+  # end
 
+  def add_attributes
+    DslrShop::Scraper.scrape_from_detail(self)
   end
 
 end

data/lib/dslr_shop/cli.rb

@@ -4,22 +4,18 @@ class DslrShop::CLI
 
   def run
     make_cameras
-    add_attributes_from_detail
+    # add_attributes_from_detail
     list_cameras
     display_menu
     goodbye
   end
 
   def make_cameras
-    camera_collection = DslrShop::Scraper.scrape_from_list(LIST_PAGE)
-    DslrShop::Camera.create_from_collection(camera_collection)
+    DslrShop::Scraper.scrape_from_list(LIST_PAGE)
   end
 
-  def add_attributes_from_detail
-    DslrShop::Camera.all.each {|camera|
-      camera_attributes = DslrShop::Scraper.scrape_from_detail(camera.url)
-      camera.add_attributes(camera_attributes)
-    }
+  def add_attributes_from_detail(camera)
+    camera.add_attributes
   end
 
   def list_cameras
@@ -56,6 +52,7 @@ class DslrShop::CLI
     end
 
     if index.to_i>0
+      self.add_attributes_from_detail(camera_list[index.to_i - 1])
       puts "#{camera_list[index.to_i - 1].brand.upcase} #{camera_list[index.to_i - 1].name}".colorize(:color => :light_blue, :background => :light_yellow)
       puts "Rank: #{index}".colorize(:color => :light_blue, :background => :light_yellow)
       puts "Camera Type: #{camera_list[index.to_i - 1].type}".colorize(:color => :light_blue, :background => :light_yellow)

data/lib/dslr_shop/scraper.rb

@@ -3,29 +3,28 @@ class DslrShop::Scraper
   def self.scrape_from_list(list_url)
     doc = Nokogiri::HTML(open(list_url))
     camera_nodes = doc.search("div.item.clearfix")
-    camera_nodes.map {|camera|
-      {
-        brand: camera.search("div.desc-zone.zone h3 a span")[0].text,
-        name: camera.search("div.desc-zone.zone h3 a span")[1].text.chomp(" (Body Only)"),
-        availability: camera.search("p.scAvailabilityTri span").text.strip,
-        price: camera.search("div.atc-price p span.price").text.strip,
-        url: camera.search("div.desc-zone.zone h3 a").attr('href').text
-      }
+    camera_nodes.map {|camera_node|
+      camera = DslrShop::Camera.new
+      camera.brand = camera_node.search("div.desc-zone.zone h3 a span")[0].text
+      camera.name =  camera_node.search("div.desc-zone.zone h3 a span")[1].text.chomp(" (Body Only)")
+      camera.availability = camera_node.search("p.scAvailabilityTri span").text.strip
+      camera.price =  camera_node.search("div.atc-price p span.price").text.strip
+      camera.url =  camera_node.search("div.desc-zone.zone h3 a").attr('href').text
     }
   end
 
-  def self.scrape_from_detail(detail_url)
-    doc = Nokogiri::HTML(open(detail_url))
-    camera_attr = {}
-    camera_attr[:discount] = doc.search("div.pPrice p span").text.strip
-    camera_attr[:type] = doc.search("div.product-highlights ul li")[0].text
+  def self.scrape_from_detail(camera)
+    doc = Nokogiri::HTML(open(camera.url))
+
+    camera.discount = doc.search("div.pPrice p span").text.strip
+    camera.type = doc.search("div.product-highlights ul li")[0].text
     # begin
-    camera_attr[:style] = doc.search("div.items-group p span")[0].text if doc.search("div.items-group p span")[0]
+    camera.style = doc.search("div.items-group p span")[0].text if doc.search("div.items-group p span")[0]
     # rescue StandardError
     # binding.pry
     # end
-    camera_attr[:rewards] = doc.search("div.acTwoPercent a").text.gsub(/\s+[a-z]*$/, "") if doc.search("div.acTwoPercent a").size>0
-    camera_attr
+    camera.rewards = doc.search("div.acTwoPercent a").text.gsub(/\s+[a-z]*$/, "") if doc.search("div.acTwoPercent a").size>0
+    camera
   end
 
   # This gem provides an interactive CLI to view the top 24 DSLR cameras as rated by the photography store B & H Photography's website.

data/lib/dslr_shop/version.rb

@@ -1,3 +1,3 @@
 module DslrShop
-  VERSION = "0.1.0"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dslr_shop
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - sarjumulmi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-29 00:00:00.000000000 Z
+date: 2017-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -17,7 +17,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.14'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -59,7 +59,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -87,7 +87,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -101,7 +101,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements: