dscf-credit 0.3.1 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9e3b6a324773633a199dfe48d49baa98a8e410671da8ad4916f107ad38ad33fb
-  data.tar.gz: 5accc6330524779a8720ebc16b9db48bd8ee9673552216d8fce8d38ebd6e40cd
+  metadata.gz: 2e43f1b7fa03ac6fe72f99412259a4d0345b41cf0487f3d2c3f3ba63e895d589
+  data.tar.gz: af9eb779b069774cbed9fdb356762637ac6ca6f5f61d181485d23e4d64419178
 SHA512:
-  metadata.gz: 2979387747dc0f40646df26c2cdcd266443cf07fb1c417deed6f704b62292f650469a490149891f0594df3e245e8ec1e3884f65abab9af58692aae4dd71c13ce
-  data.tar.gz: 8263bd4bc902d6525d3674736fe6301e1d032f84e9c1db21dcc038b7c36c2049e532e23097b4d03532f99e6a8288caf186f9793a2189522e9ffe7eaa9a532e6b
+  metadata.gz: 87ac35ad44c00672dd4d47ab33fa4f3a27757849b963e7db80aac172844790c08f2af6b45607c1f2526451131fe802fe7df0fbfc985c42c6485ee038df8b5a1c
+  data.tar.gz: a26cc03842c4366d42ae16f6349d6406890da27a1419f4b824e349cf37d8ce4e9e4b0ba1fc540370885bcf93eda99b7b3e5e2e9eb0dc519c907d55d5140857d3

data/app/controllers/dscf/credit/credit_line_specs_controller.rb

@@ -49,12 +49,13 @@ module Dscf::Credit
         :max_interest_calculation_days,
         :penalty_frequency,
         :penalty_income_tax,
-        :active
+        :active,
+        :base_scoring_parameter_id
       )
     end
 
     def eager_loaded_associations
-      [ :credit_line, :created_by ]
+      [ :credit_line, :created_by, :base_scoring_parameter ]
     end
 
     def allowed_order_columns
@@ -63,10 +64,10 @@ module Dscf::Credit
 
     def default_serializer_includes
       {
-        index: [ :credit_line ],
-        show: [ :credit_line, :created_by ],
-        create: [ :credit_line, :created_by ],
-        update: [ :credit_line, :created_by ]
+        index: [ :credit_line, :base_scoring_parameter ],
+        show: [ :credit_line, :created_by, :base_scoring_parameter ],
+        create: [ :credit_line, :created_by, :base_scoring_parameter ],
+        update: [ :credit_line, :created_by, :base_scoring_parameter ]
       }
     end
   end

data/app/models/dscf/credit/credit_line_spec.rb

@@ -4,11 +4,13 @@ module Dscf::Credit
 
     belongs_to :credit_line, class_name: "Dscf::Credit::CreditLine", foreign_key: "credit_line_id"
     belongs_to :created_by, polymorphic: true
+    belongs_to :base_scoring_parameter, class_name: "Dscf::Credit::ScoringParameter", foreign_key: "base_scoring_parameter_id", optional: true
 
     validates :min_amount, :max_amount, :interest_rate, :penalty_rate, :facilitation_fee_rate, :tax_rate, :credit_line_multiplier, :max_penalty_days, :loan_duration, :interest_frequency, :interest_income_tax, :vat, :max_interest_calculation_days, :penalty_frequency, :penalty_income_tax, presence: true
     validates :min_amount, :max_amount, :credit_line_multiplier, numericality: { greater_than: 0 }
     validates :interest_rate, :penalty_rate, :facilitation_fee_rate, :tax_rate, :interest_income_tax, :vat, :penalty_income_tax, numericality: { greater_than_or_equal_to: 0, less_than: 10 }
     validates :max_penalty_days, :loan_duration, :max_interest_calculation_days, numericality: { greater_than: 0 }
+    validates :credit_line_divider, numericality: { greater_than: 0, less_than_or_equal_to: 365 }, allow_nil: true
     validates :interest_frequency, inclusion: { in: %w[daily weekly monthly quarterly annually] }
     validates :penalty_frequency, inclusion: { in: %w[daily weekly monthly] }
     validate :max_amount_greater_than_min_amount
@@ -19,11 +21,11 @@ module Dscf::Credit
     scope :by_penalty_frequency, ->(frequency) { where(penalty_frequency: frequency) }
 
     def self.ransackable_attributes(auth_object = nil)
-      %w[id min_amount max_amount interest_rate penalty_rate facilitation_fee_rate tax_rate credit_line_multiplier max_penalty_days loan_duration interest_frequency interest_income_tax vat max_interest_calculation_days penalty_frequency penalty_income_tax active created_at updated_at]
+      %w[id min_amount max_amount interest_rate penalty_rate facilitation_fee_rate tax_rate credit_line_multiplier max_penalty_days loan_duration interest_frequency interest_income_tax vat max_interest_calculation_days penalty_frequency penalty_income_tax credit_line_divider active created_at updated_at]
     end
 
     def self.ransackable_associations(auth_object = nil)
-      %w[credit_line created_by]
+      %w[credit_line created_by base_scoring_parameter]
     end
 
     private

data/app/serializers/dscf/credit/credit_line_spec_serializer.rb

@@ -4,9 +4,10 @@ module Dscf::Credit
                :facilitation_fee_rate, :tax_rate, :credit_line_multiplier, :max_penalty_days,
                :loan_duration, :interest_frequency, :interest_income_tax,
                :vat, :max_interest_calculation_days, :penalty_frequency,
-               :penalty_income_tax, :active, :created_at, :updated_at
+               :penalty_income_tax, :credit_line_divider, :active, :created_at, :updated_at
 
     belongs_to :credit_line, serializer: Dscf::Credit::CreditLineSerializer
     belongs_to :created_by, serializer: Dscf::Core::UserSerializer
+    belongs_to :base_scoring_parameter, serializer: Dscf::Credit::ScoringParameterSerializer
   end
 end

data/app/serializers/dscf/credit/eligible_credit_line_serializer.rb

@@ -4,5 +4,9 @@ module Dscf::Credit
 
     belongs_to :loan_profile, serializer: Dscf::Credit::LoanProfileSerializer
     belongs_to :credit_line, serializer: Dscf::Credit::CreditLineSerializer
+
+    attribute :user_id do
+      object.loan_profile.loan_application.user_id if object.loan_profile && object.loan_profile.loan_application
+    end
   end
 end

data/app/services/dscf/credit/disbursement_service.rb

@@ -24,7 +24,7 @@ module Dscf::Credit
       loan_profile_status = loan_profile.current_status_for(:default)
       return error_result("Loan profile not approved") unless loan_profile_status == "approved"
 
-      validation_result = validate_disbursement_amount
+      validation_result = validate_disbursement_amount(credit_line)
       return validation_result unless validation_result[:success]
 
       ActiveRecord::Base.transaction do
@@ -49,11 +49,12 @@ module Dscf::Credit
 
     private
 
-    def validate_disbursement_amount
+    def validate_disbursement_amount(credit_line)
       available_limit = eligible_credit_line.available_limit
+      credit_line_spec = credit_line.credit_line_specs.active.first
 
-      if amount <= 0
-        return error_result("Invalid disbursement amount")
+      if credit_line_spec && amount < credit_line_spec.min_amount
+        return error_result("Amount must be at least #{credit_line_spec.min_amount}")
       end
 
       if amount > available_limit

data/app/services/dscf/credit/facility_limit_calculation_engine.rb

@@ -1,7 +1,38 @@
 module Dscf::Credit
+  # FacilityLimitCalculationEngine calculates credit facility limits for loan profiles
+  # based on dynamic scoring parameters and credit line specifications.
+  #
+  # @example Basic usage
+  #   loan_profile = Dscf::Credit::LoanProfile.find(profile_id)
+  #   category = Dscf::Credit::Category.find(category_id)
+  #   engine = Dscf::Credit::FacilityLimitCalculationEngine.new(loan_profile.id, category.id)
+  #   result = engine.calculate_facility_limits
+  #
+  #   if result[:success]
+  #     puts "Limits calculated: #{result[:message]}"
+  #     puts "Eligible credit lines: #{result[:data].count}"
+  #   else
+  #     puts "Error: #{result[:error]}"
+  #   end
+  #
+  # @example Result structure
+  #   {
+  #     success: true,
+  #     data: [#<EligibleCreditLine>, ...],
+  #     message: "Facility limits calculated successfully"
+  #   }
+  #
+  # @see docs/CREDIT_SCORING_ARCHITECTURE.md for scoring architecture
   class FacilityLimitCalculationEngine
     attr_reader :loan_profile, :category_id, :errors
 
+    # Initialize the facility limit calculation engine
+    #
+    # @param loan_profile_id [Integer] The ID of the loan profile to calculate limits for
+    # @param category_id [Integer] The ID of the credit line category
+    #
+    # @example
+    #   engine = FacilityLimitCalculationEngine.new(123, 456)
     def initialize(loan_profile_id, category_id)
       @errors = []
       @loan_profile = LoanProfile.find(loan_profile_id)
@@ -10,42 +41,75 @@ module Dscf::Credit
       @errors << "Loan profile not found: #{e.message}"
     end
 
-    # Calculate facility limits for all credit lines in the category
+    # Calculate facility limits for all eligible credit lines
+    #
+    # Process steps:
+    # 1. Retrieve active credit lines for the category and bank
+    # 2. For each credit line, get the latest active credit line spec
+    # 3. Calculate base metric from scoring parameter (dynamic based on parameter type)
+    # 4. Calculate credit limit using: base_metric × multiplier × score_percentage
+    # 5. Apply min/max constraints from credit line spec
+    # 6. Create eligible credit line records with calculated limits
+    # 7. Update loan profile's total_limit
+    #
+    # @return [Hash] Result hash with the following structure:
+    #   - :success [Boolean] Whether the operation succeeded
+    #   - :data [Array<EligibleCreditLine>] Created eligible credit lines (empty array on failure)
+    #   - :message [String] Success message
+    #   - :error [String] Error message (only present on failure)
+    #   - :errors [Array<String>] Detailed error messages for debugging
+    #
+    # @example Success response
+    #   {
+    #     success: true,
+    #     data: [#<EligibleCreditLine id: 1>, #<EligibleCreditLine id: 2>],
+    #     message: "Facility limits calculated successfully"
+    #   }
+    #
+    # @example Error response
+    #   {
+    #     success: false,
+    #     error: "No credit lines found for category 5 and bank 10",
+    #     errors: ["No credit lines found for category 5 and bank 10"]
+    #   }
     def calculate_facility_limits
       return error_result("Loan profile is required") unless loan_profile
       return error_result("Category ID is required") unless category_id
 
       begin
         ActiveRecord::Base.transaction do
-          # Get all credit lines for the category and bank
           credit_lines = get_credit_lines_for_calculation
-
           if credit_lines.empty?
             return error_result("No credit lines found for category #{category_id} and bank #{loan_profile.loan_application.bank_id}")
           end
 
-          # Calculate base metric from facilitator info
-          base_metric = calculate_base_metric
-
-          if base_metric <= 0
-            return error_result("Invalid base metric calculated: #{base_metric}. Check facilitator_info avg_monthly_purchase.")
-          end
-
-          # Calculate facility limits for each credit line
           eligible_credit_lines = []
-
           credit_lines.each do |credit_line|
-            limit_result = calculate_credit_line_limit(credit_line, base_metric)
+            credit_line_spec = credit_line.credit_line_specs.active.order(created_at: :desc).first
+            unless credit_line_spec
+              @errors << "No active credit line spec for credit line #{credit_line.id}"
+              next
+            end
+
+            base_metric = calculate_base_metric(credit_line_spec)
+            if base_metric <= 0
+              @errors << "Invalid base metric for credit line #{credit_line.id}: #{base_metric}"
+              next
+            end
 
-            if limit_result[:success] && limit_result[:limit] >= 0
+            limit_result = calculate_credit_line_limit(credit_line, base_metric, credit_line_spec)
+            unless limit_result[:success]
+              @errors << limit_result[:error]
+              next
+            end
+
+            if limit_result[:limit] >= 0
               eligible_credit_line = create_eligible_credit_line(credit_line, limit_result[:limit])
               eligible_credit_lines << eligible_credit_line
             end
           end
 
-          # Update loan profile total limit
           update_loan_profile_total_limit
-
           success_result(eligible_credit_lines, "Facility limits calculated successfully")
         end
       rescue StandardError => e
@@ -57,7 +121,17 @@ module Dscf::Credit
 
     private
 
-    # Get credit lines for the specified category and bank
+    # Retrieve credit lines eligible for calculation
+    #
+    # Filters credit lines by:
+    # - Category ID
+    # - Bank ID from loan application
+    # - Active credit line specs
+    #
+    # Includes:
+    # - Credit line specs with base_scoring_parameter association
+    #
+    # @return [ActiveRecord::Relation<CreditLine>] Filtered credit lines
     def get_credit_lines_for_calculation
       CreditLine.joins(:category, :credit_line_specs)
                 .where(
@@ -65,66 +139,186 @@ module Dscf::Credit
                   bank_id: loan_profile.loan_application.bank_id,
                   dscf_credit_credit_line_specs: { active: true }
                 )
-                .includes(:credit_line_specs)
-                .distinct
+                .includes(credit_line_specs: :base_scoring_parameter)
     end
 
-    # Calculate base metric from facilitator info
-    def calculate_base_metric
-      facilitator_info = loan_profile.loan_application.facilitator_info || {}
+    # Calculate the base metric for credit limit calculation
+    #
+    # This method dynamically determines the base metric value based on the
+    # base_scoring_parameter associated with the credit line spec. The base metric
+    # is extracted from the loan application's facilitator_info and normalized
+    # using the credit_line_divider from the credit line spec.
+    #
+    # Flow:
+    # 1. Check if credit_line_spec has a base_scoring_parameter
+    # 2. If not, use fallback_base_metric (looks for avg_monthly_purchase manually)
+    # 3. Extract the raw_value from facilitator_info using parameter ID
+    # 4. Normalize the value using credit_line_divider:
+    #    - If divider is present and > 0: divide raw_value by divider
+    #    - If divider is nil or <= 0: use raw_value as-is
+    #
+    # @param credit_line_spec [CreditLineSpec] The credit line specification
+    # @return [Float] The calculated base metric (0.0 if invalid or missing data)
+    #
+    # @example With divider = 30
+    #   # credit_line_spec.credit_line_divider = 30
+    #   # facilitator_info[param_id]["raw_value"] = 30000.0
+    #   # Returns: 1000.0 (30000 / 30)
+    #
+    # @example With divider = 365
+    #   # credit_line_spec.credit_line_divider = 365
+    #   # facilitator_info[param_id]["raw_value"] = 365000.0
+    #   # Returns: 1000.0 (365000 / 365)
+    #
+    # @example With nil divider
+    #   # credit_line_spec.credit_line_divider = nil
+    #   # facilitator_info[param_id]["raw_value"] = 1000.0
+    #   # Returns: 1000.0 (no normalization)
+    def calculate_base_metric(credit_line_spec)
+      return fallback_base_metric unless credit_line_spec.base_scoring_parameter
 
-      # Find avg_monthly_purchase from the nested JSON structure
-      # facilitator_info structure: { "301": { "param_name": "avg_monthly_purchase", "value": 0.1, "raw_value": 30000 } }
-      avg_monthly_purchase = nil
+      base_param = credit_line_spec.base_scoring_parameter
+      facilitator_info = loan_profile.loan_application.facilitator_info || {}
+      param_id = base_param.id.to_s
 
-      facilitator_info.each do |param_id, param_data|
-        if param_data.is_a?(Hash) &&
-           (param_data["param_name"] == "avg_monthly_purchase" || param_data[:param_name] == "avg_monthly_purchase")
-          avg_monthly_purchase = param_data["raw_value"] || param_data[:raw_value]
-          break
-        end
+      param_data = facilitator_info[param_id]
+      unless param_data
+        Rails.logger.warn "No data for scoring parameter #{base_param.id} (#{base_param.name}) in facilitator_info"
+        return 0.0
       end
 
-      # Handle string and numeric values
-      if avg_monthly_purchase.is_a?(String)
-        avg_monthly_purchase = avg_monthly_purchase.to_f
-      else
-        avg_monthly_purchase = avg_monthly_purchase.to_f if avg_monthly_purchase
+      raw_value = param_data["raw_value"] || param_data[:raw_value]
+      value = raw_value.to_f rescue 0.0
+      if value <= 0
+        Rails.logger.warn "Invalid value #{raw_value} for scoring parameter #{base_param.id} (#{base_param.name})"
+        return 0.0
       end
 
-      return 0.0 if avg_monthly_purchase.nil? || avg_monthly_purchase <= 0
-
-      avg_monthly_purchase / 30.0
+      normalize_value(value, credit_line_spec)
     end
 
-    # Calculate facility limit for a specific credit line
-    def calculate_credit_line_limit(credit_line, base_metric)
-      credit_line_spec = credit_line.credit_line_specs.active.order(created_at: :desc).first
+    # Fallback method to calculate base metric when base_scoring_parameter is not set
+    #
+    # This method searches facilitator_info for a parameter named "avg_monthly_purchase"
+    # and uses it as the base metric, normalized to a daily value.
+    #
+    # This provides backward compatibility for credit line specs that don't have
+    # a base_scoring_parameter association yet.
+    #
+    # @return [Float] The calculated base metric (0.0 if not found or invalid)
+    #
+    # @example Found avg_monthly_purchase
+    #   # facilitator_info = { "123" => { "param_name" => "avg_monthly_purchase", "raw_value" => 30000.0 } }
+    #   # Returns: 1000.0 (30000 / 30)
+    #
+    # @example Not found
+    #   # facilitator_info = { "123" => { "param_name" => "other_param", "raw_value" => 5000.0 } }
+    #   # Returns: 0.0
+    def fallback_base_metric
+      facilitator_info = loan_profile.loan_application.facilitator_info || {}
+      param_value = nil
 
-      unless credit_line_spec
-        return { success: false, error: "No active credit line spec found for credit line #{credit_line.id}" }
+      facilitator_info.each do |param_id, param_data|
+        next unless param_data.is_a?(Hash)
+        if param_data["param_name"] == "avg_monthly_purchase" || param_data[:param_name] == "avg_monthly_purchase"
+          param_value = param_data["raw_value"] || param_data[:raw_value]
+          break
+        end
       end
 
+      value = param_value.to_f rescue 0.0
+      return 0.0 if value <= 0
+      value / 30.0
+    end
+
+    # Normalize a parameter value based on the credit line spec's divider
+    #
+    # Divides the raw parameter value by the credit_line_divider from the credit line spec.
+    # If the divider is nil or <= 0, returns the raw value without normalization.
+    #
+    # @param value [Float] The raw parameter value to normalize
+    # @param credit_line_spec [CreditLineSpec] The credit line specification with divider
+    # @return [Float] The normalized value (or raw value if divider is invalid)
+    #
+    # @example With valid divider
+    #   # credit_line_spec.credit_line_divider = 30
+    #   # normalize_value(30000.0, credit_line_spec) → 1000.0
+    #
+    # @example With nil divider
+    #   # credit_line_spec.credit_line_divider = nil
+    #   # normalize_value(30000.0, credit_line_spec) → 30000.0
+    #
+    # @example With zero divider
+    #   # credit_line_spec.credit_line_divider = 0
+    #   # normalize_value(30000.0, credit_line_spec) → 30000.0
+    def normalize_value(value, credit_line_spec)
+      divider = credit_line_spec.credit_line_divider
+      return value if divider.nil? || divider <= 0 # No normalization if divider is NULL or invalid
+      value / divider
+    end
+
+    # Calculate the credit limit for a specific credit line
+    #
+    # Uses the formula:
+    # credit_limit = base_metric × credit_line_multiplier × score_percentage
+    #
+    # Then applies min/max constraints from the credit line spec.
+    #
+    # @param credit_line [CreditLine] The credit line being calculated
+    # @param base_metric [Float] The normalized base metric value
+    # @param credit_line_spec [CreditLineSpec] The credit line specification with multiplier and constraints
+    # @return [Hash] Result with :success, :limit, and :credit_line_spec
+    #
+    # @example Successful calculation
+    #   # base_metric = 1000.0
+    #   # credit_line_spec.credit_line_multiplier = 30.0
+    #   # loan_profile.score = 75.0
+    #   # calculated_limit = 1000 × 30 × 0.75 = 22500.0
+    #   # { success: true, limit: 22500.0, credit_line_spec: spec }
+    def calculate_credit_line_limit(credit_line, base_metric, credit_line_spec)
       score_percentage = loan_profile.score / 100.0
       calculated_limit = base_metric * credit_line_spec.credit_line_multiplier * score_percentage
-
       final_limit = apply_min_max_constraints(calculated_limit, credit_line_spec)
-
       { success: true, limit: final_limit, credit_line_spec: credit_line_spec }
     end
 
+    # Apply minimum and maximum constraints to a calculated credit limit
+    #
+    # Constraint rules:
+    # - If calculated_limit > max_amount → cap at max_amount
+    # - If calculated_limit < min_amount → set to 0.0 (ineligible)
+    # - Otherwise → use calculated_limit
+    #
+    # @param calculated_limit [Float] The initially calculated credit limit
+    # @param credit_line_spec [CreditLineSpec] The spec with min_amount and max_amount
+    # @return [Float] The constrained credit limit
+    #
+    # @example Within constraints
+    #   # calculated_limit = 22500.0, min = 5000, max = 50000
+    #   # Returns: 22500.0
+    #
+    # @example Exceeds maximum
+    #   # calculated_limit = 60000.0, min = 5000, max = 50000
+    #   # Returns: 50000.0 (capped)
+    #
+    # @example Below minimum
+    #   # calculated_limit = 3000.0, min = 5000, max = 50000
+    #   # Returns: 0.0 (ineligible)
     def apply_min_max_constraints(calculated_limit, credit_line_spec)
-      if calculated_limit > credit_line_spec.max_amount
-        return credit_line_spec.max_amount
-      end
-
-      if calculated_limit < credit_line_spec.min_amount
-        return 0.0
-      end
-
+      return credit_line_spec.max_amount if calculated_limit > credit_line_spec.max_amount
+      return 0.0 if calculated_limit < credit_line_spec.min_amount
       calculated_limit
     end
 
+    # Create an eligible credit line record with the calculated limit
+    #
+    # Creates a new EligibleCreditLine associated with the loan profile,
+    # setting both credit_limit and available_limit to the calculated amount.
+    # Risk is initially set to nil.
+    #
+    # @param credit_line [CreditLine] The credit line to create eligibility for
+    # @param limit [Float] The calculated credit limit
+    # @return [EligibleCreditLine] The created eligible credit line record
     def create_eligible_credit_line(credit_line, limit)
       loan_profile.eligible_credit_lines.create!(
         credit_line: credit_line,
@@ -134,26 +328,33 @@ module Dscf::Credit
       )
     end
 
+    # Update the loan profile's total limit
+    #
+    # Sums all available_limit values from the loan profile's eligible credit lines
+    # and updates the loan_profile.total_limit to reflect the current state.
+    #
+    # @return [void]
     def update_loan_profile_total_limit
       total_limit = loan_profile.eligible_credit_lines.sum(:available_limit)
       loan_profile.update!(total_limit: total_limit)
     end
 
+    # Build success result hash
+    #
+    # @param data [Array<EligibleCreditLine>] The created eligible credit lines
+    # @param message [String] Success message describing the result
+    # @return [Hash] Success response with data and message
     def success_result(data, message)
-      {
-        success: true,
-        data: data,
-        message: message
-      }
+      { success: true, data: data, message: message }
     end
 
+    # Build error result hash
+    #
+    # @param error_message [String] Error message describing what went wrong
+    # @return [Hash] Error response with success: false, error message, and detailed errors array
     def error_result(error_message)
       @errors << error_message unless @errors.include?(error_message)
-      {
-        success: false,
-        error: error_message,
-        errors: @errors
-      }
+      { success: false, error: error_message, errors: @errors }
     end
   end
 end

data/db/migrate/20251011202425_add_base_scoring_parameter_to_dscf_credit_credit_line_specs.rb

@@ -0,0 +1,5 @@
+class AddBaseScoringParameterToDscfCreditCreditLineSpecs < ActiveRecord::Migration[8.0]
+  def change
+    add_reference :dscf_credit_credit_line_specs, :base_scoring_parameter, null: true, foreign_key: { to_table: :dscf_credit_scoring_parameters }, index: true
+  end
+end

data/db/migrate/20251012100039_add_credit_line_divider_to_dscf_credit_credit_line_specs.rb

@@ -0,0 +1,5 @@
+class AddCreditLineDividerToDscfCreditCreditLineSpecs < ActiveRecord::Migration[8.0]
+  def change
+    add_column :dscf_credit_credit_line_specs, :credit_line_divider, :integer, null: true
+  end
+end

data/db/migrate/20251012115159_remove_default_from_credit_line_multiplier_in_credit_line_specs.rb

@@ -0,0 +1,5 @@
+class RemoveDefaultFromCreditLineMultiplierInCreditLineSpecs < ActiveRecord::Migration[8.0]
+  def change
+    change_column_default :dscf_credit_credit_line_specs, :credit_line_multiplier, from: 30.0, to: nil
+  end
+end

data/lib/dscf/credit/version.rb

@@ -1,5 +1,5 @@
 module Dscf
   module Credit
-    VERSION = "0.3.1"
+    VERSION = "0.3.3"
   end
 end

data/spec/factories/dscf/credit/credit_line_specs.rb

@@ -2,6 +2,7 @@ FactoryBot.define do
   factory :credit_line_spec, class: "Dscf::Credit::CreditLineSpec" do
     association :credit_line, factory: :credit_line
     association :created_by, factory: :user if defined?(Dscf::Core::User)
+    base_scoring_parameter { nil }
     min_amount { Faker::Number.decimal(l_digits: 4, r_digits: 2).to_f }
     max_amount { min_amount + Faker::Number.decimal(l_digits: 5, r_digits: 2).to_f }
     interest_rate { Faker::Number.decimal(l_digits: 1, r_digits: 4).to_f }
@@ -9,6 +10,7 @@ FactoryBot.define do
     facilitation_fee_rate { Faker::Number.decimal(l_digits: 1, r_digits: 4).to_f }
     tax_rate { Faker::Number.decimal(l_digits: 1, r_digits: 4).to_f }
     credit_line_multiplier { Faker::Number.between(from: 15, to: 60) }
+    credit_line_divider { [ nil, Faker::Number.between(from: 1, to: 365) ].sample }
     max_penalty_days { Faker::Number.between(from: 30, to: 90) }
     loan_duration { Faker::Number.between(from: 30, to: 365) }
     interest_frequency { %w[daily weekly monthly quarterly annually].sample }

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: dscf-credit
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.3
 platform: ruby
 authors:
 - Adoniyas
 bindir: bin
 cert_chain: []
-date: 2025-10-10 00:00:00.000000000 Z
+date: 2025-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dscf-core
@@ -446,6 +446,9 @@ files:
 - db/migrate/20250825231109_create_dscf_credit_bank_staff.rb
 - db/migrate/20250917120000_create_dscf_credit_eligible_credit_lines.rb
 - db/migrate/20251003132939_create_dscf_credit_loan_accruals.rb
+- db/migrate/20251011202425_add_base_scoring_parameter_to_dscf_credit_credit_line_specs.rb
+- db/migrate/20251012100039_add_credit_line_divider_to_dscf_credit_credit_line_specs.rb
+- db/migrate/20251012115159_remove_default_from_credit_line_multiplier_in_credit_line_specs.rb
 - db/seeds.rb
 - lib/dscf/credit.rb
 - lib/dscf/credit/engine.rb