dscf-credit 0.2.3 → 0.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c03116320f239a1f9f953742c429298bf629e0731e1938dc1870107bd2e3a74f
-  data.tar.gz: da5c7c4a877ce2c82cd0300c25c9686f8ea1254bcfd9b82c856ecd99fb8ef5a7
+  metadata.gz: d9f8c9b62c4ec5893c8ab1b234073b103d9eb78370d133bd1e0b40b56aea1fd0
+  data.tar.gz: 12447006ba8f6896e6316cbf20093b3527454ca144659b00839e435284adea9d
 SHA512:
-  metadata.gz: 0ae96ca00a9c2cef5bb46b59a58e0b4cf13263cb89903a19bbf8c1a03c709d2a75ac59e4ea394668c4a5f2b2ea298cbfd963c22eb1af810a5fb4c6ed9c266bb3
-  data.tar.gz: 879a870adbb92ac789ed00096d658e1c729107b94572c4ee66df10c31fcf123b549ceec50499b295cb16e94f446f0218ad7f0c6430fd5839c9c91f31e4ff19fb
+  metadata.gz: d5672372c71088c52598cc2839fd5f6b71955ad9b781b3e2c568a37407858b5cdeec1cc37029208000f77cd3bb1d66d9f21a896abda6f48aab182f21436b0fdd
+  data.tar.gz: 630a449898f52513090be1aacb501a29ec977492f67e8a2e097056360ac83188bd632ddf754baaf1a745ebc1660599c29332e1f466b2de5aafffa899888d7f5f

data/app/controllers/dscf/credit/categories_controller.rb

@@ -6,7 +6,7 @@ module Dscf::Credit
 
     def model_params
       params.require(:category).permit(
-        :type,
+        :category_type,
         :name,
         :description,
         :document_reference

data/app/controllers/dscf/credit/eligible_credit_lines_controller.rb

@@ -68,7 +68,8 @@ module Dscf::Credit
         :credit_line_id,
         :credit_limit,
         :available_limit,
-        :risk
+        :risk,
+        :locked
       )
     end
 
@@ -77,7 +78,7 @@ module Dscf::Credit
     end
 
     def allowed_order_columns
-      %w[id credit_limit available_limit risk created_at updated_at loan_profile_id credit_line_id]
+      %w[id credit_limit available_limit risk locked created_at updated_at loan_profile_id credit_line_id]
     end
 
     def default_serializer_includes

data/app/controllers/dscf/credit/loan_applications_controller.rb

@@ -145,6 +145,24 @@ module Dscf::Credit
       end
     end
 
+    def create_loan_profile_for_approved_application(loan_application, score)
+      profile_service = LoanProfileCreationService.new(loan_application, score)
+      profile_result = profile_service.create_loan_profile
+
+      unless profile_result[:success]
+        error_message = "Failed to create loan profile for approved application #{loan_application.id}: #{profile_result[:error]}"
+        Rails.logger.error error_message
+        # Raise error to rollback the entire transaction including score and review status
+        raise StandardError, error_message
+      else
+        Rails.logger.info "Loan profile created successfully for approved application #{loan_application.id}"
+      end
+
+      profile_result
+    end
+
+
+
     private
 
     def update_review_status(loan_application, status)
@@ -179,7 +197,7 @@ module Dscf::Credit
         {
           message: "Automatically rejected based on credit score: #{score}% (<50%)"
         }
-      when "pending_review"
+      when "pending"
         {
           message: "Manual review required based on credit score: #{score}% (50%-60%)"
         }
@@ -191,22 +209,6 @@ module Dscf::Credit
     end
 
     # Create loan profile for approved applications
-    def create_loan_profile_for_approved_application(loan_application, score)
-      profile_service = LoanProfileCreationService.new(loan_application, score)
-      profile_result = profile_service.create_loan_profile
-
-      unless profile_result[:success]
-        error_message = "Failed to create loan profile for approved application #{loan_application.id}: #{profile_result[:error]}"
-        Rails.logger.error error_message
-        # Raise error to rollback the entire transaction including score and review status
-        raise StandardError, error_message
-      else
-        Rails.logger.info "Loan profile created successfully for approved application #{loan_application.id}"
-      end
-
-      profile_result
-    end
-
     def create_loan_profile_from_review(review)
       loan_application = review.reviewable # Assumes Review belongs_to :reviewable (polymorphic or direct association to LoanApplication)
       score = loan_application.score # Assumes score is already set on the loan application

data/app/models/dscf/credit/category.rb

@@ -1,18 +1,17 @@
 module Dscf::Credit
   class Category < ApplicationRecord
     self.table_name = "dscf_credit_categories"
-    self.inheritance_column = nil  # Disable STI since 'type' is a business attribute
 
     has_many :credit_lines, class_name: "Dscf::Credit::CreditLine", foreign_key: "category_id", dependent: :nullify
     has_many :scoring_parameters, class_name: "Dscf::Credit::ScoringParameter", foreign_key: "category_id", dependent: :nullify
 
-    validates :type, :name, presence: true
-    validates :name, uniqueness: { scope: :type }
+    validates :category_type, :name, presence: true
+    validates :name, uniqueness: { scope: :category_type }
 
-    scope :by_type, ->(category_type) { where(type: category_type) }
+    scope :by_type, ->(category_type) { where(category_type: category_type) }
 
     def self.ransackable_attributes(auth_object = nil)
-      %w[id type name description document_reference created_at updated_at]
+      %w[id category_type name description document_reference created_at updated_at]
     end
 
     def self.ransackable_associations(auth_object = nil)

data/app/models/dscf/credit/eligible_credit_line.rb

@@ -16,9 +16,11 @@ module Dscf::Credit
     scope :by_risk_range, ->(min, max) { where(risk: min..max) }
     scope :by_credit_limit_range, ->(min, max) { where(credit_limit: min..max) }
     scope :by_available_limit_range, ->(min, max) { where(available_limit: min..max) }
+    scope :locked, -> { where(locked: true) }
+    scope :unlocked, -> { where(locked: false) }
 
     def self.ransackable_attributes(auth_object = nil)
-      %w[id credit_limit available_limit risk created_at updated_at]
+      %w[id credit_limit available_limit risk locked created_at updated_at]
     end
 
     def self.ransackable_associations(auth_object = nil)

data/app/serializers/dscf/credit/category_serializer.rb

@@ -1,6 +1,6 @@
 module Dscf::Credit
   class CategorySerializer < ActiveModel::Serializer
-    attributes :id, :type, :name, :description, :document_reference, :created_at, :updated_at
+    attributes :id, :category_type, :name, :description, :document_reference, :created_at, :updated_at
 
     has_many :credit_lines, serializer: Dscf::Credit::CreditLineSerializer
     has_many :scoring_parameters, serializer: Dscf::Credit::ScoringParameterSerializer

data/app/serializers/dscf/credit/eligible_credit_line_serializer.rb

@@ -1,6 +1,6 @@
 module Dscf::Credit
   class EligibleCreditLineSerializer < ActiveModel::Serializer
-    attributes :id, :credit_limit, :available_limit, :risk, :created_at, :updated_at
+    attributes :id, :credit_limit, :available_limit, :risk, :locked, :created_at, :updated_at
 
     belongs_to :loan_profile, serializer: Dscf::Credit::LoanProfileSerializer
     belongs_to :credit_line, serializer: Dscf::Credit::CreditLineSerializer

data/db/migrate/20250822091011_create_dscf_credit_categories.rb

@@ -1,7 +1,7 @@
 class CreateDscfCreditCategories < ActiveRecord::Migration[8.0]
   def change
     create_table :dscf_credit_categories do |t|
-      t.string :type, null: false
+      t.string :category_type, null: false
       t.string :name, null: false
       t.text :description
       t.string :document_reference
@@ -9,9 +9,9 @@ class CreateDscfCreditCategories < ActiveRecord::Migration[8.0]
       t.timestamps
     end
 
-    add_index :dscf_credit_categories, :type
+    add_index :dscf_credit_categories, :category_type
     add_index :dscf_credit_categories, :name
     add_index :dscf_credit_categories, :document_reference
-    add_index :dscf_credit_categories, [ :type, :name ], unique: true
+    add_index :dscf_credit_categories, [ :category_type, :name ], unique: true
   end
 end

data/db/migrate/20250917120000_create_dscf_credit_eligible_credit_lines.rb

@@ -6,6 +6,7 @@ class CreateDscfCreditEligibleCreditLines < ActiveRecord::Migration[8.0]
       t.decimal :credit_limit, precision: 15, scale: 2, null: false
       t.decimal :available_limit, precision: 15, scale: 2, null: false
       t.decimal :risk, precision: 5, scale: 4, null: true
+      t.boolean :locked, default: false, null: false
 
       t.timestamps
     end

data/db/seeds.rb

@@ -340,24 +340,24 @@ end
 
 # 4.5. Categories (independent)
 puts "Seeding categories..."
-sme_category = Dscf::Credit::Category.find_or_create_by(type: 'credit_line', name: 'SME') do |category|
+sme_category = Dscf::Credit::Category.find_or_create_by(category_type: 'credit_line', name: 'SME') do |category|
   category.description = 'Small and Medium Enterprise credit category'
 end
 
-personal_category = Dscf::Credit::Category.find_or_create_by(type: 'credit_line', name: 'Personal') do |category|
+personal_category = Dscf::Credit::Category.find_or_create_by(category_type: 'credit_line', name: 'Personal') do |category|
   category.description = 'Personal credit category for individuals'
 end
 
-agricultural_category = Dscf::Credit::Category.find_or_create_by(type: 'credit_line', name: 'Agricultural') do |category|
+agricultural_category = Dscf::Credit::Category.find_or_create_by(category_type: 'credit_line', name: 'Agricultural') do |category|
   category.description = 'Agricultural sector credit category'
 end
 
-corporate_category = Dscf::Credit::Category.find_or_create_by(type: 'credit_line', name: 'Corporate') do |category|
+corporate_category = Dscf::Credit::Category.find_or_create_by(category_type: 'credit_line', name: 'Corporate') do |category|
   category.description = 'Corporate credit category for large businesses'
 end
 
 # Add eligibility category for scoring
-eligibility_category = Dscf::Credit::Category.find_or_create_by(type: 'eligibility', name: 'default') do |category|
+eligibility_category = Dscf::Credit::Category.find_or_create_by(category_type: 'eligibility', name: 'default') do |category|
   category.description = 'Default eligibility category for credit scoring'
 end
 

data/lib/dscf/credit/version.rb

@@ -1,5 +1,5 @@
 module Dscf
   module Credit
-    VERSION = "0.2.3"
+    VERSION = "0.2.5"
   end
 end

data/spec/factories/dscf/credit/categories.rb

@@ -1,27 +1,27 @@
 FactoryBot.define do
   factory :category, class: "Dscf::Credit::Category" do
-    type { %w[scoring loan_profile payment risk_assessment].sample }
-    sequence(:name) { |n| "#{type.humanize} Category #{n}" }
+    category_type { %w[scoring loan_profile payment risk_assessment].sample }
+    sequence(:name) { |n| "#{category_type.humanize} Category #{n}" }
     description { Faker::Lorem.paragraph }
     document_reference { Faker::Alphanumeric.alphanumeric(number: 10).upcase }
 
     trait :scoring do
-      type { "scoring" }
+      category_type { "scoring" }
       name { "Scoring Category" }
     end
 
     trait :loan_profile do
-      type { "loan_profile" }
+      category_type { "loan_profile" }
       name { "Loan Profile Category" }
     end
 
     trait :payment do
-      type { "payment" }
+      category_type { "payment" }
       name { "Payment Category" }
     end
 
     trait :risk_assessment do
-      type { "risk_assessment" }
+      category_type { "risk_assessment" }
       name { "Risk Assessment Category" }
     end
   end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: dscf-credit
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.5
 platform: ruby
 authors:
 - Adoniyas
 bindir: bin
 cert_chain: []
-date: 2025-10-07 00:00:00.000000000 Z
+date: 2025-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dscf-core