dscf-credit 0.2.2 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3c8471bd555308d0b88c282f893299234859a46f02ae02c003f02b147115e1ae
-  data.tar.gz: 3becd29b404c498ff195e300afa0c313a00155cb20d2ec600f39da1d36e1a45e
+  metadata.gz: '0883e69edbfba633fb3b886139de199303da27bfaa0ed9402c39d7ed036fb778'
+  data.tar.gz: e1ea1f2d623086de0e807c1e986cb340b41d10501056960a1f4c7f8b03b84192
 SHA512:
-  metadata.gz: c205f203030be0f10872f4dcc1dac30b3ad797abe5a006a071bd579459bd13bf95fb821144d86f96c021e8eb1b7494e1544b6a046eb7b67150484cfeb7910116
-  data.tar.gz: 4910b18be7d23f314940a74e70b2cf1e032b8134e50903ed1770283e5a363af87b5986f32d0308799620326fda211c123a735747d4d9eedd240c958153b87d66
+  metadata.gz: f624bce3e341b942f97bc54201f94f995db7dc8a507083c8061d6fdfc58e982f0f2c2f13b573c881b37ffc5e1170184db026c9ae247473a05aef86620620117f
+  data.tar.gz: ba02250152266b20ecca88cf929b2379b3931fd7d1f0dd9561d632e1928a6c15c7b83deaac2ffa8930601f8bd6de9969b7578a140a08d43aeb272070a95f5138

data/app/controllers/dscf/credit/loan_applications_controller.rb

@@ -2,6 +2,26 @@ module Dscf::Credit
   class LoanApplicationsController < ApplicationController
     include Dscf::Core::Common
     include Dscf::Core::ReviewableController
+    reviewable_context :default,
+      statuses: %w[pending approved rejected modify],
+      initial_status: "pending",
+      transitions: {
+        "pending" => %w[approved rejected modify],
+        "modify" => [ "pending" ]
+      },
+    actions: {
+      approve: {
+        status: "approved",
+        after: ->(review) {
+          loan_application = review.reviewable
+          score = loan_application.score
+          LoanApplicationsController.new.create_loan_profile_for_approved_application(loan_application, score)
+        }
+      },
+      reject: { status: "rejected", require_feedback: true },
+      request_modification: { status: "modify", require_feedback: true },
+      resubmit: { status: "pending", update_model: true }
+    }
 
     def create
       super do
@@ -125,6 +145,24 @@ module Dscf::Credit
       end
     end
 
+    def create_loan_profile_for_approved_application(loan_application, score)
+      profile_service = LoanProfileCreationService.new(loan_application, score)
+      profile_result = profile_service.create_loan_profile
+
+      unless profile_result[:success]
+        error_message = "Failed to create loan profile for approved application #{loan_application.id}: #{profile_result[:error]}"
+        Rails.logger.error error_message
+        # Raise error to rollback the entire transaction including score and review status
+        raise StandardError, error_message
+      else
+        Rails.logger.info "Loan profile created successfully for approved application #{loan_application.id}"
+      end
+
+      profile_result
+    end
+
+
+
     private
 
     def update_review_status(loan_application, status)
@@ -171,20 +209,25 @@ module Dscf::Credit
     end
 
     # Create loan profile for approved applications
-    def create_loan_profile_for_approved_application(loan_application, score)
+    def create_loan_profile_from_review(review)
+      loan_application = review.reviewable # Assumes Review belongs_to :reviewable (polymorphic or direct association to LoanApplication)
+      score = loan_application.score # Assumes score is already set on the loan application
+
+      unless score
+        Rails.logger.warn "No score available for loan application #{loan_application.id} during approve callback"
+        return
+      end
+
       profile_service = LoanProfileCreationService.new(loan_application, score)
       profile_result = profile_service.create_loan_profile
 
       unless profile_result[:success]
         error_message = "Failed to create loan profile for approved application #{loan_application.id}: #{profile_result[:error]}"
         Rails.logger.error error_message
-        # Raise error to rollback the entire transaction including score and review status
-        raise StandardError, error_message
+        raise StandardError, error_message # This will rollback the transaction in perform_review_action
       else
-        Rails.logger.info "Loan profile created successfully for approved application #{loan_application.id}"
+        Rails.logger.info "Loan profile created successfully for approved application #{loan_application.id} via review callback"
       end
-
-      profile_result
     end
 
     def model_params

data/app/services/dscf/credit/credit_scoring_engine.rb

@@ -255,7 +255,7 @@ module Dscf::Credit
       when 0...50
         "rejected"
       when 50..60
-        "pending_review"
+        "pending"
       else # score > 60
         "approved"
       end

data/db/seeds.rb

@@ -568,99 +568,6 @@ puts "Seeding loan profile scoring specs..."
 # Note: This will be moved after loan profiles are created
 
 # 10.5. Loan Applications (depends on banks, users, and bank branches)
-puts "Seeding loan applications..."
-loan_application1 = Dscf::Credit::LoanApplication.find_or_create_by(
-  bank: bunna_bank,
-  user_id: user2.id,
-  review_branch: bunna_head_office
-) do |application|
-  application.backer = user1
-  application.bank_statement_source = "internal"
-  application.user_info = {
-    name: "Jane Smith",
-    phone: "+251922334455",
-    email: "jane.smith@example.com",
-    address: "123 Main St, Addis Ababa",
-    id_number: "ID123456789",
-    date_of_birth: "1985-05-15"
-  }
-  application.facilitator_info = {
-    business_name: "ABC Trading Company",
-    license_number: "LIC001234",
-    business_type: "retail",
-    years_in_business: 5,
-    monthly_turnover: 150000.00
-  }
-  application.bank_info = {
-    account_number: "123456789012",
-    account_holder: "Jane Smith",
-    bank_name: "Bunna Bank",
-    branch_name: "Head Office"
-  }
-  application.field_assessment = {
-    credit_score: 720,
-    risk_level: "medium",
-    recommendation: "approved",
-    assessed_by: "Field Officer A",
-    assessment_date: Time.current.iso8601
-  }
-end
-
-# Create approved review for loan_application1
-Dscf::Core::Review.find_or_create_by(
-  reviewable: loan_application1,
-  reviewed_by: admin_user
-) do |review|
-  review.status = 'approved'
-  review.reviewed_at = Time.current
-end
-
-loan_application2 = Dscf::Credit::LoanApplication.find_or_create_by(
-  bank: bunna_bank,
-  user_id: user3.id,
-  review_branch: bunna_merkato_branch
-) do |application|
-  application.backer = user1
-  application.bank_statement_source = "external"
-  application.user_info = {
-    name: "Mike Johnson",
-    phone: "+251933445566",
-    email: "mike.johnson@example.com",
-    address: "456 Oak Ave, Addis Ababa",
-    id_number: "ID987654321",
-    date_of_birth: "1980-12-10"
-  }
-  application.facilitator_info = {
-    business_name: "XYZ Wholesale",
-    license_number: "LIC005678",
-    business_type: "wholesale",
-    years_in_business: 8,
-    monthly_turnover: 500000.00
-  }
-  application.bank_info = {
-    account_number: "987654321098",
-    account_holder: "Mike Johnson",
-    bank_name: "Commercial Bank",
-    branch_name: "Main Branch"
-  }
-  application.field_assessment = {
-    credit_score: 650,
-    risk_level: "high",
-    recommendation: "conditional_approval",
-    assessed_by: "Field Officer B",
-    assessment_date: Time.current.iso8601
-  }
-  application.score = 65.0
-end
-
-# Create pending review for loan_application2
-Dscf::Core::Review.find_or_create_by(
-  reviewable: loan_application2,
-  reviewed_by: bank_admin
-) do |review|
-  review.status = 'pending'
-  review.reviewed_at = Time.current
-end
 
 # 10.6. Facilitator Applications (depends on users and banks)
 puts "Seeding facilitator applications..."
@@ -750,119 +657,6 @@ Dscf::Core::Review.find_or_create_by(
 end
 
 # 11. Loan Profiles (depends on loan applications)
-puts "Seeding loan profiles..."
-loan_profile1 = Dscf::Credit::LoanProfile.find_or_create_by(
-  loan_application: loan_application1
-) do |profile|
-  profile.code = "BB000001"
-  profile.score = 78.5
-  profile.total_limit = 100000.00
-end
-
-# Create approved review for loan_profile1
-Dscf::Core::Review.find_or_create_by(
-  reviewable: loan_profile1,
-  reviewed_by: admin_user
-) do |review|
-  review.status = 'approved'
-  review.reviewed_at = Time.current
-end
-
-# 12. Loan Profile Scoring Specs (depends on loan profiles)
-puts "Seeding loan profile scoring specs..."
-Dscf::Credit::LoanProfileScoringSpec.create!(
-  loan_profile: loan_profile1,
-  scoring_input_data: {
-    'monthly_income' => 45000,
-    'credit_history_score' => 720,
-    'employment_type' => 'permanent',
-    'years_at_job' => 3,
-    'existing_debt' => 15000,
-    'average_daily_purchase' => 15000  # Wholesaler's average daily purchase volume
-  },
-  score: 78.5,
-  total_limit: 100000.00,
-  active: true,
-  created_by: admin_user
-)
-
-# 11. Eligible Credit Lines (depends on loan profiles and credit lines)
-puts "Seeding eligible credit lines..."
-Dscf::Credit::EligibleCreditLine.create!(
-  loan_profile: loan_profile1,
-  credit_line: credit_line1,
-  credit_limit: 75000.00,
-  available_limit: 67500.00,
-  risk: 0.35
-)
-
-Dscf::Credit::EligibleCreditLine.create!(
-  loan_profile: loan_profile1,
-  credit_line: credit_line2,
-  credit_limit: 50000.00,
-  available_limit: 42500.00,
-  risk: 0.45
-)
-
-# 12. Loans (depends on loan profiles and credit lines)
-puts "Seeding loans..."
-loan1 = Dscf::Credit::Loan.create!(
-  loan_profile: loan_profile1,
-  credit_line: credit_line1,
-  status: 'active',
-  principal_amount: 50000.00,
-  remaining_amount: 50000.00,
-  due_date: 3.months.from_now.to_date,
-  disbursed_at: 1.day.ago,
-  active: true
-)
-
-# 12.5. Loan Accruals (depends on loans)
-puts "Seeding loan accruals..."
-Dscf::Credit::LoanAccrual.create!(
-  loan: loan1,
-  accrual_type: 'interest',
-  amount: 250.00,
-  applied_on: 1.month.ago.to_date,
-  status: 'pending'
-)
-
-Dscf::Credit::LoanAccrual.create!(
-  loan: loan1,
-  accrual_type: 'facilitation_fee',
-  amount: 1000.00,
-  applied_on: 1.day.ago.to_date,
-  status: 'paid'
-)
-
-# 13. Loan Transactions (depends on loans)
-puts "Seeding loan transactions..."
-Dscf::Credit::LoanTransaction.create!(
-  loan: loan1,
-  transaction_type: 'disbursement',
-  amount: 50000.00,
-  transaction_reference: "TXN-DISB-#{Time.current.to_i}",
-  status: 'completed'
-)
-
-Dscf::Credit::LoanTransaction.create!(
-  loan: loan1,
-  transaction_type: 'interest_accrual',
-  amount: 2500.00,
-  transaction_reference: "TXN-INT-#{Time.current.to_i}",
-  status: 'completed'
-)
-
-# 14. Daily Routine Transactions (depends on loans)
-puts "Seeding daily routine transactions..."
-Dscf::Credit::DailyRoutineTransaction.create!(
-  loan: loan1,
-  routine_type: 'interest_calculation',
-  amount: 83.33,
-  status: 'completed',
-  initiated_at: Date.current.beginning_of_day,
-  approved_at: Date.current.beginning_of_day + 1.hour
-)
 
 puts "DSCF Credit Engine seed data completed successfully!"
 puts "Created sample data for all models with proper relationships."

data/lib/dscf/credit/version.rb

@@ -1,5 +1,5 @@
 module Dscf
   module Credit
-    VERSION = "0.2.2"
+    VERSION = "0.2.4"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dscf-credit
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.4
 platform: ruby
 authors:
 - Adoniyas