dscf-credit 0.2.1 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d6af7d6aeb34ec3aa7d630f441bdfc54657b07640135bb862cc3d9b0eccd03c9
-  data.tar.gz: 15b37f5d6cfc2462b31267c16e5d85e738326d1479861abedf127362bfd7d42f
+  metadata.gz: c03116320f239a1f9f953742c429298bf629e0731e1938dc1870107bd2e3a74f
+  data.tar.gz: da5c7c4a877ce2c82cd0300c25c9686f8ea1254bcfd9b82c856ecd99fb8ef5a7
 SHA512:
-  metadata.gz: 7815d27fc10a061438a37b46a77506a83ef5fab2c08bf5f04fe4b517b52ed7354b0e7a08ba292803a95f79b991a13f1ff8ac966aeb121b2118c40ccfdaa0c493
-  data.tar.gz: fa2684a66f074ab72be71ed458d717b4fd8e04d920440808ce0b3638b914fc2bf3bcc2fdc80881acb7596e1a3fbd0c70b4d0905b2674c677abbe2838eda713cf
+  metadata.gz: 0ae96ca00a9c2cef5bb46b59a58e0b4cf13263cb89903a19bbf8c1a03c709d2a75ac59e4ea394668c4a5f2b2ea298cbfd963c22eb1af810a5fb4c6ed9c266bb3
+  data.tar.gz: 879a870adbb92ac789ed00096d658e1c729107b94572c4ee66df10c31fcf123b549ceec50499b295cb16e94f446f0218ad7f0c6430fd5839c9c91f31e4ff19fb

data/app/controllers/dscf/credit/loan_applications_controller.rb

@@ -2,6 +2,26 @@ module Dscf::Credit
   class LoanApplicationsController < ApplicationController
     include Dscf::Core::Common
     include Dscf::Core::ReviewableController
+    reviewable_context :default,
+      statuses: %w[pending approved rejected modify],
+      initial_status: "pending",
+      transitions: {
+        "pending" => %w[approved rejected modify],
+        "modify" => [ "pending" ]
+      },
+    actions: {
+      approve: {
+        status: "approved",
+        after: ->(review) {
+          loan_application = review.reviewable
+          score = loan_application.score
+          LoanApplicationsController.new.create_loan_profile_for_approved_application(loan_application, score)
+        }
+      },
+      reject: { status: "rejected", require_feedback: true },
+      request_modification: { status: "modify", require_feedback: true },
+      resubmit: { status: "pending", update_model: true }
+    }
 
     def create
       super do
@@ -187,6 +207,27 @@ module Dscf::Credit
       profile_result
     end
 
+    def create_loan_profile_from_review(review)
+      loan_application = review.reviewable # Assumes Review belongs_to :reviewable (polymorphic or direct association to LoanApplication)
+      score = loan_application.score # Assumes score is already set on the loan application
+
+      unless score
+        Rails.logger.warn "No score available for loan application #{loan_application.id} during approve callback"
+        return
+      end
+
+      profile_service = LoanProfileCreationService.new(loan_application, score)
+      profile_result = profile_service.create_loan_profile
+
+      unless profile_result[:success]
+        error_message = "Failed to create loan profile for approved application #{loan_application.id}: #{profile_result[:error]}"
+        Rails.logger.error error_message
+        raise StandardError, error_message # This will rollback the transaction in perform_review_action
+      else
+        Rails.logger.info "Loan profile created successfully for approved application #{loan_application.id} via review callback"
+      end
+    end
+
     def model_params
       params.require(:loan_application).permit(
         :bank_id,

data/app/services/dscf/credit/credit_scoring_engine.rb

@@ -107,41 +107,47 @@ module Dscf::Credit
     end
 
     def extract_parameter_value(parameter)
-      param_type_name = parameter.scoring_param_type.name
       parameter_id = parameter.id.to_s
 
-      # Get the appropriate JSON field based on parameter type
-      json_field = get_json_field_for_param_type(param_type_name)
-      return nil unless json_field
+      all_json_fields = {
+        user_info: loan_application.user_info || {},
+        bank_info: loan_application.bank_info || {},
+        facilitator_info: loan_application.facilitator_info || {},
+        field_assessment: loan_application.field_assessment || {}
+      }
+
+      param_data = nil
+      found_in_field = nil
+
+      all_json_fields.each do |field_name, field_data|
+        if field_data.key?(parameter_id)
+          param_data = field_data[parameter_id]
+          found_in_field = field_name
+          break  # Stop at first match (IDs should be unique across fields)
+        end
+      end
+
+      if param_data.nil?
+        Rails.logger.warn "Parameter #{parameter_id} (#{parameter.name}) not found in any JSON field for loan_app #{loan_application.id}"
+        return nil
+      end
 
-      # Extract value using parameter ID as key
-      param_data = json_field[parameter_id]
-      return nil unless param_data.is_a?(Hash)
+      unless param_data.is_a?(Hash)
+        Rails.logger.warn "Invalid param_data for #{parameter_id} in #{found_in_field}: expected Hash, got #{param_data.class}"
+        return nil
+      end
 
-      # Validate that the param_name matches (optional safety check)
+      # Validate param_name matches (optional safety check)
       expected_param_name = param_data["param_name"]
       if expected_param_name && expected_param_name != parameter.name
-        Rails.logger.warn "Parameter name mismatch for ID #{parameter_id}: expected '#{parameter.name}', got '#{expected_param_name}'"
+        Rails.logger.warn "Parameter name mismatch for ID #{parameter_id} in #{found_in_field}: expected '#{parameter.name}', got '#{expected_param_name}'"
       end
 
-      param_data["value"]
+      raw_value = param_data["value"]
+      Rails.logger.debug "Extracted #{parameter.name} (ID #{parameter_id}) from #{found_in_field}: value=#{raw_value}"
+      raw_value
     end
 
-    def get_json_field_for_param_type(param_type_name)
-      case param_type_name.downcase
-      when "user_info"
-        loan_application.user_info || {}
-      when "bank_info"
-        loan_application.bank_info || {}
-      when "facilitator_info"
-        loan_application.facilitator_info || {}
-      when "field_assessment"
-        loan_application.field_assessment || {}
-      else
-        Rails.logger.warn "Unknown parameter type: #{param_type_name}"
-        nil
-      end
-    end
 
     def normalize_parameter_value(parameter, raw_value)
       return 0.0 if raw_value.nil?
@@ -249,7 +255,7 @@ module Dscf::Credit
       when 0...50
         "rejected"
       when 50..60
-        "pending_review"
+        "pending"
       else # score > 60
         "approved"
       end

data/db/seeds.rb

@@ -568,99 +568,6 @@ puts "Seeding loan profile scoring specs..."
 # Note: This will be moved after loan profiles are created
 
 # 10.5. Loan Applications (depends on banks, users, and bank branches)
-puts "Seeding loan applications..."
-loan_application1 = Dscf::Credit::LoanApplication.find_or_create_by(
-  bank: bunna_bank,
-  user_id: user2.id,
-  review_branch: bunna_head_office
-) do |application|
-  application.backer = user1
-  application.bank_statement_source = "internal"
-  application.user_info = {
-    name: "Jane Smith",
-    phone: "+251922334455",
-    email: "jane.smith@example.com",
-    address: "123 Main St, Addis Ababa",
-    id_number: "ID123456789",
-    date_of_birth: "1985-05-15"
-  }
-  application.facilitator_info = {
-    business_name: "ABC Trading Company",
-    license_number: "LIC001234",
-    business_type: "retail",
-    years_in_business: 5,
-    monthly_turnover: 150000.00
-  }
-  application.bank_info = {
-    account_number: "123456789012",
-    account_holder: "Jane Smith",
-    bank_name: "Bunna Bank",
-    branch_name: "Head Office"
-  }
-  application.field_assessment = {
-    credit_score: 720,
-    risk_level: "medium",
-    recommendation: "approved",
-    assessed_by: "Field Officer A",
-    assessment_date: Time.current.iso8601
-  }
-end
-
-# Create approved review for loan_application1
-Dscf::Core::Review.find_or_create_by(
-  reviewable: loan_application1,
-  reviewed_by: admin_user
-) do |review|
-  review.status = 'approved'
-  review.reviewed_at = Time.current
-end
-
-loan_application2 = Dscf::Credit::LoanApplication.find_or_create_by(
-  bank: bunna_bank,
-  user_id: user3.id,
-  review_branch: bunna_merkato_branch
-) do |application|
-  application.backer = user1
-  application.bank_statement_source = "external"
-  application.user_info = {
-    name: "Mike Johnson",
-    phone: "+251933445566",
-    email: "mike.johnson@example.com",
-    address: "456 Oak Ave, Addis Ababa",
-    id_number: "ID987654321",
-    date_of_birth: "1980-12-10"
-  }
-  application.facilitator_info = {
-    business_name: "XYZ Wholesale",
-    license_number: "LIC005678",
-    business_type: "wholesale",
-    years_in_business: 8,
-    monthly_turnover: 500000.00
-  }
-  application.bank_info = {
-    account_number: "987654321098",
-    account_holder: "Mike Johnson",
-    bank_name: "Commercial Bank",
-    branch_name: "Main Branch"
-  }
-  application.field_assessment = {
-    credit_score: 650,
-    risk_level: "high",
-    recommendation: "conditional_approval",
-    assessed_by: "Field Officer B",
-    assessment_date: Time.current.iso8601
-  }
-  application.score = 65.0
-end
-
-# Create pending review for loan_application2
-Dscf::Core::Review.find_or_create_by(
-  reviewable: loan_application2,
-  reviewed_by: bank_admin
-) do |review|
-  review.status = 'pending'
-  review.reviewed_at = Time.current
-end
 
 # 10.6. Facilitator Applications (depends on users and banks)
 puts "Seeding facilitator applications..."
@@ -750,119 +657,6 @@ Dscf::Core::Review.find_or_create_by(
 end
 
 # 11. Loan Profiles (depends on loan applications)
-puts "Seeding loan profiles..."
-loan_profile1 = Dscf::Credit::LoanProfile.find_or_create_by(
-  loan_application: loan_application1
-) do |profile|
-  profile.code = "BB000001"
-  profile.score = 78.5
-  profile.total_limit = 100000.00
-end
-
-# Create approved review for loan_profile1
-Dscf::Core::Review.find_or_create_by(
-  reviewable: loan_profile1,
-  reviewed_by: admin_user
-) do |review|
-  review.status = 'approved'
-  review.reviewed_at = Time.current
-end
-
-# 12. Loan Profile Scoring Specs (depends on loan profiles)
-puts "Seeding loan profile scoring specs..."
-Dscf::Credit::LoanProfileScoringSpec.create!(
-  loan_profile: loan_profile1,
-  scoring_input_data: {
-    'monthly_income' => 45000,
-    'credit_history_score' => 720,
-    'employment_type' => 'permanent',
-    'years_at_job' => 3,
-    'existing_debt' => 15000,
-    'average_daily_purchase' => 15000  # Wholesaler's average daily purchase volume
-  },
-  score: 78.5,
-  total_limit: 100000.00,
-  active: true,
-  created_by: admin_user
-)
-
-# 11. Eligible Credit Lines (depends on loan profiles and credit lines)
-puts "Seeding eligible credit lines..."
-Dscf::Credit::EligibleCreditLine.create!(
-  loan_profile: loan_profile1,
-  credit_line: credit_line1,
-  credit_limit: 75000.00,
-  available_limit: 67500.00,
-  risk: 0.35
-)
-
-Dscf::Credit::EligibleCreditLine.create!(
-  loan_profile: loan_profile1,
-  credit_line: credit_line2,
-  credit_limit: 50000.00,
-  available_limit: 42500.00,
-  risk: 0.45
-)
-
-# 12. Loans (depends on loan profiles and credit lines)
-puts "Seeding loans..."
-loan1 = Dscf::Credit::Loan.create!(
-  loan_profile: loan_profile1,
-  credit_line: credit_line1,
-  status: 'active',
-  principal_amount: 50000.00,
-  remaining_amount: 50000.00,
-  due_date: 3.months.from_now.to_date,
-  disbursed_at: 1.day.ago,
-  active: true
-)
-
-# 12.5. Loan Accruals (depends on loans)
-puts "Seeding loan accruals..."
-Dscf::Credit::LoanAccrual.create!(
-  loan: loan1,
-  accrual_type: 'interest',
-  amount: 250.00,
-  applied_on: 1.month.ago.to_date,
-  status: 'pending'
-)
-
-Dscf::Credit::LoanAccrual.create!(
-  loan: loan1,
-  accrual_type: 'facilitation_fee',
-  amount: 1000.00,
-  applied_on: 1.day.ago.to_date,
-  status: 'paid'
-)
-
-# 13. Loan Transactions (depends on loans)
-puts "Seeding loan transactions..."
-Dscf::Credit::LoanTransaction.create!(
-  loan: loan1,
-  transaction_type: 'disbursement',
-  amount: 50000.00,
-  transaction_reference: "TXN-DISB-#{Time.current.to_i}",
-  status: 'completed'
-)
-
-Dscf::Credit::LoanTransaction.create!(
-  loan: loan1,
-  transaction_type: 'interest_accrual',
-  amount: 2500.00,
-  transaction_reference: "TXN-INT-#{Time.current.to_i}",
-  status: 'completed'
-)
-
-# 14. Daily Routine Transactions (depends on loans)
-puts "Seeding daily routine transactions..."
-Dscf::Credit::DailyRoutineTransaction.create!(
-  loan: loan1,
-  routine_type: 'interest_calculation',
-  amount: 83.33,
-  status: 'completed',
-  initiated_at: Date.current.beginning_of_day,
-  approved_at: Date.current.beginning_of_day + 1.hour
-)
 
 puts "DSCF Credit Engine seed data completed successfully!"
 puts "Created sample data for all models with proper relationships."

data/lib/dscf/credit/version.rb

@@ -1,5 +1,5 @@
 module Dscf
   module Credit
-    VERSION = "0.2.1"
+    VERSION = "0.2.3"
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: dscf-credit
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.3
 platform: ruby
 authors:
 - Adoniyas
 bindir: bin
 cert_chain: []
-date: 2025-10-06 00:00:00.000000000 Z
+date: 2025-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dscf-core