dscf-credit 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 447633e68d0087ea77917d1630137c52d138096a52039af3c67c577ce3c5edd9
-  data.tar.gz: 5f4b38640b2adf043787cca20d5138b3e40185333f04bb9d747203bd14abf575
+  metadata.gz: b98c5581c2ba2394b35bee75cce5a9f8de59cf7c94c12f1b8d162988a2e8a285
+  data.tar.gz: 6a377eaa47bd1b079f77fb24b408ebdbaf37e498703d85e3f39fbe5b0d233779
 SHA512:
-  metadata.gz: 02ad7c0149c073efb33bbc55e318d6cee9f6096aa29af50ef7316f3caf80ee7396c5cd3fdc7387287e88152e5af9b5854b90620b436fc6487c8c241ec8c1a98a
-  data.tar.gz: '099dd81a6c2f8f788fb38fb6c4f2d8b7f636a0853fbbed972b1078e0da5ef8e6cfe4c7b7fdec5d4bd1d5965e68f93cc8861a3122b20c1f670ebea186dba7c67b'
+  metadata.gz: 8ddcceea25d14c51c2af4e3ec279751f8a69193afa3a0e8713de2fc6acb9470f0691067e3c3cbbf34b4727acb905714402c22abbc4e0e0b8bdc20bfdf16ef6a5
+  data.tar.gz: 620cd65a6e50a64c084aeba071ba854bc10ee9a01fd8acccb3b740c51245fc0b0138fcb249e80261fbf305c1ebe6572841d89bc882d442f9e2e09c6add0bf16e

data/app/controllers/dscf/credit/facilitator_applications_controller.rb

@@ -4,12 +4,95 @@ module Dscf::Credit
     include Dscf::Core::ReviewableController
 
     def create
-      super
-      facilitator_application = @clazz.new(model_params)
-      facilitator_application.user = current_user
-      facilitator_application.reviews.build(context: "default", status: "pending")
+      super do
+        facilitator_application = @clazz.new(model_params)
 
-      facilitator_application
+        user = Dscf::Core::User.find(model_params[:user_id])
+        facilitator_application.user = user
+        facilitator_application.reviews.build(context: "default", status: "pending")
+
+        facilitator_application
+      end
+    end
+
+    def bulk_create
+      if params[:facilitator_applications].blank?
+        return render_error(
+          "facilitator_application.errors.bulk_create",
+          errors: [ "At least one facilitator application is required" ],
+          status: :unprocessable_entity
+        )
+      end
+
+      applications_params = params.require(:facilitator_applications)
+
+      unless applications_params.is_a?(Array)
+        return render_error(
+          "facilitator_application.errors.bulk_create",
+          errors: [ "Expected an array of facilitator applications" ],
+          status: :unprocessable_entity
+        )
+      end
+
+      results = {
+        successful: [],
+        failed: [],
+        total_count: applications_params.length,
+        success_count: 0,
+        failure_count: 0
+      }
+
+      applications_params.each_with_index do |app_params, index|
+        begin
+          facilitator_application = @clazz.new(app_params.permit(:user_id, :bank_id))
+
+          if app_params[:user_id].present?
+            facilitator_application.user = Dscf::Core::User.find(app_params[:user_id])
+          else
+            raise ActiveRecord::RecordInvalid.new(facilitator_application), "User ID is required"
+          end
+
+          facilitator_application.reviews.build(context: "default", status: "pending")
+
+          if facilitator_application.save
+            results[:successful] << {
+              index: index,
+              id: facilitator_application.id,
+              user_id: facilitator_application.user_id,
+              bank_id: facilitator_application.bank_id,
+              message: "Successfully created"
+            }
+            results[:success_count] += 1
+          else
+            results[:failed] << {
+              index: index,
+              user_id: app_params[:user_id],
+              errors: facilitator_application.errors.full_messages
+            }
+            results[:failure_count] += 1
+          end
+        rescue ActiveRecord::RecordNotFound => e
+          results[:failed] << {
+            index: index,
+            user_id: app_params[:user_id],
+            errors: [ "User not found: #{e.message}" ]
+          }
+          results[:failure_count] += 1
+        rescue StandardError => e
+          results[:failed] << {
+            index: index,
+            user_id: app_params[:user_id],
+            errors: [ e.message ]
+          }
+          results[:failure_count] += 1
+        end
+      end
+
+      render_success(
+        "facilitator_application.success.bulk_create",
+        data: results,
+        status: :created
+      )
     end
 
     private

data/app/controllers/dscf/credit/scoring_parameters_controller.rb

@@ -9,10 +9,10 @@ module Dscf::Credit
         scoring_parameter.created_by = current_user
         scoring_parameter.reviews.build(context: "default", status: "pending")
 
-        if validate_category_weight_limit(scoring_parameter)
+        if validate_scoring_param_type_weight_limit(scoring_parameter)
           scoring_parameter
         else
-          scoring_parameter.errors.add(:weight, "would exceed the total weight limit of 1.0 for this category")
+          scoring_parameter.errors.add(:weight, "would exceed the total weight limit of 1.0 for this scoring parameter type")
           render_error(errors: scoring_parameter.errors.full_messages, status: :unprocessable_entity)
           return
         end
@@ -20,8 +20,8 @@ module Dscf::Credit
     end
 
     def update
-      unless validate_category_weight_limit(@obj, exclude_current: true)
-        @obj.errors.add(:weight, "would exceed the total weight limit of 1.0 for this category")
+      unless validate_scoring_param_type_weight_limit(@obj, exclude_current: true)
+        @obj.errors.add(:weight, "would exceed the total weight limit of 1.0 for this scoring parameter type")
         render_error(errors: @obj.errors.full_messages, status: :unprocessable_entity)
         return
       end
@@ -75,27 +75,23 @@ module Dscf::Credit
       }
     end
 
-    def validate_category_weight_limit(scoring_parameter, exclude_current: false)
-      return true unless scoring_parameter.category_id && scoring_parameter.weight
+    def validate_scoring_param_type_weight_limit(scoring_parameter, exclude_current: false)
+      return true unless scoring_parameter.scoring_param_type_id && scoring_parameter.weight
 
-      # Get existing parameters in the same category for the same bank
       existing_params = ScoringParameter.where(
         bank_id: scoring_parameter.bank_id,
-        category_id: scoring_parameter.category_id,
+        scoring_param_type_id: scoring_parameter.scoring_param_type_id,
         active: true
       )
 
-      # Exclude current parameter from the calculation when updating
       if exclude_current && scoring_parameter.persisted?
         existing_params = existing_params.where.not(id: scoring_parameter.id)
       end
 
-      # Calculate total weight
       current_total_weight = existing_params.sum(:weight)
       new_total_weight = current_total_weight + scoring_parameter.weight.to_f
 
-      # Allow small floating point tolerance (e.g., 1.0001 should be acceptable)
-      new_total_weight <= 1.001
+      new_total_weight <= 1.00
     end
   end
 end

data/app/models/dscf/credit/facilitator_application.rb

@@ -7,7 +7,6 @@ module Dscf::Credit
     belongs_to :user, class_name: "Dscf::Core::User", foreign_key: "user_id"
     belongs_to :bank, class_name: "Dscf::Credit::Bank", foreign_key: "bank_id"
 
-    validates :facilitator_info, presence: true
 
     def self.ransackable_attributes(auth_object = nil)
       %w[id user_id bank_id created_at updated_at]

data/config/locales/en.yml

@@ -299,6 +299,7 @@ en:
       reject: "Facilitator application rejected successfully"
       request_modification: "Modification requested for facilitator application successfully"
       resubmit: "Facilitator application resubmitted successfully"
+      bulk_create: "Facilitator applications bulk creation completed"
     errors:
       index: "Failed to retrieve facilitator applications"
       show: "Failed to retrieve facilitator application details"
@@ -308,6 +309,7 @@ en:
       reject: "Failed to reject facilitator application"
       request_modification: "Failed to request modification for facilitator application"
       resubmit: "Failed to resubmit facilitator application"
+      bulk_create: "Failed to bulk create facilitator applications"
       not_found: "Facilitator application not found"
 
   # Global messages

data/config/routes.rb

@@ -81,6 +81,10 @@ Dscf::Credit::Engine.routes.draw do
   end
 
   resources :facilitator_applications do
+    collection do
+      post "bulk_create"
+    end
+
     member do
       patch "approve"
       patch "reject"

data/db/migrate/20250822092426_create_dscf_credit_facilitator_applications.rb

@@ -3,7 +3,7 @@ class CreateDscfCreditFacilitatorApplications < ActiveRecord::Migration[8.0]
     create_table :dscf_credit_facilitator_applications do |t|
       t.references :user, null: false, foreign_key: { to_table: :dscf_core_users }
       t.references :bank, null: false, foreign_key: { to_table: :dscf_credit_banks }
-      t.jsonb :facilitator_info, null: false, default: {}
+      t.jsonb :facilitator_info, null: true, default: {}
       t.timestamps
     end
   end

data/lib/dscf/credit/version.rb

@@ -1,5 +1,5 @@
 module Dscf
   module Credit
-    VERSION = "0.1.6"
+    VERSION = "0.1.7"
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: dscf-credit
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Adoniyas
 bindir: bin
 cert_chain: []
-date: 2025-10-01 00:00:00.000000000 Z
+date: 2025-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dscf-core