dscf-credit 0.1.1 → 0.1.3

data/db/seeds.rb

@@ -170,7 +170,7 @@ end
 
 # 2. Bank Branches (depends on banks)
 puts "Seeding bank branches..."
-Dscf::Credit::BankBranch.find_or_create_by(bank: bank1, branch_name: 'Head Office') do |branch|
+cbe_head_office = Dscf::Credit::BankBranch.find_or_create_by(bank: bank1, branch_name: 'Head Office') do |branch|
   branch.branch_code = 'CBE-HO-001'
   branch.branch_address = 'Churchill Avenue, Addis Ababa'
   branch.city = 'Addis Ababa'
@@ -306,14 +306,16 @@ puts "Seeding system configs..."
 Dscf::Credit::SystemConfig.find_or_create_by(config_definition: config_def1) do |config|
   config.config_value = '500000.00'
   config.status = 'approved'
-  config.approved_by = admin_user
+  config.reviewed_by = admin_user
+  config.review_date = Time.current
   config.last_updated_by = admin_user
 end
 
 Dscf::Credit::SystemConfig.find_or_create_by(config_definition: config_def2) do |config|
   config.config_value = 'daily'
   config.status = 'approved'
-  config.approved_by = admin_user
+  config.reviewed_by = admin_user
+  config.review_date = Time.current
   config.last_updated_by = admin_user
 end
 
@@ -341,6 +343,35 @@ corporate_category = Dscf::Credit::Category.find_or_create_by(type: 'credit_line
   category.description = 'Corporate credit category for large businesses'
 end
 
+# Add eligibility category for scoring
+eligibility_category = Dscf::Credit::Category.find_or_create_by(type: 'eligibility', name: 'default') do |category|
+  category.description = 'Default eligibility category for credit scoring'
+end
+
+puts "✓ Categories created/found"
+
+# 4.6. Scoring Param Types (independent)
+puts "Seeding scoring param types..."
+consumer_type = Dscf::Credit::ScoringParamType.find_or_create_by(name: 'Consumer') do |type|
+  type.description = 'Parameters for consumer credit scoring'
+end
+
+facilitator_type = Dscf::Credit::ScoringParamType.find_or_create_by(name: 'Facilitator') do |type|
+  type.description = 'Parameters for facilitator credit scoring'
+end
+
+wholesaler_type = Dscf::Credit::ScoringParamType.find_or_create_by(name: 'Wholesaler') do |type|
+  type.description = 'Parameters for wholesaler credit scoring'
+end
+
+retailer_type = Dscf::Credit::ScoringParamType.find_or_create_by(name: 'Retailer') do |type|
+  type.description = 'Parameters for retailer credit scoring'
+end
+
+manufacturer_type = Dscf::Credit::ScoringParamType.find_or_create_by(name: 'Manufacturer') do |type|
+  type.description = 'Parameters for manufacturer credit scoring'
+end
+
 # 5. Credit Lines (depends on banks, users, and categories)
 puts "Seeding credit lines..."
 credit_line1 = Dscf::Credit::CreditLine.find_or_create_by(bank: bank1, name: 'SME Credit Line') do |line|
@@ -349,8 +380,8 @@ credit_line1 = Dscf::Credit::CreditLine.find_or_create_by(bank: bank1, name: 'SM
   line.description = 'Credit line for Small and Medium Enterprises'
   line.status = 'approved'
   line.created_by = admin_user
-  line.approved_by = bank_admin
-  line.approval_date = 1.week.ago
+  line.reviewed_by = bank_admin
+  line.review_date = 1.week.ago
 end
 
 credit_line2 = Dscf::Credit::CreditLine.find_or_create_by(bank: bank1, name: 'Personal Credit Line') do |line|
@@ -359,8 +390,8 @@ credit_line2 = Dscf::Credit::CreditLine.find_or_create_by(bank: bank1, name: 'Pe
   line.description = 'Personal credit line for individuals'
   line.status = 'approved'
   line.created_by = admin_user
-  line.approved_by = bank_admin
-  line.approval_date = 5.days.ago
+  line.reviewed_by = bank_admin
+  line.review_date = 5.days.ago
 end
 
 Dscf::Credit::CreditLine.find_or_create_by(bank: bank2, name: 'Agricultural Credit Line') do |line|
@@ -369,7 +400,7 @@ Dscf::Credit::CreditLine.find_or_create_by(bank: bank2, name: 'Agricultural Cred
   line.description = 'Credit line for agricultural sector'
   line.status = 'pending'
   line.created_by = bank_admin
-  line.approved_by = admin_user
+  line.reviewed_by = admin_user
 end
 
 # 6. Credit Line Specs (depends on credit lines)
@@ -420,14 +451,17 @@ scoring_param1 = Dscf::Credit::ScoringParameter.find_or_create_by(
 ) do |param|
   param.description = 'Monthly income of the applicant'
   param.data_type = 'decimal'
-  param.type = 'financial'
   param.weight = 0.3
   param.min_value = 0
   param.max_value = 1000000
   param.active = true
-  param.approved_by = admin_user
+  param.status = 'approved'
+  param.reviewed_by = admin_user
+  param.review_date = Time.current
   param.created_by = admin_user
-  param.expires_at = 1.year.from_now
+  param.source = 'internal'
+  param.scoring_param_type = consumer_type
+  param.document_reference = 'DOC-SP-001'
 end
 
 scoring_param2 = Dscf::Credit::ScoringParameter.find_or_create_by(
@@ -436,14 +470,17 @@ scoring_param2 = Dscf::Credit::ScoringParameter.find_or_create_by(
 ) do |param|
   param.description = 'Credit history score from credit bureau'
   param.data_type = 'integer'
-  param.type = 'credit_history'
   param.weight = 0.4
   param.min_value = 300
   param.max_value = 850
   param.active = true
-  param.approved_by = admin_user
+  param.status = 'approved'
+  param.reviewed_by = admin_user
+  param.review_date = Time.current
   param.created_by = admin_user
-  param.expires_at = 1.year.from_now
+  param.source = 'external'
+  param.scoring_param_type = consumer_type
+  param.document_reference = 'DOC-SP-002'
 end
 
 scoring_param3 = Dscf::Credit::ScoringParameter.find_or_create_by(
@@ -452,12 +489,15 @@ scoring_param3 = Dscf::Credit::ScoringParameter.find_or_create_by(
 ) do |param|
   param.description = 'Type of employment (permanent, contract, self-employed)'
   param.data_type = 'string'
-  param.type = 'employment'
   param.weight = 0.2
   param.active = true
-  param.approved_by = bank_admin
+  param.status = 'approved'
+  param.reviewed_by = bank_admin
+  param.review_date = Time.current
   param.created_by = admin_user
-  param.expires_at = 1.year.from_now
+  param.source = 'internal'
+  param.scoring_param_type = consumer_type
+  param.document_reference = 'DOC-SP-003'
 end
 
 # 8. Parameter Normalizers (depends on scoring parameters)
@@ -471,7 +511,7 @@ Dscf::Credit::ParameterNormalizer.find_or_create_by(
 ) do |normalizer|
   normalizer.name = 'Permanent Employment'
   normalizer.description = 'Full-time permanent employment'
-  normalizer.normalized_value = 100
+  normalizer.normalized_value = 1.0
 end
 
 Dscf::Credit::ParameterNormalizer.find_or_create_by(
@@ -480,7 +520,7 @@ Dscf::Credit::ParameterNormalizer.find_or_create_by(
 ) do |normalizer|
   normalizer.name = 'Contract Employment'
   normalizer.description = 'Contract-based employment'
-  normalizer.normalized_value = 70
+  normalizer.normalized_value = 0.7
 end
 
 Dscf::Credit::ParameterNormalizer.find_or_create_by(
@@ -489,7 +529,7 @@ Dscf::Credit::ParameterNormalizer.find_or_create_by(
 ) do |normalizer|
   normalizer.name = 'Self Employed'
   normalizer.description = 'Self-employed individual'
-  normalizer.normalized_value = 60
+  normalizer.normalized_value = 0.6
 end
 
 # 8.5. Scoring Tables (depends on credit lines and scoring parameters)
@@ -502,7 +542,7 @@ employment_param = Dscf::Credit::ScoringParameter.find_by(bank: bank1, name: 'Em
 # Create scoring tables for credit_line1 (SME Credit Line)
 if monthly_income_param
   Dscf::Credit::ScoringTable.find_or_create_by(
-    credit_line: credit_line1,
+    category: sme_category,
     scoring_parameter: monthly_income_param
   ) do |scoring_table|
     scoring_table.weight = 0.4
@@ -513,7 +553,7 @@ end
 
 if credit_history_param
   Dscf::Credit::ScoringTable.find_or_create_by(
-    credit_line: credit_line1,
+    category: sme_category,
     scoring_parameter: credit_history_param
   ) do |scoring_table|
     scoring_table.weight = 0.35
@@ -524,7 +564,7 @@ end
 
 if employment_param
   Dscf::Credit::ScoringTable.find_or_create_by(
-    credit_line: credit_line1,
+    category: sme_category,
     scoring_parameter: employment_param
   ) do |scoring_table|
     scoring_table.weight = 0.25
@@ -536,7 +576,7 @@ end
 # Create scoring tables for credit_line2 (Personal Credit Line)
 if monthly_income_param
   Dscf::Credit::ScoringTable.find_or_create_by(
-    credit_line: credit_line2,
+    category: personal_category,
     scoring_parameter: monthly_income_param
   ) do |scoring_table|
     scoring_table.weight = 0.5
@@ -547,7 +587,7 @@ end
 
 if credit_history_param
   Dscf::Credit::ScoringTable.find_or_create_by(
-    credit_line: credit_line2,
+    category: personal_category,
     scoring_parameter: credit_history_param
   ) do |scoring_table|
     scoring_table.weight = 0.3
@@ -558,7 +598,7 @@ end
 
 if employment_param
   Dscf::Credit::ScoringTable.find_or_create_by(
-    credit_line: credit_line2,
+    category: personal_category,
     scoring_parameter: employment_param
   ) do |scoring_table|
     scoring_table.weight = 0.2
@@ -567,6 +607,40 @@ if employment_param
   end
 end
 
+# Create scoring tables for eligibility_category
+if monthly_income_param
+  Dscf::Credit::ScoringTable.find_or_create_by(
+    category: eligibility_category,
+    scoring_parameter: monthly_income_param
+  ) do |scoring_table|
+    scoring_table.weight = 0.4
+    scoring_table.active = true
+    scoring_table.created_by = admin_user
+  end
+end
+
+if credit_history_param
+  Dscf::Credit::ScoringTable.find_or_create_by(
+    category: eligibility_category,
+    scoring_parameter: credit_history_param
+  ) do |scoring_table|
+    scoring_table.weight = 0.35
+    scoring_table.active = true
+    scoring_table.created_by = admin_user
+  end
+end
+
+if employment_param
+  Dscf::Credit::ScoringTable.find_or_create_by(
+    category: eligibility_category,
+    scoring_parameter: employment_param
+  ) do |scoring_table|
+    scoring_table.weight = 0.25
+    scoring_table.active = true
+    scoring_table.created_by = admin_user
+  end
+end
+
 # 9. Loan Profiles (depends on banks and users)
 puts "Seeding loan profiles..."
 loan_profile1 = Dscf::Credit::LoanProfile.find_or_create_by(
@@ -576,11 +650,13 @@ loan_profile1 = Dscf::Credit::LoanProfile.find_or_create_by(
   profile.status = 'approved'
   profile.total_amount = 100000.00
   profile.available_amount = 75000.00
-  profile.approved_by = bank_admin
+  profile.reviewed_by = bank_admin
+  profile.review_branch = cbe_head_office
+  profile.review_date = Time.current
   # Note: backer will be set when facilitators are created via API
 end
 
-# 12. Loan Profile Scoring Specs (depends on loan profiles)
+# 10. Loan Profile Scoring Specs (depends on loan profiles)
 puts "Seeding loan profile scoring specs..."
 Dscf::Credit::LoanProfileScoringSpec.create!(
   loan_profile: loan_profile1,
@@ -589,16 +665,34 @@ Dscf::Credit::LoanProfileScoringSpec.create!(
     'credit_history_score' => 720,
     'employment_type' => 'permanent',
     'years_at_job' => 3,
-    'existing_debt' => 15000
+    'existing_debt' => 15000,
+    'average_daily_purchase' => 15000  # Wholesaler's average daily purchase volume
   },
   score: 78.5,
+  total_limit: 100000.00,
   active: true,
-  approved_by: admin_user,
-  created_by: admin_user,
-  expires_at: 6.months.from_now
+  created_by: admin_user
+)
+
+# 11. Eligible Credit Lines (depends on loan profiles and credit lines)
+puts "Seeding eligible credit lines..."
+Dscf::Credit::EligibleCreditLine.create!(
+  loan_profile: loan_profile1,
+  credit_line: credit_line1,
+  credit_limit: 75000.00,
+  available_limit: 67500.00,
+  risk: 0.35
+)
+
+Dscf::Credit::EligibleCreditLine.create!(
+  loan_profile: loan_profile1,
+  credit_line: credit_line2,
+  credit_limit: 50000.00,
+  available_limit: 42500.00,
+  risk: 0.45
 )
 
-# 13. Payment Requests (depends on users)
+# 12. Payment Requests (depends on users)
 puts "Seeding payment requests..."
 payment_request1 = Dscf::Credit::PaymentRequest.create!(
   user: user2,
@@ -621,7 +715,7 @@ payment_request2 = Dscf::Credit::PaymentRequest.create!(
   initiated_at: 1.hour.ago
 )
 
-# 14. Loans (depends on loan profiles, credit lines, and payment requests)
+# 13. Loans (depends on loan profiles, credit lines, and payment requests)
 puts "Seeding loans..."
 loan1 = Dscf::Credit::Loan.create!(
   loan_profile: loan_profile1,
@@ -638,7 +732,7 @@ loan1 = Dscf::Credit::Loan.create!(
   disbursed_at: 1.day.ago
 )
 
-# 15. Loan Transactions (depends on loans)
+# 14. Loan Transactions (depends on loans)
 puts "Seeding loan transactions..."
 Dscf::Credit::LoanTransaction.create!(
   loan: loan1,
@@ -656,7 +750,7 @@ Dscf::Credit::LoanTransaction.create!(
   status: 'completed'
 )
 
-# 16. Daily Routine Transactions (depends on loans)
+# 15. Daily Routine Transactions (depends on loans)
 puts "Seeding daily routine transactions..."
 Dscf::Credit::DailyRoutineTransaction.create!(
   loan: loan1,
@@ -667,7 +761,7 @@ Dscf::Credit::DailyRoutineTransaction.create!(
   approved_at: Date.current.beginning_of_day + 1.hour
 )
 
-# 17. Payments (depends on payment requests)
+# 16. Payments (depends on payment requests)
 puts "Seeding payments..."
 Dscf::Credit::Payment.create!(
   payment_request: payment_request1,
@@ -678,7 +772,7 @@ Dscf::Credit::Payment.create!(
   processed_at: 1.day.ago
 )
 
-# 18. Accounting Audit Requests (depends on various entities)
+# 17. Accounting Audit Requests (depends on various entities)
 puts "Seeding accounting audit requests..."
 audit_request1 = Dscf::Credit::AccountingAuditRequest.create!(
   source_entity: loan1,
@@ -696,7 +790,7 @@ Dscf::Credit::AccountingAuditRequest.create!(
   status: 'pending'
 )
 
-# 19. Accounting Entries (depends on audit requests)
+# 18. Accounting Entries (depends on audit requests)
 puts "Seeding accounting entries..."
 Dscf::Credit::AccountingEntry.create!(
   audit_request: audit_request1,
@@ -714,7 +808,7 @@ Dscf::Credit::AccountingEntry.create!(
   status: 'completed'
 )
 
-# 20. Failed Operations Logs (depends on various entities)
+# 19. Failed Operations Logs (depends on various entities)
 puts "Seeding failed operations logs..."
 Dscf::Credit::FailedOperationsLog.create!(
   entity: payment_request2,

data/lib/dscf/credit/version.rb

@@ -1,5 +1,5 @@
 module Dscf
   module Credit
-    VERSION = "0.1.1"
+    VERSION = "0.1.3"
   end
 end

data/spec/factories/dscf/credit/categories.rb

@@ -3,6 +3,7 @@ FactoryBot.define do
     type { %w[scoring loan_profile payment risk_assessment].sample }
     sequence(:name) { |n| "#{type.humanize} Category #{n}" }
     description { Faker::Lorem.paragraph }
+    document_reference { Faker::Alphanumeric.alphanumeric(number: 10).upcase }
 
     trait :scoring do
       type { "scoring" }

data/spec/factories/dscf/credit/credit_line_specs.rb

@@ -8,6 +8,7 @@ FactoryBot.define do
     penalty_rate { Faker::Number.decimal(l_digits: 1, r_digits: 4).to_f }
     facilitation_fee_rate { Faker::Number.decimal(l_digits: 1, r_digits: 4).to_f }
     tax_rate { Faker::Number.decimal(l_digits: 1, r_digits: 4).to_f }
+    credit_line_multiplier { Faker::Number.between(from: 15, to: 60) }
     max_penalty_days { Faker::Number.between(from: 30, to: 90) }
     loan_duration { Faker::Number.between(from: 30, to: 365) }
     interest_frequency { %w[daily weekly monthly quarterly annually].sample }

data/spec/factories/dscf/credit/credit_lines.rb

@@ -3,26 +3,28 @@ FactoryBot.define do
     association :bank, factory: :bank
     association :category, factory: :category
     association :created_by, factory: :user if defined?(Dscf::Core::User)
-    association :approved_by, factory: :user if defined?(Dscf::Core::User)
+    association :reviewed_by, factory: :user if defined?(Dscf::Core::User)
     name { "#{Faker::Finance.credit_card(:visa)} Credit Line" }
     sequence(:code) { |n| "CL#{n.to_s.rjust(4, '0')}" }
     description { Faker::Lorem.paragraph }
-    status { %w[pending approved active suspended].sample }
-    approval_date { Faker::Date.between(from: 6.months.ago, to: Date.current) if status.in?(%w[approved active]) }
+    status { %w[pending approved suspended].sample }
+    review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) if status.in?(%w[approved]) }
+    document_reference { Faker::Alphanumeric.alphanumeric(number: 10).upcase }
+    review_feedback { {} }
 
     trait :pending do
       status { "pending" }
-      approval_date { nil }
+      review_date { nil }
     end
 
     trait :approved do
       status { "approved" }
-      approval_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
+      review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
     end
 
     trait :active do
-      status { "active" }
-      approval_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
+      status { "approved" }
+      review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
     end
 
     trait :suspended do

data/spec/factories/dscf/credit/eligible_credit_lines.rb

@@ -0,0 +1,33 @@
+FactoryBot.define do
+  factory :eligible_credit_line, class: "Dscf::Credit::EligibleCreditLine" do
+    association :loan_profile, factory: :loan_profile
+    association :credit_line, factory: :credit_line
+    credit_limit { Faker::Number.decimal(l_digits: 5, r_digits: 2) }
+    available_limit { Faker::Number.decimal(l_digits: 4, r_digits: 2) }
+    risk { nil } # Risk should not be set at creation, only through apply_risk endpoint
+
+    trait :with_applied_risk do
+      risk { Faker::Number.decimal(l_digits: 1, r_digits: 4).clamp(0.01, 0.9) }
+    end
+
+    trait :low_risk do
+      risk { Faker::Number.decimal(l_digits: 1, r_digits: 4).clamp(0.01, 0.3) }
+    end
+
+    trait :medium_risk do
+      risk { Faker::Number.decimal(l_digits: 1, r_digits: 4).clamp(0.31, 0.6) }
+    end
+
+    trait :high_risk do
+      risk { Faker::Number.decimal(l_digits: 1, r_digits: 4).clamp(0.61, 0.9) }
+    end
+
+    trait :small_credit_limit do
+      credit_limit { Faker::Number.decimal(l_digits: 3, r_digits: 2) }
+    end
+
+    trait :large_credit_limit do
+      credit_limit { Faker::Number.decimal(l_digits: 6, r_digits: 2) }
+    end
+  end
+end

data/spec/factories/dscf/credit/facilitator_performances.rb

@@ -7,7 +7,6 @@ FactoryBot.define do
     total_outstanding_amount { Faker::Number.decimal(l_digits: 6, r_digits: 2) }
     approval_required { [ true, false ].sample }
     input_data { Faker::Json.shallow_json(width: 3, options: { key: 'Name.name', value: 'Number.number' }) }
-    expires_at { Faker::Date.between(from: 1.month.from_now, to: 1.year.from_now) }
 
     trait :high_performance do
       score { Faker::Number.between(from: 80.0, to: 100.0) }
@@ -22,9 +21,5 @@ FactoryBot.define do
     trait :requiring_approval do
       approval_required { true }
     end
-
-    trait :expired do
-      expires_at { Faker::Date.between(from: 1.year.ago, to: 1.month.ago) }
-    end
   end
 end

data/spec/factories/dscf/credit/facilitators.rb

@@ -2,22 +2,27 @@ FactoryBot.define do
   factory :facilitator, class: "Dscf::Credit::Facilitator" do
     association :bank, factory: :bank
     association :user, factory: :user if defined?(Dscf::Core::User)
-    association :kyc_approved_by, factory: :user if defined?(Dscf::Core::User)
+    association :kyc_reviewed_by, factory: :user if defined?(Dscf::Core::User)
     name { Faker::Name.name }
     type { %w[individual corporate agent].sample }
     total_limit { Faker::Number.decimal(l_digits: 6, r_digits: 2) }
     kyc_status { %w[pending approved rejected].sample }
+    kyc_review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) if kyc_status == "approved" }
+    review_feedback { {} }
 
     trait :pending_kyc do
       kyc_status { "pending" }
+      kyc_review_date { nil }
     end
 
     trait :approved do
       kyc_status { "approved" }
+      kyc_review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
     end
 
     trait :rejected do
       kyc_status { "rejected" }
+      kyc_review_date { nil }
     end
 
     trait :individual do

data/spec/factories/dscf/credit/loan_profile_scoring_specs.rb

@@ -2,12 +2,10 @@ FactoryBot.define do
   factory :loan_profile_scoring_spec, class: "Dscf::Credit::LoanProfileScoringSpec" do
     association :loan_profile, factory: :loan_profile
     association :created_by, factory: :user if defined?(Dscf::Core::User)
-    association :approved_by, factory: :user if defined?(Dscf::Core::User)
     scoring_input_data { Faker::Json.shallow_json(width: 5, options: { key: 'Name.name', value: 'Number.number' }) }
     score { Faker::Number.decimal(l_digits: 2, r_digits: 2) }
+    total_limit { Faker::Number.decimal(l_digits: 6, r_digits: 2) }
     active { true }
-    expires_at { Faker::Date.between(from: 3.months.from_now, to: 1.year.from_now) }
-
     trait :active do
       active { true }
     end
@@ -23,9 +21,5 @@ FactoryBot.define do
     trait :low_score do
       score { Faker::Number.between(from: 0.0, to: 30.0) }
     end
-
-    trait :expired do
-      expires_at { Faker::Date.between(from: 1.year.ago, to: 1.month.ago) }
-    end
   end
 end

data/spec/factories/dscf/credit/loan_profiles.rb

@@ -1,27 +1,32 @@
 FactoryBot.define do
   factory :loan_profile, class: "Dscf::Credit::LoanProfile" do
     association :bank, factory: :bank
-    association :approved_by, factory: :user if defined?(Dscf::Core::User)
+    association :review_branch, factory: :bank_branch
+    association :reviewed_by, factory: :user if defined?(Dscf::Core::User)
     association :user, factory: :user if defined?(Dscf::Core::User)
     association :backer, factory: :user if defined?(Dscf::Core::User)
-    status { %w[pending approved rejected].sample }
+    status { %w[pending approved rejected kyc_approved kyc_rejected].sample }
     total_amount { Faker::Number.decimal(l_digits: 6, r_digits: 2).to_f }
     available_amount { total_amount - Faker::Number.decimal(l_digits: 4, r_digits: 2).to_f }
-    rejection_reason { Faker::Lorem.sentence if status == "rejected" }
+    review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) if status == "approved" }
+    review_feedback { status == "rejected" ? { reason: Faker::Lorem.sentence } : {} }
 
     trait :pending do
       status { "pending" }
-      rejection_reason { nil }
+      review_feedback { {} }
+      review_date { nil }
     end
 
     trait :approved do
       status { "approved" }
-      rejection_reason { nil }
+      review_feedback { {} }
+      review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
     end
 
     trait :rejected do
       status { "rejected" }
-      rejection_reason { Faker::Lorem.sentence }
+      review_feedback { { reason: Faker::Lorem.sentence } }
+      review_date { nil }
     end
 
     trait :fully_available do

data/spec/factories/dscf/credit/scoring_param_types.rb

@@ -0,0 +1,31 @@
+FactoryBot.define do
+  factory :scoring_param_type, class: "Dscf::Credit::ScoringParamType" do
+    name { Faker::Lorem.word.capitalize }
+    description { Faker::Lorem.paragraph }
+
+    trait :consumer do
+      name { "Consumer" }
+      description { "Parameters for consumer credit scoring" }
+    end
+
+    trait :facilitator do
+      name { "Facilitator" }
+      description { "Parameters for facilitator credit scoring" }
+    end
+
+    trait :wholesaler do
+      name { "Wholesaler" }
+      description { "Parameters for wholesaler credit scoring" }
+    end
+
+    trait :retailer do
+      name { "Retailer" }
+      description { "Parameters for retailer credit scoring" }
+    end
+
+    trait :manufacturer do
+      name { "Manufacturer" }
+      description { "Parameters for manufacturer credit scoring" }
+    end
+  end
+end

data/spec/factories/dscf/credit/scoring_parameters.rb

@@ -2,16 +2,20 @@ FactoryBot.define do
   factory :scoring_parameter, class: "Dscf::Credit::ScoringParameter" do
     association :bank, factory: :bank
     association :created_by, factory: :user if defined?(Dscf::Core::User)
-    association :approved_by, factory: :user if defined?(Dscf::Core::User)
-    name { Faker::Lorem.words(number: 2).join('_').downcase }
+    association :reviewed_by, factory: :user if defined?(Dscf::Core::User)
+    association :scoring_param_type, factory: :scoring_param_type
+    sequence(:name) { |n| "#{Faker::Lorem.words(number: 2).join('_').downcase}_#{n}" }
     description { Faker::Lorem.paragraph }
     data_type { %w[integer decimal boolean string].sample }
-    type { %w[income credit_history employment_status collateral].sample }
     weight { Faker::Number.decimal(l_digits: 0, r_digits: 4) }
     min_value { Faker::Number.decimal(l_digits: 2, r_digits: 2) }
     max_value { min_value + Faker::Number.decimal(l_digits: 3, r_digits: 2) }
     active { true }
-    expires_at { Faker::Date.between(from: 6.months.from_now, to: 2.years.from_now) }
+    review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
+    source { Faker::Lorem.word }
+    document_reference { Faker::Alphanumeric.alphanumeric(number: 10).upcase }
+    status { "pending" }
+    review_feedback { {} }
 
     trait :active do
       active { true }
@@ -44,5 +48,23 @@ FactoryBot.define do
       min_value { nil }
       max_value { nil }
     end
+
+    trait :pending do
+      status { "pending" }
+    end
+
+    trait :approved do
+      status { "approved" }
+      review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
+    end
+
+    trait :rejected do
+      status { "rejected" }
+      review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
+    end
+
+    trait :modify do
+      status { "modify" }
+    end
   end
 end