dscf-banking 0.2.9 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: df271e9f69727201aab1508e782bf5a18e7b59fba9e67dffd2224d92319f9280
-  data.tar.gz: '0618830ecf6bbab8f90cfffc3da24303cd08788cc8387d42070c4093b9be5b45'
+  metadata.gz: fb3d7fb4e0cee09c487b773f62c5fd87ac8a70f36a6ab19fd35478a11caf5b89
+  data.tar.gz: 2abfdc7273bde34ed021ac7111d42bb16c7ad796874d3007dd941b10c76a1aa0
 SHA512:
-  metadata.gz: 8ff010dc9f9a04cddbcebf7dcdd83b5ba0b592a6bac40da63422002a7db9e2f9ecede7ae7aef4cc0cafd8ce579c2d8df8c3773f1e4ea8261de8839de353c8788
-  data.tar.gz: 8e52eeaa335df4fbeb0af438cbb1ac1f9a9c9ee15de8629212ad9bae3ce7eb2984e2936f485f9a5edb052e45ab7bd2738c0cc3fe898dcf5ce5bcb5971ed4d393
+  metadata.gz: 24266cf3117b88ad84bd18067fe015025f14680d782b8d1f46b0e9b1af5683844474d49e6e4a3bd06e3b19033ff210d52a810e605ad85a4351ad0eea09ece1d9
+  data.tar.gz: 5dcf5ed06d580fdf6166298d0bb63a656e21aaee29e5be1fbc10dbf51f035d094208fa215b99b511d5739acb859e38ed95b510f399ee91aa0ba0cb6fdb97f40b

data/app/controllers/dscf/banking/accounts_controller.rb

@@ -213,8 +213,92 @@ module Dscf::Banking
       }
     end
 
+    def transactions
+      account = Dscf::Banking::Account.find(params[:id])
+      
+      transactions = Dscf::Banking::Transaction
+        .where("account_id = ? OR debit_account_id = ? OR credit_account_id = ?", account.id, account.id, account.id)
+        .includes(:account, :transaction_type, :debit_account, :credit_account)
+      
+      # Apply pagination if requested
+      page = params[:page].to_i
+      per_page = (params[:per_page] || 10).to_i
+      
+      # Apply filters
+      transactions = transactions.where(status: params[:status]) if params[:status].present?
+      transactions = transactions.where(transaction_type_id: params[:transaction_type_id]) if params[:transaction_type_id].present?
+      
+      # Apply ordering
+      order_column = %w[id reference_number amount currency status created_at updated_at].include?(params[:order_by]) ? params[:order_by] : "created_at"
+      order_direction = %w[asc desc].include?(params[:order_direction]) ? params[:order_direction] : "desc"
+      transactions = transactions.order("#{order_column} #{order_direction}")
+      
+      if page.positive?
+        total_count = transactions.count
+        total_pages = (total_count.to_f / per_page).ceil
+        transactions = transactions.offset((page - 1) * per_page).limit(per_page)
+        
+        render json: {
+          success: true,
+          message: "Account transactions retrieved successfully",
+          data: transactions.map { |transaction| transaction_data(transaction) },
+          pagination: {
+            current_page: page,
+            per_page: per_page,
+            total_count: total_count,
+            total_pages: total_pages
+          }
+        }
+      else
+        render json: {
+          success: true,
+          message: "Account transactions retrieved successfully",
+          data: transactions.map { |transaction| transaction_data(transaction) }
+        }
+      end
+    rescue ActiveRecord::RecordNotFound
+      render json: {
+        success: false,
+        error: "Account not found"
+      }, status: :not_found
+    end
+
     private
 
+    def transaction_data(transaction)
+      {
+        id: transaction.id,
+        reference_number: transaction.reference_number,
+        amount: transaction.amount.to_f,
+        currency: transaction.currency,
+        description: transaction.description,
+        status: transaction.status,
+        account_id: transaction.account_id,
+        debit_account_id: transaction.debit_account_id,
+        credit_account_id: transaction.credit_account_id,
+        transaction_type_id: transaction.transaction_type_id,
+        transaction_type: {
+          id: transaction.transaction_type.id,
+          code: transaction.transaction_type.code,
+          name: transaction.transaction_type.name
+        },
+        debit_account: account_summary(transaction.debit_account),
+        credit_account: account_summary(transaction.credit_account),
+        created_at: transaction.created_at,
+        updated_at: transaction.updated_at
+      }
+    end
+
+    def account_summary(account)
+      return nil unless account
+      {
+        id: account.id,
+        account_number: account.account_number,
+        name: account.name,
+        currency: account.currency
+      }
+    end
+
     def account_data(account)
       {
         id: account.id,

data/app/controllers/dscf/banking/documents_controller.rb

@@ -4,6 +4,42 @@ module Dscf::Banking
 
     before_action :find_application
 
+    def index
+      super do
+        documents = @application.documents
+        options = { each_serializer: DocumentSerializer }
+        [documents, options]
+      end
+    end
+
+    def show
+      super do
+        document = @application.documents.find(params[:id])
+        options = { serializer: DocumentSerializer }
+        [document, options]
+      end
+    end
+
+    def create
+      document = @application.documents.build(model_params)
+      
+      if document.save
+        # Attach file if provided
+        document.files.attach(params[:document][:file]) if params[:document][:file].present?
+        
+        render json: {
+          success: true,
+          data: DocumentSerializer.new(document).as_json
+        }, status: :created
+      else
+        render json: {
+          success: false,
+          error: "Failed to create document",
+          errors: document.errors.full_messages
+        }, status: :unprocessable_entity
+      end
+    end
+
     private
 
     def find_application
@@ -49,5 +85,9 @@ module Dscf::Banking
         update: []
       }
     end
+
+    def serializer_class
+      Dscf::Banking::DocumentSerializer
+    end
   end
 end

data/app/serializers/dscf/banking/application_serializer.rb

@@ -9,7 +9,7 @@ module Dscf::Banking
     belongs_to :assigned_branch_manager, optional: true
     has_one :account, serializer: AccountSerializer, if: :has_account?
     has_many :reviews, serializer: Dscf::Core::ReviewSerializer
-    has_many :documents, serializer: DocumentSerializer
+    has_many :documents, serializer: Dscf::Banking::DocumentSerializer
 
     def has_account?
       object.has_account?

data/app/serializers/dscf/banking/document_serializer.rb

@@ -1,12 +1,15 @@
 module Dscf::Banking
   class DocumentSerializer < ActiveModel::Serializer
-    attributes :id, :document_type, :is_verified, :verified_at, :metadata, :created_at, :updated_at, :file_url
+    attributes :id, :document_type, :is_verified, :verified_at, :metadata, :file_urls, :created_at, :updated_at
 
-    # Remove polymorphic association that causes ActiveStorage issues
-    # belongs_to :verified_by, polymorphic: true, optional: true
-
-    def file_url
-      object.file_url
+    def file_urls
+      return [] unless object.files.attached?
+      
+      object.files.map do |file|
+        Rails.application.routes.url_helpers.rails_blob_path(file, only_path: true)
+      end
+    rescue StandardError
+      []
     end
   end
 end

data/config/initializers/review_callbacks.rb

@@ -0,0 +1,23 @@
+Rails.application.config.to_prepare do
+  ActiveSupport::Notifications.subscribe("review.created") do |name, start, finish, id, payload|
+    reviewable = payload[:reviewable]
+    
+    if reviewable.is_a?(Dscf::Banking::Application)
+      reviewable.reload
+      review_status = reviewable.review_status
+      
+      status_map = {
+        "submitted" => "submitted",
+        "under_review" => "under_review",
+        "approved" => "approved",
+        "rejected" => "rejected",
+        "request_modification" => "request_modification"
+      }
+      
+      mapped_status = status_map[review_status]
+      if mapped_status && reviewable.status != mapped_status
+        reviewable.update!(status: mapped_status)
+      end
+    end
+  end
+end

data/config/routes.rb

@@ -7,6 +7,7 @@ Dscf::Banking::Engine.routes.draw do
       post :activate
       post :suspend
       post :close
+      get :transactions
     end
   end
   resources :product_categories

data/db/seeds.rb

@@ -48,6 +48,26 @@ user7 = User.create(name: "Fikirte Alemayehu", email: "fikirte@example.com", pas
 user7.roles << branch_manager_role
 puts "Created user: #{user7.name}"
 
+# Seed transaction types
+puts "Seeding transaction types..."
+deposit_type = Dscf::Banking::TransactionType.find_or_create_by(code: "DEPOSIT") do |tt|
+  tt.name = "Deposit"
+  tt.description = "Deposit transaction - money coming into account"
+end
+puts "Created transaction type: #{deposit_type.name}"
+
+withdrawal_type = Dscf::Banking::TransactionType.find_or_create_by(code: "WITHDRAWAL") do |tt|
+  tt.name = "Withdrawal"
+  tt.description = "Withdrawal transaction - money going out of account"
+end
+puts "Created transaction type: #{withdrawal_type.name}"
+
+transfer_type = Dscf::Banking::TransactionType.find_or_create_by(code: "TRANSFER") do |tt|
+  tt.name = "Transfer"
+  tt.description = "Transfer transaction - money moving between accounts"
+end
+puts "Created transaction type: #{transfer_type.name}"
+
 # Seed system accounts for transaction processing
 puts "Seeding system accounts..."
 system_deposit_account = Dscf::Banking::Account.find_or_create_by(

data/lib/dscf/banking/version.rb

@@ -1,5 +1,5 @@
 module Dscf
   module Banking
-    VERSION = "0.2.9"
+    VERSION = "0.3.1"
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: dscf-banking
 version: !ruby/object:Gem::Version
-  version: 0.2.9
+  version: 0.3.1
 platform: ruby
 authors:
 - Eyosiyas Mekbib
 bindir: bin
 cert_chain: []
-date: 2025-10-15 00:00:00.000000000 Z
+date: 2025-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -482,6 +482,7 @@ files:
 - app/services/dscf/banking/deposit_service.rb
 - app/services/dscf/banking/transfer_service.rb
 - app/services/dscf/banking/withdrawal_service.rb
+- config/initializers/review_callbacks.rb
 - config/initializers/review_extensions.rb
 - config/locales/en.yml
 - config/routes.rb