dscf-banking 0.2.6 → 0.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 318c6e93b2062a45adb19d98709d9f0812788e0137bea60f9b56d66d2617b56a
-  data.tar.gz: 910120a3392d73f497aa511c3f971da9326a4a7ddc45d5820430d908b0959c05
+  metadata.gz: bd6bfb0114ad393bd22ae2bf1db82507a7e50299aa6f7ac0c433e53ae3a24e91
+  data.tar.gz: 97773b5c82e95ab7d227d9473ce82658ce4df88966506d0354ee10d360749023
 SHA512:
-  metadata.gz: 2195accd89bcc4f487e514e8209c31131c011bb5d676729d5ea18c68955d2bfd98a179a85e018c8e54901a473ee9c16da8179feb1c3580534fea68c273bc26c6
-  data.tar.gz: 28a117bad46972db2b9759dcfeee8c3d9bba034bada79f924058b096a6873a93d84a1fd4f39942f3857bc8a94feef3462374f2334a82a2c28a470a8b9cdc86f7
+  metadata.gz: 41ff719fa8dceb6e423d57c80bc8d9b96aeb2ab619ab94eccffb24bc1cbe4ce852b160ecde131084e11902aedf95df074af6b3589ffe3335f28cfcf10abccdcc
+  data.tar.gz: 5db3b15472498d3509cfe556ade8bf5e64ff7261cd3e0a338f898351c8a59110fddba5d4a04f1857a106508a5154c88d8dcd3964fbcaa5b22800478ede721e49

data/app/controllers/dscf/banking/applications_controller.rb

@@ -22,9 +22,33 @@ module Dscf::Banking
         resubmit: { status: "submitted", update_model: true }
       }
 
+    # Override perform_review_action to sync application status with review status
+    def perform_review_action(action_name, action_config, context_name)
+      result = super
+      
+      # After successful review action, update the application's status to match
+      if result.is_a?(Hash) && result[:success] && @obj
+        review_status = @obj.review_status
+        application_status_map = {
+          "submitted" => "submitted",
+          "under_review" => "under_review",
+          "approved" => "approved",
+          "rejected" => "rejected",
+          "request_modification" => "request_modification"
+        }
+        
+        new_status = application_status_map[review_status]
+        if new_status && @obj.status != new_status
+          @obj.update_column(:status, Application.statuses[new_status])
+        end
+      end
+      
+      result
+    end
+
     private
 
-    def application_data(application)
+  def application_data(application)
       {
         id: application.id,
         application_number: application.application_number,
@@ -52,7 +76,7 @@ module Dscf::Banking
     end
 
     def eager_loaded_associations
-      [ :user, :virtual_account_product, reviews: { reviewed_by: :user_profile } ]
+      [ :user, :virtual_account_product, :account, :documents, reviews: { reviewed_by: :user_profile } ]
     end
 
     def allowed_order_columns
@@ -61,10 +85,10 @@ module Dscf::Banking
 
     def default_serializer_includes
       {
-        index: [:user, :virtual_account_product, reviews: { reviewed_by: :user_profile }],
-        show: [:user, :virtual_account_product, :account, reviews: { reviewed_by: :user_profile }],
-        create: [:reviews],
-        update: [:user, :virtual_account_product, :account, reviews: { reviewed_by: :user_profile }]
+        index: [ :user, :virtual_account_product, :documents, reviews: { reviewed_by: :user_profile } ],
+        show: [ :user, :virtual_account_product, :account, :documents, reviews: { reviewed_by: :user_profile } ],
+        create: [ :reviews, :documents ],
+        update: [ :user, :virtual_account_product, :account, :documents, reviews: { reviewed_by: :user_profile } ]
       }
     end
   end

data/app/controllers/dscf/banking/documents_controller.rb

@@ -0,0 +1,53 @@
+module Dscf::Banking
+  class DocumentsController < ApplicationController
+    include Dscf::Core::Common
+
+    before_action :find_application
+
+    private
+
+    def find_application
+      @application = Application.find(params[:application_id])
+    end
+
+    def model_class
+      Dscf::Core::Document
+    end
+
+    def collection
+      @application.documents
+    end
+
+    def build_resource
+      @application.documents.build
+    end
+
+    def find_resource
+      @application.documents.find(params[:id])
+    end
+
+    def model_params
+      params.require(:document).permit(
+        :document_type,
+        metadata: {}
+      ).merge(documentable: @application)
+    end
+
+    def eager_loaded_associations
+      []
+    end
+
+    def allowed_order_columns
+      %w[id document_type is_verified verified_at created_at updated_at]
+    end
+
+    def default_serializer_includes
+      {
+        index: [],
+        show: [],
+        create: [],
+        update: []
+      }
+    end
+  end
+end

data/app/controllers/dscf/banking/transactions_controller.rb

@@ -6,7 +6,7 @@ module Dscf::Banking
       render json: {
         success: false,
         error: "Transaction not found",
-        errors: ["Transaction with ID #{params[:id]} not found"]
+        errors: [ "Transaction with ID #{params[:id]} not found" ]
       }, status: :not_found
     end
 

data/app/controllers/dscf/banking/virtual_account_products_controller.rb

@@ -83,10 +83,10 @@ module Dscf::Banking
 
     def default_serializer_includes
       {
-        index: [:product_category, :created_by, :approved_by, reviews: { reviewed_by: :user_profile }],
-        show: [:product_category, :created_by, :approved_by, reviews: { reviewed_by: :user_profile }],
-        create: [:reviews],
-        update: [:product_category, :created_by, :approved_by, reviews: { reviewed_by: :user_profile }]
+        index: [ :product_category, :created_by, :approved_by, reviews: { reviewed_by: :user_profile } ],
+        show: [ :product_category, :created_by, :approved_by, reviews: { reviewed_by: :user_profile } ],
+        create: [ :reviews ],
+        update: [ :product_category, :created_by, :approved_by, reviews: { reviewed_by: :user_profile } ]
       }
     end
   end

data/app/models/dscf/banking/application.rb

@@ -8,6 +8,7 @@ module Dscf::Banking
     belongs_to :assigned_branch_manager, class_name: "Dscf::Core::User", optional: true
     belongs_to :virtual_account_product, class_name: "Dscf::Banking::VirtualAccountProduct"
     has_one :account, class_name: "Dscf::Banking::Account"
+    has_many :documents, class_name: "Dscf::Core::Document", as: :documentable, dependent: :destroy
 
     validates :application_number, presence: true, uniqueness: true, length: { maximum: 50 }
     validates :applicant_type, presence: true
@@ -20,7 +21,7 @@ module Dscf::Banking
 
     before_validation :generate_application_number, if: -> { new_record? && application_number.blank? }
     before_update :set_timestamps_on_status_change
-    after_update :create_account_if_approved
+    after_commit :create_account_if_approved, on: :update
 
     def approve!(approved_by = nil)
       update!(status: :approved, completed_at: Time.current)
@@ -43,22 +44,16 @@ module Dscf::Banking
     end
 
     def review_status
-      latest_review = reviews.where(context: 'default').order(created_at: :desc).first
+      latest_review = reviews.where(context: "default").order(created_at: :desc).first
       latest_review&.status || status
     end
 
-    def create_account_if_approved
-      if review_status == 'approved' && !has_account?
-        AccountCreationService.call(self)
-      end
-    end
-
     def self.ransackable_attributes(auth_object = nil)
       %w[id application_number status submitted_at completed_at created_at updated_at]
     end
 
     def self.ransackable_associations(auth_object = nil)
-      %w[user virtual_account_product account reviews]
+      %w[user virtual_account_product account reviews documents]
     end
 
     private
@@ -80,5 +75,12 @@ module Dscf::Banking
         end
       end
     end
+
+    def create_account_if_approved
+      return unless review_status == "approved"
+      return if has_account?
+
+      AccountCreationService.call(self)
+    end
   end
 end

data/app/serializers/dscf/banking/application_serializer.rb

@@ -9,6 +9,7 @@ module Dscf::Banking
     belongs_to :assigned_branch_manager, optional: true
     has_one :account, serializer: AccountSerializer, if: :has_account?
     has_many :reviews, serializer: Dscf::Core::ReviewSerializer
+    has_many :documents, serializer: DocumentSerializer
 
     def has_account?
       object.has_account?

data/app/serializers/dscf/banking/document_serializer.rb

@@ -0,0 +1,8 @@
+module Dscf::Banking
+  class DocumentSerializer < ActiveModel::Serializer
+    attributes :id, :document_type, :is_verified, :verified_at, :metadata, :created_at, :updated_at
+
+    # Remove polymorphic association that causes ActiveStorage issues
+    # belongs_to :verified_by, polymorphic: true, optional: true
+  end
+end

data/app/services/dscf/banking/account_creation_service.rb

@@ -9,7 +9,7 @@ module Dscf::Banking
     end
 
     def call
-      return nil unless @application.review_status == 'approved'
+      return nil unless @application.review_status == "approved"
       return nil if account_already_exists?
 
       create_account

data/config/routes.rb

@@ -30,6 +30,7 @@ Dscf::Banking::Engine.routes.draw do
       patch :request_modification
       patch :resubmit
     end
+    resources :documents, only: [ :index, :show, :create, :update, :destroy ]
   end
 
   resources :transaction_types

data/db/seeds.rb

@@ -63,7 +63,7 @@ end
 puts "Created system deposit account: #{system_deposit_account.name}"
 
 system_withdrawal_account = Dscf::Banking::Account.find_or_create_by(
-  name: "System Withdrawal Account", 
+  name: "System Withdrawal Account",
   system_account: true
 ) do |account|
   account.currency = "ETB"

data/lib/dscf/banking/version.rb

@@ -1,5 +1,5 @@
 module Dscf
   module Banking
-    VERSION = "0.2.6"
+    VERSION = "0.2.8"
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: dscf-banking
 version: !ruby/object:Gem::Version
-  version: 0.2.6
+  version: 0.2.8
 platform: ruby
 authors:
 - Eyosiyas Mekbib
 bindir: bin
 cert_chain: []
-date: 2025-10-14 00:00:00.000000000 Z
+date: 2025-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails