dscf-banking 0.2.5 → 0.2.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ae4e30f9cb66b830a7f1dbca21d6367ca2d8f1e7ac2c2498a7fffd47d43dcb98
-  data.tar.gz: 9d665128ce356618b58555517a363edcd950ecc7f9bc2bd84e275442d345de27
+  metadata.gz: c92f5cf56bdb2b4a3f6d15d1c75cfd1ac51da1e2e525ba7a568e80f289564d8a
+  data.tar.gz: 34962544cd525e20993f49a278655c6d291803c86a411b90eb3946f1aec62aea
 SHA512:
-  metadata.gz: 9144d56b603e412a7107775a79f0512dea89d38c7ef524762e94f968a9528e62b93cb9eae92fcb36775c95c9b8685eb39eabae9bf52000c5f72b2297da2820f8
-  data.tar.gz: '03409240d9099a644c393a5a07328540f4775679d4b92ef212477272d3306df2829c74aa06522cc276e24371fb6fc54f129577c447d1b851de48a0c3fb99e61a'
+  metadata.gz: 12ba4363d0f4ab6b8edf6a432539b325d68a58d7ef49b1a1d0d756ccbe7880d311eeb903e63d19920a4bc25631b1c345abcabf5bb95cd8307ffa3be2b694c43d
+  data.tar.gz: 2b8514d69f366c986b88f393fb8e7102974c71ae3936ab618b21ad59318c2002df6b1b21db304465177351189be07486ce4552f2ac0dbdb556fb4e1010a86b2b

data/app/controllers/dscf/banking/applications_controller.rb

@@ -52,7 +52,7 @@ module Dscf::Banking
     end
 
     def eager_loaded_associations
-      [ :user, :virtual_account_product, reviews: { reviewed_by: :user_profile } ]
+      [ :user, :virtual_account_product, :documents, reviews: { reviewed_by: :user_profile } ]
     end
 
     def allowed_order_columns
@@ -61,10 +61,10 @@ module Dscf::Banking
 
     def default_serializer_includes
       {
-        index: [:user, :virtual_account_product, reviews: { reviewed_by: :user_profile }],
-        show: [:user, :virtual_account_product, :account, reviews: { reviewed_by: :user_profile }],
-        create: [:reviews],
-        update: [:user, :virtual_account_product, :account, reviews: { reviewed_by: :user_profile }]
+        index: [ :user, :virtual_account_product, :documents, reviews: { reviewed_by: :user_profile } ],
+        show: [ :user, :virtual_account_product, :account, :documents, reviews: { reviewed_by: :user_profile } ],
+        create: [ :reviews, :documents ],
+        update: [ :user, :virtual_account_product, :account, :documents, reviews: { reviewed_by: :user_profile } ]
       }
     end
   end

data/app/controllers/dscf/banking/documents_controller.rb

@@ -0,0 +1,53 @@
+module Dscf::Banking
+  class DocumentsController < ApplicationController
+    include Dscf::Core::Common
+
+    before_action :find_application
+
+    private
+
+    def find_application
+      @application = Application.find(params[:application_id])
+    end
+
+    def model_class
+      Dscf::Core::Document
+    end
+
+    def collection
+      @application.documents
+    end
+
+    def build_resource
+      @application.documents.build
+    end
+
+    def find_resource
+      @application.documents.find(params[:id])
+    end
+
+    def model_params
+      params.require(:document).permit(
+        :document_type,
+        metadata: {}
+      ).merge(documentable: @application)
+    end
+
+    def eager_loaded_associations
+      []
+    end
+
+    def allowed_order_columns
+      %w[id document_type is_verified verified_at created_at updated_at]
+    end
+
+    def default_serializer_includes
+      {
+        index: [],
+        show: [],
+        create: [],
+        update: []
+      }
+    end
+  end
+end

data/app/controllers/dscf/banking/transactions_controller.rb

@@ -6,7 +6,7 @@ module Dscf::Banking
       render json: {
         success: false,
         error: "Transaction not found",
-        errors: ["Transaction with ID #{params[:id]} not found"]
+        errors: [ "Transaction with ID #{params[:id]} not found" ]
       }, status: :not_found
     end
 

data/app/controllers/dscf/banking/virtual_account_products_controller.rb

@@ -83,10 +83,10 @@ module Dscf::Banking
 
     def default_serializer_includes
       {
-        index: [:product_category, :created_by, :approved_by, reviews: { reviewed_by: :user_profile }],
-        show: [:product_category, :created_by, :approved_by, reviews: { reviewed_by: :user_profile }],
-        create: [:reviews],
-        update: [:product_category, :created_by, :approved_by, reviews: { reviewed_by: :user_profile }]
+        index: [ :product_category, :created_by, :approved_by, reviews: { reviewed_by: :user_profile } ],
+        show: [ :product_category, :created_by, :approved_by, reviews: { reviewed_by: :user_profile } ],
+        create: [ :reviews ],
+        update: [ :product_category, :created_by, :approved_by, reviews: { reviewed_by: :user_profile } ]
       }
     end
   end

data/app/models/dscf/banking/application.rb

@@ -8,6 +8,7 @@ module Dscf::Banking
     belongs_to :assigned_branch_manager, class_name: "Dscf::Core::User", optional: true
     belongs_to :virtual_account_product, class_name: "Dscf::Banking::VirtualAccountProduct"
     has_one :account, class_name: "Dscf::Banking::Account"
+    has_many :documents, class_name: "Dscf::Core::Document", as: :documentable, dependent: :destroy
 
     validates :application_number, presence: true, uniqueness: true, length: { maximum: 50 }
     validates :applicant_type, presence: true
@@ -42,8 +43,13 @@ module Dscf::Banking
       Account.exists?(application: self)
     end
 
+    def review_status
+      latest_review = reviews.where(context: "default").order(created_at: :desc).first
+      latest_review&.status || status
+    end
+
     def create_account_if_approved
-      if saved_change_to_status? && status_approved?
+      if review_status == "approved" && !has_account?
         AccountCreationService.call(self)
       end
     end
@@ -53,7 +59,7 @@ module Dscf::Banking
     end
 
     def self.ransackable_associations(auth_object = nil)
-      %w[user virtual_account_product account reviews]
+      %w[user virtual_account_product account reviews documents]
     end
 
     private

data/app/serializers/dscf/banking/application_serializer.rb

@@ -9,6 +9,7 @@ module Dscf::Banking
     belongs_to :assigned_branch_manager, optional: true
     has_one :account, serializer: AccountSerializer, if: :has_account?
     has_many :reviews, serializer: Dscf::Core::ReviewSerializer
+    has_many :documents, serializer: DocumentSerializer
 
     def has_account?
       object.has_account?

data/app/serializers/dscf/banking/document_serializer.rb

@@ -0,0 +1,8 @@
+module Dscf::Banking
+  class DocumentSerializer < ActiveModel::Serializer
+    attributes :id, :document_type, :is_verified, :verified_at, :metadata, :created_at, :updated_at
+
+    # Remove polymorphic association that causes ActiveStorage issues
+    # belongs_to :verified_by, polymorphic: true, optional: true
+  end
+end

data/app/services/dscf/banking/account_creation_service.rb

@@ -9,7 +9,7 @@ module Dscf::Banking
     end
 
     def call
-      return nil unless @application.status_approved?
+      return nil unless @application.review_status == "approved"
       return nil if account_already_exists?
 
       create_account

data/config/routes.rb

@@ -30,6 +30,7 @@ Dscf::Banking::Engine.routes.draw do
       patch :request_modification
       patch :resubmit
     end
+    resources :documents, only: [ :index, :show, :create, :update, :destroy ]
   end
 
   resources :transaction_types

data/db/seeds.rb

@@ -63,7 +63,7 @@ end
 puts "Created system deposit account: #{system_deposit_account.name}"
 
 system_withdrawal_account = Dscf::Banking::Account.find_or_create_by(
-  name: "System Withdrawal Account", 
+  name: "System Withdrawal Account",
   system_account: true
 ) do |account|
   account.currency = "ETB"

data/lib/dscf/banking/version.rb

@@ -1,5 +1,5 @@
 module Dscf
   module Banking
-    VERSION = "0.2.5"
+    VERSION = "0.2.7"
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: dscf-banking
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 0.2.7
 platform: ruby
 authors:
 - Eyosiyas Mekbib
 bindir: bin
 cert_chain: []
-date: 2025-10-14 00:00:00.000000000 Z
+date: 2025-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails