dscf-banking 0.2.4 → 0.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1b7834f2745a3928e7857c8460f4f85ef499ea7a760b1ca8d3dabeb3545886b8
-  data.tar.gz: 373cb2daa82e54960ee7e0219bd9cbc61576246e5516600f1796369ad9431395
+  metadata.gz: 318c6e93b2062a45adb19d98709d9f0812788e0137bea60f9b56d66d2617b56a
+  data.tar.gz: 910120a3392d73f497aa511c3f971da9326a4a7ddc45d5820430d908b0959c05
 SHA512:
-  metadata.gz: 1f7ab2f858766b2b722baa9fdc837646dbb686e18066e92f997a7e2cb5e80b8089d6ec1eedd109428a456ec8d4a4a6a6c8f79b7eb9268a92fb17074bd2b54b67
-  data.tar.gz: 347cfd2b812e210a23bd255be66429a73fc492f28d74cb112a8d93672c9acd60e1fa2236ed65beadf38a75c96d1c6118b80da441ab070b048d02b726a8f12804
+  metadata.gz: 2195accd89bcc4f487e514e8209c31131c011bb5d676729d5ea18c68955d2bfd98a179a85e018c8e54901a473ee9c16da8179feb1c3580534fea68c273bc26c6
+  data.tar.gz: 28a117bad46972db2b9759dcfeee8c3d9bba034bada79f924058b096a6873a93d84a1fd4f39942f3857bc8a94feef3462374f2334a82a2c28a470a8b9cdc86f7

data/app/controllers/dscf/banking/applications_controller.rb

@@ -6,7 +6,7 @@ module Dscf::Banking
     # Custom default context for applications
     reviewable_context :default,
       statuses: %w[draft submitted under_review approved rejected request_modification],
-      initial_status: "submitted",
+      initial_status: "draft",
       transitions: {
         "draft" => %w[submitted],
         "submitted" => %w[under_review approved rejected request_modification],

data/app/models/dscf/banking/application.rb

@@ -16,7 +16,7 @@ module Dscf::Banking
     validates :rejection_reason, presence: true, if: -> { status == "rejected" }
 
     enum :applicant_type, { individual: 0, business: 1 }, prefix: :applicant_type
-    enum :status, { draft: 0, submitted: 1, under_review: 2, approved: 3, rejected: 4 }, prefix: :status
+    enum :status, { draft: 0, submitted: 1, under_review: 2, approved: 3, rejected: 4, request_modification: 5 }, prefix: :status
 
     before_validation :generate_application_number, if: -> { new_record? && application_number.blank? }
     before_update :set_timestamps_on_status_change
@@ -42,8 +42,13 @@ module Dscf::Banking
       Account.exists?(application: self)
     end
 
+    def review_status
+      latest_review = reviews.where(context: 'default').order(created_at: :desc).first
+      latest_review&.status || status
+    end
+
     def create_account_if_approved
-      if saved_change_to_status? && status_approved?
+      if review_status == 'approved' && !has_account?
         AccountCreationService.call(self)
       end
     end

data/app/services/dscf/banking/account_creation_service.rb

@@ -9,7 +9,7 @@ module Dscf::Banking
     end
 
     def call
-      return nil unless @application.status_approved?
+      return nil unless @application.review_status == 'approved'
       return nil if account_already_exists?
 
       create_account

data/lib/dscf/banking/version.rb

@@ -1,5 +1,5 @@
 module Dscf
   module Banking
-    VERSION = "0.2.4"
+    VERSION = "0.2.6"
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: dscf-banking
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.6
 platform: ruby
 authors:
 - Eyosiyas Mekbib
 bindir: bin
 cert_chain: []
-date: 2025-10-13 00:00:00.000000000 Z
+date: 2025-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails