dscf-banking 0.2.2 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 15401decf84bf542c773e447b403a9bf49631c9d0a566b81b0301dfddb880ff4
-  data.tar.gz: 5f5cc744a1fadafbd69fd740167aad3ab668c0aa37951ce8ff0a8842e0881e5c
+  metadata.gz: 1b7834f2745a3928e7857c8460f4f85ef499ea7a760b1ca8d3dabeb3545886b8
+  data.tar.gz: 373cb2daa82e54960ee7e0219bd9cbc61576246e5516600f1796369ad9431395
 SHA512:
-  metadata.gz: 57fbc8692e1d4767bb48be19d29c7ec5350239cbfdaaa18c9ee0349acd43246e83b8a8343d24d0788a9be475a250bce445f3740ffab362e1eb90c438a889a74a
-  data.tar.gz: 9a5eff19db2c9e2d1379c699a83d7409e339efb92d6bc8f761a92630912bfd58b2881743abc024f3809e2860fc044623dad1e8d53dfaece60670f06af1c986cb
+  metadata.gz: 1f7ab2f858766b2b722baa9fdc837646dbb686e18066e92f997a7e2cb5e80b8089d6ec1eedd109428a456ec8d4a4a6a6c8f79b7eb9268a92fb17074bd2b54b67
+  data.tar.gz: 347cfd2b812e210a23bd255be66429a73fc492f28d74cb112a8d93672c9acd60e1fa2236ed65beadf38a75c96d1c6118b80da441ab070b048d02b726a8f12804

data/app/controllers/dscf/banking/accounts_controller.rb

@@ -210,6 +210,7 @@ module Dscf::Banking
         minimum_balance: account.minimum_balance,
         currency: account.currency,
         active: account.active,
+        system_account: account.system_account,
         application_id: account.application_id,
         virtual_account_product_id: account.virtual_account_product_id,
         account_properties: account.account_properties,
@@ -231,6 +232,7 @@ module Dscf::Banking
         :minimum_balance,
         :currency,
         :active,
+        :system_account,
         account_properties: {}
       )
     end

data/app/controllers/dscf/banking/applications_controller.rb

@@ -5,18 +5,21 @@ module Dscf::Banking
 
     # Custom default context for applications
     reviewable_context :default,
-      statuses: %w[draft submitted under_review approved rejected],
+      statuses: %w[draft submitted under_review approved rejected request_modification],
       initial_status: "submitted",
       transitions: {
         "draft" => %w[submitted],
-        "submitted" => %w[under_review approved rejected],
-        "under_review" => %w[approved rejected]
+        "submitted" => %w[under_review approved rejected request_modification],
+        "under_review" => %w[approved rejected request_modification],
+        "request_modification" => %w[submitted]
       },
       actions: {
         submit: { status: "submitted" },
         assign_for_review: { status: "under_review" },
         approve: { status: "approved" },
-        reject: { status: "rejected", require_feedback: true }
+        reject: { status: "rejected", require_feedback: true },
+        request_modification: { status: "request_modification", require_feedback: true },
+        resubmit: { status: "submitted", update_model: true }
       }
 
     private

data/app/controllers/dscf/banking/transactions_controller.rb

@@ -2,6 +2,14 @@ module Dscf::Banking
   class TransactionsController < ApplicationController
     include Dscf::Core::Common
 
+    rescue_from ActiveRecord::RecordNotFound do |exception|
+      render json: {
+        success: false,
+        error: "Transaction not found",
+        errors: ["Transaction with ID #{params[:id]} not found"]
+      }, status: :not_found
+    end
+
     # Transfer money between accounts (from test cases)
     def transfer
       debit_account = Dscf::Banking::Account.find_by(account_number: transfer_params[:debit_account_number])

data/config/locales/en.yml

@@ -18,8 +18,12 @@ en:
       assign_for_review: "Application assigned for review successfully"
       approve: "Application approved successfully"
       reject: "Application rejected successfully"
+      request_modification: "Modification requested for application"
+      resubmit: "Application resubmitted successfully"
     errors:
       submit: "Failed to submit application"
       assign_for_review: "Failed to assign application for review"
       approve: "Failed to approve application"
-      reject: "Failed to reject application"
+      reject: "Failed to reject application"
+      request_modification: "Failed to request modification for application"
+      resubmit: "Failed to resubmit application"

data/config/routes.rb

@@ -27,6 +27,8 @@ Dscf::Banking::Engine.routes.draw do
       patch :assign_for_review
       patch :approve
       patch :reject
+      patch :request_modification
+      patch :resubmit
     end
   end
 

data/db/seeds.rb

@@ -48,4 +48,30 @@ user7 = User.create(name: "Fikirte Alemayehu", email: "fikirte@example.com", pas
 user7.roles << branch_manager_role
 puts "Created user: #{user7.name}"
 
+# Seed system accounts for transaction processing
+puts "Seeding system accounts..."
+system_deposit_account = Dscf::Banking::Account.find_or_create_by(
+  name: "System Deposit Account",
+  system_account: true
+) do |account|
+  account.currency = "ETB"
+  account.status = :active
+  account.current_balance = 0
+  account.available_balance = 0
+  account.minimum_balance = 0
+end
+puts "Created system deposit account: #{system_deposit_account.name}"
+
+system_withdrawal_account = Dscf::Banking::Account.find_or_create_by(
+  name: "System Withdrawal Account", 
+  system_account: true
+) do |account|
+  account.currency = "ETB"
+  account.status = :active
+  account.current_balance = 0
+  account.available_balance = 0
+  account.minimum_balance = 0
+end
+puts "Created system withdrawal account: #{system_withdrawal_account.name}"
+
 puts "Seeding completed successfully."

data/lib/dscf/banking/version.rb

@@ -1,5 +1,5 @@
 module Dscf
   module Banking
-    VERSION = "0.2.2"
+    VERSION = "0.2.4"
   end
 end

data/spec/factories/dscf/banking/documents.rb

@@ -0,0 +1,10 @@
+FactoryBot.define do
+  factory :dscf_banking_document, class: "Dscf::Core::Document" do
+    association :documentable, factory: :application
+    document_type { :business_license }
+    verified_by { nil }
+
+    # For file attachment, we can use a simple fixture or skip it in basic tests
+    # file { Rack::Test::UploadedFile.new(Rails.root.join('spec', 'fixtures', 'test.pdf'), 'application/pdf') }
+  end
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: dscf-banking
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.4
 platform: ruby
 authors:
 - Eyosiyas Mekbib
 bindir: bin
 cert_chain: []
-date: 2025-10-11 00:00:00.000000000 Z
+date: 2025-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -442,6 +442,7 @@ files:
 - app/controllers/dscf/banking/accounts_controller.rb
 - app/controllers/dscf/banking/application_controller.rb
 - app/controllers/dscf/banking/applications_controller.rb
+- app/controllers/dscf/banking/documents_controller.rb
 - app/controllers/dscf/banking/interest_configurations_controller.rb
 - app/controllers/dscf/banking/interest_rate_tiers_controller.rb
 - app/controllers/dscf/banking/interest_rate_types_controller.rb
@@ -467,6 +468,7 @@ files:
 - app/models/dscf/banking/virtual_account_product.rb
 - app/serializers/dscf/banking/account_serializer.rb
 - app/serializers/dscf/banking/application_serializer.rb
+- app/serializers/dscf/banking/document_serializer.rb
 - app/serializers/dscf/banking/interest_configuration_serializer.rb
 - app/serializers/dscf/banking/interest_rate_tier_serializer.rb
 - app/serializers/dscf/banking/interest_rate_type_serializer.rb
@@ -504,6 +506,7 @@ files:
 - lib/tasks/dscf/banking_tasks.rake
 - spec/factories/dscf/banking/accounts.rb
 - spec/factories/dscf/banking/applications.rb
+- spec/factories/dscf/banking/documents.rb
 - spec/factories/dscf/banking/interest_configurations.rb
 - spec/factories/dscf/banking/interest_rate_tiers.rb
 - spec/factories/dscf/banking/interest_rate_types.rb