dry_crud 1.7.0 → 2.0.0

data/lib/generators/dry_crud/templates/spec/helpers/utility_helper_spec.rb

@@ -0,0 +1,74 @@
+# encoding: UTF-8
+require 'spec_helper'
+
+describe UtilityHelper do
+
+  include CrudTestHelper
+
+  before(:all) do
+    reset_db
+    setup_db
+    create_test_data
+  end
+
+  after(:all) { reset_db }
+
+  describe '#column_type' do
+    let(:model) { crud_test_models(:AAAAA) }
+
+    it 'should recognize types' do
+      column_type(model, :name).should == :string
+      column_type(model, :children).should == :integer
+      column_type(model, :companion_id).should == :integer
+      column_type(model, :rating).should == :float
+      column_type(model, :income).should == :decimal
+      column_type(model, :birthdate).should == :date
+      column_type(model, :gets_up_at).should == :time
+      column_type(model, :last_seen).should == :datetime
+      column_type(model, :human).should == :boolean
+      column_type(model, :remarks).should == :text
+      column_type(model, :companion).should be_nil
+    end
+  end
+
+  describe '#content_tag_nested' do
+
+    it 'should escape safe content' do
+      html = content_tag_nested(:div, %w(a b)) { |e| content_tag(:span, e) }
+      html.should be_html_safe
+      html.should == '<div><span>a</span><span>b</span></div>'
+    end
+
+    it 'should escape unsafe content' do
+      html = content_tag_nested(:div, %w(a b)) { |e| "<#{e}>" }
+      html.should == '<div>&lt;a&gt;&lt;b&gt;</div>'
+    end
+
+    it 'should simply join without block' do
+      html = content_tag_nested(:div, %w(a b))
+      html.should == '<div>ab</div>'
+    end
+  end
+
+  describe '#safe_join' do
+    it 'should works as super without block' do
+      html = safe_join(['<a>', '<b>'.html_safe])
+      html.should == '&lt;a&gt;<b>'
+    end
+
+    it 'should collect contents for array' do
+      html = safe_join(%w(a b)) { |e| content_tag(:span, e) }
+      html.should == '<span>a</span><span>b</span>'
+    end
+  end
+
+  describe '#default_crud_attrs' do
+    it 'do not contain id and password' do
+      default_crud_attrs.should ==
+        [:name, :email, :whatever, :children, :companion_id, :rating, :income,
+         :birthdate, :gets_up_at, :last_seen, :human, :remarks,
+         :created_at, :updated_at]
+    end
+  end
+
+end

data/lib/generators/dry_crud/templates/spec/support/crud_controller_examples.rb

@@ -1,163 +1,220 @@
+# encoding: UTF-8
 require 'support/crud_controller_test_helper'
 
 RSpec.configure do |c|
-  c.before :failing => true do
+  c.before failing: true do
     model_class.any_instance.stub(:save).and_return(false)
     model_class.any_instance.stub(:destroy).and_return(false)
   end
 end
 
-# A set of examples to include into the tests for your crud controller subclasses.
-# Simply #let :test_entry, :new_entry_attrs and :edit_entry_attrs to test the basic
-# crud functionality. 
+# A set of examples to include into the tests for your crud controller
+# subclasses. Simply #let :test_entry, :new_entry_attrs and :edit_entry_attrs
+# to test the basic crud functionality.
 # If single examples do not match with you implementation, you may skip
 # them by passing a skip parameter with context arrays:
-#   include_examples 'crud controller', :skip => [%w(index html sort) %w(destroy json)]
-shared_examples "crud controller" do |options|
+#   include_examples 'crud controller',
+#                    skip: [%w(index html sort) %w(destroy json)]
+shared_examples 'crud controller' do |options|
 
   include CrudControllerTestHelper
 
   render_views
 
   subject { response }
-  
+
   let(:model_class)      { controller.send(:model_class) }
   let(:model_identifier) { controller.model_identifier }
   let(:test_params)      { scope_params }
-  let(:entry)            { assigns(controller.send(:ivar_name, model_class)) }
-  let(:entries)          { assigns(controller.send(:ivar_name, model_class).pluralize) }
   let(:sort_column)      { model_class.column_names.first }
+  let(:entry)            { assigns(controller.send(:ivar_name, model_class)) }
+  let(:entries) { assigns(controller.send(:ivar_name, model_class).pluralize) }
   let(:search_value) do
     field = controller.search_columns.first
     val = test_entry[field].to_s
-    val[0..((val.size + 1)/ 2)]
+    val[0..((val.size + 1) / 2)]
   end
 
   before do
     m = example.metadata
-    perform_combined_request if m[:perform_request] != false && m[:action] && m[:method]
+    if m[:perform_request] != false && m[:action] && m[:method]
+      perform_combined_request
+    end
   end
-  
-  
-  describe_action :get, :index, :unless => skip?(options, 'index') do
-    context ".html", :format => :html, :unless => skip?(options, %w(index html)) do
-    
-      context 'plain', :unless => skip?(options, %w(index html plain)), :combine => 'ihp' do
+
+  describe_action :get, :index,
+                  unless: skip?(options, 'index') do
+
+    context '.html',
+            format: :html,
+            unless: skip?(options, %w(index html)) do
+
+      context 'plain',
+              unless: skip?(options, %w(index html plain)),
+              combine: 'ihp' do
         it_should_respond
         it_should_assign_entries
         it_should_render
       end
-      
-      context "search", :if => described_class.search_columns.present?, :unless => skip?(options, %w(index html search)), :combine => 'ihse' do
-        let(:params) { {:q => search_value} }
-        
+
+      context 'search',
+              if: described_class.search_columns.present?,
+              unless: skip?(options, %w(index html search)),
+              combine: 'ihse' do
+        let(:params) { { q: search_value } }
+
         it_should_respond
-        context "entries" do
+
+        context 'entries' do
           subject { entries }
           it { should include(test_entry) }
         end
       end
-      
-      context "sort", :unless => skip?(options, %w(index html sort)) do
-        context "ascending", :unless => skip?(options, %w(index html sort ascending)), :combine => 'ihso' do
-          let(:params) { {:sort => sort_column, :sort_dir => 'asc'} } 
-          
+
+      context 'sort',
+              unless: skip?(options, %w(index html sort)) do
+        context 'ascending',
+                unless: skip?(options, %w(index html sort ascending)),
+                combine: 'ihso' do
+          let(:params) { { sort: sort_column, sort_dir: 'asc' } }
+
           it_should_respond
-          it "should have sorted entries" do
+
+          it 'should have sorted entries' do
             sorted = entries.sort_by(&(sort_column.to_sym))
             entries.should == sorted
           end
         end
-        
-        context "descending", :unless => skip?(options, %w(index html sort descending)), :combine => 'ihsd' do
-          let(:params) { {:sort => sort_column, :sort_dir => 'desc'} } 
-      
+
+        context 'descending',
+                unless: skip?(options, %w(index html sort descending)),
+                combine: 'ihsd' do
+          let(:params) { { sort: sort_column, sort_dir: 'desc' } }
+
           it_should_respond
-          it "should have sorted entries" do
+
+          it 'should have sorted entries' do
             sorted = entries.sort_by(&(sort_column.to_sym))
             entries.should == sorted.reverse
           end
         end
       end
     end
-    
-    context ".json", :format => :json, :unless => skip?(options, %w(index json)), :combine => 'ij' do
+
+    context '.json',
+            format: :json,
+            unless: skip?(options, %w(index json)),
+            combine: 'ij' do
       it_should_respond
       it_should_assign_entries
       its(:body) { should start_with('[{') }
     end
   end
-  
-  describe_action :get, :show, :id => true, :unless => skip?(options, 'show') do
 
-    context ".html", :format => :html, :unless => skip?(options, %w(show html)) do
-      context "plain", :unless => skip?(options, %w(show html plain)), :combine => 'sh' do
+  describe_action :get, :show,
+                  id: true,
+                  unless: skip?(options, 'show') do
+
+    context '.html',
+            format: :html,
+            unless: skip?(options, %w(show html)) do
+
+      context 'plain',
+              unless: skip?(options, %w(show html plain)),
+              combine: 'sh' do
         it_should_respond
         it_should_assign_entry
         it_should_render
       end
-      
-      context "with non-existing id", :unless => skip?(options, 'show', 'html', 'with non-existing id') do
-        let(:params) { {:id => 9999 } }
-        
-        it "should raise RecordNotFound", :perform_request => false do
-          expect { perform_request }.to raise_error(ActiveRecord::RecordNotFound)
+
+      context 'with non-existing id',
+              unless: skip?(options,
+                            %w(show html with_non_existing_id)) do
+        let(:params) { { id: 9999 } }
+
+        it 'should raise RecordNotFound', perform_request: false do
+          expect { perform_request }
+          .to raise_error(ActiveRecord::RecordNotFound)
         end
       end
     end
-    
-    context ".json", :format => :json, :unless => skip?(options, %w(show json)), :combine => 'sj' do
+
+    context '.json',
+            format: :json,
+            unless: skip?(options, %w(show json)),
+            combine: 'sj' do
       it_should_respond
       it_should_assign_entry
       its(:body) { should start_with('{') }
     end
   end
-  
-  describe_action :get, :new, :unless => skip?(options, %w(new)) do
-    context "plain", :unless => skip?(options, %w(new plain)), :combine => 'new' do
+
+  describe_action :get, :new,
+                  unless: skip?(options, %w(new)) do
+    context 'plain',
+            unless: skip?(options, %w(new plain)),
+            combine: 'new' do
       it_should_respond
       it_should_render
       it_should_persist_entry(false)
     end
-    
-    context "with params", :unless => skip?(options, 'new', 'with params') do
+
+    context 'with params',
+            unless: skip?(options, %w(new with_params)) do
       let(:params) { { model_identifier => new_entry_attrs } }
       it_should_set_attrs(:new)
     end
   end
-  
-  describe_action :post, :create, :unless => skip?(options, %w(create)) do
+
+  describe_action :post, :create,
+                  unless: skip?(options, %w(create)) do
     let(:params) { { model_identifier => new_entry_attrs } }
-    
-    it "should add entry to database", :perform_request => false do
+
+    it 'should add entry to database', perform_request: false do
       expect { perform_request }.to change { model_class.count }.by(1)
     end
-    
-    context "html", :format => :html, :unless => skip?(options, %w(create html)) do
-      context "with valid params", :unless => skip?(options, %w(create html valid)), :combine => 'ch' do
+
+    context 'html',
+            format: :html,
+            unless: skip?(options, %w(create html)) do
+      it_should_persist_entry # cannot combine this
+
+      context 'with valid params',
+              unless: skip?(options, %w(create html valid)),
+              combine: 'chv' do
         it_should_redirect_to_show
         it_should_set_attrs(:new)
-        it_should_persist_entry
         it_should_have_flash(:notice)
       end
-      
-      context "with invalid params", :failing => true, :unless => skip?(options, %w(create html invalid)), :combine => 'chi' do
+
+      context 'with invalid params',
+              failing: true,
+              unless: skip?(options, %w(create html invalid)),
+              combine: 'chi' do
         it_should_render('new')
         it_should_persist_entry(false)
         it_should_set_attrs(:new)
         it_should_not_have_flash(:notice)
       end
     end
-    
-    context "json", :format => :json, :unless => skip?(options, %w(create json)) do
-      context "with valid params", :unless => skip?(options, %w(create json valid)), :combine => 'cjv' do
+
+    context 'json',
+            format: :json,
+            unless: skip?(options, %w(create json)) do
+      it_should_persist_entry # cannot combine this
+
+      context 'with valid params',
+              unless: skip?(options, %w(create json valid)),
+              combine: 'cjv' do
         it_should_respond(201)
         it_should_set_attrs(:new)
         its(:body) { should start_with('{') }
-        it_should_persist_entry
       end
-      
-      context "with invalid params", :failing => true, :unless => skip?(options, %w(create json invalid)), :combine => 'cji' do
+
+      context 'with invalid params',
+              failing: true,
+              unless: skip?(options, %w(create json invalid)),
+              combine: 'cji' do
         it_should_respond(422)
         it_should_set_attrs(:new)
         its(:body) { should match(/"errors":\{/) }
@@ -165,80 +222,108 @@ shared_examples "crud controller" do |options|
       end
     end
   end
-  
-  describe_action :get, :edit, :id => true, :unless => skip?(options, %w(edit)), :combine => 'edit' do
+
+  describe_action :get, :edit,
+                  id: true,
+                  unless: skip?(options, %w(edit)),
+                  combine: 'edit' do
     it_should_respond
     it_should_render
     it_should_assign_entry
   end
-  
-  describe_action :put, :update, :id => true, :unless => skip?(options, %w(update)) do
-    let(:params) { {model_identifier => edit_entry_attrs} }
-    
-    it "should update entry in database", :perform_request => false do
+
+  describe_action :put, :update,
+                  id: true,
+                  unless: skip?(options, %w(update)) do
+    let(:params) { { model_identifier => edit_entry_attrs } }
+
+    it 'should update entry in database', perform_request: false do
       expect { perform_request }.to change { model_class.count }.by(0)
     end
-    
-    context ".html", :format => :html, :unless => skip?(options, %w(update html)) do
-      context "with valid params", :unless => skip?(options, %w(update html valid)), :combine => 'uhv' do
+
+    context '.html',
+            format: :html,
+            unless: skip?(options, %w(update html)) do
+      context 'with valid params',
+              unless: skip?(options, %w(update html valid)),
+              combine: 'uhv' do
         it_should_set_attrs(:edit)
         it_should_redirect_to_show
         it_should_persist_entry
         it_should_have_flash(:notice)
       end
-      
-      context "with invalid params", :failing => true, :unless => skip?(options, %w(update html invalid)), :combine => 'uhi' do
+
+      context 'with invalid params',
+              failing: true,
+              unless: skip?(options, %w(update html invalid)),
+              combine: 'uhi' do
         it_should_render('edit')
         it_should_set_attrs(:edit)
         it_should_not_have_flash(:notice)
       end
     end
-    
-    context ".json", :format => :json, :unless => skip?(options, %w(udpate json)) do
-      context "with valid params", :unless => skip?(options, %w(udpate json valid)), :combine => 'ujv' do
+
+    context '.json',
+            format: :json,
+            unless: skip?(options, %w(update json)) do
+
+      context 'with valid params',
+              unless: skip?(options, %w(update json valid)),
+              combine: 'ujv' do
         it_should_respond(204)
         it_should_set_attrs(:edit)
         its(:body) { should match(/s*/) }
         it_should_persist_entry
       end
-      
-      context "with invalid params", :failing => true, :unless => skip?(options, %w(update json invalid)), :combine => 'uji' do
+
+      context 'with invalid params',
+              failing: true,
+              unless: skip?(options, %w(update json invalid)),
+              combine: 'uji' do
         it_should_respond(422)
         it_should_set_attrs(:edit)
         its(:body) { should match(/"errors":\{/) }
       end
     end
   end
-  
-  describe_action :delete, :destroy, :id => true, :unless => skip?(options, %w(destroy)) do
-    
-    it "should remove entry from database", :perform_request => false  do
+
+  describe_action :delete, :destroy,
+                  id: true,
+                  unless: skip?(options, %w(destroy)) do
+
+    it 'should remove entry from database', perform_request: false  do
       expect { perform_request }.to change { model_class.count }.by(-1)
     end
-    
-    context ".html", :format => :html, :unless => skip?(options, %w(destroy html)) do
-      context "successfull", :combine => 'dhs' do
+
+    context '.html',
+            format: :html,
+            unless: skip?(options, %w(destroy html)) do
+
+      context 'successfull', combine: 'dhs' do
         it_should_redirect_to_index
         it_should_have_flash(:notice)
       end
-      
-      context "with failure", :failing => true, :combine => 'dhf' do
+
+      context 'with failure', failing: true, combine: 'dhf' do
         it_should_redirect_to_index
         it_should_have_flash(:alert)
       end
     end
-    
-    context ".json", :format => :json, :unless => skip?(options, %w(destroy json)) do
-      context "successfull", :combine => 'djs' do
+
+    context '.json',
+            format: :json,
+            unless: skip?(options, %w(destroy json)) do
+
+      context 'successfull', combine: 'djs' do
         it_should_respond(204)
         its(:body) { should match(/s*/) }
       end
-      
-      context "with failure", :failing => true, :combine => 'djf' do
+
+      context 'with failure', failing: true, combine: 'djf' do
         it_should_respond(422)
         its(:body) { should match(/"errors":\{/) }
       end
     end
   end
-  
+
 end