dry-view 0.5.2 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d739724ab980eb210e9f651c78b3cbdf59e28c597e149b05d936f49a89f9d74f
-  data.tar.gz: 23604cb777111c1711b09fd1da0b98f18840872d6c03f6867257eb42b3b3d755
+  metadata.gz: 9c234898af572e4ebd4b6717f0ba9519f2b4feda8a6d7b2133c00ee8cea2ac7a
+  data.tar.gz: 6f086379dad341a18fbf4f68b3b6edde81cdcdf30e38c859aa5ba86556c56ae7
 SHA512:
-  metadata.gz: 5e66915108ff44c6e164459e30d3bcff67324b50dbd52bd853e1802bcbbefe824b440fc5e6e018033778f5d80717b8b61da1eaaf50071cad6ec9f3da154b15f8
-  data.tar.gz: c587910c53a1d229533740204875a99b480e232b8a8fb397775dc234d33cdda60b42095800ba7c16d3c4d181a64d9f7bab909e202684f7d8e192222a7d9cb650
+  metadata.gz: 0af32817c536bd8beeb57d63e856aeb49400579ab084a586c7d8fcdad32052d91244cf4a450a5b10243915fa652140d3389fccbd2421a04d2479767d515e5bb5
+  data.tar.gz: e6dbf82b4d90b57751a74047ffa8d9cda75986bb468a42553ab150f8c9f12458662329f0be859bc1701ce6d39e3ee1ee523abcc23d0ce928ccba106e3b9593f3

data/CHANGELOG.md

@@ -1,3 +1,16 @@
+# 0.5.3 / 2018-10-22
+
+### Added
+
+- `renderer_options` setting for configuring tilt-based renderer (liseki in [#62][pr62])
+
+### Changed
+
+- Part objects wrap values more transparently, via added `#respond_to_missing?` (liseki in [#63][pr63])
+
+[pr62]: https://github.com/dry-rb/dry-view/pull/62
+[pr63]: https://github.com/dry-rb/dry-view/pull/63
+
 # 0.5.2 / 2018-06-13
 
 ### Changed

data/lib/dry/view/controller.rb

@@ -14,6 +14,7 @@ module Dry
 
       DEFAULT_LAYOUTS_DIR = 'layouts'.freeze
       DEFAULT_CONTEXT = Object.new.freeze
+      DEFAULT_RENDERER_OPTIONS = {default_encoding: 'utf-8'.freeze}.freeze
       EMPTY_LOCALS = {}.freeze
 
       include Dry::Equalizer(:config)
@@ -24,6 +25,9 @@ module Dry
       setting :layout, false
       setting :template
       setting :default_format, :html
+      setting :renderer_options, DEFAULT_RENDERER_OPTIONS do |options|
+        DEFAULT_RENDERER_OPTIONS.merge(options.to_h).freeze
+      end
       setting :context, DEFAULT_CONTEXT
       setting :decorator, Decorator.new
 
@@ -49,7 +53,7 @@ module Dry
       # @api private
       def self.renderer(format)
         renderers.fetch(format) {
-          renderers[format] = Renderer.new(paths, format: format)
+          renderers[format] = Renderer.new(paths, format: format, **config.renderer_options)
         }
       end
 

data/lib/dry/view/part.rb

@@ -80,6 +80,12 @@ module Dry
         end
       end
 
+      def respond_to_missing?(name, include_private = false)
+        d = self.class.decorated_attributes
+        c = CONVENIENCE_METHODS
+        d.key?(name) || c.include?(name) || _value.respond_to?(name, include_private) || super
+      end
+
       def _render_scope(name, **locals)
         Scope.new(
           locals: locals.merge(name => self),

data/lib/dry/view/renderer.rb

@@ -7,19 +7,20 @@ module Dry
       PARTIAL_PREFIX = "_".freeze
       PATH_DELIMITER = "/".freeze
 
-      include Dry::Equalizer(:paths, :format)
+      include Dry::Equalizer(:paths, :format, :options)
 
       TemplateNotFoundError = Class.new(StandardError)
 
-      attr_reader :paths, :format, :engine, :tilts
+      attr_reader :paths, :format, :options, :tilts
 
       def self.tilts
         @__engines__ ||= {}
       end
 
-      def initialize(paths, format:)
+      def initialize(paths, format:, **options)
         @paths = paths
         @format = format
+        @options = options
         @tilts = self.class.tilts
       end
 
@@ -61,10 +62,9 @@ module Dry
         partial_name = name_segments[0..-2].push("#{PARTIAL_PREFIX}#{name_segments[-1]}").join(PATH_DELIMITER)
       end
 
-      # TODO: make default_encoding configurable
       def tilt(path)
         tilts.fetch(path) {
-          tilts[path] = Tilt.new(path, nil, default_encoding: "utf-8")
+          tilts[path] = Tilt.new(path, nil, **options)
         }
       end
     end

data/lib/dry/view/version.rb

@@ -1,5 +1,5 @@
 module Dry
   module View
-    VERSION = '0.5.2'.freeze
+    VERSION = '0.5.3'.freeze
   end
 end

data/spec/fixtures/templates/controller_renderer_options.html.erb

@@ -0,0 +1,3 @@
+<% form action: '/people' do |f| %>
+<%= f.text :name %>
+<% end %>

data/spec/unit/controller_spec.rb

@@ -34,4 +34,50 @@ RSpec.describe Dry::View::Controller do
       expect { controller.(options) }.to raise_error Dry::View::Controller::UndefinedTemplateError
     end
   end
+
+  describe 'renderer options' do
+    subject(:controller) {
+      Class.new(Dry::View::Controller) do
+        configure do |config|
+          config.paths = SPEC_ROOT.join('fixtures/templates')
+          config.template = 'controller_renderer_options'
+          config.renderer_options = {
+            outvar: '@__buf__'
+          }
+        end
+      end.new
+    }
+
+    subject(:context) {
+      Class.new do
+        def self.form(action:, &blk)
+          new(action, &blk)
+        end
+
+        def initialize(action, &blk)
+          @buf = eval('@__buf__', blk.binding)
+
+          @buf << "<form action=\"#{action}\" method=\"post\">"
+          blk.(self)
+          @buf << '</form>'
+        end
+
+        def text(name)
+          "<input type=\"text\" name=\"#{name}\" />"
+        end
+      end
+    }
+
+    it 'uses default encoding' do
+      klass = Class.new(Dry::View::Controller)
+      expect(klass.config.renderer_options).to be_a Hash
+      expect(klass.config.renderer_options[:default_encoding]).to eql 'utf-8'
+    end
+
+    it 'are passed to renderer' do
+      expect(controller.(context: context)).to eql(
+        '<form action="/people" method="post"><input type="text" name="name" /></form>'
+      )
+    end
+  end
 end

data/spec/unit/part_spec.rb

@@ -68,6 +68,20 @@ RSpec.describe Dry::View::Part do
         expect { part.farewell }.to raise_error(NoMethodError)
       end
     end
+
+    describe '#respond_to_missing?' do
+      let(:value) { double(greeting: 'hello from value') }
+
+      it 'handles convenience methods' do
+        expect(part).to respond_to(:context)
+        expect(part).to respond_to(:render)
+        expect(part).to respond_to(:value)
+      end
+
+      it 'handles value methods' do
+        expect(part).to respond_to(:greeting)
+      end
+    end
   end
 
   context 'without a renderer' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dry-view
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.3
 platform: ruby
 authors:
 - Piotr Solnica
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-06-12 00:00:00.000000000 Z
+date: 2018-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: tilt
@@ -143,6 +143,7 @@ files:
 - lib/dry/view/scope.rb
 - lib/dry/view/version.rb
 - spec/fixtures/templates/_hello.html.slim
+- spec/fixtures/templates/controller_renderer_options.html.erb
 - spec/fixtures/templates/decorated_parts.html.slim
 - spec/fixtures/templates/edit.html.slim
 - spec/fixtures/templates/empty.html.slim
@@ -196,12 +197,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.5
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Functional view rendering system
 test_files:
 - spec/fixtures/templates/_hello.html.slim
+- spec/fixtures/templates/controller_renderer_options.html.erb
 - spec/fixtures/templates/decorated_parts.html.slim
 - spec/fixtures/templates/edit.html.slim
 - spec/fixtures/templates/empty.html.slim