dry-view 0.5.1 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3b7142689536853b1e216512d00558c4edbaafe44ee3abc2d1e51eb1ad498bc1
-  data.tar.gz: 6373160c6fa073a52c9fa106b6f1c8ac0b58c088bbce26e29b4b65ff587dad27
+  metadata.gz: d739724ab980eb210e9f651c78b3cbdf59e28c597e149b05d936f49a89f9d74f
+  data.tar.gz: 23604cb777111c1711b09fd1da0b98f18840872d6c03f6867257eb42b3b3d755
 SHA512:
-  metadata.gz: 0eaccf27fc9d7f29a8b3be6e9b695341738e67d98b132630d8ec6bc462683bdcfa4613ed59c00a8d3791f93789f4a5c437ee6dd2b66c5c893d52e537a3a93f51
-  data.tar.gz: a6b0bb154f5056de7b1bf6ca21d78e7ad9e1453dcc64d438d7f435e6285f236e0627d55838ba020bdf68749a4a1da577b6dc1e2cacc9e8b8993ba553d99a797d
+  metadata.gz: 5e66915108ff44c6e164459e30d3bcff67324b50dbd52bd853e1802bcbbefe824b440fc5e6e018033778f5d80717b8b61da1eaaf50071cad6ec9f3da154b15f8
+  data.tar.gz: c587910c53a1d229533740204875a99b480e232b8a8fb397775dc234d33cdda60b42095800ba7c16d3c4d181a64d9f7bab909e202684f7d8e192222a7d9cb650

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+# 0.5.2 / 2018-06-13
+
+### Changed
+
+- Only truthy view part attributes are decorated (timriley)
+
+[Compare v0.5.0...v0.5.1](https://github.com/dry-rb/dry-view/compare/v0.5.1...v0.5.2)
+
 # 0.5.1 / 2018-02-20
 
 ### Added

data/lib/dry/view/part.rb

@@ -90,13 +90,18 @@ module Dry
 
       def _resolve_decorated_attribute(name)
         _decorated_attributes.fetch(name) {
-          _decorated_attributes[name] = _decorator.(
-            name,
-            _value.__send__(name),
-            renderer: _renderer,
-            context: _context,
-            **self.class.decorated_attributes[name],
-          )
+          attribute = _value.__send__(name)
+
+          _decorated_attributes[name] =
+            if attribute # Decorate truthy attributes only
+              _decorator.(
+                name,
+                attribute,
+                renderer: _renderer,
+                context: _context,
+                **self.class.decorated_attributes[name],
+              )
+            end
         }
       end
     end

data/lib/dry/view/version.rb

@@ -1,5 +1,5 @@
 module Dry
   module View
-    VERSION = '0.5.1'.freeze
+    VERSION = '0.5.2'.freeze
   end
 end

data/spec/integration/part/decorated_attributes_spec.rb

@@ -32,10 +32,14 @@ RSpec.describe 'Part / Decorated attributes' do
     end
   }
 
+  let (:author) {
+    author_class.new(name: 'Jane Doe')
+  }
+
   let(:article) {
     article_class.new(
       title: 'Hello world',
-      author: author_class.new(name: 'Jane Doe'),
+      author: author,
       comments: [
         comment_class.new(author: author_class.new(name: 'Sue Smith'), body: 'Great article')
       ]
@@ -59,10 +63,18 @@ RSpec.describe 'Part / Decorated attributes' do
           end
         }
 
-        it 'decorates exposures with the standard Dry::View::Part class' do
+        it 'decorates attributes with the standard Dry::View::Part class' do
           expect(article_part.author).to be_a Dry::View::Part
           expect(article_part.comments[0]).to be_a Dry::View::Part
         end
+
+        context 'falsey values' do
+          let(:author) { nil }
+
+          it 'does not decorate the attributes' do
+            expect(article_part.author).to be_nil
+          end
+        end
       end
 
       describe 'single declaration' do
@@ -72,10 +84,18 @@ RSpec.describe 'Part / Decorated attributes' do
           end
         }
 
-        it 'decorates exposures with the standard Dry::View::Part class' do
+        it 'decorates attributes with the standard Dry::View::Part class' do
           expect(article_part.author).to be_a Dry::View::Part
           expect(article_part.comments[0]).to be_a Dry::View::Part
         end
+
+        context 'falsey values' do
+          let(:author) { nil }
+
+          it 'does not decorate the attributes' do
+            expect(article_part.author).to be_nil
+          end
+        end
       end
     end
 
@@ -97,10 +117,18 @@ RSpec.describe 'Part / Decorated attributes' do
         end
       }
 
-      it 'deorates exposures with the specified part class' do
+      it 'deorates attributes with the specified part class' do
         expect(article_part.author).to be_a Test::AuthorPart
         expect(article_part.comments[0]).to be_a Test::CommentPart
       end
+
+      context 'falsey values' do
+        let(:author) { nil }
+
+        it 'does not decorate the attributes' do
+          expect(article_part.author).to be_nil
+        end
+      end
     end
   end
 
@@ -148,10 +176,18 @@ RSpec.describe 'Part / Decorated attributes' do
       end
     end
 
-    it 'deorates exposures using the custom decorator' do
+    it 'deorates attributes using the custom decorator' do
       expect(article_part.author).to be_a Test::AuthorPart
       expect(article_part.comments[0]).to be_a Test::CommentPart
       expect(article_part.comments[0].author).to be_a Test::AuthorPart
     end
+
+    context 'falsey values' do
+      let(:author) { nil }
+
+      it 'does not decorate the attributes' do
+        expect(article_part.author).to be_nil
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dry-view
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors:
 - Piotr Solnica
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-02-19 00:00:00.000000000 Z
+date: 2018-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: tilt