dry-validation 0.7.4 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 16d323de18e994f717e80abb07098dc2e82534af
-  data.tar.gz: ef0e116d3f56eb249b70315bf43af0d74a249c58
+  metadata.gz: 16fb2c50b37c5d1aff843031ff3d7af6e87ab05a
+  data.tar.gz: 64f74fc7df4b183322908ec96120d4dbbb4b38c2
 SHA512:
-  metadata.gz: 2b9690fa21b55e46d09db96f93d4d58f07d7d5fe7291219d3107f154eda2597e6e7209049403fcb1f518936d025a62d31ed2315e8795a02e7bd017c9ead52b33
-  data.tar.gz: b8ac25905f1f1d602c0f930cc2895b9e6fd27d53fae3dfcc2794e46f255034417e14ce9407491ba19fd2c86276b3e820783890bdac10fb42bf190f72e9577ec3
+  metadata.gz: 244e25e33c6a1795436fc015cab5d4c23961c974eaf7208144faf69a81c040ede351c54e7225efc1695283f061225b0543e2ee6120fce29c00069725fc0ee791
+  data.tar.gz: fc89edb2c0f6862d1771b46a77863b644947db429861a34d944cab9799d328df01e7bb0554291fa23f12d67ba545a276fe8f3c98435837485fb002bee55b5101

data/.gitignore

@@ -3,6 +3,7 @@ coverage
 /.bundle
 vendor/bundle
 bin/
+log/
 tmp/
 .idea/
 Gemfile.lock

data/.travis.yml

@@ -1,18 +1,17 @@
 language: ruby
 sudo: false
 cache: bundler
-bundler_args: --without console benchmarks
+bundler_args: --full-index --without console benchmarks
 script:
   - bundle exec rake spec
 rvm:
   - 2.0
-  - 2.1
-  - 2.2
-  - 2.3.0
+  - 2.1.10
+  - 2.2.5
+  - 2.3.1
   - rbx-2
-  - jruby-9000
+  - jruby-9.1.1.0
   - ruby-head
-  - jruby-head
 env:
   global:
     - JRUBY_OPTS='--dev -J-Xmx1024M'
@@ -21,6 +20,10 @@ matrix:
     - rvm: rbx-2
     - rvm: ruby-head
     - rvm: jruby-head
+  include:
+    - rvm: jruby-head
+      before_install: gem install bundler --no-ri --no-rdoc
+
 notifications:
   email: false
   webhooks:

data/CHANGELOG.md

@@ -1,3 +1,61 @@
+# v0.8.0 2016-07-01
+
+### Added
+
+* Explicit interface for type specs used to set up coercions, ie `required(:age, :int)` (solnic)
+* Support new dry-logic predicates: `:excluded_from?`, `:excludes?`, `:included_in?`, `:includes?`, `:not_eql?`, `:odd?`, `:even?` (jodosha, fran-worley)
+* Support for blocks in `value`, `filled` and `maybe` macros (solnic)
+* Support for passing a schema to `value|filled|maybe` macros ie `maybe(SomeSchema)` (solnic)
+* Support for `each(SomeSchema)` (solnic)
+* Support for `value|filled|maybe` macros + `each` inside a block ie: `maybe(:filled?) { each(:int?) }` (solnic)
+* Support for dedicated hint messages via `en.errors.#{predicate}.(hint|failure)` look-up paths (solnic)
+* Support for configuring custom DSL extensions via `dsl_extensions` setting on Schema class (solnic)
+* Support for preconfiguring a predicate for the input value ie `value :hash?` used for prerequisite-checks (solnic)
+* Infer coercion from constrained types  (solnic)
+* Add value macro (coop)
+* Enable .schema to accept objects that respond to #schema (ttdonovan)
+* Support for schema predicates which don't need any arguments (fran-worley)
+* Error and hint messages have access to all predicate arguments by default (fran-worley+solnic)
+* Invalid predicate name in DSL will raise an error (solnic)
+* Predicate with invalid arity in DSL will raise an error (solnic)
+
+### Fixed
+
+* Support for jRuby  9.1.1.0 (flash-gordon)
+* Fix bug when using predicates with options in each and when (fran-worley)
+* Fix bug when validating custom types (coop)
+* Fix depending on deeply nested values in high-lvl rules (solnic)
+* Fix duplicated error message for lt? when hint was used (solnic)
+* Fix hints for nested schemas (solnic)
+* Fix an issue where rules with same names inside nested schemas have incorrect hints (solnic)
+* Fix a bug where hints were being generated 4 times (solnic)
+* Fix duplicated error messages when message is different than a hint (solnic)
+
+### Changed
+
+* Uses new `:weak` hash constructor from dry-types 0.8.0 which can partially coerce invalid hash (solnic)
+* `key` has been deprecated in favor of `required` (coop)
+* `required` has been deprecated in favor of `filled` (coop)
+* Now relies on dry-logic v0.3.0 and dry-types v0.8.0 (fran-worley)
+* Tring to use illogical predicates with maybe and filled macros now raise InvalidSchemaError (fran-worley)
+* Enable coercion on form.true and form.false (fran-worley)
+* Remove attr (will be extracted to a separate gem) (coop)
+* Deprecate required in favour of filled (coop)
+* Deprecate key in favor of required (coop)
+* Remove nested key syntax (solnic)
+
+### Internal
+
+* ~15% performance boost via various optimizations (solnic)
+* When using explicit type specs building a schema is ~80-85x faster (solnic)
+* No longer uses `Dry::Types::Predicates` as `:type?` predicate was moved to dry-logic (solnic)
+* Integration specs covering predicates with Form and Schema (jodosha)
+* Use latest ruby versions on travis (flash-gordon)
+* Make pry console optional with IRB as a default (flash-gordon)
+* Remove wrapping rules in :set nodes (solnic)
+
+[Compare v0.7.4...master](https://github.com/dryrb/dry-validation/compare/v0.7.4...master)
+
 # v0.7.4 2016-04-06
 
 ### Added

data/Gemfile

@@ -13,9 +13,9 @@ group :tools do
 end
 
 group :benchmarks do
-  gem 'hotch'
-  gem 'activemodel', '5.0.0.beta3'
-  gem 'actionpack', '5.0.0.beta3'
+  gem 'hotch', platform: :mri
+  gem 'activemodel', '~> 5.0.0.rc'
+  gem 'actionpack', '~> 5.0.0.rc'
   gem 'benchmark-ips'
   gem 'virtus'
 end

data/benchmarks/benchmark_form_invalid.rb

@@ -0,0 +1,64 @@
+require 'benchmark/ips'
+require 'active_model'
+
+require 'dry-validation'
+
+I18n.locale = :en
+I18n.backend.load_translations
+
+class User
+  include ActiveModel::Validations
+
+  attr_reader :email, :age
+
+  validates :email, :age, presence: true
+  validates :age, numericality: { greater_than: 18 }
+
+  def initialize(attrs)
+    @email, @age = attrs.values_at('email', 'age')
+  end
+end
+
+schema = Dry::Validation.Schema do
+  configure do
+    config.messages = :i18n
+  end
+
+  required(:email).filled
+  required(:age).filled(:int?, gt?: 18)
+end
+
+form = Dry::Validation.Form do
+  configure do
+    config.messages = :i18n
+    config.type_specs = true
+  end
+
+  required(:email, :string).filled
+  required(:age, :int).filled(:int?, gt?: 18)
+end
+
+params = { 'email' => '', 'age' => '18' }
+coerced = { email: nil, age: 18 }
+
+puts schema.(coerced).inspect
+puts form.(params).inspect
+puts User.new(params).validate
+
+Benchmark.ips do |x|
+  x.report('ActiveModel::Validations') do
+    user = User.new(params)
+    user.validate
+    user.errors
+  end
+
+  x.report('dry-validation / schema') do
+    schema.(coerced).messages
+  end
+
+  x.report('dry-validation / form') do
+    form.(params).messages
+  end
+
+  x.compare!
+end

data/benchmarks/benchmark_form_valid.rb

@@ -0,0 +1,64 @@
+require 'benchmark/ips'
+require 'active_model'
+
+require 'dry-validation'
+
+I18n.locale = :en
+I18n.backend.load_translations
+
+class User
+  include ActiveModel::Validations
+
+  attr_reader :email, :age
+
+  validates :email, :age, presence: true
+  validates :age, numericality: { greater_than: 18 }
+
+  def initialize(attrs)
+    @email, @age = attrs.values_at('email', 'age')
+  end
+end
+
+schema = Dry::Validation.Schema do
+  configure do
+    config.messages = :i18n
+  end
+
+  required(:email).filled
+  required(:age).filled(:int?, gt?: 18)
+end
+
+form = Dry::Validation.Form do
+  configure do
+    config.messages = :i18n
+    config.type_specs = true
+  end
+
+  required(:email, :string).filled
+  required(:age, :int).filled(:int?, gt?: 18)
+end
+
+params = { 'email' => 'foo@bar.baz', 'age' => '19' }
+coerced = { email: 'foo@bar.baz', age: 19 }
+
+puts schema.(coerced).inspect
+puts form.(params).inspect
+puts User.new(params).validate
+
+Benchmark.ips do |x|
+  x.report('ActiveModel::Validations') do
+    user = User.new(params)
+    user.validate
+    user.errors
+  end
+
+  x.report('dry-validation / schema') do
+    schema.(coerced).messages
+  end
+
+  x.report('dry-validation / form') do
+    form.(params).messages
+  end
+
+  x.compare!
+end

data/benchmarks/profile_schema_call_invalid.rb

@@ -0,0 +1,20 @@
+require_relative 'suite'
+require 'hotch'
+
+schema = Dry::Validation.Schema do
+  configure { config.messages = :i18n }
+
+  required(:email).filled
+  required(:age).filled(:int?, gt?: 18)
+  required(:address).filled(:hash?)
+end
+
+input = { email: '', age: 18, address: {} }
+
+puts schema.(input).inspect
+
+Hotch() do
+  10_000.times do
+    schema.(input)
+  end
+end

data/benchmarks/profile_schema_call_valid.rb

@@ -0,0 +1,20 @@
+require_relative 'suite'
+require 'hotch'
+
+schema = Dry::Validation.Schema do
+  configure { config.messages = :i18n }
+
+  required(:email).filled
+  required(:age).filled(:int?, gt?: 18)
+  required(:address).filled(:hash?)
+end
+
+input = { email: 'jane@doe.org', age: 19, address: { city: 'Krakow' } }
+
+puts schema.(input).inspect
+
+Hotch() do
+  10_000.times do
+    schema.(input)
+  end
+end

data/benchmarks/profile_schema_definition.rb

@@ -0,0 +1,14 @@
+require_relative 'suite'
+require 'hotch'
+
+Hotch() do
+  1000.times do
+    Dry::Validation.Schema do
+      configure { config.messages = :i18n }
+
+      required(:email).filled
+      required(:age).filled(:int?, gt?: 18)
+      required(:address).filled(:hash?)
+    end
+  end
+end

data/benchmarks/profile_schema_messages_invalid.rb

@@ -0,0 +1,20 @@
+require_relative 'suite'
+require 'hotch'
+
+schema = Dry::Validation.Schema do
+  configure { config.messages = :i18n }
+
+  required(:email).filled
+  required(:age).filled(:int?, gt?: 18)
+  required(:address).filled(:hash?)
+end
+
+input = { email: '', age: 18, address: {} }
+
+puts schema.(input).inspect
+
+Hotch() do
+  10_000.times do
+    schema.(input).messages
+  end
+end

data/benchmarks/suite.rb

@@ -0,0 +1,5 @@
+require 'i18n'
+require 'dry-validation'
+
+I18n.locale = :en
+I18n.backend.load_translations

data/config/errors.yml

@@ -4,9 +4,13 @@ en:
 
     empty?: "must be empty"
 
-    exclusion?: "must not be one of: %{list}"
+    excludes?: "must not include %{value}"
 
-    eql?: "must be equal to %{eql_value}"
+    excluded_from?: "must not be one of: %{list}"
+
+    eql?: "must be equal to %{left}"
+
+    not_eql?: "must not be equal to %{left}"
 
     filled?: "must be filled"
 
@@ -24,8 +28,11 @@ en:
 
     hash?: "must be a hash"
 
+    included_in?: "must be one of: %{list}"
     inclusion?: "must be one of: %{list}"
 
+    includes?: "must include %{value}"
+
     bool?: "must be boolean"
 
     true?: "must be true"
@@ -48,7 +55,7 @@ en:
 
     attr?: "is missing"
 
-    lt?: "must be less than %{num} (%{value} was given)"
+    lt?: "must be less than %{num}"
 
     lteq?: "must be less than or equal to %{num}"
 
@@ -64,11 +71,11 @@ en:
 
     size?:
       arg:
-        default: "size must be %{num}"
+        default: "size must be %{size}"
         range: "size must be within %{left} - %{right}"
 
       value:
         string:
           arg:
-            default: "length must be %{num}"
+            default: "length must be %{size}"
             range: "length must be within %{left} - %{right}"

data/dry-validation.gemspec

@@ -19,8 +19,8 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'dry-configurable', '~> 0.1', '>= 0.1.3'
   spec.add_runtime_dependency 'dry-container', '~> 0.2', '>= 0.2.8'
   spec.add_runtime_dependency 'dry-equalizer', '~> 0.2'
-  spec.add_runtime_dependency 'dry-logic', '~> 0.2', '>= 0.2.2'
-  spec.add_runtime_dependency 'dry-types', '~> 0.6', '>= 0.6.0'
+  spec.add_runtime_dependency 'dry-logic', '~> 0.3', '>= 0.3.0'
+  spec.add_runtime_dependency 'dry-types', '~> 0.8', '>= 0.8.0'
 
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake'

data/examples/basic.rb

@@ -1,9 +1,9 @@
 require 'dry-validation'
 
 schema = Dry::Validation.Schema do
-  key(:email).required
+  required(:email).filled
 
-  key(:age).required(:int?, gt?: 18)
+  required(:age).filled(:int?, gt?: 18)
 end
 
 errors = schema.call(email: 'jane@doe.org', age: 19).messages

data/examples/form.rb

@@ -1,9 +1,9 @@
 require 'dry-validation'
 
 schema = Dry::Validation.Form do
-  key(:email).required
+  required(:email).filled
 
-  key(:age).required(:int?, gt?: 18)
+  required(:age).filled(:int?, gt?: 18)
 end
 
 errors = schema.call('email' => '', 'age' => '18').messages

data/examples/json.rb

@@ -2,9 +2,9 @@ require 'json'
 require 'dry-validation'
 
 schema = Dry::Validation.JSON do
-  key(:email).required
+  required(:email).filled
 
-  key(:age).required(:int?, gt?: 18)
+  required(:age).filled(:int?, gt?: 18)
 end
 
 errors = schema.call(JSON.parse('{"email": "", "age": "18"}')).messages