dry-system 0.19.0 → 0.21.0

data/lib/dry/system/container.rb

@@ -7,16 +7,19 @@ require "dry-configurable"
 require "dry-container"
 require "dry/inflector"
 
+require "dry/core/constants"
 require "dry/core/deprecations"
 
 require "dry/system"
-require "dry/system/errors"
-require "dry/system/booter"
 require "dry/system/auto_registrar"
-require "dry/system/manual_registrar"
-require "dry/system/importer"
+require "dry/system/booter"
 require "dry/system/component"
 require "dry/system/constants"
+require "dry/system/errors"
+require "dry/system/identifier"
+require "dry/system/importer"
+require "dry/system/indirect_component"
+require "dry/system/manual_registrar"
 require "dry/system/plugins"
 
 require_relative "component_dir"
@@ -48,7 +51,7 @@ module Dry
     #
     # Every container needs to be configured with following settings:
     #
-    # * `:name` - a unique container identifier
+    # * `:name` - a unique container name
     # * `:root` - a system root directory (defaults to `pwd`)
     #
     # @example
@@ -73,17 +76,17 @@ module Dry
       extend Dry::System::Plugins
 
       setting :name
-      setting(:root, Pathname.pwd.freeze) { |path| Pathname(path) }
-      setting :system_dir, "system"
-      setting :bootable_dirs, ["system/boot"]
-      setting :registrations_dir, "container"
-      setting :component_dirs, Config::ComponentDirs.new, cloneable: true
-      setting :inflector, Dry::Inflector.new
-      setting :booter, Dry::System::Booter
-      setting :auto_registrar, Dry::System::AutoRegistrar
-      setting :manual_registrar, Dry::System::ManualRegistrar
-      setting :importer, Dry::System::Importer
-      setting(:components, {}, reader: true, &:dup)
+      setting :root, default: Pathname.pwd.freeze, constructor: -> path { Pathname(path) }
+      setting :system_dir, default: "system"
+      setting :bootable_dirs, default: ["system/boot"]
+      setting :registrations_dir, default: "container"
+      setting :component_dirs, default: Config::ComponentDirs.new, cloneable: true
+      setting :inflector, default: Dry::Inflector.new
+      setting :booter, default: Dry::System::Booter
+      setting :auto_registrar, default: Dry::System::AutoRegistrar
+      setting :manual_registrar, default: Dry::System::ManualRegistrar
+      setting :importer, default: Dry::System::Importer
+      setting :components, default: {}, reader: true, constructor: :dup.to_proc
 
       class << self
         def strategies(value = nil)
@@ -101,8 +104,8 @@ module Dry
         # @see https://dry-rb.org/gems/dry-configurable
         #
         # @api public
-        def setting(name, *args, &block)
-          super(name, *args, &block)
+        def setting(name, default = Dry::Core::Constants::Undefined, **options, &block)
+          super(name, default, **options, &block)
           # TODO: dry-configurable needs a public API for this
           config._settings << _settings[name]
           self
@@ -233,7 +236,7 @@ module Dry
         #     persistence.register(:db, DB.new)
         #   end
         #
-        # @param name [Symbol] a unique identifier for a bootable component
+        # @param name [Symbol] a unique name for a bootable component
         #
         # @see Lifecycle
         #
@@ -261,17 +264,15 @@ module Dry
         deprecate :finalize, :boot
 
         # @api private
-        def boot_external(identifier, from:, key: nil, namespace: nil, &block)
+        def boot_external(name, from:, key: nil, namespace: nil, &block)
           System.providers[from].component(
-            identifier, key: key, namespace: namespace, finalize: block, container: self
+            name, key: key, namespace: namespace, finalize: block, container: self
           )
         end
 
         # @api private
-        def boot_local(identifier, namespace: nil, &block)
-          Components::Bootable.new(
-            identifier, container: self, namespace: namespace, &block
-          )
+        def boot_local(name, namespace: nil, &block)
+          Components::Bootable.new(name, container: self, namespace: namespace, &block)
         end
 
         # Return if a container was finalized
@@ -490,7 +491,7 @@ module Dry
         #
         # @!method registered?(key)
         #   Whether a +key+ is registered (doesn't trigger loading)
-        #   @param [String,Symbol] key Identifier
+        #   @param [String,Symbol] key The key
         #   @return [Boolean]
         #   @api public
         #
@@ -580,17 +581,17 @@ module Dry
         def load_component(key)
           return self if registered?(key)
 
-          component = component(key)
-
-          if component.bootable?
-            booter.start(component)
+          if (bootable_component = booter.find_component(key))
+            booter.start(bootable_component)
             return self
           end
 
+          component = find_component(key)
+
           booter.boot_dependency(component)
           return self if registered?(key)
 
-          if component.file_exists?
+          if component.loadable?
             load_local_component(component)
           elsif manual_registrar.file_exists?(component)
             manual_registrar.(component)
@@ -614,25 +615,21 @@ module Dry
 
           container = importer[import_namespace]
 
-          container.load_component(identifier.dequalified(import_namespace).key)
+          container.load_component(identifier.namespaced(from: import_namespace, to: nil).key)
 
           importer.(import_namespace, container)
         end
 
-        def component(identifier)
-          if (bootable_component = booter.find_component(identifier))
-            return bootable_component
-          end
-
+        def find_component(key)
           # Find the first matching component from within the configured component dirs.
-          # If no matching component is found, return a plain component instance with no
-          # associated file path. This fallback is important because the component may
-          # still be loadable via the manual registrar or an imported container.
+          # If no matching component is found, return a null component; this fallback is
+          # important because the component may still be loadable via the manual registrar
+          # or an imported container.
           component_dirs.detect { |dir|
-            if (component = dir.component_for_identifier(identifier))
+            if (component = dir.component_for_key(key))
               break component
             end
-          } || Component.new(identifier)
+          } || IndirectComponent.new(Identifier.new(key, separator: config.namespace_separator))
         end
       end
 

data/lib/dry/system/errors.rb

@@ -11,13 +11,13 @@ module Dry
       end
     end
 
-    # Error raised when the container tries to load a component with missing
-    # file
-    #
-    # @api public
-    FileNotFoundError = Class.new(StandardError) do
-      def initialize(component)
-        super("could not resolve require file for component '#{component.identifier}'")
+    # Error raised when a namespace for a component dir is added to configuration more
+    # than once
+    NamespaceAlreadyAddedError = Class.new(StandardError) do
+      def initialize(path)
+        path_label = path ? "path #{path.inspect}" : "root path"
+
+        super("Namespace for #{path_label} already added")
       end
     end
 
@@ -27,7 +27,7 @@ module Dry
     ComponentFileMismatchError = Class.new(StandardError) do
       def initialize(component)
         super(<<-STR)
-          Bootable component '#{component.identifier}' not found
+          Bootable component '#{component.name}' not found
         STR
       end
     end
@@ -43,26 +43,17 @@ module Dry
       end
     end
 
-    # Error raised when component's identifier is not valid
+    # Error raised when component's name is not valid
     #
     # @api public
-    InvalidComponentIdentifierError = Class.new(ArgumentError) do
+    InvalidComponentNameError = Class.new(ArgumentError) do
       def initialize(name)
         super(
-          "component identifier +#{name}+ is invalid or boot file is missing"
+          "component +#{name}+ is invalid or boot file is missing"
         )
       end
     end
 
-    # Error raised when component's identifier for booting is not a symbol
-    #
-    # @api public
-    InvalidComponentIdentifierTypeError = Class.new(ArgumentError) do
-      def initialize(name)
-        super("component identifier #{name.inspect} must be a symbol")
-      end
-    end
-
     # Error raised when trying to stop a component that hasn't started yet
     #
     # @api public

data/lib/dry/system/identifier.rb

@@ -13,42 +13,29 @@ module Dry
     #
     # @api public
     class Identifier
-      include Dry::Equalizer(:identifier, :namespace, :separator)
+      include Dry::Equalizer(:key, :separator)
 
-      # @return [String] the identifier string
+      # @return [String] the identifier's string key
       # @api public
-      attr_reader :identifier
-
-      # @return [String, nil] the namespace for the component
-      # @api public
-      attr_reader :namespace
+      attr_reader :key
 
       # @return [String] the configured namespace separator
       # @api public
       attr_reader :separator
 
       # @api private
-      def initialize(identifier, namespace: nil, separator: DEFAULT_SEPARATOR)
-        @identifier = identifier.to_s
-        @namespace = namespace
+      def initialize(key, separator: DEFAULT_SEPARATOR)
+        @key = key.to_s
         @separator = separator
       end
 
-      # @!method key
-      #   Returns the identifier string
-      #
-      #   @return [String]
-      #   @see #identifier
-      #   @api public
-      alias_method :key, :identifier
-
       # @!method to_s
-      #   Returns the identifier string
+      #   Returns the identifier string key
       #
       #   @return [String]
-      #   @see #identifier
+      #   @see #key
       #   @api public
-      alias_method :to_s, :identifier
+      alias_method :to_s, :key
 
       # Returns the root namespace segment of the identifier string, as a symbol
       #
@@ -62,31 +49,11 @@ module Dry
         segments.first.to_sym
       end
 
-      # Returns a path-delimited representation of the identifier, with the namespace
-      # incorporated. This path is intended for usage when requiring the component's
-      # source file.
-      #
-      # @example
-      #   identifier.key # => "articles.operations.create"
-      #   identifier.namespace # => "admin"
+      # Returns true if the given leading namespaces are a leading part of the
+      # identifier's key
       #
-      #   identifier.path # => "admin/articles/operations/create"
-      #
-      # @return [String] the path
-      # @api public
-      def path
-        @require_path ||= identifier.gsub(separator, PATH_SEPARATOR).yield_self { |path|
-          if namespace
-            namespace_path = namespace.to_s.gsub(separator, PATH_SEPARATOR)
-            "#{namespace_path}#{PATH_SEPARATOR}#{path}"
-          else
-            path
-          end
-        }
-      end
-
-      # Returns true if the given namespace prefix is part of the identifier's leading
-      # namespaces
+      # Also returns true if nil is given (technically, from nothing everything is
+      # wrought)
       #
       # @example
       #   identifier.key # => "articles.operations.create"
@@ -94,63 +61,74 @@ module Dry
       #   identifier.start_with?("articles.operations") # => true
       #   identifier.start_with?("articles") # => true
       #   identifier.start_with?("article") # => false
+      #   identifier.start_with?(nil) # => true
       #
       # @param leading_namespaces [String] the one or more leading namespaces to check
       # @return [Boolean]
       # @api public
       def start_with?(leading_namespaces)
-        identifier.start_with?("#{leading_namespaces}#{separator}")
+        leading_namespaces.nil? ||
+          key.start_with?("#{leading_namespaces}#{separator}") ||
+          key.eql?(leading_namespaces)
       end
 
-      # Returns a copy of the identifier with the given leading namespaces removed from
-      # the identifier string.
-      #
-      # Additional options may be provided, which are passed to #initialize when
-      # constructing the new copy of the identifier
-      #
-      # @param leading_namespace [String] the one or more leading namespaces to remove
-      # @param options [Hash] additional options for initialization
+      # Returns the key with its segments separated by the given separator
       #
-      # @return [Dry::System::Identifier] the copy of the identifier
+      # @example
+      #   identifier.key # => "articles.operations.create"
+      #   identifier.key_with_separator("/") # => "articles/operations/create"
       #
-      # @see #initialize
+      # @return [String] the key using the separator
       # @api private
-      def dequalified(leading_namespaces, **options)
-        new_identifier = identifier.gsub(
-          /^#{Regexp.escape(leading_namespaces)}#{Regexp.escape(separator)}/,
-          EMPTY_STRING
-        )
-
-        return self if new_identifier == identifier
-
-        self.class.new(
-          new_identifier,
-          namespace: namespace,
-          separator: separator,
-          **options
-        )
+      def key_with_separator(separator)
+        segments.join(separator)
       end
 
-      # Returns a copy of the identifier with the given options applied
+      # Returns a copy of the identifier with the key's leading namespace(s) replaced
+      #
+      # @example Changing a namespace
+      #   identifier.key # => "articles.operations.create"
+      #   identifier.namespaced(from: "articles", to: "posts").key # => "posts.commands.create"
+      #
+      # @example Removing a namespace
+      #   identifier.key # => "articles.operations.create"
+      #   identifier.namespaced(from: "articles", to: nil).key # => "operations.create"
       #
-      # @param namespace [String, nil] a new namespace to be used
+      # @example Adding a namespace
+      #   identifier.key # => "articles.operations.create"
+      #   identifier.namespaced(from: nil, to: "admin").key # => "admin.articles.operations.create"
+      #
+      # @param from [String, nil] the leading namespace(s) to replace
+      # @param to [String, nil] the replacement for the leading namespace
       #
       # @return [Dry::System::Identifier] the copy of the identifier
       #
       # @see #initialize
       # @api private
-      def with(namespace:)
-        self.class.new(
-          identifier,
-          namespace: namespace,
-          separator: separator
-        )
+      def namespaced(from:, to:)
+        return self if from == to
+
+        separated_to = "#{to}#{separator}" if to
+
+        new_key =
+          if from.nil?
+            "#{separated_to}#{key}"
+          else
+            key.sub(
+              /^#{Regexp.escape(from.to_s)}#{Regexp.escape(separator)}/,
+              separated_to || EMPTY_STRING
+            )
+          end
+
+        return self if new_key == key
+
+        self.class.new(new_key, separator: separator)
       end
 
       private
 
       def segments
-        @segments ||= identifier.split(separator)
+        @segments ||= key.split(separator)
       end
     end
   end

data/lib/dry/system/indirect_component.rb

@@ -0,0 +1,65 @@
+# frozen_string_literal: true
+
+require "dry/core/equalizer"
+
+module Dry
+  module System
+    # An indirect component is a component that cannot be directly from a source file
+    # directly managed by the container. It may be component that needs to be loaded
+    # indirectly, either via a manual registration file or an imported container
+    #
+    # Indirect components are an internal abstraction and, unlike ordinary components, are
+    # not exposed to users via component dir configuration hooks.
+    #
+    # @see Container#load_component
+    # @see Container#find_component
+    #
+    # @api private
+    class IndirectComponent
+      include Dry::Equalizer(:identifier)
+
+      # @!attribute [r] identifier
+      #   @return [String] the component's unique identifier
+      attr_reader :identifier
+
+      # @api private
+      def initialize(identifier)
+        @identifier = identifier
+      end
+
+      # Returns false, indicating that the component is not directly loadable from the
+      # files managed by the container
+      #
+      # This is the inverse of {Component#loadable?}
+      #
+      # @return [FalseClass]
+      #
+      # @api private
+      def loadable?
+        false
+      end
+
+      # Returns the component's unique key
+      #
+      # @return [String] the key
+      #
+      # @see Identifier#key
+      #
+      # @api private
+      def key
+        identifier.to_s
+      end
+
+      # Returns the root namespace segment of the component's key, as a symbol
+      #
+      # @see Identifier#root_key
+      #
+      # @return [Symbol] the root key
+      #
+      # @api private
+      def root_key
+        identifier.root_key
+      end
+    end
+  end
+end

data/lib/dry/system/loader.rb

@@ -17,7 +17,7 @@ module Dry
     #   class MyApp < Dry::System::Container
     #     configure do |config|
     #       # ...
-    #       config.loader MyLoader
+    #       config.component_dirs.loader = MyLoader
     #     end
     #   end
     #
@@ -28,7 +28,7 @@ module Dry
         #
         # @api public
         def require!(component)
-          require(component.path) if component.file_exists?
+          require(component.require_path)
           self
         end
 
@@ -61,8 +61,7 @@ module Dry
         # @api public
         def constant(component)
           inflector = component.inflector
-
-          inflector.constantize(inflector.camelize(component.path))
+          inflector.constantize(inflector.camelize(component.const_path))
         end
 
         private

data/lib/dry/system/manual_registrar.rb

@@ -30,16 +30,12 @@ module Dry
       end
 
       # @api private
-      def call(name)
-        name = name.respond_to?(:root_key) ? name.root_key.to_s : name
-
-        require(root.join(config.registrations_dir, name))
+      def call(component)
+        require(root.join(config.registrations_dir, component.root_key.to_s))
       end
 
-      def file_exists?(name)
-        name = name.respond_to?(:root_key) ? name.root_key.to_s : name
-
-        File.exist?(File.join(registrations_dir, "#{name}#{RB_EXT}"))
+      def file_exists?(component)
+        File.exist?(File.join(registrations_dir, "#{component.root_key}#{RB_EXT}"))
       end
 
       private

data/lib/dry/system/plugins/bootsnap.rb

@@ -16,7 +16,7 @@ module Dry
         def self.extended(system)
           super
           system.use(:env)
-          system.before(:configure) { setting :bootsnap, DEFAULT_OPTIONS }
+          system.before(:configure) { setting :bootsnap, default: DEFAULT_OPTIONS }
           system.after(:configure, &:setup_bootsnap)
         end
 

data/lib/dry/system/plugins/dependency_graph.rb

@@ -15,7 +15,7 @@ module Dry
           system.use(:notifications)
 
           system.before(:configure) do
-            setting :ignored_dependencies, []
+            setting :ignored_dependencies, default: []
           end
 
           system.after(:configure) do
@@ -34,10 +34,10 @@ module Dry
         # @api private
         def register(key, contents = nil, options = {}, &block)
           super
-
-          unless config.ignored_dependencies.include?(key.to_sym)
+          dependency_key = key.to_s
+          unless config.ignored_dependencies.include?(dependency_key)
             self[:notifications].instrument(
-              :registered_dependency, key: key, class: self[key].class
+              :registered_dependency, key: dependency_key, class: self[dependency_key].class
             )
           end
 

data/lib/dry/system/plugins/env.rb

@@ -20,7 +20,7 @@ module Dry
 
         # @api private
         def extended(system)
-          system.setting :env, inferrer.(), reader: true
+          system.setting :env, default: inferrer.(), reader: true
           super
         end
       end

data/lib/dry/system/plugins/logging.rb

@@ -11,14 +11,15 @@ module Dry
           system.before(:configure) do
             setting :logger, reader: true
 
-            setting :log_dir, "log"
+            setting :log_dir, default: "log"
 
-            setting :log_levels,
-                    development: Logger::DEBUG,
-                    test: Logger::DEBUG,
-                    production: Logger::ERROR
+            setting :log_levels, default: {
+              development: Logger::DEBUG,
+              test: Logger::DEBUG,
+              production: Logger::ERROR
+            }
 
-            setting :logger_class, ::Logger, reader: true
+            setting :logger_class, default: ::Logger, reader: true
           end
 
           system.after(:configure, &:register_logger)

data/lib/dry/system/plugins.rb

@@ -84,9 +84,7 @@ module Dry
       # Enables a plugin if not already enabled.
       # Raises error if plugin cannot be found in the plugin registry.
       #
-      # Plugin identifier
-      #
-      # @param [Symbol] name The plugin identifier
+      # @param [Symbol] name The plugin name
       # @param [Hash] options Plugin options
       #
       # @return [self]

data/lib/dry/system/provider.rb

@@ -7,14 +7,14 @@ require "dry/system/components/bootable"
 module Dry
   module System
     class Provider
-      attr_reader :identifier
+      attr_reader :name
 
       attr_reader :options
 
       attr_reader :components
 
-      def initialize(identifier, options)
-        @identifier = identifier
+      def initialize(name, options)
+        @name = name
         @options = options
         @components = Concurrent::Map.new
       end
@@ -35,9 +35,9 @@ module Dry
         boot_files.detect { |path| Pathname(path).basename(RB_EXT).to_s == name.to_s }
       end
 
-      def component(name, options = {})
-        identifier = options[:key] || name
-        components.fetch(identifier).new(name, options)
+      def component(component_name, options = {})
+        component_key = options[:key] || component_name
+        components.fetch(component_key).new(component_name, options)
       end
 
       def load_components

data/lib/dry/system/provider_registry.rb

@@ -15,12 +15,12 @@ module Dry
         items.each(&block)
       end
 
-      def register(identifier, options)
-        items << Provider.new(identifier, options)
+      def register(name, options)
+        items << Provider.new(name, options)
       end
 
-      def [](identifier)
-        detect { |provider| provider.identifier == identifier }
+      def [](name)
+        detect { |provider| provider.name == name }
       end
     end
   end