dry-system 0.14.1 → 0.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba8a673942fec2cb269c2c7679a6efbf7a977ff134f4440d53e8ee55f33d2d74
-  data.tar.gz: 51dfe194d1053882a7f90341dd57322816306bd122ca47b7152c4815465c01a7
+  metadata.gz: f029366a9ef603592adb0566dc7d7d1afb13b4e0a5ea86d70d6560a4e80b80f0
+  data.tar.gz: 96b625962372b8e0a00a4cb99a449f8a5ed550c3328b887ef65c47a314628092
 SHA512:
-  metadata.gz: 8f8e5a0355b3d62dd42ff8caef1fd928fb92e8c17f158e71cc639d430e1be2d2ccf51dc514f523fa303114de14c86182e60123a7a9346abaef2bb0a4114ceded
-  data.tar.gz: 565f94e2a6b9a6ab53ac79244074b4ec2e817aeb73518ac77db29b1532ae0ba14b38eb40d531d283a5a7a83118f6dba05f18c55d748cf793941432de61ac5d69
+  metadata.gz: 1ef15338eb9e108b6e489a59ce10f0e8e57608cb6882ae7f8b89680786752b68e00b12a15238f61af63c03382b160dadfe59457ef0d35516fe9defcfe69cb4f9
+  data.tar.gz: 4db3b188698061f78f23a8647d6145dc4466da9ac867c7c561f4aecd59434a18493b98b22d60c92f619f19f5fc177a723a8f2b4050be16f00d9151cadf7fdef2

data/CHANGELOG.md

@@ -1,3 +1,25 @@
+## v0.15.0 2020-01-30
+
+
+### Added
+
+- New hook - `before(:configure)` which a plugin should use if it needs to declare new settings (@solnic)
+
+```ruby
+# in your plugin code
+before(:configure) { setting :my_new_setting }
+
+after(:configure) { config.my_new_setting = "awesome" }
+```
+
+
+### Changed
+
+- Centralize error definitions in `lib/dry/system/errors.rb` (@cgeorgii)
+- All built-in plugins use `before(:configure)` now to declare their settings (@solnic)
+
+[Compare v0.14.1...vv0.15.0](https://github.com/dry-rb/dry-system/compare/v0.14.1...vv0.15.0)
+
 ## 0.14.1 2020-01-22
 
 

data/dry-system.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
   spec.metadata['source_code_uri']   = 'https://github.com/dry-rb/dry-system'
   spec.metadata['bug_tracker_uri']   = 'https://github.com/dry-rb/dry-system/issues'
 
-  spec.required_ruby_version = '>= 2.4.0'
+  spec.required_ruby_version = ">= 2.4.0"
 
   # to update dependencies edit project.yml
   spec.add_runtime_dependency "concurrent-ruby", "~> 1.0"

data/lib/dry/system/constants.rb

@@ -11,36 +11,5 @@ module Dry
     PATH_SEPARATOR = '/'
     DEFAULT_SEPARATOR = '.'
     WORD_REGEX = /\w+/.freeze
-
-    ComponentsDirMissing = Class.new(StandardError)
-    DuplicatedComponentKeyError = Class.new(ArgumentError)
-    InvalidSettingsError = Class.new(ArgumentError) do
-      # @api private
-      def initialize(attributes)
-        message = <<~STR
-          Could not initialize settings. The following settings were invalid:
-
-          #{attributes_errors(attributes).join("\n")}
-        STR
-        super(message)
-      end
-
-      private
-
-      def attributes_errors(attributes)
-        attributes.map { |key, error| "#{key.name}: #{error}" }
-      end
-    end
-
-    # Exception raise when a plugin dependency failed to load
-    #
-    # @api public
-    PluginDependencyMissing = Class.new(StandardError) do
-      # @api private
-      def initialize(plugin, message, gem = nil)
-        details = gem ? "#{message} - add #{gem} to your Gemfile" : message
-        super("dry-system plugin #{plugin.inspect} failed to load its dependencies: #{details}")
-      end
-    end
   end
 end

data/lib/dry/system/container.rb

@@ -112,9 +112,10 @@ module Dry
         #
         # @api public
         def configure(&block)
+          hooks[:before_configure].each { |hook| instance_eval(&hook) }
           super(&block)
           load_paths!(config.system_dir)
-          hooks[:configure].each { |hook| instance_eval(&hook) }
+          hooks[:after_configure].each { |hook| instance_eval(&hook) }
           self
         end
 
@@ -642,7 +643,11 @@ module Dry
 
         # @api private
         def after(event, &block)
-          hooks[event] << block
+          hooks[:"after_#{event}"] << block
+        end
+
+        def before(event, &block)
+          hooks[:"before_#{event}"] << block
         end
 
         # @api private

data/lib/dry/system/errors.rb

@@ -84,5 +84,36 @@ module Dry
         super("Plugin #{plugin_name.inspect} does not exist")
       end
     end
+
+    ComponentsDirMissing = Class.new(StandardError)
+    DuplicatedComponentKeyError = Class.new(ArgumentError)
+    InvalidSettingsError = Class.new(ArgumentError) do
+      # @api private
+      def initialize(attributes)
+        message = <<~STR
+          Could not initialize settings. The following settings were invalid:
+
+          #{attributes_errors(attributes).join("\n")}
+        STR
+        super(message)
+      end
+
+      private
+
+      def attributes_errors(attributes)
+        attributes.map { |key, error| "#{key.name}: #{error}" }
+      end
+    end
+
+    # Exception raise when a plugin dependency failed to load
+    #
+    # @api public
+    PluginDependencyMissing = Class.new(StandardError) do
+      # @api private
+      def initialize(plugin, message, gem = nil)
+        details = gem ? "#{message} - add #{gem} to your Gemfile" : message
+        super("dry-system plugin #{plugin.inspect} failed to load its dependencies: #{details}")
+      end
+    end
   end
 end

data/lib/dry/system/plugins.rb

@@ -94,6 +94,7 @@ module Dry
       # @api public
       def use(name, options = {})
         return self if enabled_plugins.include?(name)
+
         raise PluginNotFoundError, name unless (plugin = Plugins.registry[name])
 
         plugin.load_dependencies

data/lib/dry/system/plugins/bootsnap.rb

@@ -16,7 +16,7 @@ module Dry
         def self.extended(system)
           super
           system.use(:env)
-          system.setting :bootsnap, DEFAULT_OPTIONS
+          system.before(:configure) { setting :bootsnap, DEFAULT_OPTIONS }
           system.after(:configure, &:setup_bootsnap)
         end
 

data/lib/dry/system/plugins/dependency_graph.rb

@@ -14,7 +14,9 @@ module Dry
 
           system.use(:notifications)
 
-          system.setting :ignored_dependencies, []
+          system.before(:configure) do
+            setting :ignored_dependencies, []
+          end
 
           system.after(:configure) do
             self[:notifications].register_event(:resolved_dependency)

data/lib/dry/system/plugins/logging.rb

@@ -8,16 +8,18 @@ module Dry
       module Logging
         # @api private
         def self.extended(system)
-          system.setting :logger, reader: true
+          system.before(:configure) do
+            setting :logger, reader: true
 
-          system.setting :log_dir, 'log'
+            setting :log_dir, 'log'
 
-          system.setting :log_levels,
-            development: Logger::DEBUG,
-            test: Logger::DEBUG,
-            production: Logger::ERROR
+            setting :log_levels,
+              development: Logger::DEBUG,
+              test: Logger::DEBUG,
+              production: Logger::ERROR
 
-          system.setting :logger_class, ::Logger, reader: true
+            setting :logger_class, ::Logger, reader: true
+          end
 
           system.after(:configure, &:register_logger)
 

data/lib/dry/system/version.rb

@@ -2,6 +2,6 @@
 
 module Dry
   module System
-    VERSION = '0.14.1'
+    VERSION = '0.15.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dry-system
 version: !ruby/object:Gem::Version
-  version: 0.14.1
+  version: 0.15.0
 platform: ruby
 authors:
 - Piotr Solnica
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-22 00:00:00.000000000 Z
+date: 2020-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby