dry-system 0.12.0 → 0.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9eed405eef945e6f3b43d0efba531f65c21e032db60c229173318872b6c80ddb
-  data.tar.gz: 6ec5f37f4555a6395e040567ef1b1ec018db3773a0520c92dc8b68d049e15666
+  metadata.gz: a9e7b9270e8cf896626e675f2bf98f2e8a7521a56e6b16a64ee30d724aa307a4
+  data.tar.gz: fa1ca1a837c0f3185d04a4d420ebb7325793f1165b4dcf4427ee94f81c10c26b
 SHA512:
-  metadata.gz: 1c6b8d7a56cc1ccf3c7adb25556e3130f6adde4fb39471f0bf2b7024a6aa3b9e70fef857768a2b6a183cb47d86b7f8278c1e665a1e3ab8d60438411e83fc6370
-  data.tar.gz: 24b626c4effa07c3dcc57ce56cd7ebcae188add2acfff8e2bc6f41e4fc7714712eb7d27430f9366f4b7cd738bfbb4a16726d4024ff30703ba42af4f28dc564fc
+  metadata.gz: d774649cda42fc3eb0f4253f3db5d869947f9ac0e0189a0256926b26f97d15761efa30384991bf62b388c1b59eb370780d787c61984c654544b57ced182d8935
+  data.tar.gz: adc45c72848ec6fc31f96a17cfcd02f5034492e645cb549024c149aadc8de2096dc54b27b893c2218bf61a23db610c8b1bf85898fddab0f401ac9af9a0f14fc9

data/CHANGELOG.md

@@ -1,8 +1,23 @@
+# 0.13.0 - 2019-10-13
+
+### Changed
+
+- [BREAKING] `Container.key?` triggers lazy-loading for not finalized containers. If component wasn't found it returns `false` without raising an error. This is a breaking change, if you seek the previous behavior, use `Container.registered?` (flash-gordon)
+
+### Added
+
+- `Container.resolve` accepts and optional block parameter which will be called if component cannot be found. This makes dry-system consistent with dry-container 0.7.2 (flash-gordon)
+  ```ruby
+  App.resolve('missing.dep') { :fallback } # => :fallback
+  ```
+
+[Compare v0.12.0...v0.13.0](https://github.com/dry-rb/dry-system/compare/v0.12.0...v0.13.0)
+
 # 0.12.0 - 2019-04-24
 
 ### Changed
 
-* Compatibility with dry-struct 1.0 and dry-types 1.0 (flash-gordon)
+- Compatibility with dry-struct 1.0 and dry-types 1.0 (flash-gordon)
 
 [Compare v0.11.0...v0.12.0](https://github.com/dry-rb/dry-system/compare/v0.11.0...v0.12.0)
 
@@ -10,8 +25,8 @@
 
 ### Changed
 
-* [BREAKING] `:decorate` plugin was moved from dry-system to dry-container (available in 0.7.0+). To upgrade remove `use :decorate` and change `decorate` calls from `decorate(key, decorator: something)` to `decorate(key, with: something)` (flash-gordon)
-* [internal] Compatibility with dry-struct 0.7.0 and dry-types 0.15.0
+- [BREAKING] `:decorate` plugin was moved from dry-system to dry-container (available in 0.7.0+). To upgrade remove `use :decorate` and change `decorate` calls from `decorate(key, decorator: something)` to `decorate(key, with: something)` (flash-gordon)
+- [internal] Compatibility with dry-struct 0.7.0 and dry-types 0.15.0
 
 [Compare v0.10.1...v0.11.0](https://github.com/dry-rb/dry-system/compare/v0.10.1...v0.11.0)
 
@@ -19,18 +34,19 @@
 
 ### Added
 
-* Support for stopping bootable components with `Container.stop(component_name)` (GustavoCaso)
+- Support for stopping bootable components with `Container.stop(component_name)` (GustavoCaso)
 
 ### Fixed
 
-* When using a non-finalized container, you can now resolve multiple different container objects registered using the same root key as a bootable component (timriley)
+- When using a non-finalized container, you can now resolve multiple different container objects registered using the same root key as a bootable component (timriley)
 
 [Compare v0.10.0...v0.10.1](https://github.com/dry-rb/dry-system/compare/v0.10.0...v0.10.1)
 
 # 0.10.0 - 2018-06-07
 
 ### Added
-* You can now set a custom inflector on the container level. As a result, the `Loader`'s constructor accepts two arguments: `path` and `inflector`, update your custom loaders accordingly (flash-gordon)
+
+- You can now set a custom inflector on the container level. As a result, the `Loader`'s constructor accepts two arguments: `path` and `inflector`, update your custom loaders accordingly (flash-gordon)
 
   ```ruby
   class MyContainer < Dry::System::Container
@@ -44,10 +60,10 @@
 
 ### Changed
 
-* A helpful error will be raised if an invalid setting value is provided (GustavoCaso)
-* When using setting plugin, will use default values from types (GustavoCaso)
-* Minimal supported ruby version was bumped to `2.3` (flash-gordon)
-* `dry-struct` was updated to `~> 0.5` (flash-gordon)
+- A helpful error will be raised if an invalid setting value is provided (GustavoCaso)
+- When using setting plugin, will use default values from types (GustavoCaso)
+- Minimal supported ruby version was bumped to `2.3` (flash-gordon)
+- `dry-struct` was updated to `~> 0.5` (flash-gordon)
 
 [Compare v0.9.2...v0.10.0](https://github.com/dry-rb/dry-system/compare/v0.9.2...v0.10.0)
 
@@ -55,7 +71,7 @@
 
 ### Fixed
 
-* Default namespace no longer breaks resolving dependencies with identifier that includes part of the namespace (ie `mail.mailer`) (GustavoCaso)
+- Default namespace no longer breaks resolving dependencies with identifier that includes part of the namespace (ie `mail.mailer`) (GustavoCaso)
 
 [Compare v0.9.1...v0.9.2](https://github.com/dry-rb/dry-system/compare/v0.9.1...v0.9.2)
 
@@ -63,7 +79,7 @@
 
 ### Fixed
 
-* Plugin dependencies are now auto-required and a meaningful error is raised when a dep failed to load (solnic)
+- Plugin dependencies are now auto-required and a meaningful error is raised when a dep failed to load (solnic)
 
 [Compare v0.9.0...v0.9.1](https://github.com/dry-rb/dry-system/compare/v0.9.0...v0.9.1)
 
@@ -71,21 +87,21 @@
 
 ### Added
 
-* Plugin API (solnic)
-* `:env` plugin which adds support for setting `env` config value (solnic)
-* `:logging` plugin which adds a default logger (solnic)
-* `:decorate` plugin for decorating registered objects (solnic)
-* `:notifications` plugin adding pub/sub bus to containers (solnic)
-* `:monitoring` plugin which adds `monitor` method for monitoring object method calls (solnic)
-* `:bootsnap` plugin which adds support for bootsnap (solnic)
+- Plugin API (solnic)
+- `:env` plugin which adds support for setting `env` config value (solnic)
+- `:logging` plugin which adds a default logger (solnic)
+- `:decorate` plugin for decorating registered objects (solnic)
+- `:notifications` plugin adding pub/sub bus to containers (solnic)
+- `:monitoring` plugin which adds `monitor` method for monitoring object method calls (solnic)
+- `:bootsnap` plugin which adds support for bootsnap (solnic)
 
 ### Changed
 
-* [BREAKING] renamed `Container.{require=>require_from_root}` (GustavoCaso)
+- [BREAKING] renamed `Container.{require=>require_from_root}` (GustavoCaso)
 
 ### Internal
 
-* `#bootable?` and `#boot_file` methods were moved from `Component` to `Booter` (GustavoCaso)
+- `#bootable?` and `#boot_file` methods were moved from `Component` to `Booter` (GustavoCaso)
 
 [Compare v0.8.1...v0.9.0](https://github.com/dry-rb/dry-system/compare/v0.8.1...v0.9.0)
 
@@ -93,8 +109,8 @@
 
 ### Fixed
 
-* Aliasing an external component works correctly (solnic)
-* Manually calling `:init` will also finalize a component (solnic)
+- Aliasing an external component works correctly (solnic)
+- Manually calling `:init` will also finalize a component (solnic)
 
 [Compare v0.8.0...v0.8.1](https://github.com/dry-rb/dry-system/compare/v0.8.0...v0.8.1)
 
@@ -102,16 +118,16 @@
 
 ### Added
 
-* Support for external bootable components (solnic)
-* Built-in `:system` components including `:settings` component (solnic)
+- Support for external bootable components (solnic)
+- Built-in `:system` components including `:settings` component (solnic)
 
 ### Fixed
 
-* Lazy-loading components work when a container has `default_namespace` configured (GustavoCaso)
+- Lazy-loading components work when a container has `default_namespace` configured (GustavoCaso)
 
 ### Changed
 
-* [BREAKING] Improved boot DSL with support for namespacing and lifecycle before/after callbacks (solnic)
+- [BREAKING] Improved boot DSL with support for namespacing and lifecycle before/after callbacks (solnic)
 
 [Compare v0.7.3...v0.8.0](https://github.com/dry-rb/dry-system/compare/v0.7.3...v0.8.0)
 
@@ -119,20 +135,20 @@
 
 ### Fixed
 
-* `Container.enable_stubs!` calls super too, which actually adds `stub` API (solnic)
-* Issues with lazy-loading and import in stub mode are gone (solnic)
+- `Container.enable_stubs!` calls super too, which actually adds `stub` API (solnic)
+- Issues with lazy-loading and import in stub mode are gone (solnic)
 
 # 0.7.2 - 2017-08-02
 
 ### Added
 
-* `Container.enable_stubs!` for test environments which enables stubbing components (GustavoCaso)
+- `Container.enable_stubs!` for test environments which enables stubbing components (GustavoCaso)
 
 ### Changed
 
-* Component identifiers can now include same name more than once ie `foo.stuff.foo` (GustavoCaso)
-* `Container#boot!` was renamed to `Container#start` (davydovanton)
-* `Container#boot` was renamed to `Container#init` (davydovanton)
+- Component identifiers can now include same name more than once ie `foo.stuff.foo` (GustavoCaso)
+- `Container#boot!` was renamed to `Container#start` (davydovanton)
+- `Container#boot` was renamed to `Container#init` (davydovanton)
 
 [Compare v0.7.1...v0.7.2](https://github.com/dry-rb/dry-system/compare/v0.7.1...v0.7.2)
 
@@ -150,20 +166,20 @@
 - AutoRegistrar parses initial lines of Ruby source files for "magic comments" when auto-registering components. An `# auto_register: false` magic comment will prevent a Ruby file from being auto-registered (timriley)
 - `Container.auto_register!`, when called with a block, yields a configuration object to control the auto-registration behavior for that path, with support for configuring 2 different aspects of auto-registration behavior (both optional):
 
-    ```ruby
-    class MyContainer < Dry::System::Container
-      auto_register!('lib') do |config|
-        config.instance do |component|
-          # custom logic for initializing a component
-        end
-
-        config.exclude do |component|
-          # return true to skip auto-registration of the component, e.g.
-          # component.path =~ /entities/
-        end
+  ```ruby
+  class MyContainer < Dry::System::Container
+    auto_register!('lib') do |config|
+      config.instance do |component|
+        # custom logic for initializing a component
+      end
+
+      config.exclude do |component|
+        # return true to skip auto-registration of the component, e.g.
+        # component.path =~ /entities/
       end
     end
-    ```
+  end
+  ```
 
 - A helpful error will be raised if a bootable component's finalize block name doesn't match its boot file name (GustavoCaso)
 
@@ -175,13 +191,12 @@
 
 [Compare v0.6.0...v0.7.0](https://github.com/dry-rb/dry-system/compare/v0.6.0...v0.7.0)
 
-
 # 0.6.0 - 2016-02-02
 
 ### Changed
 
-* Lazy load components as they are resolved, rather than on injection (timriley)
-* Perform registration even though component already required (blelump)
+- Lazy load components as they are resolved, rather than on injection (timriley)
+- Perform registration even though component already required (blelump)
 
 [Compare v0.5.1...v0.6.0](https://github.com/dry-rb/dry-system/compare/v0.5.1...v0.6.0)
 
@@ -201,8 +216,8 @@ for multi-container setups. As part of this release `dry-system` has been rename
 ### Added
 
 - Boot DSL with:
-  * Lifecycle triggers: `init`, `start` and `stop` (solnic)
-  * `use` method which auto-boots a dependency and makes it available in the booting context (solnic)
+  - Lifecycle triggers: `init`, `start` and `stop` (solnic)
+  - `use` method which auto-boots a dependency and makes it available in the booting context (solnic)
 - When a component relies on a bootable component, and is being loaded in isolation, the component will be booted automatically (solnic)
 
 ### Changed
@@ -251,27 +266,27 @@ for multi-container setups. As part of this release `dry-system` has been rename
 
 - Support for supplying a default namespace to a container, which is passed to the container's injector to allow for convenient shorthand access to registered objects in the same namespace (timriley in [#20](https://github.com/dry-rb/dry-system/pull/20))
 
-    ```ruby
-    # Set up container with default namespace
-    module Admin
-      class Container < Dry::Component::Container
-        configure do |config|
-          config.root = Pathname.new(__dir__).join("../..")
-          config.default_namespace = "admin"
-        end
+  ```ruby
+  # Set up container with default namespace
+  module Admin
+    class Container < Dry::Component::Container
+      configure do |config|
+        config.root = Pathname.new(__dir__).join("../..")
+        config.default_namespace = "admin"
       end
-
-      Import = Container.injector
     end
 
-    module Admin
-      class CreateUser
-        # "users.repository" will resolve an Admin::Users::Repository instance,
-        # where previously you had to identify it as "admin.users.repository"
-        include Admin::Import["users.repository"]
-      end
+    Import = Container.injector
+  end
+
+  module Admin
+    class CreateUser
+      # "users.repository" will resolve an Admin::Users::Repository instance,
+      # where previously you had to identify it as "admin.users.repository"
+      include Admin::Import["users.repository"]
     end
-    ```
+  end
+  ```
 
 - Support for supplying to options directly to dry-auto_inject's `Builder` via `Dry::Component::Container#injector(options)`. This allows you to provide dry-auto_inject customizations like your own container of injection strategies (timriley in [#20](https://github.com/dry-rb/dry-system/pull/20))
 - Support for accessing all available injector strategies, not just the defaults (e.g. `MyContainer.injector.some_custom_strategy`) (timriley in [#19](https://github.com/dry-rb/dry-system/pull/19))
@@ -311,27 +326,27 @@ Removed two pieces that are moving to dry-web:
 
 ### Added
 
-* Provide a dependency injector as an `Inject` constant inside any subclass of `Dry::Component::Container`. This injector supports all of `dry-auto_inject`'s default injection strategies, and will lazily load any dependencies as they are injected. It also supports arbitrarily switching strategies, so they can be used in different classes as required (e.g. `include MyComponent::Inject.args["dep"]`) (timriley)
-* Support aliased dependency names when calling the injector object (e.g. `MyComponent::Inject[foo: "my_app.foo", bar: "another.thing"]`) (timriley)
-* Allow a custom dependency loader to be set on a container via its config (AMHOL)
+- Provide a dependency injector as an `Inject` constant inside any subclass of `Dry::Component::Container`. This injector supports all of `dry-auto_inject`'s default injection strategies, and will lazily load any dependencies as they are injected. It also supports arbitrarily switching strategies, so they can be used in different classes as required (e.g. `include MyComponent::Inject.args["dep"]`) (timriley)
+- Support aliased dependency names when calling the injector object (e.g. `MyComponent::Inject[foo: "my_app.foo", bar: "another.thing"]`) (timriley)
+- Allow a custom dependency loader to be set on a container via its config (AMHOL)
 
-    ```ruby
-    class MyContainer < Dry::Component::Container
-      configure do |config|
-        # other config
-        config.loader = MyLoader
-      end
+  ```ruby
+  class MyContainer < Dry::Component::Container
+    configure do |config|
+      # other config
+      config.loader = MyLoader
     end
-    ```
+  end
+  ```
 
 ### Changed
 
-* `Container.boot` now only makes a simple `require` for the boot file (solnic)
-* Container object is passed to `Container.finalize` blocks (solnic)
-* Allow `Pathname` objects passed to `Container.require` (solnic)
-* Support lazily loading missing dependencies from imported containers (solnic)
-* `Container.import_module` renamed to `.injector` (timriley)
-* Default injection strategy is now `kwargs`, courtesy of the new dry-auto_inject default (timriley)
+- `Container.boot` now only makes a simple `require` for the boot file (solnic)
+- Container object is passed to `Container.finalize` blocks (solnic)
+- Allow `Pathname` objects passed to `Container.require` (solnic)
+- Support lazily loading missing dependencies from imported containers (solnic)
+- `Container.import_module` renamed to `.injector` (timriley)
+- Default injection strategy is now `kwargs`, courtesy of the new dry-auto_inject default (timriley)
 
 [Compare v0.0.2...v0.1.0](https://github.com/dry-rb/dry-system/compare/v0.0.2...v0.1.0)
 
@@ -339,12 +354,12 @@ Removed two pieces that are moving to dry-web:
 
 ### Added
 
-* Containers have a `name` setting (solnic)
-* Containers can be imported into one another (solnic)
+- Containers have a `name` setting (solnic)
+- Containers can be imported into one another (solnic)
 
 ### Changed
 
-* Container name is used to determine the name of its config file (solnic)
+- Container name is used to determine the name of its config file (solnic)
 
 [Compare v0.0.1...v0.0.2](https://github.com/dry-rb/dry-system/compare/v0.0.1...v0.0.2)
 

data/README.md

@@ -1,5 +1,5 @@
 [gem]: https://rubygems.org/gems/dry-system
-[travis]: https://travis-ci.org/dry-rb/dry-system
+[travis]: https://travis-ci.com/dry-rb/dry-system
 [codeclimate]: https://codeclimate.com/github/dry-rb/dry-system
 [inchpages]: http://inch-ci.org/github/dry-rb/dry-system
 [chat]: https://dry-rb.zulipchat.com
@@ -8,7 +8,7 @@
 
 
 [![Gem Version](https://badge.fury.io/rb/dry-system.svg)][gem]
-[![Build Status](https://travis-ci.org/dry-rb/dry-system.svg?branch=master)][travis]
+[![Build Status](https://travis-ci.com/dry-rb/dry-system.svg?branch=master)][travis]
 [![Code Climate](https://codeclimate.com/github/dry-rb/dry-system/badges/gpa.svg)][codeclimate]
 [![Test Coverage](https://codeclimate.com/github/dry-rb/dry-system/badges/coverage.svg)][codeclimate]
 [![Inline docs](http://inch-ci.org/github/dry-rb/dry-system.svg?branch=master)][inchpages]

data/lib/dry-system.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'dry/system'

data/lib/dry/system.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'dry/system/provider'
 require 'dry/system/provider_registry'
 
@@ -22,7 +24,7 @@ module Dry
 
     # @api private
     def self.providers
-      @__providers__ ||= ProviderRegistry.new
+      @providers ||= ProviderRegistry.new
     end
   end
 end

data/lib/dry/system/auto_registrar.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'dry/system/constants'
 require 'dry/system/magic_comments_parser'
 require 'dry/system/auto_registrar/configuration'
@@ -35,7 +37,9 @@ module Dry
           next if !component.auto_register? || registration_config.exclude.(component)
 
           container.require_component(component) do
-            register(component.identifier, memoize: registration_config.memoize) { registration_config.instance.(component) }
+            register(component.identifier, memoize: registration_config.memoize) {
+              registration_config.instance.(component)
+            }
           end
         end
       end
@@ -44,15 +48,15 @@ module Dry
 
       # @api private
       def components(dir)
-        files(dir).
-          map { |file_name| [file_name, file_options(file_name)] }.
-          map { |(file_name, options)| component(relative_path(dir, file_name), **options) }.
-          reject { |component| key?(component.identifier) }
+        files(dir)
+          .map { |file_name| [file_name, file_options(file_name)] }
+          .map { |(file_name, options)| component(relative_path(dir, file_name), **options) }
+          .reject { |component| registered?(component.identifier) }
       end
 
       # @api private
       def files(dir)
-        Dir["#{root}/#{dir}/**/#{RB_GLOB}"]
+        ::Dir["#{root}/#{dir}/**/#{RB_GLOB}"].sort
       end
 
       # @api private
@@ -77,8 +81,8 @@ module Dry
       end
 
       # @api private
-      def key?(name)
-        container.key?(name)
+      def registered?(name)
+        container.registered?(name)
       end
 
       # @api private

data/lib/dry/system/auto_registrar/configuration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dry
   module System
     class AutoRegistrar

data/lib/dry/system/booter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'dry/system/components/bootable'
 require 'dry/system/errors'
 require 'dry/system/constants'
@@ -49,9 +51,7 @@ module Dry
       def load_component(path)
         identifier = Pathname(path).basename(RB_EXT).to_s.to_sym
 
-        unless components.exists?(identifier)
-          require path
-        end
+        require path unless components.exists?(identifier)
 
         self
       end
@@ -108,7 +108,7 @@ module Dry
       # @api private
       def stop(name_or_component)
         call(name_or_component) do |component|
-          raise ComponentNotStartedError.new(name_or_component) unless booted.include?(component)
+          raise ComponentNotStartedError, name_or_component unless booted.include?(component)
 
           component.stop
           booted.delete(component)
@@ -120,9 +120,7 @@ module Dry
       # @api private
       def call(name_or_component)
         with_component(name_or_component) do |component|
-          unless component
-            raise ComponentFileMismatchError.new(name, registered_booted_keys)
-          end
+          raise ComponentFileMismatchError.new(name, registered_booted_keys) unless component
 
           yield(component) if block_given?
 
@@ -153,13 +151,16 @@ module Dry
 
       # @api private
       def require_boot_file(identifier)
-        boot_file = boot_files.detect { |path| Pathname(path).basename(RB_EXT).to_s == identifier.to_s }
+        boot_file = boot_files.detect { |path|
+          Pathname(path).basename(RB_EXT).to_s == identifier.to_s
+        }
+
         require boot_file if boot_file
       end
 
       # @api private
       def boot_files
-        Dir["#{path}/**/#{RB_GLOB}"]
+        ::Dir["#{path}/**/#{RB_GLOB}"].sort
       end
 
       # @api private