dry-initializer 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d65124ac530b85023e9152387677a694f2cab063b484ba48133ed8006fc79c2a
-  data.tar.gz: e35526cc7df9ad5271485742f75991e397c06c04af8029003ebdd567974f763c
+  metadata.gz: e17a987f9500b55fd7bf3c60caa5e8ce5c4c26cb78b94f339b62a63bdeb5a9e3
+  data.tar.gz: 362138efc7974312bf747f060c7af4d4117e6b8c7648849998c1aefb39d14b1e
 SHA512:
-  metadata.gz: ad262ac79a0191fdaee557a4d1f1b48fbb3c3dc57af0cd639077277dffe52fcecb979db69af0b5f00c803006ceab893d7a057ae085006fc343ef742e2b6f0a2a
-  data.tar.gz: 7b79bd6d05a8a9a7bb239b35cd12629dbd8eda35721916d06b7d04dac7639d361f04958e3a3ace67f5267163c27ae983ad4cb63bbf003efc96cdcf25d9028099
+  metadata.gz: fc4416e43fce6418f4708f5d7fc6753096009e9f2087f334bc11a2edeb44b3f9099d6d53ad9969d7e38ffefa524031c0e95fd4c7cb277ff7fed1a9ff63ebad5b
+  data.tar.gz: a2745ea32279c9e6bd9a964b0cef5e876bf3f02afd604b4193e6223d629fc1ca6ee8fd22cf1543d652b9ff5548b3bb9a7fc28c7a06f4eeb04cf233b4ccf451de

data/CHANGELOG.md

@@ -5,6 +5,40 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [3.0.1] [2019-04-15]
+
+### Fixed
+
+- Usage of underscored names of `option`-s and `param`-s (nepalez)
+
+  You can use any sequence of underscores except for in nested types.
+  In nested types single underscores can be used to split alphanumeric
+  parts only.
+
+  ```ruby
+  class Test
+    extend Dry::Initializer
+
+    # Proper usage
+    option :foo_bar do
+      option :__foo__, proc(&:to_s)
+    end
+  end
+
+    # Improper usage
+    option :__foo__ do
+      # ...
+    end
+
+    option :foo__bar do
+      # ...
+    end
+  end
+  ```
+
+  This restriction is necessary because we constantize option/param names
+  when defining nested structs.
+
 ## [3.0.0] [2019-04-14]
 
 ### Added
@@ -846,3 +880,4 @@ First public release
 [2.6.0]: https://github.com/dry-rb/dry-initializer/compare/v2.4.0...v2.5.0
 [2.6.0]: https://github.com/dry-rb/dry-initializer/compare/v2.5.0...v2.6.0
 [3.0.0]: https://github.com/dry-rb/dry-initializer/compare/v2.5.0...v3.0.0
+[3.0.1]: https://github.com/dry-rb/dry-initializer/compare/v3.0.0...v3.0.1

data/dry-initializer.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name     = "dry-initializer"
-  gem.version  = "3.0.0"
+  gem.version  = "3.0.1"
   gem.author   = ["Vladimir Kochnev (marshall-lee)", "Andrew Kozin (nepalez)"]
   gem.email    = "andrew.kozin@gmail.com"
   gem.homepage = "https://github.com/dry-rb/dry-initializer"

data/lib/dry/initializer/dispatchers/build_nested_type.rb

@@ -13,7 +13,7 @@ module Dry::Initializer::Dispatchers::BuildNestedType
   # rubocop: disable Metrics/ParameterLists
   def call(parent:, source:, target:, type: nil, block: nil, **options)
     check_certainty!(source, type, block)
-    check_name!(target)
+    check_name!(target, block)
     type ||= build_nested_type(parent, target, block)
     { parent: parent, source: source, target: target, type: type, **options }
   end
@@ -22,8 +22,8 @@ module Dry::Initializer::Dispatchers::BuildNestedType
   private
 
   def check_certainty!(source, type, block)
-    return unless type
     return unless block
+    return unless type
 
     raise ArgumentError, <<~MESSAGE
       You should define coercer of values of argument '#{source}'
@@ -31,7 +31,8 @@ module Dry::Initializer::Dispatchers::BuildNestedType
     MESSAGE
   end
 
-  def check_name!(name)
+  def check_name!(name, block)
+    return unless block
     return unless name[/^_|__|_$/]
 
     raise ArgumentError, <<~MESSAGE

data/spec/type_constraint_spec.rb

@@ -5,14 +5,14 @@ describe "type constraint" do
     before do
       class Test::Foo
         extend Dry::Initializer
-        param :foo, proc(&:to_s), optional: true
+        param :__foo__, proc(&:to_s), optional: true
       end
     end
 
     subject { Test::Foo.new :foo }
 
     it "coerces a value" do
-      expect(subject.foo).to eq "foo"
+      expect(subject.__foo__).to eq "foo"
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dry-initializer
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - Vladimir Kochnev (marshall-lee)
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-14 00:00:00.000000000 Z
+date: 2019-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec