dry-initializer 0.9.2 → 0.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 18ddd83e225177df21ed6dda7229643f2a746b3e
-  data.tar.gz: 58e21460831b91ce91438c6ba869c130f7b13f9b
+  metadata.gz: 92409ca11ac8b4f856593691a82b0fbeae8c48bf
+  data.tar.gz: f8176cbbfb30b21c3084ad5108791ff2062e094b
 SHA512:
-  metadata.gz: 15e1f2a75cf3229433588554d3c148f24d7109196602591f3b1a834b915c247e05c5564d1b306ab188d6d3c3a5e00c8de5fabb803485d2f7c44d8d7b1b4e4062
-  data.tar.gz: bcbfec542d6db6dd57aa16a1f5dd01583a711307fb7ed9eeec267e30881c721640944a3969646936b3a5bfa03836746438828d58bf3b6cff21212d75857832e9
+  metadata.gz: c8c311f7daac997e3b08f86da46b31e40c9cd87a8ec0e9de14ff4d47679be2956cd009a11396aedd03f26e0455d9df149f2eb97582c90829459e517af9c8a21b
+  data.tar.gz: af5e325331c0dc37d4e160f90ffa59b608c21660bf919fa30f216c918203be548c165c909d1a28e9fcbcfeac6d30a38bc53bdd0623614976972921c5837aa3c5

data/CHANGELOG.md

@@ -1,3 +1,21 @@
+## v0.9.3 2016-11-10
+
+### Deprecated
+
+* After discussion in [PR #17](https://github.com/dry-rb/dry-initializer/pull/17)
+  (many thanks to @sahal2080 and @hrom512 for starting that issue and PR),
+  the method `using` is deprecated and will be removed from v0.10.0 (@nepalez)
+
+### Fixed
+
+* Support of weird option names (@nepalez)
+
+  ```ruby
+  option :"First name", as: :first_name
+  ```
+
+[Compare v0.9.2...v0.9.3](https://github.com/dry-rb/dry-initializer/compare/v0.9.2...v0.9.3)
+
 ## v0.9.2 2016-11-10
 
 ### Fixed

data/dry-initializer.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name     = "dry-initializer"
-  gem.version  = "0.9.2"
+  gem.version  = "0.9.3"
   gem.author   = ["Vladimir Kochnev (marshall-lee)", "Andrew Kozin (nepalez)"]
   gem.email    = ["hashtable@yandex.ru", "andrew.kozin@gmail.com"]
   gem.homepage = "https://github.com/dryrb/dry-initializer"

data/lib/dry/initializer/mixin.rb

@@ -40,6 +40,7 @@ module Dry::Initializer
     # @return [self]
     #
     def using(**settings, &block)
+      warn "[DEPRECATION] The method `using` will be removed in v0.10.0"
       Scope.new(self, settings).instance_eval(&block)
       self
     end

data/lib/dry/initializer/plugins/base.rb

@@ -42,7 +42,7 @@ module Dry::Initializer::Plugins
     # Returns the name for the attribute
     # @return (see .name)
     def rename
-      @rename ||= settings[:option] ? settings[:as] || name : name
+      @rename ||= settings[:option] ? (settings[:as] || name) : name
     end
   end
 end

data/lib/dry/initializer/plugins/variable_setter.rb

@@ -22,8 +22,9 @@ module Dry::Initializer::Plugins
 
     def call
       return "@#{name} = #{name}" if param?
-      return "@#{rename} = __options__.fetch(:#{name})" if required?
-      "@#{rename} = __options__.fetch(:#{name}, Dry::Initializer::UNDEFINED)"
+      key = ":\"#{name}\""
+      return "@#{rename} = __options__.fetch(#{key})" if required?
+      "@#{rename} = __options__.fetch(#{key}, Dry::Initializer::UNDEFINED)"
     end
   end
 end

data/spec/renaming_options_spec.rb

@@ -3,11 +3,11 @@ describe "renaming options" do
     class Test::Foo
       extend Dry::Initializer::Mixin
 
-      option :foo, as: :bar
+      option :"some foo", as: :bar
     end
   end
 
-  subject { Test::Foo.new foo: :BAZ }
+  subject { Test::Foo.new "some foo": :BAZ }
 
   it "renames the attribute" do
     expect(subject.bar).to eq :BAZ
@@ -16,6 +16,5 @@ describe "renaming options" do
 
   it "renames the variable" do
     expect(subject.instance_variable_get(:@bar)).to eq :BAZ
-    expect(subject.instance_variable_get(:@foo)).to be_nil
   end
 end

data/spec/shared_definitions_spec.rb

@@ -3,8 +3,12 @@ describe "shared definition" do
     class Test::Foo
       extend Dry::Initializer::Mixin
 
+      class << self
+        alias_method :attribute, :param
+      end
+
       using default: proc { nil } do
-        param  :foo
+        attribute :foo
         option :end
         option :baz, default: proc { 0 }
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dry-initializer
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.9.3
 platform: ruby
 authors:
 - Vladimir Kochnev (marshall-lee)
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-10 00:00:00.000000000 Z
+date: 2016-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -182,3 +182,4 @@ test_files:
 - spec/type_argument_spec.rb
 - spec/type_constraint_spec.rb
 - spec/value_coercion_via_dry_types_spec.rb
+has_rdoc: