dry-initializer 0.9.1 → 0.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5f1a12226f496582e5c8b178ce72abca1df2fc4c
-  data.tar.gz: 9ce23487b5fb5b34b71d5055f3ed76cdab34fc98
+  metadata.gz: 18ddd83e225177df21ed6dda7229643f2a746b3e
+  data.tar.gz: 58e21460831b91ce91438c6ba869c130f7b13f9b
 SHA512:
-  metadata.gz: 00db904ff87579dfd61ff759f42692f3049647fd20d1ced500f38bb3fca46968e30adf73c274c1ecd825e1c1da0ec017d3e9c06a96e211371c360cb9bf1a6598
-  data.tar.gz: 562a60f879ea4e0d60baa4d6ec328b7d8ab51c5f1e061aa9250d3d5f1fcbc7b6e60c5158d0d417dbf60bcabab5426bc090e876ffe26e93a99bee727347c5165b
+  metadata.gz: 15e1f2a75cf3229433588554d3c148f24d7109196602591f3b1a834b915c247e05c5564d1b306ab188d6d3c3a5e00c8de5fabb803485d2f7c44d8d7b1b4e4062
+  data.tar.gz: bcbfec542d6db6dd57aa16a1f5dd01583a711307fb7ed9eeec267e30881c721640944a3969646936b3a5bfa03836746438828d58bf3b6cff21212d75857832e9

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## v0.9.2 2016-11-10
+
+### Fixed
+
+* Validation of attributes (params and options) (@nepalez)
+
+[Compare v0.9.1...v0.9.2](https://github.com/dry-rb/dry-initializer/compare/v0.9.1...v0.9.2)
+
 ## v0.9.1 2016-11-06
 
 ### Added
@@ -6,7 +14,7 @@
 
   option :name, as: :username # to take :name option and create :username attribute
 
-[Compare 0.9.0...v0.9.1](https://github.com/dry-rb/dry-initializer/compare/0.9.0...v0.9.1)
+[Compare v0.9.0...v0.9.1](https://github.com/dry-rb/dry-initializer/compare/v0.9.0...v0.9.1)
 
 ## v0.9.0 2016-11-06
 
@@ -28,7 +36,7 @@
 
 * Refactor scope (`using`) to support methods renaming and aliasing (@nepalez)
 
-[Compare 0.8.1...v0.9.0](https://github.com/dry-rb/dry-initializer/compare/0.8.1...v0.9.0)
+[Compare v0.8.1...v0.9.0](https://github.com/dry-rb/dry-initializer/compare/v0.8.1...v0.9.0)
 
 ## v0.8.1 2016-11-05
 
@@ -38,7 +46,7 @@
 
     option :name, Dry::Types['strict.string']
 
-[Compare v0.8.0...0.8.1](https://github.com/dry-rb/dry-initializer/compare/v0.8.0..0.8.1)
+[Compare v0.8.0...v0.8.1](https://github.com/dry-rb/dry-initializer/compare/v0.8.0...v0.8.1)
 
 ## v0.8.0 2016-11-05
 
@@ -88,7 +96,7 @@ are deprecated and will be removed in the next version of the gem.
 * `tolerant_to_unknown_options`
 * `intolerant_to_unknown_options`
 
-[Compare v0.7.0...v0.8.0](https://github.com/dry-rb/dry-initializer/compare/v0.7.0..v0.8.0)
+[Compare v0.7.0...v0.8.0](https://github.com/dry-rb/dry-initializer/compare/v0.7.0...v0.8.0)
 
 ## v0.7.0 2016-10-11
 
@@ -96,7 +104,7 @@ are deprecated and will be removed in the next version of the gem.
 
 * Shared settings with `#using` method (@nepalez)
 
-[Compare v0.6.0...v0.7.0](https://github.com/dry-rb/dry-initializer/compare/v0.6.0..v0.7.0)
+[Compare v0.6.0...v0.7.0](https://github.com/dry-rb/dry-initializer/compare/v0.6.0...v0.7.0)
 
 ## v0.6.0 2016-10-09
 
@@ -104,7 +112,7 @@ are deprecated and will be removed in the next version of the gem.
 
 * Support for private and protected readers in the `reader:` option (@jmgarnier)
 
-[Compare v0.5.0...v0.6.0](https://github.com/dry-rb/dry-initializer/compare/v0.5.0..v0.6.0)
+[Compare v0.5.0...v0.6.0](https://github.com/dry-rb/dry-initializer/compare/v0.5.0...v0.6.0)
 
 ## v0.5.0 2016-08-21
 
@@ -112,7 +120,7 @@ are deprecated and will be removed in the next version of the gem.
 
 * Allow `optional` attribute to be left undefined (@nepalez)
 
-[Compare v0.4.0...v0.5.0](https://github.com/dry-rb/dry-initializer/compare/v0.4.0..v0.5.0)
+[Compare v0.4.0...v0.5.0](https://github.com/dry-rb/dry-initializer/compare/v0.4.0...v0.5.0)
 
 ## v0.4.0 2016-05-28
 
@@ -120,13 +128,13 @@ are deprecated and will be removed in the next version of the gem.
 
 * Support of modules and case equality as type constraints (@nepalez)
 
-[Compare v0.3.3...v0.4.0](https://github.com/dry-rb/dry-initializer/compare/v0.3.3..v0.4.0)
+[Compare v0.3.3...v0.4.0](https://github.com/dry-rb/dry-initializer/compare/v0.3.3...v0.4.0)
 
 ## v0.3.3 2016-05-28
 
 * Add deprecation warnings about modules and case equality as type constraints (@nepalez)
 
-[Compare v0.3.2...v0.3.3](https://github.com/dry-rb/dry-initializer/compare/v0.3.2..v0.3.3)
+[Compare v0.3.2...v0.3.3](https://github.com/dry-rb/dry-initializer/compare/v0.3.2...v0.3.3)
 
 ## v0.3.2 2016-05-25
 
@@ -134,7 +142,7 @@ are deprecated and will be removed in the next version of the gem.
 
 * Add explicit requirement for ruby 'set' (@rickenharp)
 
-[Compare v0.3.1...v0.3.2](https://github.com/dry-rb/dry-initializer/compare/v0.3.1..v0.3.2)
+[Compare v0.3.1...v0.3.2](https://github.com/dry-rb/dry-initializer/compare/v0.3.1...v0.3.2)
 
 ## v0.3.1 2016-05-22
 
@@ -142,7 +150,7 @@ are deprecated and will be removed in the next version of the gem.
 
 * Support for tolerance to unknown options (@nepalez)
 
-[Compare v0.3.0...v0.3.1](https://github.com/dry-rb/dry-initializer/compare/v0.3.0..v0.3.1)
+[Compare v0.3.0...v0.3.1](https://github.com/dry-rb/dry-initializer/compare/v0.3.0...v0.3.1)
 
 ## v0.3.0 2016-05-19
 
@@ -174,7 +182,7 @@ its method #register doesn't mutate the builder instance.
 
 * Prevent plugin's registry from polluting superclass (@nepalez)
 
-[Compare v0.2.1...v0.3.0](https://github.com/dry-rb/dry-initializer/compare/v0.2.1..v0.3.0)
+[Compare v0.2.1...v0.3.0](https://github.com/dry-rb/dry-initializer/compare/v0.2.1...v0.3.0)
 
 ### Internals
 
@@ -243,7 +251,7 @@ Default assignments became slower (while plain type constraint are not)!
 
   ```ruby
   option :name, type: /foo/
-  option :name, type: (1..14)
+  option :name, type: (1...14)
   ```
 
 * Support defaults and type constraints for the "container" syntax (@nepalez)
@@ -267,7 +275,7 @@ Default assignments became slower (while plain type constraint are not)!
 
 ### Added
 
-* `include Dry::Initializer.define -> do .. end` syntax (@flash-gordon)
+* `include Dry::Initializer.define -> do ... end` syntax (@flash-gordon)
 
 [Compare v0.1.0...v0.1.1](https://github.com/dry-rb/dry-initializer/compare/v0.1.0...v0.1.1)
 

data/dry-initializer.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name     = "dry-initializer"
-  gem.version  = "0.9.1"
+  gem.version  = "0.9.2"
   gem.author   = ["Vladimir Kochnev (marshall-lee)", "Andrew Kozin (nepalez)"]
   gem.email    = ["hashtable@yandex.ru", "andrew.kozin@gmail.com"]
   gem.homepage = "https://github.com/dryrb/dry-initializer"

data/lib/dry/initializer/signature.rb

@@ -12,8 +12,10 @@ module Dry::Initializer
     def add(*args)
       signature = Plugins::Signature.new(*args)
 
-      validates_uniqueness_of signature
-      validates_order_of signature
+      validate_order_of signature
+      validate_param_uniqueness_of signature
+      validate_option_uniqueness_of signature
+      validate_attribute_uniqueness_of signature
 
       self.class.new(*@list, signature)
     end
@@ -28,13 +30,27 @@ module Dry::Initializer
 
     private
 
-    def validates_uniqueness_of(signature)
-      return unless include? signature
+    def validate_param_uniqueness_of(signature)
+      return unless signature.param?
+      return unless select(&:param?).map(&:name).include? signature.name
 
       fail RedefinitionError.new(signature.name)
     end
 
-    def validates_order_of(signature)
+    def validate_option_uniqueness_of(signature)
+      return if signature.param?
+      return unless reject(&:param?).map(&:name).include? signature.name
+
+      fail RedefinitionError.new(signature.name)
+    end
+
+    def validate_attribute_uniqueness_of(signature)
+      return unless map(&:rename).include? signature.rename
+
+      fail RedefinitionError.new(signature.name)
+    end
+
+    def validate_order_of(signature)
       return unless signature.required? && signature.param?
       return unless reject(&:required?).any?(&:param?)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dry-initializer
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.9.2
 platform: ruby
 authors:
 - Vladimir Kochnev (marshall-lee)
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-06 00:00:00.000000000 Z
+date: 2016-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec