dry-initializer 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 741920ad4c93079821b5dd2f4031fadaf6e4c3b7
-  data.tar.gz: b64f94cc5b3295a3a9decc367fd00fd46bd0ee36
+  metadata.gz: 70ccaaebd426057c1b1b16f3496d7c8176fc64d1
+  data.tar.gz: a7506caaa5c5c2e7b84046897fa77a5793b870af
 SHA512:
-  metadata.gz: 1716c91a5cebe7bd125542c3a3004fed51fef824d865351609332b18f234a1adbe99420e91045d5f5144dbf44d69bde670a84d578bd433137611af7c4daea12a
-  data.tar.gz: 71b93072383a3ec4ad127057a4db3f99b0f1b21b6d50d0d8dda5776e21b43943de82c15f8a3e94668152339112fda1952e08fc1bd905439dd08d409012232737
+  metadata.gz: d9eced89d306d84bd02fcd30f0ba87d9de23ec0743ab0e3e1965f230b2de50a284fb7fbb4e7151a4394f7547b1c6f438a2c92d5568f4d8c82fd204a86dcfef9f
+  data.tar.gz: 744fadbba1b5a6e6caa64a90f50a786baf36f0e0b74fd314d12b48469fcd221d470e3d4ddc58200ac5cbacac5ef78e59ab0f18942156821ac7e968e57240a4cd

data/.rubocop.yml

@@ -28,6 +28,10 @@ Style/Alias:
 Style/AsciiComments:
   Enabled: false
 
+Style/BlockDelimiters:
+  Exclude:
+    - spec/**/*_spec.rb
+
 Style/CaseEquality:
   Enabled: false
 

data/.travis.yml

@@ -1,15 +1,18 @@
 ---
+sudo:     false
 language: ruby
-before_install: gem install bundler -v 1.11.2
 cache:    bundler
-script:   bundle  exec rspec
+script:
+  - bundle exec rspec
+  - bundle exec rubocop
 rvm:
   - '2.2'
   - '2.3.0'
-  - rbx-2
+  # - rbx-2
   - ruby-head
-  - jruby-9
+  - jruby-9.1.0.0
   - jruby-head
+before_install: gem install bundler -v 1.12.5
 matrix:
   allow_failures:
     - rvm: ruby-head

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## v0.6.0 2016-10-09
+
+### Added
+
+* Support for private and protected readers in the `reader:` option (@jmgarnier)
+
+[Compare v0.5.0...v0.6.0](https://github.com/dry-rb/dry-initializer/compare/v0.5.0..v0.6.0)
+
 ## v0.5.0 2016-08-21
 
 ### Added

data/dry-initializer.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name     = "dry-initializer"
-  gem.version  = "0.5.0"
+  gem.version  = "0.6.0"
   gem.author   = ["Vladimir Kochnev (marshall-lee)", "Andrew Kozin (nepalez)"]
   gem.email    = ["hashtable@yandex.ru", "andrew.kozin@gmail.com"]
   gem.homepage = "https://github.com/dryrb/dry-initializer"
@@ -16,4 +16,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "rspec", "~> 3.0"
   gem.add_development_dependency "rake", "~> 10.0"
   gem.add_development_dependency "dry-types", "~> 0.5", "> 0.5.1"
+  gem.add_development_dependency "rubocop", "~> 0.42"
 end

data/lib/dry/initializer/builder.rb

@@ -76,10 +76,19 @@ module Dry::Initializer
     end
 
     def define_readers(mixin)
-      readers = @signature.select { |item| item.settings[:reader] != false }
-                          .map(&:name)
+      define_reader(
+        mixin,
+        :attr_reader,
+        ->(item) { item.settings[:reader] != false }
+      )
+      define_reader mixin, :private
+      define_reader mixin, :protected
+    end
 
-      mixin.send :attr_reader, *readers if readers.any?
+    def define_reader(mixin, method, filter_lambda = nil)
+      filter_lambda ||= ->(item) { item.settings[:reader] == method }
+      readers = @signature.select(&filter_lambda).map(&:name)
+      mixin.send method, *readers if readers.any?
     end
 
     def reload_initializer(mixin)

data/spec/dry/reader_spec.rb

@@ -1,22 +1,87 @@
 describe "reader" do
-  subject do
-    class Test::Foo
-      extend Dry::Initializer::Mixin
+  shared_examples "it has no public attr_reader" do
+    it "does not define a public attr_reader" do
+      expect(subject).not_to respond_to :foo
+      expect(subject).not_to respond_to :bar
+    end
+  end
+
+  context "with reader: :public or no reader: option" do
+    subject do
+      class Test::Foo
+        extend Dry::Initializer::Mixin
+
+        param  :foo
+        param  :foo2, reader: :public
+        option :bar
+        option :bar2, reader: :public
+      end
+
+      Test::Foo.new 1, 2, bar: 3, bar2: 4
+    end
 
-      param  :foo, reader: false
-      option :bar, reader: false
+    it "defines a public attr_reader by default" do
+      expect(subject).to respond_to(:foo, :foo2)
+      expect(subject).to respond_to :bar
+      expect(subject).to respond_to :bar2
     end
+  end
+
+  context "with reader: false" do
+    subject do
+      class Test::Foo
+        extend Dry::Initializer::Mixin
+
+        param  :foo, reader: false
+        option :bar, reader: false
+      end
+
+      Test::Foo.new 1, bar: 2
+    end
+
+    it_behaves_like "it has no public attr_reader"
 
-    Test::Foo.new 1, bar: 2
+    it "keeps assigning variables" do
+      expect(subject.instance_variable_get(:@foo)).to eql 1
+      expect(subject.instance_variable_get(:@bar)).to eql 2
+    end
   end
 
-  it "skips attr_reader" do
-    expect(subject).not_to respond_to :foo
-    expect(subject).not_to respond_to :bar
+  context "with reader: :private" do
+    subject do
+      class Test::Foo
+        extend Dry::Initializer::Mixin
+
+        param  :foo, reader: :private
+        option :bar, reader: :private
+      end
+
+      Test::Foo.new 1, bar: 2
+    end
+
+    it_behaves_like "it has no public attr_reader"
+
+    it "adds a private attr_reader" do
+      expect(subject.send(:foo)).to eql 1
+      expect(subject.send(:bar)).to eql 2
+    end
   end
 
-  it "keeps assigning variables" do
-    expect(subject.instance_variable_get(:@foo)).to eql 1
-    expect(subject.instance_variable_get(:@bar)).to eql 2
+  context "with reader: :protected" do
+    subject do
+      class Test::Foo
+        extend Dry::Initializer::Mixin
+
+        param  :foo, reader: :protected
+        option :bar, reader: :protected
+      end
+
+      Test::Foo.new 1, bar: 2
+    end
+
+    it "adds a protected attr_reader" do
+      protected_instance_methods = subject.class.protected_instance_methods
+      expect(protected_instance_methods).to match_array([:foo, :bar])
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dry-initializer
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Vladimir Kochnev (marshall-lee)
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-21 00:00:00.000000000 Z
+date: 2016-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -59,6 +59,20 @@ dependencies:
     - - ">"
       - !ruby/object:Gem::Version
         version: 0.5.1
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.42'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.42'
 description: 
 email:
 - hashtable@yandex.ru