dry-initializer 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7db8f3d16f5e690b2184d79d06d2417e2dab2810
-  data.tar.gz: 03a361fa17734d5d37d8da5f647e975e36ee8d1f
+  metadata.gz: 741920ad4c93079821b5dd2f4031fadaf6e4c3b7
+  data.tar.gz: b64f94cc5b3295a3a9decc367fd00fd46bd0ee36
 SHA512:
-  metadata.gz: f879fb0ae4169c9a402df913d7b00f4c38e9349ca7d200c43687f5c28970e81466c3152a19b61249299451213b93ee9ce971b949d3eb0f163ebce6c55304bf3b
-  data.tar.gz: cc7a1b201b934f10c1d09a09f2b22820361135c4da201c4778828836b55dd7633e0b8db8e9673071e3344a56c73498ab036f787dec8be57bd57169c07872532b
+  metadata.gz: 1716c91a5cebe7bd125542c3a3004fed51fef824d865351609332b18f234a1adbe99420e91045d5f5144dbf44d69bde670a84d578bd433137611af7c4daea12a
+  data.tar.gz: 71b93072383a3ec4ad127057a4db3f99b0f1b21b6d50d0d8dda5776e21b43943de82c15f8a3e94668152339112fda1952e08fc1bd905439dd08d409012232737

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## v0.5.0 2016-08-21
+
+### Added
+
+* Allow `optional` attribute to be left undefined (@nepalez)
+
+[Compare v0.4.0...v0.5.0](https://github.com/dry-rb/dry-initializer/compare/v0.4.0..v0.5.0)
+
 ## v0.4.0 2016-05-28
 
 ### Deleted (backward-incompatible changes)

data/Gemfile

@@ -5,7 +5,7 @@ gemspec
 
 group :benchmarks do
   gem "benchmark-ips", "~> 2.5"
-
+  gem "activesupport", "< 5"
   gem "active_attr"
   gem "anima"
   gem "attr_extras"

data/README.md

@@ -49,7 +49,7 @@ class User
 
   # Params of the initializer along with corresponding readers
   param  :name
-  param  :role, default: proc { 'customer' }
+  param  :role,  default: proc { 'customer' }
   # Options of the initializer along with corresponding readers
   option :admin, default: proc { false }
 end

data/dry-initializer.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name     = "dry-initializer"
-  gem.version  = "0.4.0"
+  gem.version  = "0.5.0"
   gem.author   = ["Vladimir Kochnev (marshall-lee)", "Andrew Kozin (nepalez)"]
   gem.email    = ["hashtable@yandex.ru", "andrew.kozin@gmail.com"]
   gem.homepage = "https://github.com/dryrb/dry-initializer"

data/lib/dry/initializer/plugins/signature.rb

@@ -17,8 +17,12 @@ module Dry::Initializer::Plugins
       settings.key? :default
     end
 
+    def optional?
+      default? || settings.key?(:optional)
+    end
+
     def call
-      case [param?, default?]
+      case [param?, optional?]
       when [true, false]  then name.to_s
       when [false, false] then "#{name}:"
       when [true, true]   then "#{name} = #{undefined}"

data/lib/dry/initializer/signature.rb

@@ -43,8 +43,8 @@ module Dry::Initializer
     end
 
     def validates_order_of(signature)
-      return unless signature.param? && !signature.default?
-      return unless any? { |item| item.param? && item.default? }
+      return unless signature.param? && !signature.optional?
+      return unless any? { |item| item.param? && item.optional? }
 
       fail OrderError.new(signature.name)
     end

data/spec/dry/optional_spec.rb

@@ -0,0 +1,44 @@
+describe "optional value" do
+  context "when has no default value" do
+    before do
+      class Test::Foo
+        extend Dry::Initializer::Mixin
+
+        param :foo
+        param :bar, optional: true
+      end
+    end
+
+    it "is left UNDEFINED by default" do
+      subject = Test::Foo.new(1)
+
+      expect(subject.foo).to eq 1
+      expect(subject.bar).to eq Dry::Initializer::UNDEFINED
+    end
+
+    it "can be set explicitly" do
+      subject = Test::Foo.new(1, "qux")
+
+      expect(subject.foo).to eq 1
+      expect(subject.bar).to eq "qux"
+    end
+  end
+
+  context "when has default value" do
+    before do
+      class Test::Foo
+        extend Dry::Initializer::Mixin
+
+        param :foo
+        param :bar, optional: true, default: proc { "baz" }
+      end
+    end
+
+    it "is takes default value" do
+      subject = Test::Foo.new(1)
+
+      expect(subject.foo).to eq 1
+      expect(subject.bar).to eq "baz"
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dry-initializer
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Vladimir Kochnev (marshall-lee)
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-28 00:00:00.000000000 Z
+date: 2016-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -112,6 +112,7 @@ files:
 - spec/dry/default_values_spec.rb
 - spec/dry/invalid_default_spec.rb
 - spec/dry/missed_default_spec.rb
+- spec/dry/optional_spec.rb
 - spec/dry/options_tolerance_spec.rb
 - spec/dry/plugin_registry_spec.rb
 - spec/dry/reader_spec.rb
@@ -151,6 +152,7 @@ test_files:
 - spec/dry/default_values_spec.rb
 - spec/dry/invalid_default_spec.rb
 - spec/dry/missed_default_spec.rb
+- spec/dry/optional_spec.rb
 - spec/dry/options_tolerance_spec.rb
 - spec/dry/plugin_registry_spec.rb
 - spec/dry/reader_spec.rb
@@ -159,4 +161,3 @@ test_files:
 - spec/dry/type_constraint_spec.rb
 - spec/dry/value_coercion_via_dry_types_spec.rb
 - spec/spec_helper.rb
-has_rdoc: