dry-initializer 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ae0e61fb5894f53da09eea595818f5c6d9dc5482
-  data.tar.gz: d4b4eb054a1a5ccaf9d8211aed807c841fe3b0a0
+  metadata.gz: 0c2d0bd0d5582696fdc1b1cd2190f8114220f142
+  data.tar.gz: 949cbe9873d11f23b1289f61de684b92de4cb23d
 SHA512:
-  metadata.gz: ab37761b6ef475ba335e92b2751db1276d68b67a43d2e6f69a9e6e98f5e0ba2ffeb916739d2aab863327b8ab3fc64c30569144ceba881c90108628e4e50eb065
-  data.tar.gz: 866ec3b26e494e5f40066e0dd8f98a926f7cd696fdda71837ff0d06f099ab83252cca2e68e175f7632fe28c34902705ea4396246a9860ad731da62742002d648
+  metadata.gz: 31f337c8c1e6d71f05ad3145c6bedf6ed92a532261ca3e26fbbd7449d5e303e2dc452342fd210632eb532813a6cc0148dab4bedb4c88dff2d6319f03cdc6658f
+  data.tar.gz: f86d25c3b3004aa3a0792cf5fc6ea18a6e3d3baf855cb0636045de6079c882b77a2b9f3028037c902b967ea0cb687559f3c14b41176150bd48940a5abe40371b

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## v0.3.1 2016-05-22
+
+### Added
+
+* Support for tolerance to unknown options (@nepalez)
+
+[Compare v0.3.0...v0.3.1](https://github.com/dry-rb/dry-initializer/compare/v0.3.0..v0.3.1)
+
 ## v0.3.0 2016-05-19
 
 Breaks interface for adding new plugins. Register new plugin via:

data/dry-initializer.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name     = "dry-initializer"
-  gem.version  = "0.3.0"
+  gem.version  = "0.3.1"
   gem.author   = ["Vladimir Kochnev (marshall-lee)", "Andrew Kozin (nepalez)"]
   gem.email    = ["hashtable@yandex.ru", "andrew.kozin@gmail.com"]
   gem.homepage = "https://github.com/dryrb/dry-initializer"

data/lib/dry/initializer/builder.rb

@@ -17,27 +17,43 @@ module Dry::Initializer
     #
     # @param [Dry::Initializer::Plugin]
     #
+    # @return [Dry::Initializer::Builder]
+    #
     def register(plugin)
       plugins = @plugins + [plugin]
       copy { @plugins = plugins }
     end
 
+    # Makes builder to provide options-tolerant initializer
+    #
+    # @return [Dry::Initializer::Builder]
+    #
+    def tolerant_to_unknown_options
+      copy { @tolerant = "**" }
+    end
+
+    # Makes builder to provide options-intolerant initializer
+    #
+    # @return [Dry::Initializer::Builder]
+    #
+    def intolerant_to_unknown_options
+      copy { @tolerant = nil }
+    end
+
     # Defines new agrument and reloads mixin definitions
     #
-    # @param (see #call)
     # @param [#to_sym] name
     # @param [Hash<Symbol, Object>] settings
     #
-    # @return [self] itself
+    # @return [Dry::Initializer::Builder]
     #
-    def define(mixin, name, settings)
+    def define(name, settings)
       signature = @signature.add(name, settings)
       parts     = @parts + @plugins.map { |p| p.call(name, settings) }.compact
 
       copy do
         @signature = signature
         @parts     = parts
-        call(mixin)
       end
     end
 
@@ -49,6 +65,7 @@ module Dry::Initializer
       define_readers(mixin)
       reload_initializer(mixin)
       reload_callback(mixin)
+      mixin
     end
 
     private
@@ -65,10 +82,12 @@ module Dry::Initializer
     end
 
     def reload_initializer(mixin)
-      strings = @parts.select { |part| String === part }
-
+      strings   = @parts.select { |part| String === part }
+      signature = [@signature.call, @tolerant].map(&:to_s)
+                                              .reject(&:empty?)
+                                              .join(", ")
       mixin.class_eval <<-RUBY
-        def initialize(#{@signature.call})
+        def initialize(#{signature})
           #{strings.join("\n")}
           __after_initialize__
         end

data/lib/dry/initializer/mixin.rb

@@ -12,9 +12,9 @@ module Dry::Initializer
     # @return [self] itself
     #
     def param(name, **options)
-      @initializer_builder = initializer_builder
-                             .define(self, name, option: false, **options)
-      self
+      @initializer_builder = \
+        initializer_builder.define(name, option: false, **options)
+      initializer_builder.call(self)
     end
 
     # Declares a named argument
@@ -24,9 +24,9 @@ module Dry::Initializer
     # @return (see #param)
     #
     def option(name, **options)
-      @initializer_builder = initializer_builder
-                             .define(self, name, option: true, **options)
-      self
+      @initializer_builder = \
+        initializer_builder.define(name, option: true, **options)
+      initializer_builder.call(self)
     end
 
     # Adds new plugin to the builder
@@ -37,7 +37,24 @@ module Dry::Initializer
     def register_initializer_plugin(plugin)
       @initializer_builder = initializer_builder.register(plugin)
       initializer_builder.call(self)
-      self
+    end
+
+    # Makes initializer tolerant to unknown options
+    #
+    # @return [self] itself
+    #
+    def tolerant_to_unknown_options
+      @initializer_builder = initializer_builder.tolerant_to_unknown_options
+      initializer_builder.call(self)
+    end
+
+    # Makes initializer intolerant to unknown options
+    #
+    # @return [self] itself
+    #
+    def intolerant_to_unknown_options
+      @initializer_builder = initializer_builder.intolerant_to_unknown_options
+      initializer_builder.call(self)
     end
 
     private

data/spec/dry/options_tolerance_spec.rb

@@ -0,0 +1,27 @@
+describe "options tolerance" do
+  before do
+    class Test::Foo
+      extend Dry::Initializer::Mixin
+    end
+
+    class Test::Bar < Test::Foo
+      tolerant_to_unknown_options
+    end
+
+    class Test::Baz < Test::Bar
+      intolerant_to_unknown_options
+    end
+  end
+
+  it "is strict by default" do
+    expect { Test::Foo.new foo: :bar }.to raise_error(ArgumentError)
+  end
+
+  it "allows unknown options when switched on" do
+    expect { Test::Bar.new foo: :bar }.not_to raise_error
+  end
+
+  it "can be switched off" do
+    expect { Test::Baz.new foo: :bar }.to raise_error(ArgumentError)
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dry-initializer
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Vladimir Kochnev (marshall-lee)
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-19 00:00:00.000000000 Z
+date: 2016-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -115,6 +115,7 @@ files:
 - spec/dry/invalid_default_spec.rb
 - spec/dry/missed_default_spec.rb
 - spec/dry/object_type_constraint_spec.rb
+- spec/dry/options_tolerance_spec.rb
 - spec/dry/plain_type_constraint_spec.rb
 - spec/dry/plugin_registry_spec.rb
 - spec/dry/reader_spec.rb
@@ -155,6 +156,7 @@ test_files:
 - spec/dry/invalid_default_spec.rb
 - spec/dry/missed_default_spec.rb
 - spec/dry/object_type_constraint_spec.rb
+- spec/dry/options_tolerance_spec.rb
 - spec/dry/plain_type_constraint_spec.rb
 - spec/dry/plugin_registry_spec.rb
 - spec/dry/reader_spec.rb