dry-initializer 0.10.0 → 0.10.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a4d76d7f8289370012fd8520cbfc7b2b8375b6a3
-  data.tar.gz: d39b5808176f0402dbeff16f18a223d179eb3a2f
+  metadata.gz: 703f60031e8175b459409542ce364d243e74176c
+  data.tar.gz: 7397c054e19e469e5d3aff41f6ee4ea2a051b28c
 SHA512:
-  metadata.gz: 8f1676fe465def4eb3a91f332b17115b3f0bc0968233ca092fad22279e8cc3e23e6d9d43cffbd57e2bc2978fb60971eecb3e2f5d16ebb78f3f372784c996c570
-  data.tar.gz: 8ea22e40b1847f4430b9fec4ab3bcce0af62e2cb864496a2c486f17b15165519b0a5b42bb043c548e557a33516e0888cb67023c0446d23b24649239b66757d64
+  metadata.gz: 230abf76b90e2f32c5435652e90990231698fce5237ff23b12b4a87091292e9fa8aa7cefa8527357cdece57c563d22c11136cc179bf3e875a39fd45a9a4ad530
+  data.tar.gz: 26c23b5a2ca43c0de31110d24a0253140433d6a8b4e0d21ccabb8a2fc879fff899d99e4da04c91662da5e782e321774563379d64e25626c5b0f7948979c70e09

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## v0.10.1 2016-12-27
+
+### Fixed
+
+* Wrong arity when there were no options and the last param had a default (@nolith)
+
+[Compare v0.10.0...v0.10.1](https://github.com/dry-rb/dry-initializer/compare/v0.10.0...v0.10.1)
+
 ## v0.10.0 2016-11-20
 
 ### Deleted (BREAKING CHANGE!)

data/dry-initializer.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name     = "dry-initializer"
-  gem.version  = "0.10.0"
+  gem.version  = "0.10.1"
   gem.author   = ["Vladimir Kochnev (marshall-lee)", "Andrew Kozin (nepalez)"]
   gem.email    = ["hashtable@yandex.ru", "andrew.kozin@gmail.com"]
   gem.homepage = "https://github.com/dryrb/dry-initializer"

data/lib/dry/initializer/plugins/base.rb

@@ -36,8 +36,7 @@ module Dry::Initializer::Plugins
 
     # Builds a chunk of code
     # @return (see .call)
-    def call
-    end
+    def call; end
 
     # Returns the name for the attribute
     # @return (see .name)

data/lib/dry/initializer/signature.rb

@@ -25,7 +25,8 @@ module Dry::Initializer
     end
 
     def call
-      (select(&:param?).map(&:call) + %w(**__options__)).compact.join(", ")
+      options = all?(&:param?) ? %w(__options__={}) : %w(**__options__)
+      (select(&:param?).map(&:call) + options).compact.join(", ")
     end
 
     private

data/spec/default_values_spec.rb

@@ -48,4 +48,36 @@ describe "default values" do
     subject = Test::Foo.new
     expect(subject.mox).to eql :MOX
   end
+
+  describe "when the last param has a default and there are no options" do
+    before do
+      class Test::Bar
+        extend Dry::Initializer::Mixin
+
+        param  :foo
+        param  :bar, default: proc { {} }
+      end
+    end
+
+    it "instantiate arguments" do
+      subject = Test::Bar.new(1, 2)
+
+      expect(subject.foo).to eql 1
+      expect(subject.bar).to eql 2
+    end
+
+    it "applies default values" do
+      subject = Test::Bar.new(1)
+
+      expect(subject.foo).to eql 1
+      expect(subject.bar).to eql({})
+    end
+
+    it "instantiate arguments also if the last is an hash" do
+      subject = Test::Bar.new(1, { baz: 2, qux: 3 })
+
+      expect(subject.foo).to eql 1
+      expect(subject.bar).to eql({ baz: 2, qux: 3 })
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dry-initializer
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.10.1
 platform: ruby
 authors:
 - Vladimir Kochnev (marshall-lee)
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-20 00:00:00.000000000 Z
+date: 2016-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -151,7 +151,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.4
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: DSL for declaring params and options of the initializer
@@ -173,4 +173,3 @@ test_files:
 - spec/type_argument_spec.rb
 - spec/type_constraint_spec.rb
 - spec/value_coercion_via_dry_types_spec.rb
-has_rdoc: