dry-configurable 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ce548cd2fd8336b1a9aa14e96f4ad1a8b49709b1
-  data.tar.gz: e67a56b52da574d789d50912ceb49162c3b68c4f
+  metadata.gz: e4cbef88b095851ec643863da9c0fd42cc5cf54f
+  data.tar.gz: bde6842ae91242766940d9304d6ac82c0ceaabec
 SHA512:
-  metadata.gz: c81003e13f0ffe3ef45853a3692491c2c1f142ab3f9cde250adfd4064f68e06330f5281aca303013daf9ddd0e93e276d9f36a2a10122fb7ebb6fd461d305fdc0
-  data.tar.gz: 0a64e0ce70d1577a537bbf44c6f4b97cb270d82c71ad0582f4fafa6734161308e0ee244a2a65233301d4f77ca49a515b98b02d4a729cae2053ca3444570a9fef
+  metadata.gz: f8233d5a3b57bda025a6cd5492f805201c7cdbc8695dc5c664fe6aef0f07bdb08a3732cc8ce5747ea01b0f0acdb3e9967760ee10a6d3f0f0c06ae0ddc621b76e
+  data.tar.gz: f865d739bd8f32ca49c208ca0291a463d71dfde39e67b7c8a85e4489150a8a3560b853d8093b9413859e3bbe24cfe43a888281c3f03b638053de860c1176df78

data/lib/dry/configurable/config.rb

@@ -56,6 +56,26 @@ module Dry
         end
       end
       alias to_hash to_h
+
+      def [](name)
+        raise_unknown_setting_error(name) unless setting?(name)
+        public_send(name)
+      end
+
+      def []=(name, value)
+        raise_unknown_setting_error(name) unless setting?(name)
+        public_send("#{name}=", value)
+      end
+
+      private
+
+      def raise_unknown_setting_error(name)
+        raise ArgumentError, "+#{name}+ is not a setting name"
+      end
+
+      def setting?(name)
+        @config.key?(name.to_sym)
+      end
     end
   end
 end

data/lib/dry/configurable/config/value.rb

@@ -9,7 +9,7 @@ module Dry
         attr_reader :name, :processor
 
         def initialize(name, value, processor)
-          @name, @value, @processor = name, value, processor
+          @name, @value, @processor = name.to_sym, value, processor
         end
 
         def value

data/lib/dry/configurable/version.rb

@@ -1,6 +1,6 @@
 module Dry
   module Configurable
     # @api public
-    VERSION = '0.4.0'.freeze
+    VERSION = '0.5.0'.freeze
   end
 end

data/spec/unit/dry/configurable/config/value_spec.rb

@@ -5,6 +5,14 @@ RSpec.describe Dry::Configurable::Config::Value do
   let(:value) { 'test' }
   let(:processor) { ->(v) { v }}
 
+  describe '#initialize' do
+    it 'coerces string name to symbol' do
+      config = klass.new('db', value, processor)
+
+      expect(config.name).to eq(:db)
+    end
+  end
+
   describe '#name' do
     subject! { config.name }
 

data/spec/unit/dry/configurable/config_spec.rb

@@ -128,4 +128,48 @@ RSpec.describe Dry::Configurable::Config do
       end
     end
   end
+
+  describe '#[]' do
+    it 'returns given setting' do
+      expect(config[:db]).to eq('sqlite:memory')
+      expect(config[:user]).to eq('root')
+      expect(config[:pass]).to be(nil)
+    end
+
+    it 'raises an ArgumentError when setting does not exist' do
+      expect { config[:unknown] }.to raise_error(
+        ArgumentError, '+unknown+ is not a setting name'
+      )
+    end
+
+    it 'accepts setting name as a string' do
+      expect(config['user']).to eq('root')
+    end
+  end
+
+  describe '#[]=' do
+    it 'sets given setting' do
+      expect { config[:db] = 'ineedm0ar' }.to change(config, :db)
+        .from('sqlite:memory')
+        .to('ineedm0ar:memory')
+      expect { config[:user] = 'whoami' }.to change(config, :user)
+        .from('root')
+        .to('whoami')
+      expect { config[:pass] = 'h4xz0rz' }.to change(config, :pass)
+        .from(nil)
+        .to('h4xz0rz')
+    end
+
+    it 'raises an ArgumentError when setting does not exist' do
+      expect { config[:unknown] = 'unknown' }.to raise_error(
+        ArgumentError, '+unknown+ is not a setting name'
+      )
+    end
+
+    it 'accepts setting name as a string' do
+      expect { config['user'] = 'whoami' }.to change(config, :user)
+        .from('root')
+        .to('whoami')
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dry-configurable
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Andy Holland
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-09 00:00:00.000000000 Z
+date: 2016-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby