dry-configurable 0.11.2 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 65b62072b64448e9497df8793ee48ffe9054ab0d5aaae81155ae39261540699a
-  data.tar.gz: 3c9d313e814c318fa2cda842893d6f6f2a10ca7f7782ef1754f2d13aeecd7082
+  metadata.gz: 102cb0a4fe42ebde6835f50b7e75826dbc4b98c78cca9fcee5c5863c1c47651f
+  data.tar.gz: f5da17ecfb79edfa42c0d6c9a0d05d3e4cce2297533ec3151afafc9e6d4151b3
 SHA512:
-  metadata.gz: 9b4ef50f85d48ed7a428c5c982d9ecde8d099c054e4f9cacee8b391dbbe9484ac0a9a0c2d7225e0d131c6737afb32102d5d270cb15b5470f75550ecf30269121
-  data.tar.gz: a7354981a2991f3cca99aa07490194aba880c68c6d7eb47c5365b5860722a3bbafba1dcceeeeb8bd12859742ad461f2ca9e18f92834fd60758ac3c2df95082b1
+  metadata.gz: 7d6dac8ebf7eddf6eb8b61da5cef0a434769270fc5ad2ab13ea7a4c5d093c047681b1bc85da4ba09190cfcf17ef023293dc4ccdb2f8dd2ac7eae19dbb4c69706
+  data.tar.gz: be0be051c79c2ef527d678cb9f839d6cabf40669b19864d38a735fe428a277068504897bd289baf69e0da26f470e35e0c2e73bc99f62dd16286fa7148a35572c

data/CHANGELOG.md

@@ -1,3 +1,65 @@
+<!--- DO NOT EDIT THIS FILE - IT'S AUTOMATICALLY GENERATED VIA DEVTOOLS --->
+
+## 0.12.0 2020-12-26
+
+
+### Fixed
+
+- Setting values provided by defaults and/or pre-processor blocks are no longer accidentally memoized across instances of classes including Dry::Configurable (#99) (@timriley & @esparta)
+
+### Changed
+
+- Instance behavior is now prepended, so that if you have your own `initialize`, calling `super` is no longer required (see #98 for more details) (@zabolotnov87)
+- Switched to equalizer from dry-core (@solnic)
+
+[Compare v0.11.6...v0.12.0](https://github.com/dry-rb/dry-configurable/compare/v0.11.6...v0.12.0)
+
+## 0.11.6 2020-06-22
+
+
+### Changed
+
+- A meaningful error is raised when the extension is included more than once (issue #89 fixed via #94) (@landongrindheim)
+- Evaluate setting input immediately when input is provided. This allows for earlier feedback from constructors designed to raise errors on invalid input (#95) (@timriley)
+
+[Compare v0.11.5...v0.11.6](https://github.com/dry-rb/dry-configurable/compare/v0.11.5...v0.11.6)
+
+## 0.11.5 2020-03-23
+
+
+### Fixed
+
+- When settings are copied or cloned, unevaluated values will no longer be copied. This prevents unintended crashes when settings have constructors expecting a certain type of value, but that value is yet to be provided (Fixed via #87) (@timriley)
+
+### Changed
+
+- A meaningful error is raised when the extension is included more than once (issue #89 fixed via #94) (@landongrindheim)
+
+[Compare v0.11.4...v0.11.5](https://github.com/dry-rb/dry-configurable/compare/v0.11.4...v0.11.5)
+
+## 0.11.4 2020-03-16
+
+
+### Fixed
+
+- `Config#update` returns `self` again (issue #60 fixed via #92) (@solnic)
+
+### Changed
+
+- `Setting#inspect` no longer uses its value - this could cause crashes when inspecting settings that are yet to have a value applied (e.g. when they have a constructor that expects a value to be present) (@timriley)
+
+[Compare v0.11.3...v0.11.4](https://github.com/dry-rb/dry-configurable/compare/v0.11.3...v0.11.4)
+
+## 0.11.3 2020-02-22
+
+
+### Fixed
+
+- Retrieving settings by a string name works again (issue #82) (@waiting-for-dev)
+
+
+[Compare v0.11.2...v0.11.3](https://github.com/dry-rb/dry-configurable/compare/v0.11.2...v0.11.3)
+
 ## 0.11.2 2020-02-20
 
 

data/README.md

@@ -21,7 +21,7 @@
 
 This library officially supports the following Ruby versions:
 
-* MRI >= `2.4`
+* MRI >= `2.5`
 * jruby >= `9.2`
 
 ## License

data/dry-configurable.gemspec

@@ -25,12 +25,11 @@ Gem::Specification.new do |spec|
   spec.metadata['source_code_uri']   = 'https://github.com/dry-rb/dry-configurable'
   spec.metadata['bug_tracker_uri']   = 'https://github.com/dry-rb/dry-configurable/issues'
 
-  spec.required_ruby_version = ">= 2.4.0"
+  spec.required_ruby_version = ">= 2.5.0"
 
   # to update dependencies edit project.yml
   spec.add_runtime_dependency "concurrent-ruby", "~> 1.0"
-  spec.add_runtime_dependency "dry-core", "~> 0.4", ">= 0.4.7"
-  spec.add_runtime_dependency "dry-equalizer", "~> 0.2"
+  spec.add_runtime_dependency "dry-core", "~> 0.5", ">= 0.5.0"
 
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"

data/lib/dry/configurable.rb

@@ -7,6 +7,7 @@ require 'dry/configurable/class_methods'
 require 'dry/configurable/instance_methods'
 require 'dry/configurable/config'
 require 'dry/configurable/setting'
+require 'dry/configurable/errors'
 
 module Dry
   # A simple configuration mixin
@@ -51,10 +52,12 @@ module Dry
 
     # @api private
     def self.included(klass)
+      raise AlreadyIncluded if klass.include?(InstanceMethods)
+
       super
       klass.class_eval do
         extend(ClassMethods)
-        include(InstanceMethods)
+        prepend(InstanceMethods)
 
         class << self
           undef :config

data/lib/dry/configurable/config.rb

@@ -2,7 +2,7 @@
 
 require 'concurrent/map'
 
-require 'dry/equalizer'
+require 'dry/core/equalizer'
 
 require 'dry/configurable/constants'
 require 'dry/configurable/errors'
@@ -33,6 +33,7 @@ module Dry
       #
       # @return Config value
       def [](name)
+        name = name.to_sym
         raise ArgumentError, "+#{name}+ is not a setting name" unless _settings.key?(name)
 
         _settings[name].value
@@ -49,7 +50,7 @@ module Dry
 
       # Update config with new values
       #
-      # @param [Hash] A hash with new values
+      # @param values [Hash] A hash with new values
       #
       # @return [Config]
       #
@@ -63,6 +64,7 @@ module Dry
             self[key] = value
           end
         end
+        self
       end
 
       # Dump config into a hash

data/lib/dry/configurable/dsl.rb

@@ -43,7 +43,7 @@ module Dry
 
         default, opts = args
 
-        node = [:setting, [name, default, opts == default ? EMPTY_HASH : opts]]
+        node = [:setting, [name.to_sym, default, opts == default ? EMPTY_HASH : opts]]
 
         if block
           if block.arity.zero?

data/lib/dry/configurable/errors.rb

@@ -6,6 +6,7 @@ module Dry
   # @api public
   module Configurable
     Error = Class.new(::StandardError)
+    AlreadyIncluded = ::Class.new(Error)
     FrozenConfig = ::Class.new(Error)
   end
 end

data/lib/dry/configurable/setting.rb

@@ -2,7 +2,7 @@
 
 require 'set'
 
-require 'dry/equalizer'
+require 'dry/core/equalizer'
 
 require 'dry/configurable/constants'
 require 'dry/configurable/config'
@@ -13,7 +13,7 @@ module Dry
     #
     # @api private
     class Setting
-      include Dry::Equalizer(:name, :value, :options)
+      include Dry::Equalizer(:name, :value, :options, inspect: false)
 
       OPTIONS = %i[input default reader constructor settings].freeze
 
@@ -53,13 +53,25 @@ module Dry
         end
       end
 
+      # @api private
+      def self.clonable_value?(value)
+        CLONABLE_VALUE_TYPES.any? { |type| value.is_a?(type) }
+      end
+
       # @api private
       def initialize(name, input: Undefined, default: Undefined, **options)
         @name = name
         @writer_name = :"#{name}="
-        @input = input.equal?(Undefined) ? default : input
+        @input = input
         @default = default
         @options = options
+
+        evaluate if input_defined?
+      end
+
+      # @api private
+      def input_defined?
+        !input.equal?(Undefined)
       end
 
       # @api private
@@ -67,6 +79,11 @@ module Dry
         @value ||= evaluate
       end
 
+      # @api private
+      def evaluated?
+        instance_variable_defined?(:@value)
+      end
+
       # @api private
       def nested(settings)
         Nested.new(name, input: settings, **options)
@@ -97,23 +114,20 @@ module Dry
         writer_name.equal?(meth)
       end
 
-      # @api private
-      def clonable_value?
-        CLONABLE_VALUE_TYPES.any? { |type| value.is_a?(type) }
-      end
-
       private
 
       # @api private
       def initialize_copy(source)
         super
-        @value = source.value.dup if source.clonable_value?
+        @input = source.input.dup if Setting.clonable_value?(source.input)
+        @default = source.default.dup if Setting.clonable_value?(source.default)
+        @value = source.value.dup if source.evaluated? && Setting.clonable_value?(source.value)
         @options = source.options.dup
       end
 
       # @api private
       def evaluate
-        @value = constructor[input.equal?(Undefined) ? nil : input]
+        @value = constructor[Undefined.coalesce(input, default, nil)]
       end
     end
   end

data/lib/dry/configurable/settings.rb

@@ -2,7 +2,7 @@
 
 require 'concurrent/map'
 
-require 'dry/equalizer'
+require 'dry/core/equalizer'
 require 'dry/configurable/constants'
 
 module Dry

data/lib/dry/configurable/version.rb

@@ -3,6 +3,6 @@
 module Dry
   module Configurable
     # @api public
-    VERSION = '0.11.2'
+    VERSION = '0.12.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dry-configurable
 version: !ruby/object:Gem::Version
-  version: 0.11.2
+  version: 0.12.0
 platform: ruby
 authors:
 - Andy Holland
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-20 00:00:00.000000000 Z
+date: 2020-12-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -30,34 +30,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '0.5'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.4.7
+        version: 0.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '0.5'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.4.7
-- !ruby/object:Gem::Dependency
-  name: dry-equalizer
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.2'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.2'
+        version: 0.5.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -142,14 +128,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.4.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: A mixin to add configuration functionality to your classes