dry-configurable 0.11.1 → 0.11.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d6c2b78240f829b83467c0edd12a5c4dc59d4d7b0fdb5aa9e44fdfc5e3031e13
-  data.tar.gz: 506974ab79b93359fbac5305fa76860f13b13047dd85a76dffbbdebc500d2d93
+  metadata.gz: d76fbe81b58bc0a6d0e5abb5f135e32e6eb7f47533af60864a09e0143b3ea66c
+  data.tar.gz: 33f74bd69c1f030477088d32e80024969983e8dd793c58c89264828edc207a90
 SHA512:
-  metadata.gz: 4e1bf6f3ea8ebd9bae2d0bd759cd3f81fd591d8df3a11e675b23acc54f1228ec3311bdab3c04f6b85e5db01ca718d1ed64b2347fa2bcbb3d439c127a6efdfe39
-  data.tar.gz: 2ff1ff49ddee94891d5e920e5b48c2c4a5d50d7a2e56c4c4df7c68b46cd61c4270ee375ad6c5a9d6b95f4ca8b01b4d4dd397e2f350a4d6aa584c0d3d87e4442c
+  metadata.gz: aef6696e55e9ec56e46fabc857db9f1c2c8e266efad943844faf574d2d7d224829ca14457f66c8082f016d4cbdcb7f6bc9a1f33f641c743621c3b998d2f604d4
+  data.tar.gz: 11ab00f69b7c172d23d6de19a2f0a208bbd83ecd91b865cb591d18df0f91fd4578d487fb2acd71a88e4b89477a17e602816999847cad4fc0671139aa68e11d00

data/CHANGELOG.md

@@ -1,13 +1,69 @@
 ## unreleased 
 
 
+### Changed
+
+- A meaningful error is raised when the extension is included more than once (issue #89 fixed via #94) (@landongrindheim)
+- Evaluate setting input immediately when input is provided. This allows for earlier feedback from constructors designed to raise errors on invalid input (#95) (@timriley)
+
+[Compare v0.11.5...master](https://github.com/dry-rb/dry-configurable/compare/v0.11.5...master)
+
+## 0.11.5 2020-03-23
+
+
+### Fixed
+
+- When settings are copied or cloned, unevaluated values will no longer be copied. This prevents unintended crashes when settings have constructors expecting a certain type of value, but that value is yet to be provided (Fixed via #87) (@timriley)
+
+### Changed
+
+- A meaningful error is raised when the extension is included more than once (issue #89 fixed via #94) (@landongrindheim)
+
+[Compare v0.11.4...v0.11.5](https://github.com/dry-rb/dry-configurable/compare/v0.11.4...v0.11.5)
+
+## 0.11.4 2020-03-16
+
+
+### Fixed
+
+- `Config#update` returns `self` again (issue #60 fixed via #92) (@solnic)
+
+### Changed
+
+- `Setting#inspect` no longer uses its value - this could cause crashes when inspecting settings that are yet to have a value applied (e.g. when they have a constructor that expects a value to be present) (@timriley)
+
+[Compare v0.11.3...v0.11.4](https://github.com/dry-rb/dry-configurable/compare/v0.11.3...v0.11.4)
+
+## 0.11.3 2020-02-22
+
+
+### Fixed
+
+- Retrieving settings by a string name works again (issue #82) (@waiting-for-dev)
+
+
+[Compare v0.11.2...v0.11.3](https://github.com/dry-rb/dry-configurable/compare/v0.11.2...v0.11.3)
+
+## 0.11.2 2020-02-20
+
+
+### Fixed
+
+- Warning about redefined `Setting#value` is gone (@solnic)
+
+
+[Compare v0.11.1...v0.11.2](https://github.com/dry-rb/dry-configurable/compare/v0.11.1...v0.11.2)
+
+## 0.11.1 2020-02-18
+
+
 ### Fixed
 
 - You can use `:settings` as a config key again (issue #80) (@solnic)
 - Setting value is lazy-evaluated now, which fixes some cases where a constructor could crash with a `nil` value (@solnic)
 
 
-[Compare v0.11.0...master](https://github.com/dry-rb/dry-configurable/compare/v0.11.0...master)
+[Compare v0.11.0...v0.11.1](https://github.com/dry-rb/dry-configurable/compare/v0.11.0...v0.11.1)
 
 ## 0.11.0 2020-02-15
 

data/lib/dry/configurable.rb

@@ -7,6 +7,7 @@ require 'dry/configurable/class_methods'
 require 'dry/configurable/instance_methods'
 require 'dry/configurable/config'
 require 'dry/configurable/setting'
+require 'dry/configurable/errors'
 
 module Dry
   # A simple configuration mixin
@@ -51,6 +52,8 @@ module Dry
 
     # @api private
     def self.included(klass)
+      raise AlreadyIncluded if klass.include?(InstanceMethods)
+
       super
       klass.class_eval do
         extend(ClassMethods)

data/lib/dry/configurable/config.rb

@@ -33,6 +33,7 @@ module Dry
       #
       # @return Config value
       def [](name)
+        name = name.to_sym
         raise ArgumentError, "+#{name}+ is not a setting name" unless _settings.key?(name)
 
         _settings[name].value
@@ -49,7 +50,7 @@ module Dry
 
       # Update config with new values
       #
-      # @param [Hash] A hash with new values
+      # @param values [Hash] A hash with new values
       #
       # @return [Config]
       #
@@ -63,6 +64,7 @@ module Dry
             self[key] = value
           end
         end
+        self
       end
 
       # Dump config into a hash

data/lib/dry/configurable/dsl.rb

@@ -43,7 +43,7 @@ module Dry
 
         default, opts = args
 
-        node = [:setting, [name, default, opts == default ? EMPTY_HASH : opts]]
+        node = [:setting, [name.to_sym, default, opts == default ? EMPTY_HASH : opts]]
 
         if block
           if block.arity.zero?

data/lib/dry/configurable/errors.rb

@@ -6,6 +6,7 @@ module Dry
   # @api public
   module Configurable
     Error = Class.new(::StandardError)
+    AlreadyIncluded = ::Class.new(Error)
     FrozenConfig = ::Class.new(Error)
   end
 end

data/lib/dry/configurable/setting.rb

@@ -13,7 +13,7 @@ module Dry
     #
     # @api private
     class Setting
-      include Dry::Equalizer(:name, :value, :options)
+      include Dry::Equalizer(:name, :value, :options, inspect: false)
 
       OPTIONS = %i[input default reader constructor settings].freeze
 
@@ -33,9 +33,6 @@ module Dry
       # @api private
       attr_reader :default
 
-      # @api private
-      attr_reader :value
-
       # @api private
       attr_reader :options
 
@@ -63,6 +60,13 @@ module Dry
         @input = input.equal?(Undefined) ? default : input
         @default = default
         @options = options
+
+        evaluate if input_defined?
+      end
+
+      # @api private
+      def input_defined?
+        !input.equal?(Undefined)
       end
 
       # @api private
@@ -70,6 +74,11 @@ module Dry
         @value ||= evaluate
       end
 
+      # @api private
+      def evaluated?
+        instance_variable_defined?(:@value)
+      end
+
       # @api private
       def nested(settings)
         Nested.new(name, input: settings, **options)
@@ -110,7 +119,7 @@ module Dry
       # @api private
       def initialize_copy(source)
         super
-        @value = source.value.dup if source.clonable_value?
+        @value = source.value.dup if source.input_defined? && source.clonable_value?
         @options = source.options.dup
       end
 

data/lib/dry/configurable/version.rb

@@ -3,6 +3,6 @@
 module Dry
   module Configurable
     # @api public
-    VERSION = '0.11.1'
+    VERSION = '0.11.6'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dry-configurable
 version: !ruby/object:Gem::Version
-  version: 0.11.1
+  version: 0.11.6
 platform: ruby
 authors:
 - Andy Holland
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-18 00:00:00.000000000 Z
+date: 2020-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby