dry-component 0.4.2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 62d04c04b930c78a211b75bbe2b12e81709d5d72
-  data.tar.gz: 4142d98f2cbea51f1d33f3864b8a952ede77416a
+  metadata.gz: 71fded9ea102f66efa6c00cc6249f74cd8c497b7
+  data.tar.gz: 9a8abe72737921f3ef16539b733002884d25e9b9
 SHA512:
-  metadata.gz: 461b2819291b294fca018c24f12e392ee1fe3e9272232b9b87c79f5031968d74d9f91a2a7e52935ebc4c59fb3ec8f33e103eeeb94160a0ce5cceea184c9492c1
-  data.tar.gz: 0441572d29a273a379388e6bfb2f7a6c31b94ffd55051a55ebdfe1b7eac35fb57004443334d632b5f2fa857099f16bdd38c72dbe44617c57b2277923db75f3cd
+  metadata.gz: 411c457ecc7cb1365764a84f29854f53ce36afdf832acff7af145e1660d2a740b130c003631392330e16b5c49f673ecb6eb894a67df40f096aa2f1f4456cf3e2
+  data.tar.gz: dc30846c1bec2bfdcd410c3f3eded9749ba3465d6d92449864d5bd0e5fb7de8051bae72600ac3e99b5b9bc6db3160885d5c682b8e5590d4c3332cdfca5f5fe7f

data/CHANGELOG.md

@@ -1,16 +1,26 @@
+# 0.4.3 - 2016-08-01
+
+### Fixed
+
+- Return immediately from `Container.load_component` if the requested component key already exists in the container. This fixes a crash when requesting to load a manually registered component with a name that doesn't map to a filename (timriley in [#24](https://github.com/dry-rb/dry-component/pull/24))
+
+[Compare v0.4.2...v0.4.3](https://github.com/dry-rb/dry-component/compare/v0.4.2...v0.4.3)
+
 # 0.4.2 - 2016-07-26
 
 ### Fixed
 
 - Ensure file components can be loaded when they're requested for the first time using their shorthand container identifier (i.e. with the container's default namespace removed) (timriley)
 
+[Compare v0.4.1...v0.4.2](https://github.com/dry-rb/dry-component/compare/v0.4.1...v0.4.2)
+
 # 0.4.1 - 2016-07-26 [YANKED]
 
 ### Fixed
 
 - Require the 0.4.0 release of dry-auto_inject for the features below (in 0.4.0) to work properly (timriley)
 
-[Compare v0.3.0...v0.4.0](https://github.com/dry-rb/dry-component/compare/v0.4.0...v0.4.1)
+[Compare v0.4.0...v0.4.1](https://github.com/dry-rb/dry-component/compare/v0.4.0...v0.4.1)
 
 # 0.4.0 - 2016-07-26 [YANKED]
 

data/lib/dry/component/container.rb

@@ -123,6 +123,8 @@ module Dry
       end
 
       def self.load_component(key)
+        return self if key?(key)
+
         component = loader.load(key)
         src_key = component.namespaces[0]
 
@@ -145,6 +147,8 @@ module Dry
             end
           end
         end
+
+        self
       end
 
       def self.require_component(component, &block)

data/lib/dry/component/version.rb

@@ -1,5 +1,5 @@
 module Dry
   module Component
-    VERSION = '0.4.2'.freeze
+    VERSION = '0.4.3'.freeze
   end
 end

data/spec/unit/container_spec.rb

@@ -42,6 +42,16 @@ RSpec.describe Dry::Component::Container do
 
         expect(Test::Foo.new.dep).to be_instance_of(Test::Dep)
       end
+
+      it "raises an error if a component's file can't be found" do
+        expect { container.load_component('test.missing') }.to raise_error Dry::Component::FileNotFoundError
+      end
+
+      it "is a no op if a matching component is already registered" do
+        container.register "test.no_matching_file", Object.new
+
+        expect { container.load_component("test.no_matching_file") }.not_to raise_error
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dry-component
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Piotr Solnica
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-26 00:00:00.000000000 Z
+date: 2016-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: inflecto