dry-auto_inject 0.7.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0703f168c7bd86b0b847ff3805d192745b22595a9b0b70bd1880e74d4a189251
-  data.tar.gz: f4fe146fe1721a14cf22a90cb7a5d58f17f55ba97a5e74304368a04c69a26f47
+  metadata.gz: fbf423b57383e30d33060a0d0566ca2c9d9c451289f38132974325e5d7cdc2b8
+  data.tar.gz: a35a4d23402b9b5a1b47de1c953c0e089e646334c1ffffcaa4c320539d8eeecd
 SHA512:
-  metadata.gz: ad18bccd197227333852c9cb65116cfff76a3fce5a5dfaef22ad73cdcfbda699f8305602d330af59b2dd3a8fe02c40cf403ac10e23f973db9b1787b2928e824e
-  data.tar.gz: a699bbd6b33883d036fee625782790ea9a43e6687c730a7f62185c47570df021f661e33ea492ab9c72d79584717074b5ebd2bb7c012b27753c127c928ae19983
+  metadata.gz: 561d57d6c0aae98c94a6c6121dcd47601178fe37ce3c6077d87f28b85f4da7113112a66efba4c091f50dcbc1983212d2212abacf175845a212064cdbe340a389
+  data.tar.gz: 942e8def2974a6d131180ab66e1895ff2104ba960372513edea233598bb65ca52c612f359fcd33a43f698593aad288aa9012b75e29072c8d35e0a3af0bde87ae

data/CHANGELOG.md

@@ -1,4 +1,36 @@
-# 0.7.0 / 2019-12-28
+<!--- DO NOT EDIT THIS FILE - IT'S AUTOMATICALLY GENERATED VIA DEVTOOLS --->
+
+## 0.9.0 2022-01-26
+
+
+### Changed
+
+- [BREAKING] Support for ... was changed, now constructors with such signature are not considered
+as pass-through because they can forward arguments to another method (flash-gordon in [#78](https://github.com/dry-rb/dry-auto_inject/pull/78))
+
+- [BREAKING] Support for 2.6 was dropped
+
+[Compare v0.8.0...v0.9.0](https://github.com/dry-rb/dry-auto_inject/compare/v0.8.0...v0.9.0)
+
+## 0.8.0 2021-06-06
+
+
+### Added
+
+- Support For `...` passthrough-args (@ytaben)
+
+### Fixed
+
+- Constructors with kwargs strategy properly forward blocks to super (mintyfresh in [#68](https://github.com/dry-rb/dry-auto_inject/pull/68))
+
+### Changed
+
+- [BREAKING] Support for 2.4 and 2.5 was dropped
+
+[Compare v0.7.0...v0.8.0](https://github.com/dry-rb/dry-auto_inject/compare/v0.7.0...v0.8.0)
+
+## 0.7.0 2019-12-28
+
 
 ### Fixed
 
@@ -10,19 +42,18 @@
 
 [Compare v0.6.1...v0.7.0](https://github.com/dry-rb/dry-auto_inject/compare/v0.6.1...v0.7.0)
 
-# 0.6.1 / 2019-04-16
+## 0.6.1 2019-04-16
+
 
 ### Fixed
 
 - Allow explicit injection of falsey values (timriley in [#58](https://github.com/dry-rb/dry-auto_inject/pull/58))
 
-[Compare v0.6.0...v0.6.1](https://github.com/dry-rb/dry-auto_inject/compare/v0.6.0...v0.6.1)
 
-# 0.6.0 / 2018-11-29
+[Compare v0.6.0...v0.6.1](https://github.com/dry-rb/dry-auto_inject/compare/v0.6.0...v0.6.1)
 
-### Changed
+## 0.6.0 2018-11-29
 
-- [BREAKING] 0.6.0 supports Ruby 2.3 and above. If you're on 2.3 keep in mind its EOL is scheduled at the end of March, 2019
 
 ### Added
 
@@ -32,9 +63,14 @@
 
 - A couple of regressions were fixed along the way, see [#46](https://github.com/dry-rb/dry-auto_inject/issues/46) and [#49](https://github.com/dry-rb/dry-auto_inject/issues/49) (flash-gordon + timriley in [#48](https://github.com/dry-rb/dry-auto_inject/pull/48))
 
+### Changed
+
+- [BREAKING] 0.6.0 supports Ruby 2.3 and above. If you're on 2.3 keep in mind its EOL is scheduled at the end of March, 2019
+
 [Compare v0.5.0...v0.6.0](https://github.com/dry-rb/dry-auto_inject/compare/v0.5.0...v0.6.0)
 
-# 0.5.0 / 2018-11-09
+## 0.5.0 2018-11-09
+
 
 ### Changed
 
@@ -72,7 +108,8 @@
 
 [Compare v0.4.6...v0.5.0](https://github.com/dry-rb/dry-auto_inject/compare/v0.4.6...v0.5.0)
 
-# 0.4.6 / 2018-03-27
+## 0.4.6 2018-03-27
+
 
 ### Changed
 
@@ -80,37 +117,48 @@
 
 [Compare v0.4.5...v0.4.6](https://github.com/dry-rb/dry-auto_inject/compare/v0.4.5...v0.4.6)
 
-# 0.4.5 / 2018-01-02
+## 0.4.5 2018-01-02
+
 
 ### Added
 
 - Improved handling of kwargs being passed to #initialize’s super method (timriley)
 
+
 [Compare v0.4.4...v0.4.5](https://github.com/dry-rb/dry-auto_inject/compare/v0.4.4...v0.4.5)
 
-# 0.4.4 / 2017-09-14
+## 0.4.4 2017-09-14
+
 
 ### Added
 
 - Determine name for dependencies by splitting identifiers on any invalid local variable name characters (e.g. "/", "?", "!"), instead of splitting on dots only (raventid in [#39](https://github.com/dry-rb/dry-auto_inject/pull/39))
 
-# 0.4.3 / 2017-05-27
+
+[Compare v0.4.3...v0.4.4](https://github.com/dry-rb/dry-auto_inject/compare/v0.4.3...v0.4.4)
+
+## 0.4.3 2017-05-27
+
 
 ### Added
 
 - Push sequential arguments along with keywords in the kwargs strategy (hbda + vladra in [#32](https://github.com/dry-rb/dry-auto_inject/pull/32))
 
+
 [Compare v0.4.2...v0.4.3](https://github.com/dry-rb/dry-auto_inject/compare/v0.4.2...v0.4.3)
 
-# 0.4.2 / 2016-10-10
+## 0.4.2 2016-10-10
+
 
 ### Fixed
 
 - Fixed issue where injectors for different containers could not be used on different classes in an inheritance hierarchy (timriley in [#31](https://github.com/dry-rb/dry-auto_inject/pull/31))
 
+
 [Compare v0.4.1...v0.4.2](https://github.com/dry-rb/dry-auto_inject/compare/v0.4.1...v0.4.2)
 
-# 0.4.1 / 2016-08-14
+## 0.4.1 2016-08-14
+
 
 ### Changed
 
@@ -118,7 +166,8 @@
 
 [Compare v0.4.0...v0.4.1](https://github.com/dry-rb/dry-auto_inject/compare/v0.4.0...v0.4.1)
 
-# 0.4.0 / 2016-07-26
+## 0.4.0 2016-07-26
+
 
 ### Added
 
@@ -139,17 +188,18 @@
   end
   ```
 
+### Fixed
+
+- Fixed issue with kwargs injectors used at multiple points in a class inheritance heirarchy (flash-gordon in [#27](https://github.com/dry-rb/dry-auto_inject/pull/27))
+
 ### Changed
 
 - Use a `BasicObject`-based environment for the injector builder API instead of the previous `define_singleton_method`-based approach, which had negative performance characteristics (timriley in [#26](https://github.com/dry-rb/dry-auto_inject/pull/26))
 
-### Fixed
-
-- Fixed issue with kwargs injectors used at multiple points in a class inheritance heirarchy (flash-gordon in [#27](https://github.com/dry-rb/dry-auto_inject/pull/27))
+[Compare v0.3.0,...v0.4.0](https://github.com/dry-rb/dry-auto_inject/compare/v0.3.0,...v0.4.0)
 
-[Compare v0.3.0...v0.4.0](https://github.com/dry-rb/dry-auto_inject/compare/v0.3.0...v0.4.0)
+## 0.3.0, 2016-06-02
 
-# 0.3.0, 2016-06-02
 
 ### Added
 
@@ -164,7 +214,6 @@
     include MyInject.hash["my_dep"]
   end
   ```
-
 - Support for user-provided injection strategies
 
   All injection strategies are now held in their own `Dry::AutoInject::Strategies` container. You can add register your own strategies to this container, or choose to provide a strategies container of your own:
@@ -206,7 +255,6 @@
     include MyInject.custom["my_dep"]
   end
   ```
-
 - User-specified aliases for dependencies
 
   These aliases enable you to specify your own name for dependencies, both for their local readers and their keys in the kwargs- and hash-based initializers. Specify aliases by passing a hash of names:
@@ -229,7 +277,6 @@
   ```ruby
   include MyInject["some_dep", another_dep: "some_other.dep"]
   ```
-
 - Inspect the `super` method of the including class’s `#initialize` and send it arguments that will match its own arguments list/arity. This allows auto_inject to be used more easily in existing class inheritance heirarchies.
 
 ### Changed
@@ -237,21 +284,25 @@
 - `kwargs` is the new default injection strategy
 - Rubinius support is not available for the `kwargs` strategy (see [#18](https://github.com/dry-rb/dry-auto_inject/issues/18))
 
-[Compare v0.2.0...v0.3.0](https://github.com/dry-rb/dry-auto_inject/compare/v0.2.0...v0.3.0)
+[Compare v0.2.0...v0.3.0,](https://github.com/dry-rb/dry-auto_inject/compare/v0.2.0...v0.3.0,)
+
+## 0.2.0 2016-02-09
 
-# v0.2.0 2016-02-09
 
 ### Added
 
 - Support for hashes as constructor arguments via `Import.hash` interface (solnic)
 
+
 [Compare v0.1.0...v0.2.0](https://github.com/dry-rb/dry-auto_inject/compare/v0.1.0...v0.2.0)
 
-# v0.1.0 2015-11-12
+## 0.1.0 2015-11-12
 
 Changed interface from `Dry::AutoInject.new { container(some_container) }` to
-`Dry::AutoInject(some_container)`.
 
-# v0.0.1 2015-08-20
+
+[Compare v0.0.1...v0.1.0](https://github.com/dry-rb/dry-auto_inject/compare/v0.0.1...v0.1.0)
+
+## 0.0.1 2015-08-20
 
 First public release \o/

data/LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2015-2019 dry-rb team
+Copyright (c) 2015-2021 dry-rb team
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of
 this software and associated documentation files (the "Software"), to deal in

data/README.md

@@ -1,58 +1,30 @@
+<!--- this file is synced from dry-rb/template-gem project -->
 [gem]: https://rubygems.org/gems/dry-auto_inject
-[ci]: https://github.com/dry-rb/dry-auto_inject/actions?query=workflow%3Aci
-[codeclimate]: https://codeclimate.com/github/dry-rb/dry-auto_inject
-[coveralls]: https://coveralls.io/r/dry-rb/dry-auto_inject
-[inchpages]: http://inch-ci.org/github/dry-rb/dry-auto_inject
+[actions]: https://github.com/dry-rb/dry-auto_inject/actions
+[codacy]: https://www.codacy.com/gh/dry-rb/dry-auto_inject
 [chat]: https://dry-rb.zulipchat.com
+[inchpages]: http://inch-ci.org/github/dry-rb/dry-auto_inject
 
 # dry-auto_inject [![Join the chat at https://dry-rb.zulipchat.com](https://img.shields.io/badge/dry--rb-join%20chat-%23346b7a.svg)][chat]
 
 [![Gem Version](https://badge.fury.io/rb/dry-auto_inject.svg)][gem]
-[![Build Status](https://github.com/dry-rb/dry-auto_inject/workflows/ci/badge.svg)][ci]
-[![Code Climate](https://codeclimate.com/github/dry-rb/dry-auto_inject/badges/gpa.svg)][codeclimate]
-[![Test Coverage](https://codeclimate.com/github/dry-rb/dry-auto_inject/badges/coverage.svg)][codeclimate]
+[![CI Status](https://github.com/dry-rb/dry-auto_inject/workflows/ci/badge.svg)][actions]
+[![Codacy Badge](https://api.codacy.com/project/badge/Grade/d869ec8dc92e46b6a6eafa551f68c3f4)][codacy]
+[![Codacy Badge](https://api.codacy.com/project/badge/Coverage/d869ec8dc92e46b6a6eafa551f68c3f4)][codacy]
 [![Inline docs](http://inch-ci.org/github/dry-rb/dry-auto_inject.svg?branch=master)][inchpages]
-![No monkey-patches](https://img.shields.io/badge/monkey--patches-0-brightgreen.svg)
-
-A simple extension which allows you to automatically inject dependencies to your
-object constructors from a configured container.
-
-It does 3 things:
-
-- Defines a constructor which accepts dependencies
-- Defines attribute readers for dependencies
-- Injects dependencies automatically to the constructor with overridden `.new`
-
-## Installation
-
-Add this line to your application's Gemfile:
-
-```ruby
-gem 'dry-auto_inject'
-```
-
-And then execute:
-
-```sh
-$ bundle
-```
-
-Or install it yourself as:
-
-```sh
-$ gem install dry-auto_inject
-```
 
 ## Links
 
-- [Documentation](http://dry-rb.org/gems/dry-auto_inject/)
+* [User documentation](https://dry-rb.org/gems/dry-auto_inject)
+* [API documentation](http://rubydoc.info/gems/dry-auto_inject)
 
-## Development
+## Supported Ruby versions
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+This library officially supports the following Ruby versions:
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+* MRI `>= 2.7.0`
+* jruby `>= 9.3` (postponed until 2.7 is supported)
 
-## Contributing
+## License
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/dry-rb/dry-auto_inject.
+See `LICENSE` file.

data/dry-auto_inject.gemspec

@@ -1,29 +1,37 @@
 # frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+# this file is synced from dry-rb/template-gem project
+
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'dry/auto_inject/version'
+require "dry/auto_inject/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = 'dry-auto_inject'
+  spec.name          = "dry-auto_inject"
+  spec.authors       = ["Piotr Solnica"]
+  spec.email         = ["piotr.solnica@gmail.com"]
+  spec.license       = "MIT"
   spec.version       = Dry::AutoInject::VERSION.dup
-  spec.authors       = ['Piotr Solnica']
-  spec.email         = ['piotr.solnica@gmail.com']
-  spec.license       = 'MIT'
 
-  spec.summary       = 'Container-agnostic automatic constructor injection'
-  spec.homepage      = 'https://github.com/dry-rb/dry-auto_inject'
+  spec.summary       = "Container-agnostic automatic constructor injection"
+  spec.description   = spec.summary
+  spec.homepage      = "https://dry-rb.org/gems/dry-auto_inject"
+  spec.files         = Dir["CHANGELOG.md", "LICENSE", "README.md", "dry-auto_inject.gemspec", "lib/**/*"]
+  spec.bindir        = "bin"
+  spec.executables   = []
+  spec.require_paths = ["lib"]
 
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  spec.bindir        = 'exe'
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ['lib']
+  spec.metadata["allowed_push_host"] = "https://rubygems.org"
+  spec.metadata["changelog_uri"]     = "https://github.com/dry-rb/dry-auto_inject/blob/master/CHANGELOG.md"
+  spec.metadata["source_code_uri"]   = "https://github.com/dry-rb/dry-auto_inject"
+  spec.metadata["bug_tracker_uri"]   = "https://github.com/dry-rb/dry-auto_inject/issues"
 
-  spec.required_ruby_version = '>= 2.4.0'
+  spec.required_ruby_version = ">= 2.7.0"
 
-  spec.add_runtime_dependency 'dry-container', '>= 0.3.4'
+  # to update dependencies edit project.yml
+  spec.add_runtime_dependency "dry-container", ">= 0.3.4"
 
-  spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rspec', '~> 3.8'
+  spec.add_development_dependency "bundler"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rspec"
 end

data/lib/dry/auto_inject/builder.rb

@@ -1,17 +1,20 @@
 # frozen_string_literal: true
 
-require 'dry/auto_inject/strategies'
-require 'dry/auto_inject/injector'
+require "dry/auto_inject/strategies"
+require "dry/auto_inject/injector"
 
 module Dry
   module AutoInject
-    class Builder < BasicObject
+    class Builder
       # @api private
       attr_reader :container
 
       # @api private
       attr_reader :strategies
 
+      # This clashes with the hash strategy
+      undef hash
+
       def initialize(container, options = {})
         @container = container
         @strategies = options.fetch(:strategies) { Strategies }
@@ -22,8 +25,8 @@ module Dry
         default[*dependency_names]
       end
 
-      def respond_to?(name, include_private = false)
-        Builder.public_instance_methods.include?(name) || strategies.key?(name)
+      def respond_to_missing?(name, _include_private = false)
+        strategies.key?(name)
       end
 
       private

data/lib/dry/auto_inject/dependency_map.rb

@@ -5,7 +5,7 @@ module Dry
     DuplicateDependencyError = Class.new(StandardError)
     DependencyNameInvalid = Class.new(StandardError)
 
-    VALID_NAME = /([a-z_][a-zA-Z_0-9]*)$/
+    VALID_NAME = /([a-z_][a-zA-Z_0-9]*)$/.freeze
 
     class DependencyMap
       def initialize(*dependencies)
@@ -41,13 +41,18 @@ module Dry
 
       def name_for(identifier)
         matched = VALID_NAME.match(identifier.to_s)
-        raise DependencyNameInvalid, "name +#{identifier}+ is not a valid Ruby identifier" unless matched
+        unless matched
+          raise DependencyNameInvalid,
+                "name +#{identifier}+ is not a valid Ruby identifier"
+        end
+
         matched[0]
       end
 
       def add_dependency(name, identifier)
         name = name.to_sym
         raise DuplicateDependencyError, "name +#{name}+ is already used" if @map.key?(name)
+
         @map[name] = identifier
       end
     end

data/lib/dry/auto_inject/injector.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'dry/auto_inject/strategies'
+require "dry/auto_inject/strategies"
 
 module Dry
   module AutoInject
@@ -14,6 +14,8 @@ module Dry
       # @api private
       attr_reader :builder
 
+      define_method(:respond_to?, ::Kernel.instance_method(:respond_to?))
+
       # @api private
       def initialize(container, strategy, builder:)
         @container = container
@@ -25,13 +27,13 @@ module Dry
         strategy.new(container, *dependency_names)
       end
 
-      def respond_to?(name, include_private = false)
-        Injector.instance_methods.include?(name) || builder.respond_to?(name)
+      def respond_to_missing?(name, _include_private = false)
+        builder.respond_to?(name)
       end
 
       private
 
-      def method_missing(name, *args, &block)
+      def method_missing(name, *_args)
         builder.__send__(name)
       end
     end

data/lib/dry/auto_inject/method_parameters.rb

@@ -1,47 +1,25 @@
-require 'set'
+# frozen_string_literal: true
+
+require "set"
 
 module Dry
   module AutoInject
     # @api private
     class MethodParameters
-      PASS_THROUGH = [[:rest]]
-
-      if RUBY_VERSION >= '2.4.4.' && !defined? JRUBY_VERSION
-        def self.of(obj, name)
-          Enumerator.new do |y|
-            begin
-              method = obj.instance_method(name)
-            rescue NameError
-            end
-
-            loop do
-              break if method.nil?
-
-              y << MethodParameters.new(method.parameters)
-              method = method.super_method
-            end
+      PASS_THROUGH = [[%i[rest]], [%i[rest], %i[keyrest]]].freeze
+
+      def self.of(obj, name)
+        Enumerator.new do |y|
+          begin
+            method = obj.instance_method(name)
+          rescue ::NameError # rubocop: disable Lint/SuppressedException
           end
-        end
-      else
-        # see https://bugs.ruby-lang.org/issues/13973
-        def self.of(obj, name)
-          Enumerator.new do |y|
-            ancestors = obj.ancestors
-
-            loop do
-              klass = ancestors.shift
-              break if klass.nil?
-
-              begin
-                method = klass.instance_method(name)
-
-                next unless method.owner.equal?(klass)
-              rescue NameError
-                next
-              end
-
-              y << MethodParameters.new(method.parameters)
-            end
+
+          loop do
+            break if method.nil?
+
+            y << MethodParameters.new(method.parameters)
+            method = method.super_method
           end
         end
       end
@@ -54,11 +32,13 @@ module Dry
 
       def splat?
         return @splat if defined? @splat
+
         @splat = parameters.any? { |type, _| type == :rest }
       end
 
       def sequential_arguments?
         return @sequential_arguments if defined? @sequential_arguments
+
         @sequential_arguments = parameters.any? { |type, _|
           type == :req || type == :opt
         }
@@ -83,7 +63,7 @@ module Dry
       end
 
       def pass_through?
-        parameters.eql?(PASS_THROUGH)
+        PASS_THROUGH.include?(parameters)
       end
 
       EMPTY = new([])

data/lib/dry/auto_inject/strategies/args.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require 'dry/auto_inject/strategies/constructor'
-require 'dry/auto_inject/method_parameters'
+require "dry/auto_inject/strategies/constructor"
+require "dry/auto_inject/method_parameters"
 
 module Dry
   module AutoInject
@@ -17,7 +17,7 @@ module Dry
                 args[i] || container[identifier]
               }
 
-              super(*deps, *args[deps.size..-1])
+              super(*deps, *args[deps.size..])
             end
           end
         end
@@ -36,28 +36,35 @@ module Dry
         end
 
         def define_initialize_with_params
-          initialize_args = dependency_map.names.join(', ')
+          initialize_args = dependency_map.names.join(", ")
+
+          assignment = dependency_map.names.map { "@#{_1} = #{_1}" }.join("\n")
 
           instance_mod.class_eval <<-RUBY, __FILE__, __LINE__ + 1
-            def initialize(#{initialize_args})
-              #{dependency_map.names.map { |name| "@#{name} = #{name}" }.join("\n")}
-              super()
-            end
+            def initialize(#{initialize_args})  # def initialize(dep)
+              #{assignment}                     #   @dep = dep
+              super()                           #   super()
+            end                                 # end
           RUBY
         end
 
         def define_initialize_with_splat(super_parameters)
           super_pass = if super_parameters.splat?
-            '*args'
-          else
-            "*args.take(#{super_parameters.length})"
+                         "*args"
+                       else
+                         "*args.take(#{super_parameters.length})"
+                       end
+
+          assignments = dependency_map.names.map.with_index do |name, idx|
+            "@#{name} = args[#{idx}]"
           end
+          body = assignments.join("\n")
 
           instance_mod.class_eval <<-RUBY, __FILE__, __LINE__ + 1
-            def initialize(*args)
-              #{dependency_map.names.map.with_index { |name, i| "@#{name} = args[#{i}]" }.join("\n")}
-              super(#{super_pass})
-            end
+            def initialize(*args)    # def initialize(*args)
+              #{body}                #   @dep = args[0]
+              super(#{super_pass})   #   super(*args)
+            end                      # end
           RUBY
         end
       end

data/lib/dry/auto_inject/strategies/constructor.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'dry/auto_inject/dependency_map'
+require "dry/auto_inject/dependency_map"
 
 module Dry
   module AutoInject
@@ -15,6 +15,7 @@ module Dry
         attr_reader :class_mod
 
         def initialize(container, *dependency_names)
+          super()
           @container = container
           @dependency_map = DependencyMap.new(*dependency_names)
           @instance_mod = InstanceMethods.new
@@ -37,8 +38,9 @@ module Dry
         private
 
         def define_readers
+          readers = dependency_map.names.map { ":#{_1}" }
           instance_mod.class_eval <<-RUBY, __FILE__, __LINE__ + 1
-            attr_reader #{dependency_map.names.map { |name| ":#{name}" }.join(', ')}
+            attr_reader #{readers.join(", ")} # attr_reader :dep1, :dep2
           RUBY
           self
         end
@@ -47,7 +49,7 @@ module Dry
           raise NotImplementedError, "must be implemented by a subclass"
         end
 
-        def define_initialize(klass)
+        def define_initialize(_klass)
           raise NotImplementedError, "must be implemented by a subclass"
         end
       end