dropsonde 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0ac6f28ed9d64982c400f6a7460b57f44396020e6f17f04f587cc6e5007ff115
-  data.tar.gz: ef5a2ac1957b4b45c756b0e4bbc5ae66291706afabd3a7b80e899702f8aa6757
+  metadata.gz: a0fd6246263a8a375056fe6fdcb3bcc6b1db8cc6bddc7ea80f9dc870b48c85bc
+  data.tar.gz: b19a11ca730df12f61e95ae1f7bb81b9bbb65d8251966f3bcdd1fb203dacb96d
 SHA512:
-  metadata.gz: d9bda687091ec5a1d6bd8ca7e5f1414e2c489e3a1c66a970b879d7f6a2d6ab82e11f079eebfea13ed7a710ebe20b4c0aefd0a08f1af17547e3a5cd120c587847
-  data.tar.gz: e96d699c38c0d158bce376f13d77d9bafa3ef5d4020e104d32694df04fcc68c91bb458d2bb858f9d120dc5b9146ffd3bfde450535cfe0b971b331b349e7dc78b
+  metadata.gz: 53c7d74ceb0aa6358ddb12828faf70b840a33a4bbd30977317023050833a5db24d2b72eefc1eecfc1008e6e8eae80249b93a710edc098045c333787e4faa0ef2
+  data.tar.gz: 6644219dfdcbf761cb2c85bf446266ddf38d343d7a84d969ae88ffb30068c5faa647393457e1e255cd5fcbc2b8acb58f52d9efcd539c5713541932df79f0a807

data/lib/dropsonde/metrics.rb

@@ -51,7 +51,7 @@ class Dropsonde::Metrics
       schema = plugin.schema
 
       plugin.setup
-      data = sanity_check_data(plugin)
+      data = sanity_check_data(plugin, plugin.run)
       plugin.cleanup
 
       str << plugin.name+"\n"

data/lib/dropsonde/metrics/modules.rb

@@ -86,18 +86,21 @@ class Dropsonde::Metrics::Modules
     if Dropsonde.puppetDB
       # classes and how many nodes they're enforced on
       results = Dropsonde.puppetDB.request( '',
-        'resources[certname, type, title] { type = "Class" }'
+        'resources[type, title] { type = "Class" }'
       ).data
 
-      # select only classes from public modules
-      classes = results.map do |klass|
-        next unless modules.find {|mod| mod[:name] == klass['title'].split('::').first.downcase }
+      # select only classes from public modules.
+      # Use uniq to reduce the iteration over very large datasets
+      classes = results.uniq.map do |klass|
+        title   = klass['title']
+        modname = title.split('::').first.downcase
+        next unless modules.find {|mod| mod[:name] == modname }
 
         {
-          :name  => klass['title'],
-          :count => results.count {|row| row['title'] == klass['title']},
+          :name  => title,
+          :count => results.count {|row| row['title'] == title},
         }
-      end.compact.uniq
+      end.compact
     else
       classes = []
     end

data/lib/dropsonde/version.rb

@@ -1,3 +1,3 @@
 class Dropsonde
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dropsonde
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Ben Ford
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-24 00:00:00.000000000 Z
+date: 2020-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json