droplet_kit 1.2.3 → 1.3.0

data/spec/lib/droplet_kit/resources/account_resource_spec.rb

@@ -18,7 +18,12 @@ RSpec.describe DropletKit::AccountResource do
       expect(account_info.email).to eq(parsed['account']['email'])
       expect(account_info.uuid).to eq(parsed['account']['uuid'])
       expect(account_info.email_verified).to eq(parsed['account']['email_verified'])
+    end
 
+    it_behaves_like 'resource that handles common errors' do
+      let(:path) { '/v2/account' }
+      let(:method) { :get }
+      let(:action) { :info }
     end
   end
 end

data/spec/lib/droplet_kit/resources/action_resource_spec.rb

@@ -72,5 +72,12 @@ RSpec.describe DropletKit::ActionResource do
       expect(action.region.available).to be(true)
       expect(action.region.features).to include("virtio", "private_networking", "backups", "ipv6", "metadata")
     end
+
+    it_behaves_like 'resource that handles common errors' do
+      let(:path) { '/v2/actions/123' }
+      let(:method) { :get }
+      let(:action) { :find }
+      let(:arguments) { { id: 123 } }
+    end
   end
 end

data/spec/lib/droplet_kit/resources/domain_record_resource_spec.rb

@@ -31,10 +31,10 @@ RSpec.describe DropletKit::DomainRecordResource do
         name: 'www',
         data: '@'
       )
-      as_hash = DropletKit::DomainRecordMapping.representation_for(:create, domain_record, NullHashLoad)
-      expect(as_hash[:type]).to eq('CNAME')
-      expect(as_hash[:name]).to eq('www')
-      expect(as_hash[:data]).to eq('@')
+      as_hash = DropletKit::DomainRecordMapping.hash_for(:create, domain_record)
+      expect(as_hash['type']).to eq('CNAME')
+      expect(as_hash['name']).to eq('www')
+      expect(as_hash['data']).to eq('@')
 
       as_json = DropletKit::DomainRecordMapping.representation_for(:create, domain_record)
       stub_do_api('/v2/domains/example.com/records', :post).with(body: as_json).to_return(body: response, status: 201)
@@ -55,6 +55,13 @@ RSpec.describe DropletKit::DomainRecordResource do
       expected_record = DropletKit::DomainRecordMapping.extract_single(response, :read)
       expect(resource.find(id: 12, for_domain: 'example.com')).to eq(expected_record)
     end
+
+    it_behaves_like 'resource that handles common errors' do
+      let(:path) { '/v2/domains/example.com/records/12' }
+      let(:method) { :get }
+      let(:action) { :find }
+      let(:arguments) { { for_domain: 'example.com', id: 123 } }
+    end
   end
 
   describe '#delete' do
@@ -71,8 +78,8 @@ RSpec.describe DropletKit::DomainRecordResource do
       response = api_fixture('domain_records/update')
 
       domain_record = DropletKit::DomainRecord.new(name: 'lol')
-      as_hash = DropletKit::DomainRecordMapping.representation_for(:update, domain_record, NullHashLoad)
-      expect(as_hash[:name]).to eq('lol')
+      as_hash = DropletKit::DomainRecordMapping.hash_for(:update, domain_record)
+      expect(as_hash['name']).to eq('lol')
 
       as_json = DropletKit::DomainRecordMapping.representation_for(:update, domain_record)
       request = stub_do_api('/v2/domains/example.com/records/1066', :put).with(body: as_json).to_return(body: response, status: 200)

data/spec/lib/droplet_kit/resources/domain_resource_spec.rb

@@ -24,9 +24,9 @@ RSpec.describe DropletKit::DomainResource do
       response = api_fixture('domains/create')
 
       domain = DropletKit::Domain.new(ip_address: '1.1.1.1', name: 'example.com')
-      as_hash = DropletKit::DomainMapping.representation_for(:create, domain, NullHashLoad)
-      expect(as_hash[:ip_address]).to eq('1.1.1.1')
-      expect(as_hash[:name]).to eq('example.com')
+      as_hash = DropletKit::DomainMapping.hash_for(:create, domain)
+      expect(as_hash['ip_address']).to eq('1.1.1.1')
+      expect(as_hash['name']).to eq('example.com')
 
       as_json = DropletKit::DomainMapping.representation_for(:create, domain)
       stub_do_api('/v2/domains', :post).with(body: as_json).to_return(body: response, status: 201)
@@ -46,6 +46,13 @@ RSpec.describe DropletKit::DomainResource do
 
       expect(resource.find(name: 'example.com')).to eq(expected_domain)
     end
+
+    it_behaves_like 'resource that handles common errors' do
+      let(:path) { '/v2/domains/example.com' }
+      let(:method) { :get }
+      let(:action) { :find }
+      let(:arguments) { { name: 'example.com' } }
+    end
   end
 
   describe '#delete' do

data/spec/lib/droplet_kit/resources/droplet_action_resource_spec.rb

@@ -3,27 +3,8 @@ require 'spec_helper'
 RSpec.describe DropletKit::DropletActionResource do
   subject(:resource) { described_class.new(connection: connection) }
   let(:droplet_id) { 1066 }
-  def json
-    {
-      "action" => {
-        "id" => 2,
-        "status" => "in-progress",
-        "type" => action,
-        "started_at" => "2014-07-29T14:35:27Z",
-        "completed_at" => nil,
-        "resource_id" => 12,
-        "resource_type" => "droplet",
-        "region_slug" => "nyc1",
-        "region" => {
-          "name" => "New York",
-          "slug" => "nyc1",
-          "available" => true,
-          "sizes" => ["512mb"],
-          "features" => ["virtio", "private_networking", "backups", "ipv6", "metadata"]
-        }
-      }
-    }.to_json
-  end
+
+  let(:fixture) { api_fixture("droplet_actions/#{action}") }
 
   include_context 'resources'
 
@@ -34,16 +15,22 @@ RSpec.describe DropletKit::DropletActionResource do
   ACTIONS_WITHOUT_INPUT.each do |action_name|
     describe "Action #{action_name}" do
       let(:action) { action_name }
+      let(:path) { "/v2/droplets/#{droplet_id}/actions" }
 
       it 'performs the action' do
-        request = stub_do_api("/v2/droplets/#{droplet_id}/actions", :post).with(
-          body: { type: action_name }.to_json
-        ).to_return(body: json, status: 201)
+        request = stub_do_api(path, :post).with(
+          body: { type: action }.to_json
+        ).to_return(body: fixture, status: 201)
 
-        returned_action = resource.send(action_name, droplet_id: droplet_id)
+        returned_action = resource.send(action, droplet_id: droplet_id)
 
         expect(request).to have_been_made
-        expect(returned_action.type).to eq(action_name)
+        expect(returned_action.type).to eq(action)
+      end
+
+      it_behaves_like 'an action that handles invalid parameters' do
+        let(:object) { DropletKit::Droplet.new }
+        let(:arguments) { { droplet_id: droplet_id } }
       end
     end
   end
@@ -54,7 +41,7 @@ RSpec.describe DropletKit::DropletActionResource do
     it 'performs the action' do
       request = stub_do_api("/v2/droplets/#{droplet_id}/actions", :post).with(
         body: { type: action, name: 'Dwight' }.to_json
-      ).to_return(body: json, status: 201)
+      ).to_return(body: fixture, status: 201)
 
       returned_action = resource.send(action, droplet_id: droplet_id, name: 'Dwight')
 
@@ -69,7 +56,7 @@ RSpec.describe DropletKit::DropletActionResource do
     it 'performs the action' do
       request = stub_do_api("/v2/droplets/#{droplet_id}/actions", :post).with(
         body: { type: action, kernel: 1556 }.to_json
-      ).to_return(body: json, status: 201)
+      ).to_return(body: fixture, status: 201)
 
       returned_action = resource.send(action, droplet_id: droplet_id, kernel: 1556)
 
@@ -84,7 +71,7 @@ RSpec.describe DropletKit::DropletActionResource do
     it 'performs the action' do
       request = stub_do_api("/v2/droplets/#{droplet_id}/actions", :post).with(
         body: { type: action, name: 'newname.com' }.to_json
-      ).to_return(body: json, status: 201)
+      ).to_return(body: fixture, status: 201)
 
       returned_action = resource.send(action, droplet_id: droplet_id, name: 'newname.com')
 
@@ -99,7 +86,7 @@ RSpec.describe DropletKit::DropletActionResource do
     it 'performs the action' do
       request = stub_do_api("/v2/droplets/#{droplet_id}/actions", :post).with(
         body: { type: action, image: 'ubuntu-14-04-x86' }.to_json
-      ).to_return(body: json, status: 201)
+      ).to_return(body: fixture, status: 201)
 
       returned_action = resource.send(action, droplet_id: droplet_id, image: 'ubuntu-14-04-x86')
 
@@ -114,7 +101,7 @@ RSpec.describe DropletKit::DropletActionResource do
     it 'performs the action' do
       request = stub_do_api("/v2/droplets/#{droplet_id}/actions", :post).with(
         body: { type: action, image: 'ubuntu-14-04-x86' }.to_json
-      ).to_return(body: json, status: 201)
+      ).to_return(body: fixture, status: 201)
 
       returned_action = resource.send(action, droplet_id: droplet_id, image: 'ubuntu-14-04-x86')
 
@@ -129,7 +116,7 @@ RSpec.describe DropletKit::DropletActionResource do
     it 'performs the action' do
       request = stub_do_api("/v2/droplets/#{droplet_id}/actions", :post).with(
         body: { type: action, size: '1gb', disk: nil }.to_json
-      ).to_return(body: json, status: 201)
+      ).to_return(body: fixture, status: 201)
 
       returned_action = resource.send(action, droplet_id: droplet_id, size: '1gb')
 
@@ -144,7 +131,7 @@ RSpec.describe DropletKit::DropletActionResource do
     it 'performs the action' do
       request = stub_do_api("/v2/droplets/#{droplet_id}/actions", :post).with(
         body: { type: action, size: '1gb', disk: true }.to_json
-      ).to_return(body: json, status: 201)
+      ).to_return(body: fixture, status: 201)
 
       returned_action = resource.send(action, droplet_id: droplet_id, size: '1gb', disk: true)
 
@@ -156,7 +143,7 @@ RSpec.describe DropletKit::DropletActionResource do
   describe '#find' do
     it 'returns an action' do
       request = stub_do_api("/v2/droplets/1066/actions/123", :get).to_return(
-        body: api_fixture('actions/find')
+        body: api_fixture('droplet_actions/find')
       )
 
       returned_action = resource.find(droplet_id: 1066, id: 123)
@@ -176,5 +163,12 @@ RSpec.describe DropletKit::DropletActionResource do
       expect(returned_action.region.available).to be(true)
       expect(returned_action.region.features).to include("virtio", "private_networking", "backups", "ipv6", "metadata")
     end
+
+    it_behaves_like 'resource that handles common errors' do
+      let(:path) { '/v2/droplets/1066/actions/123' }
+      let(:method) { :get }
+      let(:action) { :find }
+      let(:arguments) { { droplet_id: 1066, id: 123 } }
+    end
   end
 end

data/spec/lib/droplet_kit/resources/droplet_resource_spec.rb

@@ -89,9 +89,18 @@ RSpec.describe DropletKit::DropletResource do
       expect(droplet).to be_kind_of(DropletKit::Droplet)
       check_droplet(droplet)
     end
+
+    it_behaves_like 'resource that handles common errors' do
+      let(:path) { '/v2/droplets/123' }
+      let(:method) { :get }
+      let(:action) { :find }
+      let(:arguments) { { id: 123 } }
+    end
   end
 
   describe '#create' do
+    let(:path) { '/v2/droplets' }
+
     context 'for a successful create' do
       it 'returns the created droplet' do
         droplet = DropletKit::Droplet.new(
@@ -106,32 +115,42 @@ RSpec.describe DropletKit::DropletResource do
           user_data: "#cloud-config\nruncmd\n\t- echo 'Hello!'"
         )
 
-        as_hash = DropletKit::DropletMapping.representation_for(:create, droplet, NullHashLoad)
-        expect(as_hash[:name]).to eq(droplet.name)
-        expect(as_hash[:region]).to eq(droplet.region)
-        expect(as_hash[:size]).to eq(droplet.size)
-        expect(as_hash[:image]).to eq(droplet.image)
-        expect(as_hash[:ssh_keys]).to eq(droplet.ssh_keys)
-        expect(as_hash[:backups]).to eq(droplet.backups)
-        expect(as_hash[:ipv6]).to eq(droplet.ipv6)
-        expect(as_hash[:private_networking]).to eq(droplet.private_networking)
-        expect(as_hash[:user_data]).to eq(droplet.user_data)
+        as_hash = DropletKit::DropletMapping.hash_for(:create, droplet)
+        expect(as_hash['name']).to eq(droplet.name)
+        expect(as_hash['region']).to eq(droplet.region)
+        expect(as_hash['size']).to eq(droplet.size)
+        expect(as_hash['image']).to eq(droplet.image)
+        expect(as_hash['ssh_keys']).to eq(droplet.ssh_keys)
+        expect(as_hash['backups']).to eq(droplet.backups)
+        expect(as_hash['ipv6']).to eq(droplet.ipv6)
+        expect(as_hash['private_networking']).to eq(droplet.private_networking)
+        expect(as_hash['user_data']).to eq(droplet.user_data)
 
         as_string = DropletKit::DropletMapping.representation_for(:create, droplet)
-        stub_do_api('/v2/droplets', :post).with(body: as_string).to_return(body: api_fixture('droplets/create'), status: 202)
+        stub_do_api(path, :post).with(body: as_string).to_return(body: api_fixture('droplets/create'), status: 202)
         created_droplet = resource.create(droplet)
         check_droplet(created_droplet)
       end
-    end
 
-    context 'for an unsuccessful create' do
-      it 'raises a FailedCreate exception with the message attached' do
-        response_body = { id: :unprocessable_entity, message: 'Something is not right' }
-        stub_do_api('/v2/droplets', :post).to_return(body: response_body.to_json, status: 422)
+      it 'reuses the same object' do
+        droplet = DropletKit::Droplet.new(
+          name: 'test.example.com',
+          region: 'nyc1',
+          size: '512mb',
+          image: 'ubuntu-14-04-x86'
+        )
 
-        expect { resource.create(DropletKit::Droplet.new) }.to raise_exception(DropletKit::FailedCreate).with_message(response_body[:message])
+        json = DropletKit::DropletMapping.representation_for(:create, droplet)
+        stub_do_api(path, :post).with(body: json).to_return(body: api_fixture('droplets/create'), status: 202)
+        created_droplet = resource.create(droplet)
+        expect(created_droplet).to be droplet
       end
     end
+
+    it_behaves_like 'an action that handles invalid parameters' do
+      let(:action) { 'create' }
+      let(:arguments) { DropletKit::Droplet.new }
+    end
   end
 
   describe '#kernels' do

data/spec/lib/droplet_kit/resources/droplet_upgrade_resource_spec.rb

@@ -12,5 +12,11 @@ RSpec.describe DropletKit::DropletUpgradeResource do
 
       expect(resource.all).to eq(expected)
     end
+
+    it_behaves_like 'resource that handles common errors' do
+      let(:path) { '/v2/droplet_upgrades' }
+      let(:method) { :get }
+      let(:action) { :all }
+    end
   end
 end

data/spec/lib/droplet_kit/resources/floating_ip_action_resource_spec.rb

@@ -0,0 +1,137 @@
+require 'spec_helper'
+
+RSpec.describe DropletKit::FloatingIpActionResource do
+  subject(:resource) { described_class.new(connection: connection) }
+  include_context 'resources'
+
+  describe '#assign' do
+    let(:ip) { '127.0.0.1' }
+    let(:droplet_id) { 123 }
+    let(:path) { "/v2/floating_ips/#{ip}/actions" }
+    let(:action) { 'assign' }
+    let(:fixture) { api_fixture("floating_ip_actions/#{action}") }
+
+    it 'sends an assign request for a floating ip' do
+      request = stub_do_api(path).with(
+        body: { type: action, droplet_id: droplet_id }.to_json
+      ).to_return(body: fixture, status: 201)
+
+      action = resource.assign(ip: ip, droplet_id: droplet_id)
+
+      expect(request).to have_been_made
+
+      expect(action).to be_kind_of(DropletKit::Action)
+      expect(action.id).to eq(2)
+      expect(action.status).to eq("in-progress")
+      expect(action.type).to eq("assign")
+      expect(action.started_at).to eq("2014-08-05T15:15:28Z")
+      expect(action.completed_at).to eq(nil)
+      expect(action.resource_id).to eq(12)
+      expect(action.resource_type).to eq("floating_ip")
+      expect(action.region_slug).to eq("nyc1")
+
+      expect(action.region).to be_kind_of(DropletKit::Region)
+      expect(action.region.slug).to eq('nyc1')
+      expect(action.region.name).to eq('New York')
+      expect(action.region.sizes).to include('512mb')
+      expect(action.region.available).to be(true)
+      expect(action.region.features).to include("virtio", "private_networking", "backups", "ipv6", "metadata")
+    end
+
+    it_behaves_like 'an action that handles invalid parameters' do
+      let(:arguments) { { ip: ip, droplet_id: droplet_id } }
+    end
+  end
+
+  describe '#unassign' do
+    let(:ip) { '127.0.0.1' }
+    let(:path) { "/v2/floating_ips/#{ip}/actions" }
+    let(:action) { 'unassign' }
+    let(:fixture) { api_fixture("floating_ip_actions/#{action}") }
+
+    it 'sends an unassign request for a floating ip' do
+      request = stub_do_api(path).with(
+        body: { type: action }.to_json
+      ).to_return(body: fixture, status: 201)
+
+      action = resource.unassign(ip: ip)
+
+      expect(request).to have_been_made
+
+      expect(action).to be_kind_of(DropletKit::Action)
+      expect(action.id).to eq(2)
+      expect(action.status).to eq("in-progress")
+      expect(action.type).to eq("unassign")
+      expect(action.started_at).to eq("2014-08-05T15:15:28Z")
+      expect(action.completed_at).to eq(nil)
+      expect(action.resource_id).to eq(12)
+      expect(action.resource_type).to eq("floating_ip")
+      expect(action.region_slug).to eq("nyc1")
+
+      expect(action.region).to be_kind_of(DropletKit::Region)
+      expect(action.region.slug).to eq('nyc1')
+      expect(action.region.name).to eq('New York')
+      expect(action.region.sizes).to include('512mb')
+      expect(action.region.available).to be(true)
+      expect(action.region.features).to include("virtio", "private_networking", "backups", "ipv6", "metadata")
+    end
+
+    it_behaves_like 'an action that handles invalid parameters' do
+      let(:arguments) { { ip: ip } }
+    end
+  end
+
+  describe '#all' do
+    let(:ip) { '127.0.0.1' }
+
+    it 'returns all of the floating ip actions via a paginated resources' do
+      request = stub_do_api("/v2/floating_ips/#{ip}/actions", :get).to_return(
+        body: api_fixture('floating_ip_actions/all'),
+        status: 200
+      )
+
+      actions = resource.all(ip: ip).take(20)
+
+      expect(request).to have_been_made
+
+      expect(actions.size).to be(2)
+
+      action = actions.first
+
+      expect(action.id).to eq(19)
+      expect(action.status).to eq("completed")
+      expect(action.type).to eq("assign_ip")
+      expect(action.started_at).to eq("2014-10-28T17:11:05Z")
+      expect(action.completed_at).to eq("2014-10-28T17:11:06Z")
+      expect(action.resource_id).to eq(45646587)
+      expect(action.resource_type).to eq("floating_ip")
+      expect(action.region).to be_kind_of(DropletKit::Region)
+      expect(action.region_slug).to eq("nyc1")
+    end
+
+    it_behaves_like 'a paginated index' do
+      let(:fixture_path) { 'floating_ip_actions/all' }
+      let(:api_path) { "/v2/floating_ips/#{ip}/actions" }
+      let(:parameters) { { ip: ip } }
+    end
+  end
+
+  describe '#find' do
+    let(:ip) { '127.0.0.1' }
+
+    it 'returns a single action' do
+      stub_do_api("/v2/floating_ips/#{ip}/actions/23", :get).to_return(body: api_fixture('floating_ip_actions/find'))
+      action = resource.find(ip: ip, id: 23)
+
+      expect(action.id).to eq(19)
+      expect(action.status).to eq("completed")
+      expect(action.type).to eq("assign_ip")
+      expect(action.started_at).to eq("2014-10-28T17:11:05Z")
+      expect(action.completed_at).to eq("2014-10-28T17:11:06Z")
+      expect(action.resource_id).to eq(45646587)
+      expect(action.resource_type).to eq("floating_ip")
+      expect(action.region).to be_kind_of(DropletKit::Region)
+      expect(action.region_slug).to eq("nyc1")
+    end
+  end
+end