dropcaster 0.0.6 → 1.2.0

data/test/unit/test_channel.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'helper'
 
 class TestChannel < MiniTest::Test
@@ -9,7 +11,7 @@ class TestChannel < MiniTest::Test
   end
 
   def test_item_count
-    assert_equal(1, @channel.items.size)
+    assert_equal(NUMBER_OF_MP3_FILES, @channel.items.size)
   end
 
   def test_channel
@@ -47,7 +49,9 @@ class TestChannel < MiniTest::Test
   end
 
   def test_channel_explicit_nil
-    assert_channel_explicit(nil, nil)
+    @options[:explicit] = nil
+    channel = Dropcaster::Channel.new(FIXTURES_DIR, @options)
+    assert_nil(channel.explicit)
   end
 
   def test_channel_explicit_clean
@@ -62,19 +66,19 @@ class TestChannel < MiniTest::Test
 
   def test_raise_on_missing_title
     assert_raises Dropcaster::MissingAttributeError do
-      Dropcaster::Channel.new(FIXTURES_DIR, {:url => 'bar', :description => 'foobar'})
+      Dropcaster::Channel.new(FIXTURES_DIR, { url: 'bar', description: 'foobar' })
     end
   end
 
   def test_raise_on_missing_url
     assert_raises Dropcaster::MissingAttributeError do
-      Dropcaster::Channel.new(FIXTURES_DIR, {:title => 'foo', :description => 'foobar'})
+      Dropcaster::Channel.new(FIXTURES_DIR, { title: 'foo', description: 'foobar' })
     end
   end
 
   def test_raise_on_missing_description
     assert_raises Dropcaster::MissingAttributeError do
-      Dropcaster::Channel.new(FIXTURES_DIR, {:title => 'foo', :url => 'bar'})
+      Dropcaster::Channel.new(FIXTURES_DIR, { title: 'foo', url: 'bar' })
     end
   end
 end

data/test/unit/test_channel_locator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'helper'
 require 'tmpdir'
 require 'pry'
@@ -8,6 +10,7 @@ class TestChannelLocator < MiniTest::Test
   def setup
     @temp_dir = Dir.mktmpdir
   end
+
   def teardown
     FileUtils.remove_entry_secure(@temp_dir)
   end
@@ -30,7 +33,7 @@ class TestChannelLocator < MiniTest::Test
   end
 
   def test_array_of_files_same_dir
-    sources = Array.new
+    sources = []
     sources << File.join(@temp_dir, 'file1.mp3')
     sources << File.join(@temp_dir, 'file2.mp3')
     sources << File.join(@temp_dir, 'file3.mp3')
@@ -39,7 +42,7 @@ class TestChannelLocator < MiniTest::Test
   end
 
   def test_array_of_files_different_dir
-    sources = Array.new
+    sources = []
     sources << File.join(@temp_dir, 'foo', 'file1.mp3')
     sources << File.join(@temp_dir, 'bar', 'file1.mp3')
     sources << File.join(@temp_dir, 'baz', 'file1.mp3')
@@ -54,9 +57,9 @@ class TestChannelLocator < MiniTest::Test
   end
 
   def test_array_with_more_than_a_single_directory
-    Dir.mktmpdir{|tmp_dir1|
-      Dir.mktmpdir{|tmp_dir2|
-        sources = Array.new
+    Dir.mktmpdir { |tmp_dir1|
+      Dir.mktmpdir { |tmp_dir2|
+        sources = []
         sources << File.join(tmp_dir1, 'another_dir')
         sources << File.join(tmp_dir2, 'another_dir')
 

data/test/unit/test_channel_xml.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'helper'
 require 'xml/libxml'
 require 'pry'
@@ -14,7 +16,7 @@ class TestChannelXML < MiniTest::Test
   # Returnes the XML node for the channel passed as XML string
   #
   def channel_node(rss)
-    XML::Document.string(rss).find("//rss/channel").first
+    XML::Document.string(rss).find('//rss/channel').first
   end
 
   #
@@ -27,11 +29,10 @@ class TestChannelXML < MiniTest::Test
     Dropcaster::Channel.new(FIXTURES_DIR, @options.dup).to_rss
   end
 
-  def test_item
-    item = @channel.find("item").first
+  def test_itunes_item
+    item = @channel.find('item[title = "iTunes Name"]').first
     assert(item)
 
-    assert_equal('iTunes Name', item.find('title').first.content)
     assert_equal('iTunes Artist', item.find('itunes:author', NS_ITUNES).first.content)
     assert_equal('iTunes Description (Video Pane)', item.find('itunes:summary', NS_ITUNES).first.content)
     assert_equal('http://www.example.com/podcasts/everything/AllAboutEverything.jpg', item.find('itunes:image', NS_ITUNES).first['href'])
@@ -51,12 +52,31 @@ class TestChannelXML < MiniTest::Test
     assert_equal('3', item.find('itunes:duration', NS_ITUNES).first.content)
   end
 
+  def test_special_ampersand_item
+    # in the actual XML, this is "special &amp;.mp3", but it gets interpreted by XML::Document
+    # if it was just "special &.mp3", it would be invalid XML and we wouldn't get this far
+    item = @channel.find('item[title = "test/fixtures/special &.mp3"]').first
+    assert(item)
+
+    enclosure = item.find('enclosure').first
+    assert(enclosure)
+    assert_equal('http://www.example.com/podcasts/everything/test/fixtures/special%20%26.mp3', enclosure['url'])
+  end
+
+  def test_uppercase_extension_item
+    item = @channel.find('item[title = "test/fixtures/extension.MP3"]').first
+    assert(item)
+
+    enclosure = item.find('enclosure').first
+    assert(enclosure)
+    assert_equal('http://www.example.com/podcasts/everything/test/fixtures/extension.MP3', enclosure['url'])
+  end
+
   def test_attributes_mandatory
-    options = {:title => 'Test Channel',
-               :url => 'http://www.example.com/',
-               :description => 'A test channel',
-               :enclosures_url => 'http://www.example.com/foo/bar',
-              }
+    options = { title: 'Test Channel',
+                url: 'http://www.example.com/',
+                description: 'A test channel',
+                enclosures_url: 'http://www.example.com/foo/bar' }
 
     channel = channel_node(Dropcaster::Channel.new(FIXTURES_DIR, options).to_rss)
     assert_equal('Test Channel', channel.find('title').first.content)

data/test/unit/{test_item.rb → test_itunes_item.rb}

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 require 'helper'
 
-class TestItem < MiniTest::Test
+class TestItunesItem < MiniTest::Test
   include DropcasterTest
 
   def setup
@@ -12,7 +14,7 @@ class TestItem < MiniTest::Test
     assert_equal(58119, @item.file_size)
     assert_equal('77bf84447c0f69ce4a33a18b0ae1e030b82010de', @item.uuid)
     assert_equal(File.mtime(FIXTURE_ITUNES_MP3).to_i, @item.pub_date.to_i)
-    assert_equal('test/fixtures/iTunes.mp3', @item.file_name)
+    assert_equal('test/fixtures/iTunes.mp3', @item.file_path.to_s)
   end
 
   def test_tag
@@ -38,14 +40,11 @@ class TestItem < MiniTest::Test
     assert_equal('iTunes Grouping', @item.tag2.TT1)
     assert_equal('iTunes Description (Video Pane)', @item.tag2.TT3)
     assert_equal('iTunes Composer', @item.tag2.TCM)
+    assert_equal('iTunes Comments (Info Pane)', @item.tag2.COM[1])
   end
 
   def test_lyrics
     assert_equal(1, @item.lyrics.size)
     assert_equal("iTunes Lyrics Line 1\niTunes Lyrics Line 2", @item.lyrics['eng'])
   end
-
-  def test_tag2_comment
-    assert_equal('iTunes Comments (Info Pane)', @item.tag2.COM[1])
-  end
 end

data/website/.gitignore

@@ -0,0 +1,2 @@
+_site
+.sass-cache

data/website/README.markdown

@@ -0,0 +1,8 @@
+Markdown pages are generated from the README.markdown etc. and then served my Jekyll. Therefore, after each change to the source files, we need to regenerate the pages using the following rake task:
+
+    rake clobber web:generate
+
+Run local test site:
+
+    # http://jekyllrb.com/docs/github-pages/
+    jekyll serve --baseurl ''

data/website/_config.yml

@@ -0,0 +1,14 @@
+# Site settings
+title: Dropcaster
+email: nerab@gmx.at
+description: > # this means to ignore newlines until "baseurl:"
+  Dropcaster is a podcast feed generator for the command line. It is most
+  simple to use with Dropbox, but works equally well with any other (static
+  file) web hoster.
+baseurl: "/dropcaster" # the subpath of your site, e.g. /blog/
+# url: "http://yourdomain.com" # the base hostname & protocol for your site
+# twitter_username: jekyllrb
+github_username:  nerab
+
+# Build settings
+markdown: kramdown

data/website/_front_matter/contributing.yaml

@@ -0,0 +1,5 @@
+---
+layout: page
+title: Contributing
+permalink: /contributing.html
+---

data/website/_front_matter/index.yaml

@@ -0,0 +1,3 @@
+---
+layout: page
+---

data/website/_front_matter/vision.yaml

@@ -0,0 +1,5 @@
+---
+layout: page
+title: Vision
+permalink: /vision.html
+---

data/website/_includes/footer.html

@@ -0,0 +1,55 @@
+<footer class="site-footer">
+
+  <div class="wrapper">
+
+    <h2 class="footer-heading">{{ site.title }}</h2>
+
+    <div class="footer-col-wrapper">
+      <div class="footer-col  footer-col-1">
+        <ul class="contact-list">
+          <li>{{ site.title }}</li>
+          <li><a href="mailto:{{ site.email }}">{{ site.email }}</a></li>
+        </ul>
+      </div>
+
+      <div class="footer-col  footer-col-2">
+        <ul class="social-media-list">
+          {% if site.github_username %}
+          <li>
+            <a href="https://github.com/{{ site.github_username }}">
+              <span class="icon  icon--github">
+                <svg viewBox="0 0 16 16">
+                  <path fill="#828282" d="M7.999,0.431c-4.285,0-7.76,3.474-7.76,7.761 c0,3.428,2.223,6.337,5.307,7.363c0.388,0.071,0.53-0.168,0.53-0.374c0-0.184-0.007-0.672-0.01-1.32 c-2.159,0.469-2.614-1.04-2.614-1.04c-0.353-0.896-0.862-1.135-0.862-1.135c-0.705-0.481,0.053-0.472,0.053-0.472 c0.779,0.055,1.189,0.8,1.189,0.8c0.692,1.186,1.816,0.843,2.258,0.645c0.071-0.502,0.271-0.843,0.493-1.037 C4.86,11.425,3.049,10.76,3.049,7.786c0-0.847,0.302-1.54,0.799-2.082C3.768,5.507,3.501,4.718,3.924,3.65 c0,0,0.652-0.209,2.134,0.796C6.677,4.273,7.34,4.187,8,4.184c0.659,0.003,1.323,0.089,1.943,0.261 c1.482-1.004,2.132-0.796,2.132-0.796c0.423,1.068,0.157,1.857,0.077,2.054c0.497,0.542,0.798,1.235,0.798,2.082 c0,2.981-1.814,3.637-3.543,3.829c0.279,0.24,0.527,0.713,0.527,1.437c0,1.037-0.01,1.874-0.01,2.129 c0,0.208,0.14,0.449,0.534,0.373c3.081-1.028,5.302-3.935,5.302-7.362C15.76,3.906,12.285,0.431,7.999,0.431z"/>
+                </svg>
+              </span>
+
+              <span class="username">{{ site.github_username }}</span>
+            </a>
+          </li>
+          {% endif %}
+
+          {% if site.twitter_username %}
+          <li>
+            <a href="https://twitter.com/{{ site.twitter_username }}">
+              <span class="icon  icon--twitter">
+                <svg viewBox="0 0 16 16">
+                  <path fill="#828282" d="M15.969,3.058c-0.586,0.26-1.217,0.436-1.878,0.515c0.675-0.405,1.194-1.045,1.438-1.809
+                  c-0.632,0.375-1.332,0.647-2.076,0.793c-0.596-0.636-1.446-1.033-2.387-1.033c-1.806,0-3.27,1.464-3.27,3.27 c0,0.256,0.029,0.506,0.085,0.745C5.163,5.404,2.753,4.102,1.14,2.124C0.859,2.607,0.698,3.168,0.698,3.767 c0,1.134,0.577,2.135,1.455,2.722C1.616,6.472,1.112,6.325,0.671,6.08c0,0.014,0,0.027,0,0.041c0,1.584,1.127,2.906,2.623,3.206 C3.02,9.402,2.731,9.442,2.433,9.442c-0.211,0-0.416-0.021-0.615-0.059c0.416,1.299,1.624,2.245,3.055,2.271 c-1.119,0.877-2.529,1.4-4.061,1.4c-0.264,0-0.524-0.015-0.78-0.046c1.447,0.928,3.166,1.469,5.013,1.469 c6.015,0,9.304-4.983,9.304-9.304c0-0.142-0.003-0.283-0.009-0.423C14.976,4.29,15.531,3.714,15.969,3.058z"/>
+                </svg>
+              </span>
+
+              <span class="username">{{ site.twitter_username }}</span>
+            </a>
+          </li>
+          {% endif %}
+        </ul>
+      </div>
+
+      <div class="footer-col  footer-col-3">
+        <p class="text">{{ site.description }}</p>
+      </div>
+    </div>
+
+  </div>
+
+</footer>

data/website/_includes/head.html

@@ -0,0 +1,11 @@
+<head>
+    <meta charset="utf-8">
+    <meta name="viewport" content="width=device-width initial-scale=1" />
+    <meta http-equiv="X-UA-Compatible" content="IE=edge">
+
+    <title>{{ site.title }}{% if page.title %} - {{ page.title }}{% endif %}</title>
+    <meta name="description" content="{{ site.description }}">
+
+    <link rel="stylesheet" href="{{ "/css/main.css" | prepend: site.baseurl }}">
+    <link rel="canonical" href="{{ page.url | replace:'index.html','' | prepend: site.baseurl | prepend: site.url }}">
+</head>

data/website/_includes/header.html

@@ -0,0 +1,27 @@
+<header class="site-header">
+
+  <div class="wrapper">
+
+    <a class="site-title" href="{{ site.baseurl }}/">{{ site.title }}</a>
+
+    <nav class="site-nav">
+      <a href="#" class="menu-icon">
+        <svg viewBox="0 0 18 15">
+          <path fill="#424242" d="M18,1.484c0,0.82-0.665,1.484-1.484,1.484H1.484C0.665,2.969,0,2.304,0,1.484l0,0C0,0.665,0.665,0,1.484,0 h15.031C17.335,0,18,0.665,18,1.484L18,1.484z"/>
+          <path fill="#424242" d="M18,7.516C18,8.335,17.335,9,16.516,9H1.484C0.665,9,0,8.335,0,7.516l0,0c0-0.82,0.665-1.484,1.484-1.484 h15.031C17.335,6.031,18,6.696,18,7.516L18,7.516z"/>
+          <path fill="#424242" d="M18,13.516C18,14.335,17.335,15,16.516,15H1.484C0.665,15,0,14.335,0,13.516l0,0 c0-0.82,0.665-1.484,1.484-1.484h15.031C17.335,12.031,18,12.696,18,13.516L18,13.516z"/>
+        </svg>
+      </a>
+
+      <div class="trigger">
+        {% for page in site.pages %}
+          {% if page.title %}
+          <a class="page-link" href="{{ page.url | prepend: site.baseurl }}">{{ page.title }}</a>
+          {% endif %}
+        {% endfor %}
+      </div>
+    </nav>
+
+  </div>
+
+</header>

data/website/_layouts/default.html

@@ -0,0 +1,20 @@
+<!DOCTYPE html>
+<html>
+
+  {% include head.html %}
+
+  <body>
+
+    {% include header.html %}
+
+    <div class="page-content">
+      <div class="wrapper">
+        {{ content }}
+      </div>
+    </div>
+
+    {% include footer.html %}
+
+  </body>
+
+</html>

data/website/_layouts/page.html

@@ -0,0 +1,14 @@
+---
+layout: default
+---
+<div class="post">
+
+  <header class="post-header">
+    <h1 class="post-title">{{ page.title }}</h1>
+  </header>
+
+  <article class="post-content">
+    {{ content }}
+  </article>
+
+</div>

data/website/_layouts/post.html

@@ -0,0 +1,15 @@
+---
+layout: default
+---
+<div class="post">
+
+  <header class="post-header">
+    <h1 class="post-title">{{ page.title }}</h1>
+    <p class="post-meta">{{ page.date | date: "%b %-d, %Y" }}{% if page.author %} • {{ page.author }}{% endif %}{% if page.meta %} • {{ page.meta }}{% endif %}</p>
+  </header>
+
+  <article class="post-content">
+    {{ content }}
+  </article>
+
+</div>

data/website/_sass/_base.scss

@@ -0,0 +1,204 @@
+/**
+ * Reset some basic elements
+ */
+body, h1, h2, h3, h4, h5, h6,
+p, blockquote, pre, hr,
+dl, dd, ol, ul, figure {
+    margin: 0;
+    padding: 0;
+}
+
+
+
+/**
+ * Basic styling
+ */
+body {
+    font-family: $base-font-family;
+    font-size: $base-font-size;
+    line-height: $base-line-height;
+    font-weight: 300;
+    color: $text-color;
+    background-color: $background-color;
+    -webkit-text-size-adjust: 100%;
+}
+
+
+
+/**
+ * Set `margin-bottom` to maintain vertical rhythm
+ */
+h1, h2, h3, h4, h5, h6,
+p, blockquote, pre,
+ul, ol, dl, figure,
+%vertical-rhythm {
+    margin-bottom: $spacing-unit / 2;
+}
+
+
+
+/**
+ * Images
+ */
+img {
+    max-width: 100%;
+    vertical-align: middle;
+}
+
+
+
+/**
+ * Figures
+ */
+figure > img {
+    display: block;
+}
+
+figcaption {
+    font-size: $small-font-size;
+}
+
+
+
+/**
+ * Lists
+ */
+ul, ol {
+    margin-left: $spacing-unit;
+}
+
+li {
+    > ul,
+    > ol {
+         margin-bottom: 0;
+    }
+}
+
+
+
+/**
+ * Headings
+ */
+h1, h2, h3, h4, h5, h6 {
+    font-weight: 300;
+}
+
+
+
+/**
+ * Links
+ */
+a {
+    color: $brand-color;
+    text-decoration: none;
+
+    &:visited {
+        color: darken($brand-color, 15%);
+    }
+
+    &:hover {
+        color: $text-color;
+        text-decoration: underline;
+    }
+}
+
+
+
+/**
+ * Blockquotes
+ */
+blockquote {
+    color: $grey-color;
+    border-left: 4px solid $grey-color-light;
+    padding-left: $spacing-unit / 2;
+    font-size: 18px;
+    letter-spacing: -1px;
+    font-style: italic;
+
+    > :last-child {
+        margin-bottom: 0;
+    }
+}
+
+
+
+/**
+ * Code formatting
+ */
+pre,
+code {
+    font-size: 15px;
+    border: 1px solid $grey-color-light;
+    border-radius: 3px;
+    background-color: #eef;
+}
+
+code {
+    padding: 1px 5px;
+}
+
+pre {
+    padding: 8px 12px;
+    overflow-x: scroll;
+
+    > code {
+        border: 0;
+        padding-right: 0;
+        padding-left: 0;
+    }
+}
+
+
+
+/**
+ * Wrapper
+ */
+.wrapper {
+    max-width: -webkit-calc(800px - (#{$spacing-unit} * 2));
+    max-width:         calc(800px - (#{$spacing-unit} * 2));
+    margin-right: auto;
+    margin-left: auto;
+    padding-right: $spacing-unit;
+    padding-left: $spacing-unit;
+    @extend %clearfix;
+
+    @include media-query($on-laptop) {
+        max-width: -webkit-calc(800px - (#{$spacing-unit}));
+        max-width:         calc(800px - (#{$spacing-unit}));
+        padding-right: $spacing-unit / 2;
+        padding-left: $spacing-unit / 2;
+    }
+}
+
+
+
+/**
+ * Clearfix
+ */
+%clearfix {
+
+    &:after {
+        content: "";
+        display: table;
+        clear: both;
+    }
+}
+
+
+
+/**
+ * Icons
+ */
+.icon {
+
+    > svg {
+        display: inline-block;
+        width: 16px;
+        height: 16px;
+        vertical-align: middle;
+
+        path {
+            fill: $grey-color;
+        }
+    }
+}