dribbble 1.0.1 → 2.0.0

data/spec/lib/dribbble/client_spec.rb

@@ -1,14 +1,16 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dribbble::Client do
-  before :all do
-    @client = Dribbble::Client.new 'valid_token'
+  before do
+    @client = described_class.new 'valid_token'
   end
 
   describe 'without token' do
     it 'raises Dribbble::Error::MissingToken' do
       expect do
-        Dribbble::Client.new
+        described_class.new
       end.to raise_error(Dribbble::Error::MissingToken)
     end
   end
@@ -17,7 +19,7 @@ describe Dribbble::Client do
     describe 'with an invalid token' do
       subject do
         stub_dribbble :get, '/user', DribbbleAPI::Unauthorized
-        Dribbble::Client.new(token: 'fake_invalid_token')
+        described_class.new(token: 'fake_invalid_token')
       end
 
       it 'raise Dribbble::Error::Unauthorized' do
@@ -30,7 +32,7 @@ describe Dribbble::Client do
     describe 'with a valid token' do
       subject do
         stub_dribbble :get, '/user', DribbbleAPI::UserSuccess
-        Dribbble::Client.new(token: 'valid_token')
+        described_class.new(token: 'valid_token')
       end
 
       it 'return a Dribbble::User' do
@@ -38,38 +40,17 @@ describe Dribbble::Client do
         expect(subject.user.name).to be_a String
       end
     end
-  end
-
-  describe 'on #buckets' do
-    subject do
-      stub_dribbble :get, '/user/buckets', DribbbleAPI::BucketsSuccess
-      @client.buckets
-    end
-
-    it 'return buckets' do
-      expect(subject.first).to be_a Dribbble::Bucket
-    end
-  end
-
-  describe 'on #followers' do
-    subject do
-      stub_dribbble :get, '/user/followers', DribbbleAPI::FollowersSuccess
-      @client.followers
-    end
 
-    it 'return users' do
-      expect(subject.first).to be_a Dribbble::User
-    end
-  end
-
-  describe 'on #likes' do
-    subject do
-      stub_dribbble :get, '/user/likes', DribbbleAPI::UserLikesSuccess
-      @client.likes
-    end
+    describe 'with current user' do
+      subject do
+        stub_dribbble :get, '/user', DribbbleAPI::CurrentUserSuccess
+        @client.user
+      end
 
-    it 'return shots' do
-      expect(subject.first).to be_a Dribbble::Shot
+      it 'return current user' do
+        expect(subject).to be_a Dribbble::User
+        expect(subject.id).to eq(1)
+      end
     end
   end
 
@@ -94,38 +75,4 @@ describe Dribbble::Client do
       expect(subject.first).to be_a Dribbble::Shot
     end
   end
-
-  describe 'on #following_shots' do
-    subject do
-      stub_dribbble :get, '/user/following/shots', DribbbleAPI::ShotsSuccess
-      @client.following_shots
-    end
-
-    it 'return shots' do
-      expect(subject.first).to be_a Dribbble::Shot
-    end
-  end
-
-  describe 'on #teams' do
-    subject do
-      stub_dribbble :get, '/user/teams', DribbbleAPI::TeamsSuccess
-      @client.teams
-    end
-
-    it 'return teams' do
-      expect(subject.first).to be_a Dribbble::Team
-    end
-  end
-
-  describe 'on #user' do
-    subject do
-      stub_dribbble :get, '/user', DribbbleAPI::CurrentUserSuccess
-      @client.user
-    end
-
-    it 'return current user' do
-      expect(subject).to be_a Dribbble::User
-      expect(subject.id).to eq(8_008_135)
-    end
-  end
 end

data/spec/lib/dribbble/project_spec.rb

@@ -1,44 +1,80 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RAW_PROJECT = data_from_json 'project_success.json'
 
 describe Dribbble::Project do
   describe 'on instance' do
-    before :all do
-      @project = Dribbble::Project.new 'valid_token', RAW_PROJECT
+    before do
+      @project = described_class.new 'valid_token', RAW_PROJECT
     end
 
     describe 'after initialization' do
       RAW_PROJECT.each do |field, value|
         it "respond to #{field}" do
-          expect(@project.send field).to eq(value)
+          expect(@project.send(field)).to eq(value)
         end
       end
     end
+  end
 
-    describe 'on #shots' do
+  describe 'on class' do
+    describe 'on #find' do
       subject do
-        stub_dribbble :get, '/projects/3/shots', DribbbleAPI::ShotsSuccess
-        @project.shots
+        stub_dribbble :get, '/projects/3', DribbbleAPI::ProjectSuccess
+        described_class.find 'valid_token', 3
       end
 
-      it 'responds with shots' do
-        expect(subject.size).to eq 2
-        expect(subject.first).to be_a Dribbble::Shot
+      it 'return a shot' do
+        expect(subject).to be_a described_class
+        expect(subject.id).to eq(3)
       end
     end
-  end
 
-  describe 'on class' do
-    describe 'on #find' do
+    describe 'on #create' do
       subject do
-        stub_dribbble :get, '/projects/3', DribbbleAPI::ProjectSuccess
-        Dribbble::Project.find 'valid_token', 3
+        stub_dribbble :post, '/projects', DribbbleAPI::ProjectsAccepted
+        data = {
+          name: 'Project title',
+          desciption: 'Project description'
+        }
+        described_class.create 'valid_token', data
       end
 
-      it 'return a project' do
-        expect(subject).to be_a Dribbble::Project
+      it 'create the project' do
+        expect(subject).to be_truthy
         expect(subject.id).to eq(3)
+        expect(subject.name).to eq('Project title')
+        expect(subject.description).to eq('Project description')
+      end
+    end
+
+    describe 'on #delete' do
+      subject do
+        stub_dribbble :get, '/projects/3', DribbbleAPI::ProjectSuccess
+        stub_dribbble :delete, '/projects/3', DribbbleAPI::ProjectsDeleted
+        described_class.delete 'valid_token', 3
+      end
+
+      it 'return true' do
+        expect(subject).to eq(true)
+      end
+    end
+
+    describe 'on #update' do
+      subject do
+        stub_dribbble :get, '/projects/3', DribbbleAPI::ProjectSuccess
+        stub_dribbble :put, '/projects/3', DribbbleAPI::ProjectsUpdated
+        data = {
+          name: 'Project title',
+          description: 'Project description'
+        }
+        described_class.update 'valid_token', 3, data
+      end
+
+      it 'update data' do
+        expect(subject.name).to eq('Project title')
       end
     end
   end

data/spec/lib/dribbble/shot_spec.rb

@@ -1,17 +1,19 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RAW_SHOT = data_from_json 'shot_success.json'
 
 describe Dribbble::Shot do
   describe 'on instance' do
-    before :all do
-      @shot = Dribbble::Shot.new 'valid_token', RAW_SHOT
+    before do
+      @shot = described_class.new 'valid_token', RAW_SHOT
     end
 
     describe 'after initialization' do
       RAW_SHOT.each do |field, value|
         it "respond to #{field}" do
-          expect(@shot.send field).to eq(value)
+          expect(@shot.send(field)).to eq(value)
         end
       end
     end
@@ -42,18 +44,7 @@ describe Dribbble::Shot do
       end
     end
 
-    describe 'on #attachments' do
-      describe 'all' do
-        subject do
-          stub_dribbble :get, '/shots/471756/attachments', DribbbleAPI::AttachmentsSuccess
-          @shot.attachments
-        end
-
-        it 'return a shot' do
-          expect(subject.first).to be_a Dribbble::Attachment
-        end
-      end
-
+    skip 'on #attachments' do
       describe 'create' do
         describe 'when shot is accepted' do
           subject do
@@ -78,18 +69,6 @@ describe Dribbble::Shot do
         end
       end
 
-      describe 'find' do
-        subject do
-          stub_dribbble :get, '/shots/471756/attachments/206165', DribbbleAPI::AttachmentSuccess
-          @shot.find_attachment 206_165
-        end
-
-        it 'return an attachment' do
-          expect(subject).to be_a Dribbble::Attachment
-          expect(subject.id).to eq(206_165)
-        end
-      end
-
       describe 'delete' do
         subject do
           stub_dribbble :delete, '/shots/471756/attachments/206165', DribbbleAPI::AttachmentDeleted
@@ -101,157 +80,6 @@ describe Dribbble::Shot do
         end
       end
     end
-
-    describe 'on #buckets' do
-      subject do
-        stub_dribbble :get, '/shots/471756/buckets', DribbbleAPI::BucketsSuccess
-        @shot.buckets
-      end
-
-      it 'return a shot' do
-        expect(subject.first).to be_a Dribbble::Bucket
-      end
-    end
-
-    describe 'on #comments' do
-      describe 'all' do
-        subject do
-          stub_dribbble :get, '/shots/471756/comments', DribbbleAPI::CommentsSuccess
-          @shot.comments
-        end
-
-        it 'return comments' do
-          expect(subject.first).to be_a Dribbble::Comment
-        end
-      end
-
-      describe 'create' do
-        subject do
-          stub_dribbble :post, '/shots/471756/comments', DribbbleAPI::CommentCreated
-          @shot.create_comment body: "<p>Could he somehow make the shape of an \"S\" with his arms? I feel like i see potential for some hidden shapes in here...</p>\n\n<p>Looks fun!\n</p>"
-        end
-
-        it 'return a comment' do
-          expect(subject).to be_a Dribbble::Comment
-          expect(subject.body).to eq("<p>Could he somehow make the shape of an \"S\" with his arms? I feel like i see potential for some hidden shapes in here...</p>\n\n<p>Looks fun!\n</p>")
-        end
-      end
-
-      describe 'find' do
-        subject do
-          stub_dribbble :get, '/shots/471756/comments/1145736', DribbbleAPI::CommentSuccess
-          @shot.find_comment 1_145_736
-        end
-
-        it 'return a comment' do
-          expect(subject).to be_a Dribbble::Comment
-          expect(subject.id).to eq(1_145_736)
-        end
-      end
-
-      describe 'update' do
-        subject do
-          stub_dribbble :put, '/shots/471756/comments/1145736', DribbbleAPI::CommentUpdated
-          @shot.update_comment 1_145_736, body: "New body"
-        end
-
-        it 'return a comment' do
-          expect(subject).to be_a Dribbble::Comment
-          expect(subject.body).to eq("New body")
-        end
-      end
-
-      describe 'delete' do
-        subject do
-          stub_dribbble :delete, '/shots/471756/comments/1145736', DribbbleAPI::CommentDeleted
-          @shot.delete_comment 1_145_736
-        end
-
-        it 'return true' do
-          expect(subject).to eq(true)
-        end
-      end
-    end
-
-    describe 'on #likes' do
-      subject do
-        stub_dribbble :get, '/shots/471756/likes', DribbbleAPI::ShotLikesSuccess
-        @shot.likes
-      end
-
-      it 'return a user' do
-        expect(subject.first).to be_a Dribbble::Like
-        expect(subject.first.user).to be_a Dribbble::User
-      end
-    end
-
-    describe 'on #like?' do
-      describe 'on a not liked shot' do
-        subject do
-          stub_dribbble :get, '/shots/471756/like', DribbbleAPI::ShotLikeNotFound
-          @shot.like?
-        end
-
-        it 'return a user' do
-          expect(subject).to be_falsy
-        end
-      end
-
-      describe 'on a liked shot' do
-        subject do
-          stub_dribbble :get, '/shots/471756/like', DribbbleAPI::ShotLikeSuccess
-          @shot.like?
-        end
-
-        it 'return a user' do
-          expect(subject).to be_truthy
-        end
-      end
-    end
-
-    describe 'on #like!' do
-      subject do
-        stub_dribbble :post, '/shots/471756/like', DribbbleAPI::ShotLikeCreated
-        @shot.like!
-      end
-
-      it 'return true' do
-        expect(subject).to be_truthy
-      end
-    end
-
-    describe 'on #unlike!' do
-      subject do
-        stub_dribbble :delete, '/shots/471756/like', DribbbleAPI::ShotLikeDeleted
-        @shot.unlike!
-      end
-
-      it 'return true' do
-        expect(subject).to be_truthy
-      end
-    end
-
-    describe 'on #projects' do
-      subject do
-        stub_dribbble :get, '/shots/471756/projects', DribbbleAPI::ProjectsSuccess
-        @shot.projects
-      end
-
-      it 'return a list of project' do
-        expect(subject.first).to be_a Dribbble::Project
-      end
-    end
-
-    describe 'on #rebounds' do
-      subject do
-        stub_dribbble :get, '/shots/471756/rebounds', DribbbleAPI::ShotsSuccess
-        @shot.rebounds
-      end
-
-      it 'return a list of shots' do
-        expect(subject.first).to be_a Dribbble::Shot
-      end
-    end
   end
 
   describe 'on class' do
@@ -262,9 +90,9 @@ describe Dribbble::Shot do
           title: 'Shot title',
           desciption: 'Shot description',
           image: File.new("#{Dir.pwd}/spec/support/fixtures/image.jpg", 'rb'),
-          tags: %w(tag1 tag2)
+          tags: %w[tag1 tag2]
         }
-        Dribbble::Shot.create 'valid_token', shot
+        described_class.create 'valid_token', shot
       end
 
       it 'create the shot' do
@@ -277,14 +105,14 @@ describe Dribbble::Shot do
       subject do
         stub_dribbble :get, '/shots/471756', DribbbleAPI::ShotSuccess
         stub_dribbble :put, '/shots/471756', DribbbleAPI::ShotUpdated
-        bucket = {
+        data = {
           name: 'Shot title',
           description: 'Shot description'
         }
-        Dribbble::Shot.update 'valid_token', 471_756, bucket
+        described_class.update 'valid_token', 471_756, data
       end
 
-      it 'update bucket' do
+      it 'update data' do
         expect(subject.title).to eq('Shot title')
       end
     end
@@ -293,7 +121,7 @@ describe Dribbble::Shot do
       subject do
         stub_dribbble :get, '/shots/471756', DribbbleAPI::ShotSuccess
         stub_dribbble :delete, '/shots/471756', DribbbleAPI::ShotDeleted
-        Dribbble::Shot.delete 'valid_token', 471_756
+        described_class.delete 'valid_token', 471_756
       end
 
       it 'return true' do
@@ -304,24 +132,13 @@ describe Dribbble::Shot do
     describe 'on #find' do
       subject do
         stub_dribbble :get, '/shots/471756', DribbbleAPI::ShotSuccess
-        Dribbble::Shot.find 'valid_token', 471_756
+        described_class.find 'valid_token', 471_756
       end
 
       it 'return a shot' do
-        expect(subject).to be_a Dribbble::Shot
+        expect(subject).to be_a described_class
         expect(subject.id).to eq(471_756)
       end
     end
-
-    describe 'on #all' do
-      subject do
-        stub_dribbble :get, '/shots', DribbbleAPI::ShotsSuccess
-        Dribbble::Shot.all 'valid_token'
-      end
-
-      it 'return a shot' do
-        expect(subject.first).to be_a Dribbble::Shot
-      end
-    end
   end
 end