drg_cms 0.7.0.2 → 0.7.0.8

data/app/helpers/cms_edit_helper.rb

@@ -44,17 +44,11 @@ def dc_value_for_parameter(param, current_document = nil)#:nodoc:
 end
 
 ############################################################################
-# Creates actions div for edit form.
-# 
-# Displaying readonly form turned out to be challenge. For now when readonly parameter
-# has value 2, back link will force readonly form. Value 1 or not set will result in
-# normal link.
+# Determine if action button on the form is active. Action will be greyed out otherwise.
+#
+# @return : Boolean : defined by 'active' option'. Default is True.
 ############################################################################
 def dc_is_action_active?(options)
-  if options['when_new']
-    dc_deprecate("when_option will be deprecated and replaced by active: not_new_record! Form #{CmsHelper.form_param(params)}")
-    return !(dc_dont?(options['when_new']) && @record.new_record?)
-  end
   return true unless options['active']
 
   # alias record and document so both can be used in eval
@@ -322,25 +316,25 @@ def dc_head_for_form
     caption = options['caption']
     span    = options['span'] || 1
     @css << "\n#{options['css']}" unless options['css'].blank?
-    label   = if caption.blank?
-      ''
-    elsif options['name'] == caption
-      t_label_for_field(options['name'], options['name'].capitalize.gsub('_',' ') )
-    else
-      t(caption, caption) 
-    end
+    label = if caption.blank?
+              ''
+            elsif options['name'] == caption
+              t_label_for_field(options['name'], options['name'].capitalize.gsub('_', ' ') )
+            else
+              t(caption, caption)
+            end
     # Field value
     begin
       field = if options['eval']
-        dc_process_column_eval(options, @record)
-      else
-        @record.send(options['name'])
-      end
+                dc_process_column_eval(options, @record)
+              else
+                dc_format_value(@record.send(options['name']), options['format'])
+              end
     rescue Exception => e
       dc_log_exception(e, 'dc_head_for_form')
       field = '!!!Error'
     end
-    #
+
     klass = dc_style_or_class(nil, options['class'], field, @record)
     style = dc_style_or_class(nil, options['style'], field, @record)
     html << %(<div class="dc-column #{klass}" style="width:#{percent*span}%;#{style}">
@@ -487,18 +481,17 @@ def dc_input_form_create(fields_on_tab) #:nodoc:
 </div> )
             else
               # no label
-              if dc_dont?(options['caption'])
-                label = ''
-                label_width = 0
-                data_width  = 100
-              elsif group_option > 1
-                label_width = group_option != group_count ? 10 : 14
-                data_width  = 21
-              else
-                label_width = 14
-                data_width  = 85
-              end
-              help.gsub!('<br>',"\n") if help.present?
+              label_width, data_width = if dc_dont?(options['caption'])
+                                          label = ''
+                                          [0, 100]
+                                        elsif group_option == 1
+                                          [14, 85]
+                                        elsif group_option == 2
+                                          group_count == 2 ? [14, 21] : [10, 45]
+                                        elsif group_option == 3
+                                          group_count == 3 ? [14, 21] : [10, 21]
+                                        end
+              help.gsub!('<br>', "\n") if help.present?
               %(
 <div class="dc-form-label dc-color-#{odd_even} dc-align-#{labels_pos} dc-width-#{label_width}" title="#{help}">
   <label for="record_#{options['name']}">#{label} </label>

data/app/helpers/cms_helper.rb

@@ -110,7 +110,7 @@ end
 ############################################################################
 def dc_label_help(options)
   # no label or help in comments
-  return [nil, nil] if %w(comment action).include?(options['type'])
+  return [nil, nil] if %w[comment action].include?(options['type'])
 
   label = options['caption'] || options['text'] || options['label']
   if options['name']
@@ -122,8 +122,16 @@ def dc_label_help(options)
   end
   # help text can be defined in form or in translations starting with helpers. or as helpers.help.collection.field
   help = options['help']
-  help ||= "helpers.help.#{@form['table']}.#{options['name']}" if options['name']
-  help = t(help, ' ') if help.to_s.match(/helpers\./)
+  if help.blank?
+    help = if options['name']
+             # if defined as i18n_prefix replace "label" with "help"
+             prefix = @form['i18n_prefix'] ? @form['i18n_prefix'].sub('label', 'help') : "helpers.help.#{@form['table']}"
+             "#{prefix}.#{options['name']}"
+           end
+    help = help.to_s
+  end
+  help = t(help, ' ') if help.to_s.match(/help\./)
+
   [label, help]
 end
 
@@ -300,10 +308,18 @@ def dc_log_exception(exception, where = '')
 end
 
 ############################################################################
-# Will return form id, to be used on each form for simpler css selecting.
+# Will return form id. id can be used for css selecting of fields on form.
+# Form id is by default form_name || table parameter.
 ############################################################################
 def dc_form_id
-  %( id=#{CmsHelper.form_param(params) || CmsHelper.table_param(params)} )
+  %(id="#{CmsHelper.form_param(params) || CmsHelper.table_param(params)}" ).html_safe
+end
+
+############################################################################
+# Will return class for form. Class can be used for different styling of forms.
+############################################################################
+def dc_form_class(additional_class = nil)
+  %(class="#{additional_class} #{@form['class']}" ).html_safe
 end
 
 ############################################################################

data/app/helpers/cms_index_helper.rb

@@ -35,12 +35,10 @@ module CmsIndexHelper
 def dc_actions_for_index
   @js  = @form['script'] || @form['js'] || ''
   @css = @form['css'] || ''
-  return '' if @form['index'].nil?
-
-  actions = @form['index']['actions']
+  actions = @form.dig('index', 'actions')
   return '' if actions.blank?
   
-  std_actions = {2 => 'new', 3 => 'sort', 4 => 'filter' }
+  std_actions = { 2 => 'new', 3 => 'sort', 4 => 'filter' }
   std_actions.delete(2) if @form['readonly']
 
   if actions.class == String
@@ -51,22 +49,16 @@ def dc_actions_for_index
   end
   
   html_left, html_right = '', ''
-  # Remove actions settings and sort
-  only_actions = []
-  actions.each { |key, value| only_actions << [key, value] if key.class == Integer }
-  only_actions.sort_by!(&:first)
-  only_actions.each do |key, options|
+  # remove settings and sort
+  actions_only = actions.inject([]) { |r, action| r << action if action.first.class == Integer; r }.sort_by(&:first)
+  actions_only.each do |key, options|
     session[:form_processing] = "index:actions: #{key}=#{options}"
     next if options.nil? # must be
 
-    url = @form_params.clone
-    yaml = options.class == String ? {'type' => options} : options # if single definition simulate type parameter
+    url    = @form_params.clone
+    yaml   = options.class == String ? { 'type' => options } : options # sinle action. Simulate type parameter
     action = yaml['type'].to_s.downcase 
-    if action == 'url'
-      dc_deprecate "action: url will be deprecated. Use action: link in index: actions! Form #{params['form_name']}"
-      action = 'link' 
-    end
-    # if return_to is present link directly to URL
+
     if action == 'link' && yaml['url']
       url = yaml['url']
     else
@@ -89,10 +81,8 @@ def dc_actions_for_index
           choices << [ t("helpers.label.#{@form['table']}.#{e}"), e ]
         end
       end
-      data = t('drgcms.sort') + select('sort', 'sort', choices, { include_blank: true }, { class: 'dc-sort-select',
-                                                                                           'data-table' => @form['table'], 'data-form' => CmsHelper.form_param(params)} )
-      data = mi_icon('sort') + select('sort', 'sort', choices, { include_blank: true }, { class: 'dc-sort-select',
-                                                                                           'data-table' => @form['table'], 'data-form' => CmsHelper.form_param(params)} )
+      data = mi_icon('sort') + select('sort', 'sort', choices, { include_blank: true },
+                                      { class: 'dc-sort-select', 'data-table': @form['table'], 'data-form': CmsHelper.form_param(params)} )
       html_right << %(<li title="#{t('drgcms.sort')}"><div class="dc-sort">#{data}</li>)
 
     # filter
@@ -263,9 +253,16 @@ def dc_actions_column
     actions.delete('standard')
   end
   # check must be first action
-  has_check = actions[0] && actions[0]['type'] == 'check'
-  width = actions.size == 1 ? 22 : 44
-  width = 22 if actions.size > 2 && !has_check
+  has_check = has_action_type('check', actions)
+  # when readonly only check and show are allowed
+  if @form['readonly']
+    width  = has_action_type('show', actions) ? 22 : 0
+    width += 22 if has_check
+  else
+    width = actions.size == 1 ? 22 : 44
+    width = 22 if actions.size > 2 && !has_check
+  end
+
   [actions, width, has_check]
 end
 
@@ -275,7 +272,7 @@ end
 def dc_actions_column_for_footer
   return '' unless @form['result_set']['actions']
 
-  ignore, width, ignore2 = dc_actions_column
+  ignore, width, ignore2 = dc_actions_column()
   %(<div class="dc-result-actions" style="width: #{width}px;"></div>).html_safe
 end
 
@@ -284,10 +281,10 @@ end
 ############################################################################
 def dc_actions_for_result(document)
   actions = @form['result_set']['actions']
-  return '' if actions.nil? || @form['readonly']
+  return '' if actions.nil? #|| @form['readonly']
 
   actions, width, has_check = dc_actions_column()
-  has_sub_menu = actions.size > 2 || (has_check && actions.size > 1)
+  has_sub_menu = actions.size > 2 #|| (has_check && actions.size > 1)
 
   main_menu, sub_menu = '', ''
   actions.sort_by(&:first).each do |num, action|
@@ -296,14 +293,16 @@ def dc_actions_for_result(document)
     # if single definition simulate type parameter
     yaml = action.class == String ? { 'type' => action } : action
 
+    next if @form['readonly'] && !%[show check].include?(yaml['type'])
+
     if %w(ajax link window popup submit).include?(yaml['type'])
       @record = document # otherwise document fields can't be used as parameters
       html = dc_link_ajax_window_submit_action(yaml, document)
     else
       caption = dc_get_caption(yaml) || "drgcms.#{yaml['type']}"
-      title   = t(yaml['help'] || caption, '')
+      title   = t(yaml['title'] || yaml['help'] || caption)
       caption = has_sub_menu ? t(caption, '') : nil
-      html = '<li>'
+      html    = '<li>'
       html << case yaml['type']
       when 'check' then
         main_menu << '<li>' + check_box_tag("check-#{document.id}", false, false, { class: 'dc-check' }) + '</li>'
@@ -312,13 +311,15 @@ def dc_actions_for_result(document)
       when 'edit' then
         parms['action'] = 'edit'
         parms['id'] = document.id
+        parms['readonly'] = yaml['readonly']
         dc_link_to( caption, 'edit-o', parms, title: title )
 
       when 'show' then
         parms['action'] = 'show'
         parms['id'] = document.id
         parms['readonly'] = true
-        dc_link_to( caption, 'eye', parms, title: title )
+        icon = yaml['icon'] || 'eye-o'
+        dc_link_to( caption, icon, parms, title: title )
 
       when 'duplicate' then
         parms['id'] = document.id
@@ -362,7 +363,7 @@ end
 ############################################################################
 def dc_header_for_result
   html = '<div class="dc-result-header">'
-  if @form['result_set']['actions'] && !@form['readonly']
+  if @form['result_set']['actions'] #&& !@form['readonly']
     ignore, width, has_check = dc_actions_column()
     check_all = fa_icon('check-box-o', class: 'dc-check-all') if has_check
     html << %(<div class="dc-result-actions" style="width:#{width}px;">#{check_all}</div>)
@@ -436,7 +437,7 @@ end
 ############################################################################
 # Formats value according to format supplied or data type. There is lots of things missing here.
 ############################################################################
-def dc_format_value(value, format=nil)
+def dc_format_value(value, format = nil)
   return '' if value.nil?
 
   klass = value.class.to_s
@@ -444,7 +445,7 @@ def dc_format_value(value, format=nil)
 
   format = format.to_s.upcase
   if format[0] == 'N'
-    return '' if value == 0 && format.match('Z')
+    return '' if format.match('Z') && value.to_s.to_f == 0.0
 
     format.gsub!('Z', '')
     dec = format[1].blank? ? nil : format[1].to_i
@@ -491,7 +492,9 @@ def dc_columns_for_result(document)
                 dc_process_column_eval(v, document)
               # as field
               elsif document.respond_to?(v['name'])
-                dc_format_value(document.send( v['name'] ), v['format'])
+                dc_format_value(document.send(v['name']), v['format'])
+              elsif respond_to?(v['name'])
+                dc_format_value(send(v['name'], document), v['format'])
               else
                 "??? #{v['name']}"
               end
@@ -501,7 +504,7 @@ def dc_columns_for_result(document)
     end
     html << '<div class="spacer"></div>'
     # set class
-    clas = dc_style_or_class(nil, v['td_class'], value, document)
+    clas = dc_style_or_class(nil, v['td_class'] || v['class'], value, document)
     # set width and align an additional style
     style = dc_style_or_class(nil, v['td_style'] || v['style'], value, document)
     flex_align  = v['align'].to_s == 'right' ? 'flex-direction:row-reverse;' : ''
@@ -522,15 +525,13 @@ def dc_eval_to_array(expression)
   expression.split(/\ |\,|\(|\)/).delete_if {|e| e.blank? }.map {|e| e.gsub(/\'|\"/,'').strip }
 end
 
-private
-
 ############################################################################
 # Process eval. Breaks eval option and calls with send method.
 # Parameters:
 #   evaluate : String : Expression to be evaluated
 #   parameters : Array : array of parameters which will be send to method
 ############################################################################
-def dc_process_eval(evaluate, parameters)
+def dc_process_eval(evaluate, parameters = nil)
   # evaluate by calling send method 
   clas, method = evaluate.split('.')
   if method.nil?
@@ -541,6 +542,8 @@ def dc_process_eval(evaluate, parameters)
   end  
 end
 
+private
+
 ############################################################################
 # Process eval option for field value. 
 # Used for processing single field column on result_set or form head.
@@ -594,7 +597,7 @@ end
 # Defines style or class for row (tr) or column (td)
 ############################################################################
 def dc_style_or_class(selector, yaml, value, record)
-  return '' if yaml.nil?
+  return '' if yaml.blank?
 
   # alias record and value so both names can be used in eval
   field, document = value, record
@@ -662,4 +665,16 @@ def form_has_input_field?(field_name)
   !(field['type'] == 'readonly' || field['readonly'])
 end
 
+############################################################################
+# return true if actions define check or show option
+############################################################################
+def has_action_type(type, actions)
+  h = { 'check' => 0, 'show' => 1 }
+  return false unless identifier = h[type]
+  return false unless actions[identifier]
+
+  type_value = actions[identifier].class == String ? actions[identifier] : actions[identifier]['type']
+  type_value == type
+end
+
 end

data/app/helpers/dc_application_helper.rb

@@ -260,7 +260,7 @@ def dc_table_title(text, result_set = nil)
   c = %(<div class="dc-title">#{text})
   c << dc_help_button(result_set)
 
-  if result_set && result_set.respond_to?(:current_page)
+  if result_set&.respond_to?(:current_page)
     c << %(<div class="dc-paginate">#{paginate(result_set, :params => {action: 'index', clear: 'no', filter: nil})}</div>)
   end
   c << '<div style="clear: both;"></div></div>'
@@ -268,26 +268,27 @@ def dc_table_title(text, result_set = nil)
 end
 
 ############################################################################
-# Creates title for cmsedit edit action dialog. 
-#  
+# Creates title for cmsedit edit action dialog.
+#
 # Returns:
 # String. HTML code for title.
 ############################################################################
 def dc_edit_title
   session[:form_processing] = "form:title:"
-  title = @form['form']['title']
+  title_data = @form['form']['title']
+  if title_data.class == String
+    t(title_data, title_data)
   # defined as form:title:edit
-  if title && title['edit'] && !@form['readonly']
-    t( title['edit'], title['edit'] )
-  elsif title && title['show'] && @form['readonly']
-    t( title['show'], title['show'] )
+  elsif title_data&.dig('edit') && !@form['readonly']
+    t( title_data['edit'], title_data['edit'] )
+  elsif title_data&.dig('show') && @form['readonly']
+    t( title_data['show'], title_data['show'] )
   else
-    # concatenate title
     c = (@form['readonly'] ? t('drgcms.show') : t('drgcms.edit')) + " : "
     c << (@form['title'].class == String ? t( @form['title'], @form['title'] ) : t_tablename(@form['table']))
-    title = title.try('field')
-
-    c << "#{@record[ title ]}" if title && @record.respond_to?(title)
+    # add description field value to title
+    field_name = title_data['field'] if title_data
+    c << " : #{@record[ field_name ]}" if field_name && @record.respond_to?(field_name)
     c
   end
 end
@@ -300,14 +301,18 @@ end
 ############################################################################
 def dc_new_title
   session[:form_processing] = "form:title:"
-  title = @form['form']['title']
+  title_data = @form['form']['title']
+  if title_data.class == String
+    t(title_data, title_data)
   # defined as form:title:new
-  if title && title['new']
-    t( title['new'], title['new'] )
+  elsif title_data&.dig('new')
+    t( title_data['new'], title_data['new'] )
   else
     # in memory structures
     if @form['table'] == 'dc_memory'
-      t( @form['title'], @form['title'] )
+      return t( @form['title'], @form['title'] ) if @form['title']
+
+      t("#{@form['i18n_prefix']}.tabletitle", '')
     else
       "#{t('drgcms.new')} : #{t_tablename(@form['table'])}"    
     end
@@ -684,51 +689,40 @@ end
 ############################################################################
 # Returns list of all collections (tables) as array of choices for usage in select fields.
 # List is collected from cms_menu.yml files and may not include all collections used in application.
-# Currently list is only used for helping defining collection names on dc_permission form. 
-# 
+# Currently list is only used for helping defining collection names on dc_permission form.
+#
 # Example (as used in forms):
 #    form:
 #      fields:
 #        10:
 #          name: table_name
 #          type: text_with_select
-#          eval: dc_choices4_all_collections      
+#          eval: dc_choices4_all_collections
 ############################################################################
 def dc_choices4_all_collections
-  choices = {}
-  DrgCms.paths(:forms).reverse.each do |path|
-    filename = "#{path}/cms_menu.yml"
-    next unless File.exist?(filename)
-
-    menu = YAML.load_file(filename) rescue nil      # load menu
-    next if menu.nil? or !menu['menu']              # not menu or error
-    menu['menu'].each do |section|
-      next unless section.last['items']             # next if no items
-      section.last['items'].each do |k, v|          # look for caption and 
-        key = v['table']
-        choices[key] ||= "#{key} - #{t(v['caption'], v['caption'])}" 
-      end
-    end
-  end  
-  choices.invert.to_a.sort # hash has to be inverted for values to be returned right
+  models = Mongoid.models.map(&:to_s).uniq.map(&:underscore).delete_if { |e| e.match('/') }
+  models.sort.inject([]) do |r, model_name|
+    r << ["#{model_name} - #{t("helpers.label.#{model_name}.tabletitle", '')}", model_name]
+  end
 end
 
 ##########################################################################
-# Returns choices for creating collection edit select field on CMS top menu.
+# Code for top CMS menu.
 ##########################################################################
-def dc_choices4_cmsmenu
+def dc_cms_menu
   menus = {}
   DrgCms.paths(:forms).reverse.each do |path|
     filename = "#{path}/cms_menu.yml"
-    next unless File.exist?(filename)
-    menu = YAML.load_file(filename) rescue nil      # load menu
-    next if menu.nil? or !menu['menu']              # not menu or error
-    menus = CmsHelper.forms_merge(menu['menu'], menus) # ignore top level part
- end
+    next if !File.exist?(filename)
+
+    menu  = YAML.load_file(filename) rescue nil # load menu
+    menus = CmsHelper.forms_merge(menu['menu'], menus) if menu.dig('menu') # merge menus
+  end
 
   html = '<ul>'
   menus.to_a.sort.each do |index, menu|    # sort menus, result is array of sorted hashes
     next unless menu['caption']
+
     icon = menu['icon'].match('/') ? image_tag(menu['icon']) : fa_icon(menu['icon']) #external or fa- image
     html << %(<li class="cmsedit-top-level-menu"><div>#{icon}#{t(menu['caption'])}</div><ul>)
     menu['items'].to_a.sort.each do |index1, value|   # again, sort menu items first 
@@ -736,19 +730,18 @@ def dc_choices4_cmsmenu
         opts = { target: value['target'] || 'iframe_cms' }
         "<li>#{dc_link_to(t(value['caption']), value['icon'] || '', value['link'], opts)}</li>"
       else
-        opts =        
-        { controller: value['controller'], 
-          action: value['action'], 
-          table: value['table'],
-          form_name: value['form_name'] || value['table'],
-          target: value['target'] || 'iframe_cms',
-        }
+        opts = { controller: value['controller'], action: value['action'],
+                 table: value['table'], form_name: value['form_name'] || value['table'],
+                 target: value['target'] || 'iframe_cms',
+               }
+        # additional parameters
+        value['params'].each { |k, v| opts[k] = dc_value_for_parameter(v) } if value['params']
         "<li>#{dc_link_to(t(value['caption']), value['icon'] || '', opts)}</li>"
       end
     end   
     html << '</ul></li>'  
   end
-  html
+  html.html_safe
 end
 
 ############################################################################
@@ -760,7 +753,7 @@ def dc_choices4_folders_list
   home   = File.join(public,dc_get_site.files_directory)
   choices = Dir.glob(home + '/**/*/').select { |fn| File.directory?(fn) }
   choices << home # add home
-  choices.collect! {|e| e.gsub(public,'')} # remove public part
+  choices.collect! { |e| e.gsub(public,'') } # remove public part
   choices.sort
 end
 
@@ -782,7 +775,7 @@ end
 #      type: select
 #      eval: dc_choices4('dc_poll','name','_id')
 ############################################################################
-def dc_choices4(model, name, id='_id', options = {})
+def dc_choices4(model, name, id = '_id', options = {})
   model = model.classify.constantize
   qry   = model.only(id, name)
   if (param = options[:site])
@@ -792,8 +785,6 @@ def dc_choices4(model, name, id='_id', options = {})
   end
   qry = qry.and(active: true) if model.method_defined?(:active)
   qry = qry.order_by(name => 1).collation(locale: I18n.locale.to_s)
-  #choices = qry.inject([]) {|result,e| result << [ e[name], e[id] ]}
-  #choices.sort_alphabetical_by(&:first) # use UTF-8 sort
   qry.map { |e| [e[name], e[id]] }
 end
 
@@ -1073,25 +1064,25 @@ end
 ########################################################################
 def dc_internal_var(object, var_name, current_document = nil)
   begin
-    case
-    when object == 'session' then _origin.session[var_name]
-    when object == 'params'  then _origin.params[var_name]
-    when object == 'site'    then _origin.dc_get_site.send(var_name)
-    when object == 'page'    then _origin.page.send(var_name)
-    when object == 'record'  then
+    case object
+    when 'session' then _origin.session[var_name]
+    when 'params'  then _origin.params[var_name]
+    when 'site'    then _origin.dc_get_site.send(var_name)
+    when 'page'    then _origin.page.send(var_name)
+    when 'record'  then
       current_document ? current_document.send(var_name) : _origin.record.send(var_name)
-    when object == 'class'   then
+    when 'class'   then
       clas, method_name = var_name.split('.')
       klas = clas.classify.constantize
       # call method. Error will be caught below.
       klas.send(method_name)
     else
-      'VARIABLE: UNKNOWN OBJECT'
+      'dc_internal: UNKNOWN OBJECT'
     end
   rescue Exception => e
     Rails.logger.debug "\ndc_internal_var. Runtime error. #{e.message}\n"
     Rails.logger.debug(e.backtrace.join($/)) if Rails.env.development?
-    'VARIABLE: ERROR'
+    'dc_internal: ERROR'
   end
 end
 
@@ -1122,11 +1113,10 @@ end
 def dc_get_json_ld()
   return '' if @json_ld.nil? or @json_ld.size == 0
 
-  %Q[
+  %(
 <script type="application/ld+json">
 #{JSON.pretty_generate({'@context' => 'http://schema.org', '@graph' => @json_ld})}
-</script>
-].html_safe
+</script>).html_safe
 end
 
 ########################################################################
@@ -1150,12 +1140,12 @@ end
 # Returns:
 # HTML data to be embedded into page header
 #######################################################################
-def dc_get_seo_meta_tags()
+def dc_get_seo_meta_tags
   html = ''
-  html << "<link rel=\"canonical\" href=\"#{@page.canonical_link}\">\n  " unless @page&.canonical_link.blank?
+  html << %(<link rel="canonical" href="#{@page.canonical_link}">\n  ) if @page&.canonical_link.present?
 
   html << @meta_tags.inject('') do |r, hash|
-    r << "<meta #{hash.first} content=\"#{hash.last}\">\n  "
+    r << %(<meta #{hash.first} content="#{hash.last}">\n  )
   end if @meta_tags
   html.html_safe
 end
@@ -1170,6 +1160,7 @@ end
 ########################################################################
 def dc_add_meta_tag(type, name, content)
   return if content.blank?
+
   @meta_tags ||= {}
   key = "#{type}=\"#{name}\""
   @meta_tags[key] = content
@@ -1188,7 +1179,7 @@ end
 # [String] alt="image-tag"
 #######################################################################
 def dc_img_alt_tag(file_name, text=nil)
-  " alt=\"#{dc_img_alt(file_name, text)}\" ".html_safe
+  %( alt="#{dc_img_alt(file_name, text)}" ).html_safe
 end
 
 #######################################################################
@@ -1204,9 +1195,10 @@ end
 # [String] alt_image_name
 #######################################################################
 def dc_img_alt(file_name, text=nil)
-  return text unless text.blank?
+  return text if text.present?
+
   name = File.basename(file_name.to_s)
-  name[0,name.index('.')].downcase rescue name
+  name[0, name.index('.')].downcase rescue name
 end
 
 private