draper 0.17.0 → 1.0.0.beta2

data/spec/integration/integration_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+require 'support/dummy_app'
+require 'support/matchers/have_text'
+
+app = DummyApp.new(ENV["RAILS_ENV"])
+
+app.start_server do
+  {view: "/posts/1", mailer: "/posts/1/mail"}.each do |type, path|
+    page = app.get(path)
+
+    describe "in a #{type}" do
+      it "runs in the correct environment" do
+        page.should have_text(app.environment).in("#environment")
+      end
+
+      it "can use path helpers with a model" do
+        page.should have_text("/en/posts/1").in("#path_with_model")
+      end
+
+      it "can use path helpers with an id" do
+        page.should have_text("/en/posts/1").in("#path_with_id")
+      end
+
+      it "can use url helpers with a model" do
+        page.should have_text("http://www.example.com/en/posts/1").in("#url_with_model")
+      end
+
+      it "can use url helpers with an id" do
+        page.should have_text("http://www.example.com/en/posts/1").in("#url_with_id")
+      end
+    end
+  end
+end

data/spec/minitest-rails/spec_type_spec.rb

@@ -0,0 +1,63 @@
+require 'spec_helper'
+require 'minitest/rails/active_support'
+require 'draper/test/minitest_integration'
+
+describe "minitest-rails spec_type Lookup Integration" do
+  context "ProductDecorator" do
+    it "resolves constants" do
+      klass = MiniTest::Spec.spec_type(ProductDecorator)
+      klass.should == MiniTest::Rails::ActiveSupport::TestCase
+    end
+
+    it "resolves strings" do
+      klass = MiniTest::Spec.spec_type("ProductDecorator")
+      klass.should == MiniTest::Rails::ActiveSupport::TestCase
+    end
+  end
+
+  context "WidgetDecorator" do
+    it "resolves constants" do
+      klass = MiniTest::Spec.spec_type(WidgetDecorator)
+      klass.should == MiniTest::Rails::ActiveSupport::TestCase
+    end
+
+    it "resolves strings" do
+      klass = MiniTest::Spec.spec_type("WidgetDecorator")
+      klass.should == MiniTest::Rails::ActiveSupport::TestCase
+    end
+  end
+
+  context "decorator strings" do
+    it "resolves DoesNotExistDecorator" do
+      klass = MiniTest::Spec.spec_type("DoesNotExistDecorator")
+      klass.should == MiniTest::Rails::ActiveSupport::TestCase
+    end
+
+    it "resolves DoesNotExistDecoratorTest" do
+      klass = MiniTest::Spec.spec_type("DoesNotExistDecoratorTest")
+      klass.should == MiniTest::Rails::ActiveSupport::TestCase
+    end
+
+    it "resolves Does Not Exist Decorator" do
+      klass = MiniTest::Spec.spec_type("Does Not Exist Decorator")
+      klass.should == MiniTest::Rails::ActiveSupport::TestCase
+    end
+
+    it "resolves Does Not Exist Decorator Test" do
+      klass = MiniTest::Spec.spec_type("Does Not Exist Decorator Test")
+      klass.should == MiniTest::Rails::ActiveSupport::TestCase
+    end
+  end
+
+  context "non-decorators" do
+    it "doesn't resolve constants" do
+      klass = MiniTest::Spec.spec_type(Draper::HelperSupport)
+      klass.should == MiniTest::Spec
+    end
+
+    it "doesn't resolve strings" do
+      klass = MiniTest::Spec.spec_type("Nothing to see here...")
+      klass.should == MiniTest::Spec
+    end
+  end
+end

data/{performance → spec/performance}/decorators.rb

@@ -1,6 +1,5 @@
 require "./performance/models"
-class ProductDecorator < Draper::Base
-  decorates :product
+class ProductDecorator < Draper::Decorator
 
   def awesome_title
     "Awesome Title"
@@ -21,8 +20,7 @@ class ProductDecorator < Draper::Base
 
 end
 
-class FastProductDecorator < Draper::Base
-  decorates :product
+class FastProductDecorator < Draper::Decorator
 
   def awesome_title
     "Awesome Title"

data/spec/spec_helper.rb

@@ -3,34 +3,31 @@ require 'ammeter/init'
 require 'rails'
 
 require 'action_view'
-require './spec/support/samples/application_controller'
+require 'action_controller'
+require 'action_controller/test_case'
 
 Bundler.require
 
-require './spec/support/samples/active_model'
-require './spec/support/samples/active_record'
-require './spec/support/samples/application_helper'
-require './spec/support/samples/decorator'
-require './spec/support/samples/decorator_with_allows'
-require './spec/support/samples/decorator_with_multiple_allows'
-require './spec/support/samples/decorator_with_application_helper'
-require './spec/support/samples/decorator_with_denies'
-require './spec/support/samples/decorator_with_denies_all'
-require './spec/support/samples/decorator_with_special_methods'
-require './spec/support/samples/namespaced_product'
-require './spec/support/samples/namespaced_product_decorator'
-require './spec/support/samples/non_active_model_product'
-require './spec/support/samples/product'
-require './spec/support/samples/product_decorator'
-require './spec/support/samples/sequel_product'
-require './spec/support/samples/specific_product_decorator'
-require './spec/support/samples/some_thing'
-require './spec/support/samples/some_thing_decorator'
-require './spec/support/samples/widget'
-require './spec/support/samples/widget_decorator'
+require './spec/support/active_model'
+require './spec/support/active_record'
+require './spec/support/action_controller'
 
-module ActionController
-  class Base
-    Draper::System.setup(self)
-  end
+require './spec/support/models/product'
+require './spec/support/models/namespaced_product'
+require './spec/support/models/non_active_model_product'
+require './spec/support/models/widget'
+require './spec/support/models/some_thing'
+require './spec/support/models/uninferrable_decorator_model'
+
+require './spec/support/decorators/product_decorator'
+require './spec/support/decorators/namespaced_product_decorator'
+require './spec/support/decorators/non_active_model_product_decorator'
+require './spec/support/decorators/widget_decorator'
+require './spec/support/decorators/specific_product_decorator'
+require './spec/support/decorators/products_decorator'
+require './spec/support/decorators/some_thing_decorator'
+require './spec/support/decorators/decorator_with_application_helper'
+
+class << Rails
+  undef application # Avoid silly Rails bug: https://github.com/rails/rails/pull/6429
 end

data/spec/support/action_controller.rb

@@ -0,0 +1,12 @@
+module ActionController
+  class Base
+    Draper.setup_action_controller(self)
+  end
+end
+
+class ApplicationController < ActionController::Base
+  def hello_world
+    "Hello, World!"
+  end
+  helper_method :hello_world
+end

data/spec/support/active_model.rb

@@ -0,0 +1,7 @@
+module ActiveModel
+  module Serialization
+    def serializable_hash
+      {overridable: send(:overridable)}
+    end
+  end
+end

data/spec/support/{samples/active_record.rb → active_record.rb}

@@ -15,3 +15,8 @@ module ActiveRecord
 
   end
 end
+
+module ActiveRecord
+  class Relation
+  end
+end

data/spec/support/{samples → decorators}/decorator_with_application_helper.rb

@@ -1,4 +1,4 @@
-class DecoratorWithApplicationHelper < Draper::Base
+class DecoratorWithApplicationHelper < Draper::Decorator
   def uses_hello_world
     h.hello_world
   end

data/spec/support/decorators/namespaced_product_decorator.rb

@@ -0,0 +1,5 @@
+module Namespace
+  class ProductDecorator < Draper::Decorator
+    decorates_finders
+  end
+end

data/spec/support/decorators/non_active_model_product_decorator.rb

@@ -0,0 +1,2 @@
+class NonActiveModelProductDecorator
+end

data/spec/support/decorators/product_decorator.rb

@@ -0,0 +1,23 @@
+class ProductDecorator < Draper::Decorator
+  decorates_finders
+
+  def awesome_title
+    "Awesome Title"
+  end
+
+  def overridable
+    :overridden
+  end
+
+  def self.overridable
+    :overridden
+  end
+
+  def self.my_class_method
+  end
+
+  private
+
+  def awesome_private_title
+  end
+end

data/spec/support/decorators/products_decorator.rb

@@ -0,0 +1,10 @@
+class ProductsDecorator < Draper::CollectionDecorator
+
+  def link_to
+    h.link_to 'sample', "#"
+  end
+
+  def some_method
+    "some method works"
+  end
+end

data/spec/support/decorators/some_thing_decorator.rb

@@ -0,0 +1,2 @@
+class SomeThingDecorator < Draper::Decorator
+end

data/spec/support/{samples → decorators}/specific_product_decorator.rb

@@ -1,4 +1,2 @@
-require './spec/support/samples/product_decorator'
-
 class SpecificProductDecorator < ProductDecorator
 end

data/spec/support/dummy_app.rb

@@ -0,0 +1,84 @@
+require 'socket'
+require 'net/http'
+
+# Adapted from code by Jon Leighton
+# https://github.com/jonleighton/focused_controller/blob/ec7ccf1/test/acceptance/app_test.rb
+
+class DummyApp
+
+  def initialize(environment)
+    raise ArgumentError, "Environment must be development or production" unless ["development", "production"].include?(environment.to_s)
+    @environment = environment
+  end
+
+  attr_reader :environment
+
+  def url
+    "http://#{localhost}:#{port}"
+  end
+
+  def get(path)
+    Net::HTTP.get(URI(url + path))
+  end
+
+  def within_app(&block)
+    Dir.chdir(root, &block)
+  end
+
+  def start_server
+    within_app do
+      IO.popen("bundle exec rails s -e #{@environment} -p #{port} 2>&1") do |out|
+        start   = Time.now
+        started = false
+        output  = ""
+        timeout = 60.0
+
+        while !started && !out.eof? && Time.now - start <= timeout
+          output << read_output(out)
+          sleep 0.1
+
+          begin
+            TCPSocket.new(localhost, port)
+          rescue Errno::ECONNREFUSED
+          else
+            started = true
+          end
+        end
+
+        raise "Server failed to start:\n#{output}" unless started
+
+        yield
+
+        Process.kill('KILL', out.pid)
+      end
+    end
+  end
+
+  private
+
+  def root
+    File.expand_path('../../dummy', __FILE__)
+  end
+
+  def localhost
+    '127.0.0.1'
+  end
+
+  def port
+    @port ||= begin
+      server = TCPServer.new(localhost, 0)
+      server.addr[1]
+    ensure
+      server.close if server
+    end
+  end
+
+  def read_output(stream)
+    read = IO.select([stream], [], [stream], 0.1)
+    output = ""
+    loop { output << stream.read_nonblock(1024) } if read
+    output
+  rescue Errno::EAGAIN, Errno::EWOULDBLOCK, EOFError
+    output
+  end
+end

data/spec/support/matchers/have_text.rb

@@ -0,0 +1,50 @@
+require 'capybara'
+
+module HaveTextMatcher
+  def have_text(text)
+    HaveText.new(text)
+  end
+
+  class HaveText
+    def initialize(text)
+      @text = text
+    end
+
+    def in(css)
+      @css = css
+      self
+    end
+
+    def matches?(subject)
+      @subject = Capybara.string(subject)
+
+      @subject.has_css?(@css || "*", text: @text)
+    end
+
+    def failure_message_for_should
+      "expected to find #{@text.inspect} #{within}"
+    end
+
+    def failure_message_for_should_not
+      "expected not to find #{@text.inspect} #{within}"
+    end
+
+    private
+
+    def within
+      if @css && @subject.has_css?(@css)
+        "within\n#{@subject.find(@css).native}"
+      else
+        "#{inside} within\n#{@subject.native}"
+      end
+    end
+
+    def inside
+      @css ? "inside #{@css.inspect}" : "anywhere"
+    end
+  end
+end
+
+RSpec.configure do |config|
+  config.include HaveTextMatcher
+end

data/spec/support/{samples → models}/namespaced_product.rb

@@ -1,8 +1,6 @@
-require './spec/support/samples/product'
-
 module Namespace
   class Product < ActiveRecord::Base
-    include Draper::ModelSupport
+    include Draper::Decoratable
 
     def self.first
       @@first ||= Namespace::Product.new

data/spec/support/{samples → models}/non_active_model_product.rb

@@ -1,2 +1,3 @@
 class NonActiveModelProduct
+  include Draper::Decoratable
 end

data/spec/support/{samples → models}/product.rb

@@ -1,5 +1,8 @@
 class Product < ActiveRecord::Base
-  include Draper::ModelSupport
+  include Draper::Decoratable
+  include ActiveModel::Serialization
+
+  delegate :delegated_method, to: :thing
 
   def self.find_by_name(name)
     @@dummy ||= Product.new
@@ -22,7 +25,7 @@ class Product < ActiveRecord::Base
   end
 
   def self.model_name
-    "Product"
+    name
   end
 
   def self.find(id)
@@ -77,4 +80,16 @@ class Product < ActiveRecord::Base
     Product.new
   end
 
+  def overridable
+    :overridable
+  end
+
+  def self.overridable
+    :overridable
+  end
+
+  private
+
+  def private_title
+  end
 end

data/spec/support/models/some_thing.rb

@@ -0,0 +1,5 @@
+class SomeThing < Product
+  def delegated_method
+    'Yay, delegation'
+  end
+end

data/spec/support/models/uninferrable_decorator_model.rb

@@ -0,0 +1,3 @@
+class UninferrableDecoratorModel
+  include Draper::Decoratable
+end