draper 0.10.0 → 0.11.0

data/performance/models.rb

@@ -3,7 +3,7 @@ class Product < ActiveRecord::Base
   def self.sample_class_method
     "sample class method"
   end
-  
+
   def hello_world
     "Hello, World"
   end
@@ -13,7 +13,7 @@ class FastProduct < ActiveRecord::Base
   def self.sample_class_method
     "sample class method"
   end
-  
+
   def hello_world
     "Hello, World"
   end

data/spec/draper/base_spec.rb

@@ -54,6 +54,44 @@ describe Draper::Base do
       end.should_not raise_error
     end
 
+    context("accepts ActiveRecord like :class_name option too") do
+      it "accepts constants for :class" do
+        expect do
+        class CustomDecorator < Draper::Base
+          decorates :product, :class => Product
+        end
+        CustomDecorator.model_class.should == Product
+        end.should_not raise_error
+      end
+
+      it "accepts constants for :class_name" do
+        expect do
+        class CustomDecorator < Draper::Base
+          decorates :product, :class_name => Product
+        end
+        CustomDecorator.model_class.should == Product
+        end.should_not raise_error
+      end
+
+      it "accepts strings for :class" do
+        expect do
+        class CustomDecorator < Draper::Base
+          decorates :product, :class => 'Product'
+        end
+        CustomDecorator.model_class.should == Product
+        end.should_not raise_error
+      end
+
+      it "accepts strings for :class_name" do
+        expect do
+        class CustomDecorator < Draper::Base
+          decorates :product, :class_name => 'Product'
+        end
+        CustomDecorator.model_class.should == Product
+        end.should_not raise_error
+      end
+    end
+
     it "creates a named accessor for the wrapped model" do
       pd = ProductDecorator.new(source)
       pd.send(:product).should == source
@@ -75,22 +113,31 @@ describe Draper::Base do
   end
 
   context(".decorates_association") do
-    context "for collection associations" do
+    context "for ActiveModel collection associations" do
       before(:each){ subject.class_eval{ decorates_association :similar_products } }
       it "causes the association's method to return a collection of wrapped objects" do
         subject.similar_products.each{ |decorated| decorated.should be_instance_of(ProductDecorator) }
       end
     end
 
-    context "for a singular association" do
+    context "for Plain Old Ruby Object collection associations" do
+      before(:each){ subject.class_eval{ decorates_association :poro_similar_products } }
+      it "causes the association's method to return a collection of wrapped objects" do
+        subject.poro_similar_products.each{ |decorated| decorated.should be_instance_of(ProductDecorator) }
+      end
+    end
+
+    context "for an ActiveModel singular association" do
       before(:each){ subject.class_eval{ decorates_association :previous_version } }
       it "causes the association's method to return a single wrapped object if the association is singular" do
         subject.previous_version.should be_instance_of(ProductDecorator)
       end
+    end
 
-      it "causes the association's method to return nil if the association is nil" do
-        source.stub(:previous_version){ nil }
-        subject.previous_version.should be_nil
+    context "for a Plain Old Ruby Object singular association" do
+      before(:each){ subject.class_eval{ decorates_association :poro_previous_version } }
+      it "causes the association's method to return a single wrapped object" do
+        subject.poro_previous_version.should be_instance_of(ProductDecorator)
       end
     end
 
@@ -100,6 +147,23 @@ describe Draper::Base do
         subject.previous_version.should be_instance_of(SpecificProductDecorator)
       end
     end
+
+    context "for a polymorphic association" do
+      before(:each){ subject.class_eval{ decorates_association :thing, :polymorphic => true } }
+      it "causes the association to be decorated with the right decorator" do
+        subject.thing.should be_instance_of(SomeThingDecorator)
+      end
+    end
+
+    context "when the association is nil" do
+      before(:each) do
+        subject.class_eval{ decorates_association :previous_version }
+        source.stub(:previous_version){ nil }
+      end
+      it "causes the association's method to return nil" do
+        subject.previous_version.should be_nil
+      end
+    end
   end
 
   context('.decorates_associations') do
@@ -119,6 +183,13 @@ describe Draper::Base do
     end
   end
 
+  context(".source / .to_source") do
+    it "should return the wrapped object" do
+      subject.to_source == source
+      subject.source == source
+    end
+  end
+
   context("selecting methods") do
     it "echos the methods of the wrapped class except default exclusions" do
       source.methods.each do |method|
@@ -178,6 +249,34 @@ describe Draper::Base do
     end
   end
 
+  context ".find_by_(x)" do
+    it "runs the similarly named finder" do
+      Product.should_receive(:find_by_name)
+      ProductDecorator.find_by_name("apples")
+    end
+
+    it "returns a decorated result" do
+      ProductDecorator.find_by_name("apples").should be_kind_of(ProductDecorator)
+    end
+
+    it "runs complex finders" do
+      Product.should_receive(:find_by_name_and_size)
+      ProductDecorator.find_by_name_and_size("apples", "large")
+    end
+
+    it "accepts an options hash" do
+      Product.should_receive(:find_by_name_and_size).with("apples", "large", {:role => :admin})
+      ProductDecorator.find_by_name_and_size("apples", "large", {:role => :admin})
+    end
+
+    it "uses the options hash in the decorator instantiation" do
+      pending "Figure out an implementation that supports multiple args (find_by_name_and_count_and_size) plus an options hash"
+      Product.should_receive(:find_by_name_and_size).with("apples", "large", {:role => :admin})
+      pd = ProductDecorator.find_by_name_and_size("apples", "large", {:role => :admin})
+      pd.context[:role].should == :admin
+    end
+  end
+
   context ".decorate" do
     context "without any context" do
       subject { Draper::Base.decorate(source) }
@@ -196,6 +295,25 @@ describe Draper::Base do
         let(:source) { Product.new }
 
         it { should be_instance_of(Draper::Base) }
+
+        context "when the input is already decorated" do
+          it "does not perform double-decoration" do
+            decorated = ProductDecorator.decorate(source)
+            ProductDecorator.decorate(decorated).object_id.should == decorated.object_id
+          end
+
+          it "overwrites options with provided options" do
+            first_run = ProductDecorator.decorate(source, :context => {:role => :user})
+            second_run = ProductDecorator.decorate(first_run, :context => {:role => :admin})
+            second_run.context[:role].should == :admin
+          end
+
+          it "leaves existing options if none are supplied" do
+            first_run = ProductDecorator.decorate(source, :context => {:role => :user})
+            second_run = ProductDecorator.decorate(first_run)
+            second_run.context[:role].should == :user
+          end
+        end
       end
     end
 
@@ -219,6 +337,14 @@ describe Draper::Base do
       end
     end
 
+    context "with options" do
+      let(:options) {{ :more => "settings" }}
+
+      subject { Draper::Base.decorate(source, options ) }
+
+      its(:options) { should eq(options) }
+    end
+
     context "does not infer collections by default" do
       subject { Draper::Base.decorate(source).to_ary }
 
@@ -352,10 +478,10 @@ describe Draper::Base do
       subject = ProductDecorator.decorate(paged_array)
       subject[0].should be_instance_of ProductDecorator
     end
-    
+
     context "pretends to be of kind of wrapped collection class" do
       subject { ProductDecorator.decorate(paged_array) }
-      
+
       it "#kind_of? DecoratedEnumerableProxy" do
         subject.should be_kind_of Draper::DecoratedEnumerableProxy
       end
@@ -383,6 +509,13 @@ describe Draper::Base do
         collection.first.context.should == :admin
       end
     end
+
+    context(".source / .to_source") do
+      it "should return the wrapped object" do
+        subject.to_source == source
+        subject.source == source
+      end
+    end
   end
 
   describe "a sample usage with denies" do
@@ -408,6 +541,8 @@ describe Draper::Base do
   describe "a sample usage with allows" do
     let(:subject_with_allows){ DecoratorWithAllows.new(source) }
 
+    let(:subject_with_multiple_allows){ DecoratorWithMultipleAllows.new(source) }
+
     it "should echo the allowed method" do
       subject_with_allows.should respond_to(:goodnight_moon)
     end
@@ -415,6 +550,15 @@ describe Draper::Base do
     it "should echo _only_ the allowed method" do
       subject_with_allows.should_not respond_to(:hello_world)
     end
+
+    it "should echo the combined allowed methods" do
+      subject_with_multiple_allows.should respond_to(:goodnight_moon)
+      subject_with_multiple_allows.should respond_to(:hello_world)
+    end
+
+    it "should echo _only_ the combined allowed methods" do
+      subject_with_multiple_allows.should_not respond_to(:title)
+    end
   end
 
   describe "invalid usages of allows and denies" do
@@ -479,8 +623,14 @@ describe Draper::Base do
     it "should be able to use the pluralize helper" do
       decorator.sample_truncate.should == "Once..."
     end
+
+    it "should be able to use l rather than helpers.l" do
+      now = Time.now
+      decorator.helpers.should_receive(:localize).with(now)
+      decorator.l now
+    end
   end
-  
+
   describe "#method_missing" do
     context "when #hello_world is called for the first time" do
       it "hits method missing" do
@@ -488,7 +638,7 @@ describe Draper::Base do
         subject.hello_world
       end
     end
-    
+
     context "when #hello_world is called again" do
       before { subject.hello_world }
       it "proxies method directly after first hit" do
@@ -496,10 +646,26 @@ describe Draper::Base do
         subject.hello_world
       end
     end
+
+    context "when the delegated method calls a non-existant method" do
+      it 'should not try to delegate to non-existant methods to not confuse Kernel#Array' do
+        Array(subject).should be_kind_of(Array)
+      end
+
+      it "raises the correct NoMethodError" do
+        begin
+          subject.some_action
+        rescue NoMethodError => e
+          e.name.should_not == :some_action
+        else
+          fail("No exception raised")
+        end
+      end
+    end
   end
 
   describe "#kind_of?" do
-    context "pretends to be of kind of model class" do      
+    context "pretends to be of kind of model class" do
       it "#kind_of? decorator class" do
         subject.should be_kind_of subject.class
       end

data/spec/draper/helper_support_spec.rb

@@ -8,7 +8,7 @@ describe Draper::HelperSupport do
       output = ApplicationController.decorate(@product){|p| p.model.object_id }
       output.should == @product.object_id
     end
-    
+
     it 'uses #capture so Rails only renders the content once' do
       ApplicationController.decorate(@product){|p| p.model.object_id }
       ApplicationController.capture_triggered.should be

data/spec/draper/model_support_spec.rb

@@ -11,29 +11,38 @@ describe Draper::ModelSupport do
       a = Product.new.decorator { |d| d.awesome_title }
       a.should eql "Awesome Title"
     end
-    
+
     it 'should be aliased to .decorate' do
       subject.decorator.model.should == subject.decorate.model
     end
   end
 
-  describe '#decorate - decorate collections of AR objects' do
-    subject { Product.limit }
-    its(:decorate) { should be_kind_of(Draper::DecoratedEnumerableProxy) }
+  describe Draper::ModelSupport::ClassMethods do
+    shared_examples_for "a call to Draper::ModelSupport::ClassMethods#decorate" do
+      subject { klass.limit }
+
+      its(:decorate) { should be_kind_of(Draper::DecoratedEnumerableProxy) }
 
-    it "should decorate the collection" do
-      subject.decorate.size.should == 1
-      subject.decorate.to_ary[0].model.should be_a(Product)
+      it "should decorate the collection" do
+        subject.decorate.size.should == 1
+        subject.decorate.to_ary[0].model.should be_a(klass)
+      end
+
+      it "should return a new instance each time it is called" do
+        subject.decorate.should_not == subject.decorate
+      end
+    end
+
+    describe '#decorate - decorate collections of AR objects' do
+      let(:klass) { Product }
+
+      it_should_behave_like "a call to Draper::ModelSupport::ClassMethods#decorate"
     end
-  end
 
-  describe '#decorate - decorate collections of namespaced AR objects' do
-    subject { Namespace::Product.limit }
-    its(:decorate) { should be_kind_of(Draper::DecoratedEnumerableProxy) }
+    describe '#decorate - decorate collections of namespaced AR objects' do
+      let(:klass) { Namespace::Product }
 
-    it "should decorate the collection" do
-      subject.decorate.size.should == 1
-      subject.decorate.to_ary[0].model.should be_a(Namespace::Product)
+      it_should_behave_like "a call to Draper::ModelSupport::ClassMethods#decorate"
     end
   end
 end

data/spec/draper/view_context_spec.rb

@@ -4,19 +4,19 @@ describe Draper::ViewContext do
   let (:app_controller) do
     ApplicationController
   end
-  
+
   let (:app_controller_instance) do
     app_controller.new
   end
-  
+
   it "implements #set_current_view_context" do
     app_controller_instance.should respond_to(:set_current_view_context)
   end
-  
+
   it "calls #before_filter with #set_current_view_context" do
     app_controller.before_filters.should include(:set_current_view_context)
   end
-  
+
   it "raises an exception if the view_context is fetched without being set" do
     Draper::ViewContext.current = nil
     expect {app_controller.current_view_context}.should raise_exception(Exception)

data/spec/generators/draper/decorator/decorator_generator_spec.rb

@@ -9,6 +9,49 @@ describe Draper::DecoratorGenerator do
 
   before { prepare_destination }
 
+  context 'decorator context' do
+    before { run_generator ["product"]  }
+
+    describe 'app/decorators/product_decorator.rb' do
+      subject { file('app/decorators/product_decorator.rb') }
+      it { should exist }
+      it { should contain "class ProductDecorator < ApplicationDecorator" }
+    end
+  end
+
+  context 'default test framework' do
+    before { run_generator ["product"]  }
+
+    describe 'spec/decorators/product_decorator_spec.rb' do
+      subject { file('spec/decorators/product_decorator_spec.rb') }
+      it { should exist }
+      it { should contain "describe ProductDecorator" }
+    end
+  end
+
+  context 'using rspec' do
+    before { run_generator ["product", "-t=rspec"]  }
+
+    describe 'spec/decorators/product_decorator_spec.rb' do
+      subject { file('spec/decorators/product_decorator_spec.rb') }
+      it { should exist }
+      it { should contain "describe ProductDecorator" }
+    end
+  end
+
+  context 'using rspec' do
+    before { run_generator ["product", "-t=test_unit"]  }
+
+    describe 'test/decorators/product_decorator_test.rb' do
+      subject { file('test/decorators/product_decorator_test.rb') }
+      it { should exist }
+      it { should contain "class ProductDecoratorTest < ActiveSupport::TestCase" }
+    end
+  end
+end
+
+
+=begin
   describe 'no arguments' do
     before { run_generator %w(products)  }
 
@@ -17,6 +60,43 @@ describe Draper::DecoratorGenerator do
       it { should exist }
       it { should contain "class ProductsDecorator < ApplicationDecorator" }
     end
+  end
+
 
+  context 'simple' do
+    before { run_generator %w(products)  }
+
+    describe 'app/decorators/products_decorator.rb' do
+      subject { file('app/decorators/products_decorator.rb') }
+      it { should exist }
+      it { should contain "class ProductsDecorator < ApplicationDecorator" }
+    end
   end
-end
+
+
+
+
+
+  context 'using rspec' do
+
+    describe 'app/decorators/products_decorator.rb' do
+      subject { file('app/decorators/products_decorator.rb') }
+      it { should exist }
+      it { should contain "class ProductsDecorator < ApplicationDecorator" }
+    end
+
+    shared_examples_for "ApplicationDecoratorGenerator" do
+      describe 'app/decorators/application_decorator.rb' do
+        subject { file('app/decorators/application_decorator.rb') }
+        it { should exist }
+        it { should contain "class ApplicationDecorator < Draper::Base" }
+      end
+    end
+
+    describe 'spec/decorators/application_decorator_spec.rb' do
+      subject { file('spec/decorators/application_decorator_spec.rb') }
+      it { should exist }
+      it { should contain "describe ApplicationDecorator do" }
+    end
+  end
+=end