draftsman 0.5.1 → 0.6.0

data/spec/models/enumable_spec.rb

@@ -1,10 +1,11 @@
 require 'spec_helper'
 
-RSpec.describe Enumable, :type => :model do
+RSpec.describe Enumable, type: :model do
   let(:enumable) { Enumable.new(status: :active) }
+
   describe '#draft' do
     describe '#reify' do
-      before { enumable.draft_creation }
+      before { enumable.save_draft }
 
       it 'does not raise an exception' do
         expect { enumable.draft.reify }.to_not raise_error

data/spec/models/overridden_draft_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+RSpec.describe OverriddenDraft, type: :model do
+  context 'overridden via `draft_class_name` setting' do
+    let(:vanilla) { Vanilla.new(name: 'Bob') }
+    let!(:class_name_was) { Draftsman.draft_class_name }
+    after { Draftsman.draft_class_name = class_name_was }
+
+    before do
+      Draftsman.draft_class_name = 'OverriddenDraft'
+
+      class Vanilla <ActiveRecord::Base
+        has_drafts
+      end
+    end
+
+    describe '#draft.class.name' do
+      it 'has an `OverriddenDraft` record as its draft' do
+        vanilla.save_draft
+        expect(vanilla.draft.class.name).to eql 'OverriddenDraft'
+      end
+    end
+  end
+
+  context 'with default `draft_class_name` setting' do
+    let(:vanilla) { Vanilla.new(name: 'Bob') }
+
+    before do
+      class Vanilla < ActiveRecord::Base
+        has_drafts
+      end
+    end
+
+    describe '#draft.class.name' do
+      it 'has the default `Draftsman::Draft` record as its draft' do
+        vanilla.save_draft
+        expect(vanilla.reload.draft.class.name).to eql 'Draftsman::Draft'
+      end
+    end
+  end
+end

data/spec/models/parent_spec.rb

@@ -7,8 +7,8 @@ describe Parent do
   describe 'publish!' do
     context 'parent `create` draft with child `create` draft' do
       before do
-        parent.draft_creation
-        child.draft_creation
+        parent.save_draft
+        child.save_draft
       end
 
       subject { parent.draft.publish! }
@@ -68,8 +68,8 @@ describe Parent do
   describe 'revert!' do
     context 'parent `create` draft with child `create` draft' do
       before do
-        parent.draft_creation
-        child.draft_creation
+        parent.save_draft
+        child.save_draft
       end
 
       subject { parent.draft.revert! }
@@ -140,8 +140,8 @@ describe Parent do
   describe 'draft_publication_dependencies' do
     context 'parent `create` draft with child `create` draft' do
       before do
-        parent.draft_creation
-        child.draft_creation
+        parent.save_draft
+        child.save_draft
       end
 
       subject { parent.draft }
@@ -155,8 +155,8 @@ describe Parent do
       before do
         parent.save!
         parent.name = 'Selma'
-        parent.draft_update
-        child.draft_creation
+        parent.save_draft
+        child.save_draft
       end
 
       subject { parent.draft }
@@ -188,8 +188,8 @@ describe Parent do
   describe 'draft_reversion_dependencies' do
     context 'parent `create` draft with child `create` draft' do
       before do
-        parent.draft_creation
-        child.draft_creation
+        parent.save_draft
+        child.save_draft
       end
 
       subject { parent.draft }

data/spec/models/skipper_spec.rb

@@ -1,58 +1,17 @@
 require 'spec_helper'
 
-describe Skipper do
+RSpec.describe Skipper, type: :model do
   let(:skipper) { Skipper.new :name => 'Bob', :skip_me => 'Skipped 1' }
 
   it 'is draftable' do
     expect(subject.class.draftable?).to eql true
   end
 
-  describe 'draft_creation' do
-    subject do
-      skipper.draft_creation
-      skipper.reload
-    end
-
-    it 'is persisted' do
-      expect(subject).to be_persisted
-    end
-
-    it 'is a draft' do
-      expect(subject.draft?).to eql true
-    end
-
-    it 'has a `draft_id`' do
-      expect(subject.draft_id).to be_present
-    end
-
-    it 'has a draft' do
-      expect(subject.draft).to be_present
-    end
-
-    it 'has a `create` draft' do
-      expect(subject.draft.create?).to eql true
-    end
-
-    it 'has a `name`' do
-      expect(subject.name).to eql 'Bob'
-    end
-
-    it 'has a value for `skip_me`' do
-      expect(subject.skip_me).to eql 'Skipped 1'
-    end
-  end
-
-  describe 'draft_update' do
-    subject do
-      skipper.draft_update
-      skipper.reload
-    end
-
-    context 'without existing draft' do
-      before do
-        skipper.save!
-        skipper.name = 'Sam'
-        skipper.skip_me = 'Skipped 2'
+  describe '#save_draft' do
+    context 'on create' do
+      subject do
+        skipper.save_draft
+        skipper.reload
       end
 
       it 'is persisted' do
@@ -67,68 +26,32 @@ describe Skipper do
         expect(subject.draft_id).to be_present
       end
 
-      it 'has a `draft`' do
+      it 'has a draft' do
         expect(subject.draft).to be_present
       end
 
-      it 'identifies as an `update` draft' do
-        expect(subject.draft.update?).to eql true
+      it 'has a `create` draft' do
+        expect(subject.draft.create?).to eql true
       end
 
-      it 'has the original name' do
+      it 'has a `name`' do
         expect(subject.name).to eql 'Bob'
       end
 
-      it 'has the updated skipped attribute' do
-        expect(subject.skip_me).to eql 'Skipped 2'
-      end
-
-      it 'creates a new draft' do
-        expect { subject }.to change(Draftsman::Draft, :count).by(1)
+      it 'has a value for `skip_me`' do
+        expect(subject.skip_me).to eql 'Skipped 1'
       end
     end
 
-    describe 'changing back to initial state' do
-      before do
-        skipper.published_at = Time.now
-        skipper.save!
-        skipper.name = 'Sam'
-        skipper.draft_update
+    context 'on update' do
+      subject do
+        skipper.save_draft
         skipper.reload
-        skipper.name = 'Bob'
-        skipper.skip_me = 'Skipped 2'
       end
 
-      it 'is no longer a draft' do
-        expect(subject.draft?).to eql false
-      end
-
-      it 'no longer has a `draft_id`' do
-        expect(subject.draft_id).to be_nil
-      end
-
-      it 'no longer has a `draft`' do
-        expect(subject.draft).to be_nil
-      end
-
-      it 'has its original `name`' do
-        expect(subject.name).to eql 'Bob'
-      end
-
-      it "retains the updated skipped attribute's value" do
-        expect(subject.skip_me).to eql 'Skipped 2'
-      end
-
-      it 'destroys the draft' do
-        expect { subject }.to change(Draftsman::Draft.where(:id => skipper.draft_id), :count).by(-1)
-      end
-    end
-
-    context 'with existing `create` draft' do
-      before { skipper.draft_creation }
-
-      context 'with changes' do
+      context 'without existing draft' do
         before do
+          skipper.save!
           skipper.name = 'Sam'
           skipper.skip_me = 'Skipped 2'
         end
@@ -149,196 +72,275 @@ describe Skipper do
           expect(subject.draft).to be_present
         end
 
-        it 'has a `create` draft' do
-          expect(subject.draft.create?).to eql true
+        it 'identifies as an `update` draft' do
+          expect(subject.draft.update?).to eql true
         end
 
-        it 'has the updated `name`' do
-          expect(subject.name).to eql 'Sam'
+        it 'has the original name' do
+          expect(subject.name).to eql 'Bob'
         end
 
-        it "retains the updated skipped attribute's value" do
+        it 'has the updated skipped attribute' do
           expect(subject.skip_me).to eql 'Skipped 2'
         end
 
-        it 'updates the existing draft' do
-          expect { subject }.to_not change(Draftsman::Draft.where(:id => skipper.draft_id), :count)
-        end
-
-        it "updates the draft's `name`" do
-          expect(subject.draft.reify.name).to eql 'Sam'
+        it 'creates a new draft' do
+          expect { subject }.to change(Draftsman::Draft, :count).by(1)
         end
       end
 
-      context 'with no changes' do
-        it 'is persisted' do
-          expect(subject).to be_persisted
-        end
-
-        it 'is a draft' do
-          expect(subject.draft?).to eql true
+      describe 'changing back to initial state' do
+        before do
+          skipper.published_at = Time.now
+          skipper.save!
+          skipper.name = 'Sam'
+          skipper.save_draft
+          skipper.reload
+          skipper.name = 'Bob'
+          skipper.skip_me = 'Skipped 2'
         end
 
-        it 'has a `draft_id`' do
-          expect(subject.draft_id).to be_present
+        it 'is no longer a draft' do
+          expect(subject.draft?).to eql false
         end
 
-        it 'has a `draft`' do
-          expect(subject.draft).to be_present
+        it 'no longer has a `draft_id`' do
+          expect(subject.draft_id).to be_nil
         end
 
-        it 'has a `create` draft' do
-          expect(subject.draft.create?).to eql true
+        it 'no longer has a `draft`' do
+          expect(subject.draft).to be_nil
         end
 
-        it 'has the original `name`' do
+        it 'has its original `name`' do
           expect(subject.name).to eql 'Bob'
         end
 
-        it "has the original skipped attribute's value" do
-          expect(subject.skip_me).to eql 'Skipped 1'
+        it "retains the updated skipped attribute's value" do
+          expect(subject.skip_me).to eql 'Skipped 2'
         end
 
-        it "doesn't change the number of drafts" do
-          expect { subject }.to_not change(Draftsman::Draft.where(:id => skipper.draft_id), :count)
+        it 'destroys the draft' do
+          expect { subject }.to change(Draftsman::Draft.where(:id => skipper.draft_id), :count).by(-1)
         end
       end
-    end
 
-    context 'with existing `update` draft' do
-      before do
-        skipper.save!
-        skipper.name = 'Sam'
-        skipper.skip_me = 'Skipped 2'
-        skipper.draft_update
-        skipper.reload
-        skipper.attributes = skipper.draft.reify.attributes
-      end
+      context 'with existing `create` draft' do
+        before { skipper.save_draft }
 
-      context 'with changes to drafted attribute' do
-        before { skipper.name = 'Steve' }
+        context 'with changes' do
+          before do
+            skipper.name = 'Sam'
+            skipper.skip_me = 'Skipped 2'
+          end
 
-        it 'is persisted' do
-          expect(subject).to be_persisted
-        end
+          it 'is persisted' do
+            expect(subject).to be_persisted
+          end
 
-        it 'is a draft' do
-          expect(subject.draft?).to eql true
-        end
+          it 'is a draft' do
+            expect(subject.draft?).to eql true
+          end
 
-        it 'has a `draft_id`' do
-          expect(subject.draft_id).to be_present
-        end
+          it 'has a `draft_id`' do
+            expect(subject.draft_id).to be_present
+          end
 
-        it 'has a `draft`' do
-          expect(subject.draft).to be_present
-        end
+          it 'has a `draft`' do
+            expect(subject.draft).to be_present
+          end
 
-        it 'has an `update` draft' do
-          expect(subject.draft.update?).to eql true
-        end
+          it 'has a `create` draft' do
+            expect(subject.draft.create?).to eql true
+          end
 
-        it 'has the original `name`' do
-          expect(subject.name).to eql 'Bob'
-        end
+          it 'has the updated `name`' do
+            expect(subject.name).to eql 'Sam'
+          end
 
-        it "has the updated skipped attribute's value" do
-          expect(subject.skip_me).to eql 'Skipped 2'
-        end
+          it "retains the updated skipped attribute's value" do
+            expect(subject.skip_me).to eql 'Skipped 2'
+          end
+
+          it 'updates the existing draft' do
+            expect { subject }.to_not change(Draftsman::Draft.where(:id => skipper.draft_id), :count)
+          end
 
-        it 'updates the existing draft' do
-          expect { subject }.to_not change(Draftsman::Draft.where(:id => skipper.draft_id), :count)
+          it "updates the draft's `name`" do
+            expect(subject.draft.reify.name).to eql 'Sam'
+          end
         end
 
-        it "updates the draft's `name`" do
-          expect(subject.draft.reify.name).to eql 'Steve'
+        context 'with no changes' do
+          it 'is persisted' do
+            expect(subject).to be_persisted
+          end
+
+          it 'is a draft' do
+            expect(subject.draft?).to eql true
+          end
+
+          it 'has a `draft_id`' do
+            expect(subject.draft_id).to be_present
+          end
+
+          it 'has a `draft`' do
+            expect(subject.draft).to be_present
+          end
+
+          it 'has a `create` draft' do
+            expect(subject.draft.create?).to eql true
+          end
+
+          it 'has the original `name`' do
+            expect(subject.name).to eql 'Bob'
+          end
+
+          it "has the original skipped attribute's value" do
+            expect(subject.skip_me).to eql 'Skipped 1'
+          end
+
+          it "doesn't change the number of drafts" do
+            expect { subject }.to_not change(Draftsman::Draft.where(:id => skipper.draft_id), :count)
+          end
         end
       end
 
-      context 'with changes to skipped attributes' do
+      context 'with existing `update` draft' do
         before do
-          skipper.skip_me = 'Skip and save'
-          skipper.draft_update
+          skipper.save!
+          skipper.name = 'Sam'
+          skipper.skip_me = 'Skipped 2'
+          skipper.save_draft
           skipper.reload
           skipper.attributes = skipper.draft.reify.attributes
         end
 
-        it 'is persisted' do
-          expect(subject).to be_persisted
-        end
+        context 'with changes to drafted attribute' do
+          before { skipper.name = 'Steve' }
 
-        it 'is a draft' do
-          expect(subject.draft?).to eql true
-        end
+          it 'is persisted' do
+            expect(subject).to be_persisted
+          end
 
-        it 'has a `draft_id`' do
-          expect(subject.draft_id).to be_present
-        end
+          it 'is a draft' do
+            expect(subject.draft?).to eql true
+          end
 
-        it 'has a `draft`' do
-          expect(subject.draft).to be_present
-        end
+          it 'has a `draft_id`' do
+            expect(subject.draft_id).to be_present
+          end
 
-        it 'has an `update` draft' do
-          expect(subject.draft.update?).to eql true
-        end
+          it 'has a `draft`' do
+            expect(subject.draft).to be_present
+          end
 
-        it 'has the original `name`' do
-          expect(subject.name).to eql 'Bob'
-        end
+          it 'has an `update` draft' do
+            expect(subject.draft.update?).to eql true
+          end
 
-        it "updates skipped attribute's value" do
-          expect(subject.skip_me).to eql 'Skip and save'
-        end
+          it 'has the original `name`' do
+            expect(subject.name).to eql 'Bob'
+          end
 
-        it 'updates the existing draft' do
-          expect { subject }.to_not change(Draftsman::Draft.where(:id => skipper.draft_id), :count)
-        end
+          it "has the updated skipped attribute's value" do
+            expect(subject.skip_me).to eql 'Skipped 2'
+          end
 
-        it "keeps the draft's `name`" do
-          expect(subject.draft.reify.name).to eql 'Sam'
-        end
+          it 'updates the existing draft' do
+            expect { subject }.to_not change(Draftsman::Draft.where(:id => skipper.draft_id), :count)
+          end
 
-        it 'updates skipped attribute on draft' do
-          expect(subject.draft.reify.skip_me).to eql 'Skip and save'
+          it "updates the draft's `name`" do
+            expect(subject.draft.reify.name).to eql 'Steve'
+          end
         end
-      end
 
-      context 'with no changes' do
-        it 'is persisted' do
-          expect(subject).to be_persisted
-        end
+        context 'with changes to skipped attributes' do
+          before do
+            skipper.skip_me = 'Skip and save'
+            skipper.save_draft
+            skipper.reload
+            skipper.attributes = skipper.draft.reify.attributes
+          end
 
-        it 'is a draft' do
-          expect(subject.draft?).to eql true
-        end
+          it 'is persisted' do
+            expect(subject).to be_persisted
+          end
 
-        it 'has a `draft_id`' do
-          expect(subject.draft_id).to be_present
-        end
+          it 'is a draft' do
+            expect(subject.draft?).to eql true
+          end
 
-        it 'has a `draft`' do
-          expect(subject.draft).to be_present
-        end
+          it 'has a `draft_id`' do
+            expect(subject.draft_id).to be_present
+          end
 
-        it 'has an `update` draft' do
-          expect(subject.draft.update?).to eql true
-        end
+          it 'has a `draft`' do
+            expect(subject.draft).to be_present
+          end
 
-        it 'has the original `name`' do
-          expect(subject.name).to eql 'Bob'
-        end
+          it 'has an `update` draft' do
+            expect(subject.draft.update?).to eql true
+          end
 
-        it "has the updated skipped attributes' value" do
-          expect(subject.skip_me).to eql 'Skipped 2'
-        end
+          it 'has the original `name`' do
+            expect(subject.name).to eql 'Bob'
+          end
+
+          it "updates skipped attribute's value" do
+            expect(subject.skip_me).to eql 'Skip and save'
+          end
+
+          it 'updates the existing draft' do
+            expect { subject }.to_not change(Draftsman::Draft.where(:id => skipper.draft_id), :count)
+          end
+
+          it "keeps the draft's `name`" do
+            expect(subject.draft.reify.name).to eql 'Sam'
+          end
 
-        it "doesn't change the number of drafts" do
-          expect { subject }.to_not change(Draftsman::Draft.where(:id => skipper.draft_id), :count)
+          it 'updates skipped attribute on draft' do
+            expect(subject.draft.reify.skip_me).to eql 'Skip and save'
+          end
         end
 
-        it "does not update the draft's `name`" do
-          expect(subject.draft.reify.name).to eql 'Sam'
+        context 'with no changes' do
+          it 'is persisted' do
+            expect(subject).to be_persisted
+          end
+
+          it 'is a draft' do
+            expect(subject.draft?).to eql true
+          end
+
+          it 'has a `draft_id`' do
+            expect(subject.draft_id).to be_present
+          end
+
+          it 'has a `draft`' do
+            expect(subject.draft).to be_present
+          end
+
+          it 'has an `update` draft' do
+            expect(subject.draft.update?).to eql true
+          end
+
+          it 'has the original `name`' do
+            expect(subject.name).to eql 'Bob'
+          end
+
+          it "has the updated skipped attributes' value" do
+            expect(subject.skip_me).to eql 'Skipped 2'
+          end
+
+          it "doesn't change the number of drafts" do
+            expect { subject }.to_not change(Draftsman::Draft.where(:id => skipper.draft_id), :count)
+          end
+
+          it "does not update the draft's `name`" do
+            expect(subject.draft.reify.name).to eql 'Sam'
+          end
         end
       end
     end