draftsman 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eb576cc8ff96c4d3e43ffd8c08470200e5968c0f
-  data.tar.gz: 3759e4dd3b0e09007c0ce94b6f8cc11f9f49e503
+  metadata.gz: 74e4cf230e28a0fa2b097c33c0a3bb40360b4c3e
+  data.tar.gz: 549d0072468f067a86480273989d6a0b86118c99
 SHA512:
-  metadata.gz: 68ae774e981b6f401b4230d0ee313158c679ebf2ebb6accde016c92e280d24bec28e24da0ac30901ec0f3ed74df53b08b91905175425dd25efdbe8d4e696b7d7
-  data.tar.gz: 8366dfbccdb59440839a2a184dffa4543cc126db74bce1f01efe96d20f960025ba4a38063d6e581104cc2d8df40a8dab4a76ae23491b63f45ad7b6eec7dc190a
+  metadata.gz: 5dfed02ea98a99d534b3833327f4927b47e93ee4237899fe7c75e02ccd660195c4d562b5bf1dbdafbddb0343e19280a945eb773ee80a41dfd7625a7e2d237cc2
+  data.tar.gz: c4df9a57b0da2602328d995557a867936560965c6f4897d991107abc019789eea7d74ba4a35274e9777f469d353163b167aa00e5f23630b5cd89b2507377d092

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # CHANGELOG
 
-## v0.1.0
+## v0.1.1 - March 7, 2014
 
-* Initial release.
+-  Fixed [#3](https://github.com/minimalorange/draftsman/issues/3) - draft_publication_dependencies not honoring drafts
+   when draft is an update.
+-  Fixed [#1](https://github.com/minimalorange/draftsman/issues/1) - License missing from gemspec - Added MIT license.
+
+## v0.1.0 - November 19, 2013
+
+-  Initial release.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    draftsman (0.1.0)
+    draftsman (0.1.1)
       activerecord (>= 3.0, < 5.0)
 
 GEM

data/README.md

@@ -1,4 +1,4 @@
-# Draftsman v0.1.0 (alpha)
+# Draftsman v0.1.1 (alpha)
 
 Draftsman is a Ruby gem that lets you create draft versions of your database records. If you're developing a system in
 need of simple drafts or a publishing approval queue, then Draftsman just might be what you need.
@@ -11,9 +11,9 @@ need of simple drafts or a publishing approval queue, then Draftsman just might
 *  The RSpec tests are lacking in some areas, so I will be adding to those over time as well. (Unfortunately, this gem
    was not developed with TDD best practices because it was lifted from PaperTrail and modified from there.)
 
-This gem is inspired by the [Kentouzu][1] gem, which is based heavily on [PaperTrail][2]. In fact, much of the code for
-this gem was lifted line for line from PaperTrail (because it works beautifully). You should definitely check out
-PaperTrail and its source: it's a nice clean example of a gem that hooks into Rails and Sinatra.
+This gem is inspired by the [Kentouzu][1] gem, which is based heavily on [PaperTrail][2]. In fact, much of the structure
+for this gem emulates PaperTrail (because it works beautifully). You should definitely check out PaperTrail and its
+source: it's a nice clean example of a gem that hooks into Rails and Sinatra.
 
 ## Features
 
@@ -50,7 +50,7 @@ Works well with Rails, Sinatra, or any other application that depends on ActiveR
 Add Draftsman to your `Gemfile`.
 
 ```ruby
-gem 'draftsman', '0.1.0'
+gem 'draftsman', '0.1.1'
 ```
 
 Or if you want to grab the latest from `master`:
@@ -77,7 +77,7 @@ Run the migration(s).
 Add `draft_id`, `published_at`, and `trashed_at` attributes to the models you want to have drafts on. `trashed_at` is
 optional if you don't want to store drafts for destroys.
 
-    $ rails g migration add_draft_id_published_at_trashed_at_to_widgets draft_id:integer published_at:timestamp trashed_at:timestamp
+    $ rails g migration add_drafts_to_widgets draft_id:integer published_at:timestamp trashed_at:timestamp
     $ rake db:migrate
 
 Add `has_drafts` to the models you want to have drafts on.
@@ -496,6 +496,10 @@ Rails guide:
 This gem is a work in progress. I am adding specs as I need features in my application. Please add missing ones as you
 work on features or find bugs!
 
+## License
+
+Draftsman is released under the [MIT License][9].
+
 
 [1]: https://github.com/seaneshbaugh/kentouzu
 [2]: https://github.com/airblade/paper_trail
@@ -504,3 +508,4 @@ work on features or find bugs!
 [6]: https://github.com/janko-m/sinatra-activerecord
 [7]: https://raw.github.com/minimalorange/draftsman/master/lib/generators/draftsman/templates/create_drafts.rb
 [8]: http://www.sinatrarb.com/intro.html#Modular%20vs.%20Classic%20Style
+[9]: http://www.opensource.org/licenses/MIT

data/draftsman.gemspec

@@ -9,6 +9,7 @@ Gem::Specification.new do |s|
   s.homepage      = 'https://github.com/minimalorange/draftsman'
   s.authors       = ['Chris Peters']
   s.email         = 'chris@minimalorange.com'
+  s.license       = 'MIT'
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")

data/lib/draftsman/draft.rb

@@ -52,25 +52,27 @@ class Draftsman::Draft < ActiveRecord::Base
   def draft_publication_dependencies
     dependencies = []
 
+    my_item = self.item.draft? ? self.item.draft.reify : self.item
+
     case self.event
     when 'create', 'update'
-      associations = self.item.class.reflect_on_all_associations(:belongs_to)
+      associations = my_item.class.reflect_on_all_associations(:belongs_to)
 
       associations.each do |association|
         association_class =
           if association.polymorphic?
-            self.item.send(association.foreign_key.sub('_id', '_type')).constantize
+            my_item.send(association.foreign_key.sub('_id', '_type')).constantize
           else
             association.klass
           end
 
         if association_class.draftable? && association.name != association_class.draft_association_name.to_sym
-          dependency = self.item.send(association.name)
+          dependency = my_item.send(association.name)
           dependencies << dependency.draft if dependency.present? && dependency.draft? && dependency.draft.create?
         end
       end
     when 'destroy'
-      associations = self.item.class.reflect_on_all_associations(:has_one) + self.item.class.reflect_on_all_associations(:has_many)
+      associations = my_item.class.reflect_on_all_associations(:has_one) + my_item.class.reflect_on_all_associations(:has_many)
 
       associations.each do |association|
         if association.klass.draftable?
@@ -78,9 +80,9 @@ class Draftsman::Draft < ActiveRecord::Base
           associated_dependencies =
             case association.macro
             when :has_one
-              self.item.send(association.name).present? ? [self.item.send(association.name)] : []
+              my_item.send(association.name).present? ? [my_item.send(association.name)] : []
             when :has_many
-              self.item.send(association.name)
+              my_item.send(association.name)
             end
 
           associated_dependencies.each do |dependency|

data/lib/draftsman/version.rb

@@ -1,3 +1,3 @@
 module Draftsman
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

data/spec/models/child_spec.rb

@@ -150,7 +150,7 @@ describe Child do
       end
 
       subject { child.draft }
-      its(:draft_publication_dependencies) { should be_present }
+      its(:draft_publication_dependencies) { should_not be_empty }
       its(:draft_publication_dependencies) { should include parent.draft }
     end
 
@@ -163,10 +163,26 @@ describe Child do
       end
 
       subject { child.draft }
-      its(:draft_publication_dependencies) { should be_present }
+      its(:draft_publication_dependencies) { should_not be_empty }
       its(:draft_publication_dependencies) { should include parent.draft }
     end
 
+    context 'parent `create` draft with child `update` draft pointing to new parent' do
+      let(:new_parent) { Parent.new(:name => 'Patty') }
+      before do
+        parent.draft_creation
+        child.save!
+        new_parent.draft_creation
+        child.parent = new_parent
+        child.draft_update
+      end
+
+      subject { child.draft }
+      its(:draft_publication_dependencies) { should_not be_empty }
+      its(:draft_publication_dependencies) { should_not include parent.draft}
+      its(:draft_publication_dependencies) { should include new_parent.draft }
+    end
+
     context 'parent `destroy` draft with child `destroy` draft' do
       before do
         child.save!

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: draftsman
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Chris Peters
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-19 00:00:00.000000000 Z
+date: 2014-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -223,7 +223,8 @@ files:
 - spec/models/whitelister_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/minimalorange/draftsman
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []