dradis-projects 5.3.0 → 5.4.0

data/spec/fixtures/files/with_invalid_states.xml

@@ -1,111 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<dradis-template version="4">
-  <nodes>
-    <node>
-      <id>3</id>
-      <label>Node 1</label>
-      <parent-id/>
-      <position>0</position>
-      <properties><![CDATA[{
-}]]></properties>
-      <type-id>1</type-id>
-      <notes>
-        <note>
-          <id>2</id>
-          <author>xavi</author>
-          <category-id>2</category-id>
-          <text><![CDATA[#[Title]#
-Note 1
-
-#[Description]#
-
-]]></text>
-          <activities>
-            <activity>
-              <action>create</action>
-              <user_email>xavi</user_email>
-              <created_at>1538467955</created_at>
-            </activity>
-          </activities>
-          <comments>
-            <comment>
-              <content><![CDATA[A comment on a note]]></content>
-              <author>xavi</author>
-              <created_at>1538467968</created_at>
-            </comment>
-          </comments>
-        </note>
-      </notes>
-      <evidence>
-        <evidence>
-          <id>386</id>
-          <author>xavi</author>
-          <issue-id>586</issue-id>
-          <content><![CDATA[#[Location]#
-A
-]]></content>
-          <activities>
-            <activity>
-              <action>create</action>
-              <user_email>xavi</user_email>
-              <created_at>1538549260</created_at>
-            </activity>
-          </activities>
-          <comments>
-            <comment>
-              <content><![CDATA[A comment on an evidence]]></content>
-              <author>xavi</author>
-              <created_at>1538549286</created_at>
-            </comment>
-          </comments>
-        </evidence>
-      </evidence>
-      <activities>
-        <activity>
-          <action>create</action>
-          <user_email>xavi</user_email>
-          <created_at>1538467945</created_at>
-        </activity>
-      </activities>
-    </node>
-  </nodes>
-  <issues>
-    <issue>
-      <id>586</id>
-      <author>xavi</author>
-      <state>fakestate</state>
-      <text><![CDATA[#[Title]#
-Issue 1
-
-#[Description]#
-
-]]></text>
-      <activities>
-        <activity>
-          <action>create</action>
-          <user_email>xavi</user_email>
-          <created_at>1538467938</created_at>
-        </activity>
-      </activities>
-      <comments>
-        <comment>
-          <content><![CDATA[A comment on an issue]]></content>
-          <author>xavi</author>
-          <created_at>1538467997</created_at>
-        </comment>
-      </comments>
-    </issue>
-  </issues>
-  <methodologies/>
-  <categories>
-    <category>
-      <id>1</id>
-      <name>Issue description</name>
-    </category>
-    <category>
-      <id>2</id>
-      <name>Default category</name>
-    </category>
-  </categories>
-  <tags/>
-</dradis-template>

data/spec/fixtures/files/with_states.xml

@@ -1,111 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<dradis-template version="4">
-  <nodes>
-    <node>
-      <id>3</id>
-      <label>Node 1</label>
-      <parent-id/>
-      <position>0</position>
-      <properties><![CDATA[{
-}]]></properties>
-      <type-id>1</type-id>
-      <notes>
-        <note>
-          <id>2</id>
-          <author>xavi</author>
-          <category-id>2</category-id>
-          <text><![CDATA[#[Title]#
-Note 1
-
-#[Description]#
-
-]]></text>
-          <activities>
-            <activity>
-              <action>create</action>
-              <user_email>xavi</user_email>
-              <created_at>1538467955</created_at>
-            </activity>
-          </activities>
-          <comments>
-            <comment>
-              <content><![CDATA[A comment on a note]]></content>
-              <author>xavi</author>
-              <created_at>1538467968</created_at>
-            </comment>
-          </comments>
-        </note>
-      </notes>
-      <evidence>
-        <evidence>
-          <id>386</id>
-          <author>xavi</author>
-          <issue-id>586</issue-id>
-          <content><![CDATA[#[Location]#
-A
-]]></content>
-          <activities>
-            <activity>
-              <action>create</action>
-              <user_email>xavi</user_email>
-              <created_at>1538549260</created_at>
-            </activity>
-          </activities>
-          <comments>
-            <comment>
-              <content><![CDATA[A comment on an evidence]]></content>
-              <author>xavi</author>
-              <created_at>1538549286</created_at>
-            </comment>
-          </comments>
-        </evidence>
-      </evidence>
-      <activities>
-        <activity>
-          <action>create</action>
-          <user_email>xavi</user_email>
-          <created_at>1538467945</created_at>
-        </activity>
-      </activities>
-    </node>
-  </nodes>
-  <issues>
-    <issue>
-      <id>586</id>
-      <author>xavi</author>
-      <state>ready_for_review</state>
-      <text><![CDATA[#[Title]#
-Issue 1
-
-#[Description]#
-
-]]></text>
-      <activities>
-        <activity>
-          <action>create</action>
-          <user_email>xavi</user_email>
-          <created_at>1538467938</created_at>
-        </activity>
-      </activities>
-      <comments>
-        <comment>
-          <content><![CDATA[A comment on an issue]]></content>
-          <author>xavi</author>
-          <created_at>1538467997</created_at>
-        </comment>
-      </comments>
-    </issue>
-  </issues>
-  <methodologies/>
-  <categories>
-    <category>
-      <id>1</id>
-      <name>Issue description</name>
-    </category>
-    <category>
-      <id>2</id>
-      <name>Default category</name>
-    </category>
-  </categories>
-  <tags/>
-</dradis-template>

data/spec/fixtures/files/with_tags.xml

@@ -1,64 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<dradis-template version="2">
-  <nodes>
-    <node>
-      <id>5</id>
-      <label>Uploaded files</label>
-      <parent-id />
-      <position>0</position>
-      <properties><![CDATA[{
-}]]></properties>
-      <type-id>0</type-id>
-      <notes></notes>
-      <evidence></evidence>
-      <activities></activities>
-    </node>
-  </nodes>
-  <issues>
-    <issue>
-      <id>2</id>
-      <author>admin@securityroots.com</author>
-      <text><![CDATA[#[Title]#
-        Test Issue
-        #[Description]#
-        hello world]]>
-      </text>
-      <activities></activities>
-      <comments></comments>
-    </issue>
-  </issues>
-  <methodologies></methodologies>
-  <categories>
-    <category>
-      <id>2</id>
-      <name>Issue description</name>
-    </category>
-  </categories>
-  <tags>
-    <tag>
-      <id>1</id>
-      <name>!2ca02c_info</name>
-      <taggings></taggings>
-    </tag>
-    <tag>
-      <id>2</id>
-      <name>!ff7f0e_medium</name>
-      <taggings></taggings>
-    </tag>
-    <tag>
-      <id>3</id>
-      <name>!d62728_high</name>
-      <taggings></taggings>
-    </tag>
-    <tag>
-      <id>4</id>
-      <name>!6baed6_low</name>
-      <taggings></taggings>
-    </tag>
-    <tag>
-      <id>5</id>
-      <name>!9467bd_critical</name>
-      <taggings></taggings>
-    </tag>
-  </tags>
-</dradis-template>

data/spec/lib/dradis/plugins/projects/export/v2/template_spec.rb

@@ -1,72 +0,0 @@
-# DEPRECATED - this class is v2 of the Template Importer and shouldn't be updated.
-# V4 released on Apr 2022
-# V2 can be removed on Apr 2024
-#
-# We're duplicating this file for v4, and even though the code lives in two
-# places now, this file isn't expected to evolve and is now frozen to V2
-# behavior.
-
-require 'rails_helper'
-
-describe 'Dradis::Plugins::Projects::Export::V2::Template' do
-  let(:project) { create(:project) }
-  let(:user) { create(:user) }
-  let(:export) do
-    described_class.new(
-      default_user_id: user.id,
-      plugin: Dradis::Plugins::Projects,
-      project_id: project.id
-    ).export
-  end
-
-  context 'exporting a project' do
-    before do
-      @node = create(:node, project: project)
-      @issue = create(:issue, text: 'Issue 1', node: project.issue_library)
-    end
-
-    context 'with comments in an issue' do
-      before do
-        create(:comment, content: 'A comment on an issue', commentable: @issue)
-      end
-
-      it 'exports comments in the issue' do
-        expect(export).to include('A comment on an issue')
-      end
-    end
-
-    context 'with comments in a note' do
-      before do
-        note = create(:note, text: 'Note 1', node: @node)
-        create(:comment, content: 'A comment on a note', commentable: note)
-      end
-
-      it 'exports comments in the note' do
-        expect(export).to include('A comment on a note')
-      end
-    end
-
-    context 'with comments in an evidence' do
-      before do
-        evidence = create(:evidence, content: 'Test evidence', node: @node, issue: @issue)
-        create(:comment, content: 'A comment on an evidence', commentable: evidence)
-      end
-
-      it 'exports comments in the evidence' do
-        expect(export).to include('A comment on an evidence')
-      end
-    end
-
-    context 'with comments with a deleted author' do
-      before do
-        note = create(:note, text: 'Note 1', node: @node)
-        comment = create(:comment, content: 'Deleted user', commentable: note)
-        comment.update_attribute :user, nil
-      end
-
-      it 'exports the comment without errors' do
-        expect(export).to include('Deleted user')
-      end
-    end
-  end
-end

data/spec/lib/dradis/plugins/projects/export/v4/template_spec.rb

@@ -1,84 +0,0 @@
-# Run the spec in CE/Pro context with:
-# rspec <relative path to dradis-projects>/spec/lib/dradis/plugins/projects/export/v4/template_spec.rb
-
-require 'rails_helper'
-
-describe 'Dradis::Plugins::Projects::Export::V4::Template' do
-  let(:project) { create(:project) }
-  let(:user) { create(:user) }
-  let(:exporter) { 'Dradis::Plugins::Projects::Export::V4::Template' }
-  let(:export) do
-    exporter.constantize.new(
-      default_user_id: user.id,
-      plugin: Dradis::Plugins::Projects,
-      project_id: project.id
-    ).export
-  end
-
-  context 'exporting a project' do
-    before do
-      @node = create(:node, project: project)
-      @issue = create(:issue, text: 'Issue 1', node: project.issue_library)
-    end
-
-    describe 'comments' do
-      context 'with comments in an issue' do
-        before do
-          create(:comment, content: 'A comment on an issue', commentable: @issue)
-        end
-
-        it 'exports comments in the issue' do
-          expect(export).to include('A comment on an issue')
-        end
-      end
-
-      context 'with comments in a note' do
-        before do
-          note = create(:note, text: 'Note 1', node: @node)
-          create(:comment, content: 'A comment on a note', commentable: note)
-        end
-
-        it 'exports comments in the note' do
-          expect(export).to include('A comment on a note')
-        end
-      end
-
-      context 'with comments in an evidence' do
-        before do
-          evidence = create(:evidence, content: 'Test evidence', node: @node, issue: @issue)
-          create(:comment, content: 'A comment on an evidence', commentable: evidence)
-        end
-
-        it 'exports comments in the evidence' do
-          expect(export).to include('A comment on an evidence')
-        end
-      end
-
-      context 'with comments with a deleted author' do
-        before do
-          note = create(:note, text: 'Note 1', node: @node)
-          comment = create(:comment, content: 'Deleted user', commentable: note)
-          comment.update_attribute :user, nil
-        end
-
-        it 'exports the comment without errors' do
-          expect(export).to include('Deleted user')
-        end
-      end
-    end
-
-    describe 'states' do
-      before do
-        Issue.states.each do |state|
-          create(:issue, text: 'Issue 1', node: project.issue_library, state: state[0])
-        end
-      end
-
-      it 'export issues with states' do
-        Issue.states.each do |state|
-          expect(export).to include("<state>#{state[0]}</state>")
-        end
-      end
-    end
-  end
-end

data/spec/lib/dradis/plugins/projects/upload/package_spec.rb

@@ -1,58 +0,0 @@
-# Run the spec in CE/Pro context with:
-# rspec <relative path to dradis-projects>/spec/lib/dradis/plugins/projects/upload/package_spec.rb
-
-require 'rails_helper'
-
-describe 'Dradis::Plugins::Projects::Upload::Package::Importer' do
-  let(:project) { create(:project) }
-  let(:user) { create(:user) }
-  let(:importer_class) { Dradis::Plugins::Projects::Upload::Package }
-  let(:importer) do
-    importer_class::Importer.new(
-      default_user_id: user.id,
-      plugin: importer_class,
-      project_id: project.id
-    )
-  end
-  let(:dir) do
-    File.join(File.dirname(__FILE__), '../../../../../', 'fixtures', 'files')
-  end
-
-  context 'when the packaged template has a recoverable XML error' do
-    let(:file_path) { File.join(dir, 'package_with_recoverable_error.zip') }
-
-    it 'imports the package successfully' do
-      expect(importer.import(file: file_path)).to be true
-    end
-
-    it 'creates the issue from the package' do
-      importer.import(file: file_path)
-
-      expect(project.issues.count).to eq(1)
-    end
-  end
-
-  context 'when the packaged template has an unrecoverable XML error' do
-    let(:file_path) { File.join(dir, 'package_with_unrecoverable_error.zip') }
-
-    it 'returns false instead of raising an unhandled error' do
-      expect { importer.import(file: file_path) }.not_to raise_error
-      expect(importer.import(file: file_path)).to be false
-    end
-
-    it 'logs a clear error message' do
-      logger = double('logger')
-      allow(logger).to receive_messages(debug: nil, error: nil, fatal: nil, info: nil, warn: nil)
-      expect(logger).to receive(:error).with('Failed to import the project template file.')
-
-      importer = importer_class::Importer.new(
-        default_user_id: user.id,
-        logger: logger,
-        plugin: importer_class,
-        project_id: project.id
-      )
-
-      importer.import(file: file_path)
-    end
-  end
-end

data/spec/lib/dradis/plugins/projects/upload/template_spec.rb

@@ -1,80 +0,0 @@
-# Run the spec in CE/Pro context with:
-# rspec <relative path to dradis-projects>/spec/lib/dradis/plugins/projects/upload/template_spec.rb
-
-require 'rails_helper'
-
-describe 'Dradis::Plugins::Projects::Upload::Template::Importer' do
-  let(:project) { create(:project) }
-  let(:user) { create(:user) }
-  let(:importer_class) { Dradis::Plugins::Projects::Upload::Template }
-  let(:importer) do
-    importer_class::Importer.new(
-      default_user_id: user.id,
-      plugin: importer_class,
-      project_id: project.id
-    )
-  end
-  let(:dir) do
-    File.join(File.dirname(__FILE__), '../../../../../', 'fixtures', 'files')
-  end
-
-  context 'uploading a template with a recoverable XML error (e.g. an invalid UTF-8 byte)' do
-    let(:file_path) { File.join(dir, 'invalid_byte_recoverable.xml') }
-
-    it 'still imports the template' do
-      expect(importer.import(file: file_path)).not_to be false
-    end
-
-    it 'creates the issue with its content scrubbed instead of being dropped' do
-      importer.import(file: file_path)
-
-      expect(project.issues.count).to eq(1)
-      expect(project.issues.first.text).to include('Sample Issue')
-    end
-
-    it 'logs a warning instead of a fatal error' do
-      logger = double('logger')
-      allow(logger).to receive_messages(debug: nil, error: nil, fatal: nil, info: nil, warn: nil)
-      expect(logger).to receive(:warn).at_least(:once)
-      expect(logger).not_to receive(:error)
-
-      importer = importer_class::Importer.new(
-        default_user_id: user.id,
-        logger: logger,
-        plugin: importer_class,
-        project_id: project.id
-      )
-
-      importer.import(file: file_path)
-    end
-  end
-
-  context 'uploading a template with an unrecoverable XML error (e.g. a truncated file)' do
-    let(:file_path) { File.join(dir, 'truncated_unrecoverable.xml') }
-
-    it 'returns false' do
-      expect(importer.import(file: file_path)).to be false
-    end
-
-    it 'does not import anything' do
-      importer.import(file: file_path)
-
-      expect(project.issues.count).to eq(0)
-    end
-
-    it 'logs a fatal error' do
-      logger = double('logger')
-      allow(logger).to receive_messages(debug: nil, error: nil, fatal: nil, info: nil, warn: nil)
-      expect(logger).to receive(:error).at_least(:once)
-
-      importer = importer_class::Importer.new(
-        default_user_id: user.id,
-        logger: logger,
-        plugin: importer_class,
-        project_id: project.id
-      )
-
-      importer.import(file: file_path)
-    end
-  end
-end

data/spec/lib/dradis/plugins/projects/upload/v1/template_spec.rb

@@ -1,84 +0,0 @@
-# DEPRECATED - this class is v1 of the Template Importer and shouldn't be updated.
-# V4 released on Apr 2022
-# V1 can be removed on Apr 2024
-#
-# We're duplicating this file for v4, and even though the code lives in two
-# places now, this file isn't expected to evolve and is now frozen to V1
-# behavior.
-
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-describe Dradis::Plugins::Projects::Upload::V1::Template::Importer do
-  let(:project) { create(:project) }
-  let(:user) { create(:user) }
-  let(:importer_class) { Dradis::Plugins::Projects::Upload::Template }
-
-  context 'uploading a template with attachments url' do
-    let(:file_path) do
-      File.join(File.dirname(__FILE__), '../../../../../../', 'fixtures', 'files', 'attachments_url.xml')
-    end
-
-    it 'converts the urls' do
-      importer = importer_class::Importer.new(
-        default_user_id: user.id,
-        plugin: importer_class,
-        project_id: project.id
-      )
-
-      importer.import(file: file_path)
-
-      p_id = project.id
-      n_id = project.plugin_uploads_node.id
-
-      expect(project.issues.first.text).to include(
-        "!/pro/projects/#{p_id}/nodes/#{n_id}/attachments/hello.jpg!\n\n" +
-        "!/projects/#{p_id}/nodes/#{n_id}/attachments/hello.jpg!\n\n" +
-        "!/pro/projects/#{p_id}/nodes/#{n_id}/attachments/hello.jpg!\n\n" +
-        "!/projects/#{p_id}/nodes/#{n_id}/attachments/hello.jpg!"
-      )
-    end
-  end
-
-  context 'uploading a template malformed paths as ids' do
-    let(:file_path) do
-      File.join(File.dirname(__FILE__), '../../../../../../', 'fixtures', 'files', 'malformed_ids.xml')
-    end
-
-    it 'returns false' do
-      importer = importer_class::Importer.new(
-        default_user_id: user.id,
-        plugin: importer_class,
-        project_id: project.id
-      )
-
-      expect(importer.import(file: file_path)).to be false
-    end
-  end
-
-  context 'uploading a template with attachment but missing node' do
-    let(:file_path) do
-      File.join(File.dirname(__FILE__), '../../../../../../', 'fixtures', 'files', 'missing_node.xml')
-    end
-
-    it 'does not modify the attachment' do
-      logger = double('logger')
-      allow(logger).to receive_messages(debug: nil, error: nil, fatal: nil, info: nil)
-      expect(logger).to receive(:error).once
-
-      importer = importer_class::Importer.new(
-        default_user_id: user.id,
-        logger: logger,
-        plugin: importer_class,
-        project_id: project.id
-      )
-
-      importer.import(file: file_path)
-
-      expect(project.issues.first.text).to include(
-        "!/pro/projects/222/nodes/12345/attachments/hello.jpg!"
-      )
-    end
-  end
-end