dradis-netsparker 3.14.0 → 3.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 353d310c2beeb39d7d4e556b86460b6512e48bdc2bcfd3e5019aeab24e7835d8
-  data.tar.gz: 3d20d0a38d206e4d08228ab4e6b43066d6dfed1501ae04a36f559ccc794ce4e3
+  metadata.gz: 7087d2e46409d4e7722fc2aab3de716d655d148560485e0383a4d18e32571f5f
+  data.tar.gz: 86eb4744fac45f828968b36a3297b9d5a20151565ee70ab5e395b014c4921c30
 SHA512:
-  metadata.gz: 7400e753151cc1797d6732a6ad2f402148a66e8debb464e5033878ec1b7ac1ed284a3f34aee491fdf6deeeade8bc023e2cd279dc457454d62cf58946bd8dc0ec
-  data.tar.gz: 5e6a672d83d44a5e8ce830c6457d7a87fc83de038aeb6c1531dc4e7e1d536fd79653a3c3c0acfc6e4d59c7da5913449d254ef8b7eaa136502bf13bddf8c68767
+  metadata.gz: 55694bf4e039153ec50a76606775566774deffd92475fac5e4f5cdaac784395f0b7dc8036fa4462ce490a0698962a83ed1b7d3b57234f61469708beb5328d384
+  data.tar.gz: cf14e266180b7ce84c03dc0e19e65ea0511a22530f633c265d66a42c85decaf734a7493b5a29e4aa6300705cdfa4ac35e9d693b4c950f3dd25c2948ac9b82266

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## Dradis Framework 3.15 (November, 2019) ##
+
+*   Fix link parsing of issue.external_references
+
 ## Dradis Framework 3.14 (August, 2019) ##
 
 *   No changes.

data/dradis-netsparker.gemspec

@@ -26,9 +26,9 @@ Gem::Specification.new do |spec|
   # until we bump Dradis Pro to 4.1.
   # s.add_dependency 'rails', '~> 4.1.1'
   spec.add_dependency 'dradis-plugins', '~> 3.2'
-  spec.add_dependency 'nokogiri', '~> 1.3'
+  spec.add_dependency 'nokogiri', '~> 1.10.4'
 
-  spec.add_development_dependency 'bundler', '~> 1.6'
+  spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec-rails'
   spec.add_development_dependency 'combustion', '~> 0.5.2'

data/lib/dradis/plugins/netsparker/gem_version.rb

@@ -8,7 +8,7 @@ module Dradis
 
       module VERSION
         MAJOR = 3
-        MINOR = 14
+        MINOR = 15
         TINY = 0
         PRE = nil
 

data/lib/netsparker/vulnerability.rb

@@ -24,7 +24,7 @@ module Netsparker
 
         # simple tags
         :actions_to_take, :certainty, :description, :external_references,
-        :extrainformation, :impact, :knownvulnerabilities, 
+        :extrainformation, :impact, :knownvulnerabilities,
         :rawrequest, :rawresponse, :remedy,
         :remedy_references, :required_skills_for_exploitation, :severity,
         :type, :url,
@@ -145,8 +145,7 @@ module Netsparker
       result.gsub!(/(<p>)|(<\/p>)/, "\n")
       result.gsub!(/\n[a-z]\. /, "\n\* ")
 
-      result.gsub!(/<a href=\"(.*?)\" (.*?)>(.*?)<\/a>/i) { "\"#{$3.strip}\":#{$1.strip}" }
-      result.gsub!(/<a href=\'(.*?)\'>(.*?)<\/a>/i) { "\"#{$2.strip}\":#{$1.strip}" }
+      result.gsub!(/<a .*?href=(?:\"|\')(.*?)(?:\"|\').*?>(?:<i.*?<\/i>)?(.*?)<\/a>/i) { "\"#{$2.strip}\":#{$1.strip}" }
 
       result.gsub!(/<code><pre.*?>(.*?)<\/pre><\/code>/m) {|m| "\n\nbc.. #{$1}\n\np.  \n" }
       result.gsub!(/<pre.*?>(.*?)<\/pre>/m) {|m| "\n\nbc.. #{$1}\n\np.  \n" }

data/spec/vulnerability_spec.rb

@@ -0,0 +1,50 @@
+require 'spec_helper'
+
+describe Netsparker::Vulnerability do
+  let(:doc) { described_class.new(nil) }
+
+  describe '#cleanup_html' do
+    it 'formats the html special characters' do
+      sample = "<doc>&quot;&amp;&lt;&gt;&#39;</doc>"
+      expected = "<doc>\"&<>\'</doc>"
+      expect(doc.send(:cleanup_html, sample)).to eq(expected)
+    end
+
+    it 'outputs the CDATA text' do
+      sample = "<doc><![CDATA[Sample Text]]></doc>"
+
+      expected = "<doc>Sample Text</doc>"
+      expect(doc.send(:cleanup_html, sample)).to eq(expected)
+    end
+
+    it 're-formats the html formatting tags to textile' do
+      sample = "<doc>"\
+        "<b>Bold</b>\n"\
+        "<i>Italic</i>\n"\
+        "<em>Emphasis</em>\n"\
+        "<h2>Header</h2>\n"\
+        "<strong>Strong</strong>\n"\
+        "</doc>"
+
+      expected = "<doc>*Bold*\n_Italic_\n*Emphasis*\n*Header*\n*Strong*\n</doc>"
+      expect(doc.send(:cleanup_html, sample)).to eq(expected)
+    end
+
+    it 're-format the html link to textile' do
+      sample = "<doc>"\
+        "<a href='https://drad.is'>DradisLink1</a>\n"\
+        "<a target='_blank' href='https://drad.is'><i class='icon-external-link'></i>DradisLink2</a>\n"\
+        "<a href=\"https://drad.is\">DradisLink3</a>\n"\
+        "<a href=\"https://drad.is\" class='rspec'>DradisLink4</a>\n"\
+        "</doc>"
+
+      expected = "<doc>"\
+                   "\"DradisLink1\":https://drad.is\n"\
+                   "\"DradisLink2\":https://drad.is\n"\
+                   "\"DradisLink3\":https://drad.is\n"\
+                   "\"DradisLink4\":https://drad.is\n"\
+                 "</doc>"
+      expect(doc.send(:cleanup_html, sample)).to eq(expected)
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dradis-netsparker
 version: !ruby/object:Gem::Version
-  version: 3.14.0
+  version: 3.15.0
 platform: ruby
 authors:
 - Daniel Martin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-13 00:00:00.000000000 Z
+date: 2019-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dradis-plugins
@@ -30,28 +30,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 1.10.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 1.10.4
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -127,6 +127,7 @@ files:
 - spec/fixtures/files/netsparker-localhost-demo.xml
 - spec/fixtures/files/testsparker.xml
 - spec/spec_helper.rb
+- spec/vulnerability_spec.rb
 - templates/evidence.fields
 - templates/evidence.sample
 - templates/evidence.template
@@ -152,7 +153,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: Netsparker add-on for the Dradis Framework.
@@ -163,3 +164,4 @@ test_files:
 - spec/fixtures/files/netsparker-localhost-demo.xml
 - spec/fixtures/files/testsparker.xml
 - spec/spec_helper.rb
+- spec/vulnerability_spec.rb