dradis-nessus 3.12.0 → 3.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 3c8886330a0c21ffead6aa759414513c0c6ca7fc
-  data.tar.gz: 484397dd186eab7ff1a1feed4ca380a03962d0e0
+SHA256:
+  metadata.gz: 525b6414b2fe9dfa5b90211ce9851eae66719e6a459e289e0eb9f08d80ba42fd
+  data.tar.gz: 68206b4fff7b3df9d2967fa3d1054be5a012e320d68089d2b5308e74e9aad00b
 SHA512:
-  metadata.gz: e8ecbbf11555aadebc936da16226e9040bad513b11df0634a526e334a83e65da969ba378094a50488dd4c3bd17e3e7ff693759144b8d59166b77fc944c9dd02b
-  data.tar.gz: 0e4758a40ec0f9178ba4f35945f8c2a8fece7c5ff9e3e234685d83fbb4dbd577afb10a73775fe6b8717eee30fdcc9348dceccc74ee8fb132210a38d64eecbd20
+  metadata.gz: 118844a0a6c32a1a197925e0748f7addb774e348ba5349101cf261f585ac9a0086a39cedcff870e62fa833efd4312d6f51b1109ea61187fac59731fcf2bfabd0
+  data.tar.gz: 577bc2449a1100fbb766fe3f6851471c8c6d8d920f21506a39332cf10163ca7136017df883424c7ca10fc987774db6083bcd11115a92bab1263352bf502d6650

data/.github/issue_template.md

@@ -0,0 +1,16 @@
+### Steps to reproduce
+
+Help us help you, how can we reproduce the problem?
+
+### Expected behavior
+Tell us what should happen
+
+### Actual behavior
+Tell us what happens instead
+
+### System configuration
+**Dradis version**:
+
+**Ruby version**:
+
+**OS version**:

data/.github/pull_request_template.md

@@ -0,0 +1,36 @@
+### Summary
+
+Provide a general description of the code changes in your pull
+request... were there any bugs you had fixed? If so, mention them. If
+these bugs have open GitHub issues, be sure to tag them here as well,
+to keep the conversation linked together.
+
+
+### Other Information
+
+If there's anything else that's important and relevant to your pull
+request, mention that information here. This could include
+benchmarks, or other information.
+
+Thanks for contributing to Dradis!
+
+
+### Copyright assignment
+
+Collaboration is difficult with commercial closed source but we want
+to keep as much of the OSS ethos as possible available to users
+who want to fix it themselves.
+
+In order to unambiguously own and sell Dradis Framework commercial
+products, we must have the copyright associated with the entire
+codebase. Any code you create which is merged must be owned by us.
+That's not us trying to be a jerks, that's just the way it works.
+
+Please review the [CONTRIBUTING.md](https://github.com/dradis/dradis-ce/blob/master/CONTRIBUTING.md)
+file for the details.
+
+You can delete this section, but the following sentence needs to
+remain in the PR's description:
+
+> I assign all rights, including copyright, to any future Dradis
+> work by myself to Security Roots.

data/CHANGELOG.md

@@ -1,3 +1,23 @@
+## Dradis Framework 3.17 (May, 2020) ##
+
+*   No changes.
+
+## Dradis Framework 3.16 (February, 2020) ##
+
+*   No changes.
+
+## Dradis Framework 3.15 (November, 2019) ##
+
+*   Fixed bullet points formatting to handle internal text column widths
+
+## Dradis Framework 3.14 (August, 2019) ##
+
+*   No changes.
+
+## Dradis Framework 3.13 (June, 2019) ##
+
+*   No changes.
+
 ## Dradis Framework 3.12 (March, 2019) ##
 
 *   No changes.

data/lib/dradis/plugins/nessus/field_processor.rb

@@ -28,7 +28,7 @@ module Dradis
           else
             output = @nessus_object.try(name) || 'n/a'
 
-            if field == 'report_item.description' && output =~ /^  -/
+            if field == 'report_item.description' && output =~ /^\s+-/
               format_bullet_point_lists(output)
             else
               output
@@ -39,15 +39,17 @@ module Dradis
         private
         def format_bullet_point_lists(input)
           input.split("\n").map do |paragraph|
-            if paragraph =~ /^  - (.*)$/m
-              '* ' + $1.gsub(/    /, '').gsub(/\n/, ' ')
+            if paragraph =~ /(.*)\s+:\s*$/m
+              $1 + ':'
+            elsif paragraph =~ /^\s+-\s+(.*)$/m
+              '* ' + $1.gsub(/\s{3,}/, ' ').gsub(/\n/, ' ')
             else
               paragraph
             end
-          end.join("\n\n")
+          end.join("\n")
         end
       end
 
     end
   end
-end
+end

data/lib/dradis/plugins/nessus/gem_version.rb

@@ -8,7 +8,7 @@ module Dradis
 
       module VERSION
         MAJOR = 3
-        MINOR = 12
+        MINOR = 17
         TINY = 0
         PRE = nil
 

data/spec/dradis/plugins/nessus/field_processor_spec.rb

@@ -3,25 +3,39 @@ require 'ostruct'
 
 describe Dradis::Plugins::Nessus::FieldProcessor do
 
-  describe "%report_item.description% field formatting" do
-    context "bullet points" do
-      it "converts Nessus broken lists into Textile bullet-point lists" do
-        doc = Nokogiri::XML(File.read('spec/fixtures/files/report_item-with-list.xml'))
+  describe '%report_item.description% field formatting' do
+    context 'bullet points' do
+      before do
+        doc = Nokogiri::XML(
+          File.read('spec/fixtures/files/report_item-with-list.xml')
+        )
         processor = described_class.new(data: doc.root)
 
-        value = processor.value(field: 'report_item.description')
-        expect(value).to_not be_empty
+        @value = processor.value(field: 'report_item.description')
+      end
+
+      it 'converts Nessus broken lists into Textile bullet-point lists' do
+        expect(@value).to_not be_empty
+
+        expect(@value).to include(
+          '* A denial of service vulnerability exists relating to '\
+          'the \'mod_dav\' module as it relates to MERGE requests.'
+        )
+      end
 
-        expect(value).to include("* A denial of service vulnerability exists relating to the 'mod_dav' module as it relates to MERGE requests. (CVE-2013-1896)")
+      it 'does not add unnecessary newlines to list items' do
+        expect(@value).to include("vulnerabilities:\n\n* A flaw exists")
       end
     end
   end
 
-  it "Recasted severity values appear in the Evidence" do
-    doc = Nokogiri::XML(File.read('spec/fixtures/files/report_item-with-list.xml'))
+  it 'Recasted severity values appear in the Evidence' do
+    doc = Nokogiri::XML(
+      File.read('spec/fixtures/files/report_item-with-list.xml')
+    )
     processor = described_class.new(data: doc.root)
     value = processor.value(field: 'evidence.severity')
     expect(value).to_not be_empty
-    expect(value).to include("2")
+    expect(value).to include('2')
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dradis-nessus
 version: !ruby/object:Gem::Version
-  version: 3.12.0
+  version: 3.17.0
 platform: ruby
 authors:
 - Daniel Martin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-01 00:00:00.000000000 Z
+date: 2020-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dradis-plugins
@@ -102,6 +102,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/issue_template.md"
+- ".github/pull_request_template.md"
 - ".gitignore"
 - ".rspec"
 - CHANGELOG.md
@@ -156,8 +158,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: Nessus upload add-on for the Dradis Framework.